Title: Pipeable operator for unsubscribing from observables in the components · Issue #23038 · angular/angular · GitHub
Open Graph Title: Pipeable operator for unsubscribing from observables in the components · Issue #23038 · angular/angular
X Title: Pipeable operator for unsubscribing from observables in the components · Issue #23038 · angular/angular
Description: I'm submitting a... [ ] Regression (a behavior that used to work and stopped working in a new release) [ ] Bug report [x] Feature request [ ] Documentation issue or request [ ] Support request => Please do not submit support request here...
Open Graph Description: I'm submitting a... [ ] Regression (a behavior that used to work and stopped working in a new release) [ ] Bug report [x] Feature request [ ] Documentation issue or request [ ] Support request => P...
X Description: I'm submitting a... [ ] Regression (a behavior that used to work and stopped working in a new release) [ ] Bug report [x] Feature request [ ] Documentation issue or request [ ] Support request ...
Opengraph URL: https://github.com/angular/angular/issues/23038
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Pipeable operator for unsubscribing from observables in the components","articleBody":"\u003c!--\r\nPLEASE HELP US PROCESS GITHUB ISSUES FASTER BY PROVIDING THE FOLLOWING INFORMATION.\r\n\r\nISSUES MISSING IMPORTANT INFORMATION MAY BE CLOSED WITHOUT INVESTIGATION.\r\n-->\r\n\r\n## I'm submitting a...\r\n\u003c!-- Check one of the following options with \"x\" -->\r\n\u003cpre>\u003ccode>\r\n[ ] Regression (a behavior that used to work and stopped working in a new release)\r\n[ ] Bug report \u003c!-- Please search GitHub for a similar issue or PR before submitting -->\r\n[x] Feature request\r\n[ ] Documentation issue or request\r\n[ ] Support request => Please do not submit support request here, instead see https://github.com/angular/angular/blob/master/CONTRIBUTING.md#question\r\n\u003c/code>\u003c/pre>\r\n\r\n## Current behavior\r\n\u003c!-- Describe how the issue manifests. -->\r\nFor every observable I consume in the components I need to manually unsubscribe from it on component destruction.\r\n\r\nWhat does it mean:\r\n1. For every subscription I need to create a property on a component (or an array of those subscriptions)\r\n2. In `ngOnDestroy` I need to unsubscribe from all subscriptions above\r\n\r\nNormally this is a little bit painful. That's why I have a [helper library](https://github.com/smnbbrv/ngx-rx-collector) that creates a pipeable operator that tracks the component destruction and kinda extends standard `takeUntil` pipeable:\r\n\r\n```ts\r\nexport function untilDestroyed\u003cT>(componentInstance: any, destructorName = 'ngOnDestroy'): MonoTypeOperatorFunction\u003cT> {\r\n if (!componentInstance[metaProperty]) {\r\n const originalDestructor = componentInstance[destructorName];\r\n\r\n if (!originalDestructor && aot) {\r\n console.warn('untilDestroyed limitation: ngOnDestroy is not present on the component which is a problem for AoT. See https://github.com/angular/angular/issues/16023 for more details');\r\n }\r\n\r\n componentInstance[metaProperty] = new Subject();\r\n\r\n componentInstance[destructorName] = function() {\r\n if (originalDestructor) {\r\n originalDestructor.call(componentInstance);\r\n }\r\n\r\n componentInstance[metaProperty].next();\r\n componentInstance[metaProperty].complete();\r\n };\r\n }\r\n\r\n return takeUntil(componentInstance[metaProperty]);\r\n}\r\n```\r\n\r\nEverything is cool, it is really comfortable to use as\r\n\r\n```ts\r\ninterval(1000).pipe(untilDestroyed(this)).subscribe(console.log.bind(console));\r\n```\r\n\r\nwhere `this` is a component instance.\r\n\r\nBut here comes AoT and forces to create an empty `ngOnDestroy` according to this issue https://github.com/angular/angular/issues/16023.\r\n\r\n## Expected behavior\r\n\u003c!-- Describe what the desired behavior would be. -->\r\n\r\n1. As long as now RxJS is very flexible with those pipeables, can we have a similar **standard** pipeable shipped by angular?\r\n2. Can we embed this pipeable under the hood to bind to the component destructor that one is not forced to write `ngOnDestroy`?\r\n\r\n## Minimal reproduction of the problem with instructions\r\n\u003c!--\r\nFor bug reports please provide the *STEPS TO REPRODUCE* and if possible a *MINIMAL DEMO* of the problem via\r\nhttps://stackblitz.com or similar (you can use this template as a starting point: https://stackblitz.com/fork/angular-gitter).\r\n-->\r\n\r\n## What is the motivation / use case for changing the behavior?\r\n\u003c!-- Describe the motivation or the concrete use case. -->\r\nI need to manually unsubscribe from every observable in `ngOnDestroy`. Even using the custom pipeable I still need to create an empty `ngOnDestroy`. This could be done in a way better manner\r\n\r\n## Environment\r\n\r\n\u003cpre>\u003ccode>\r\nAngular version: >=5.0.0\r\n\u003c!-- Check whether this is still an issue in the most recent Angular version -->\r\n\r\nBrowser:\r\n- [ ] Chrome (desktop) version XX\r\n- [ ] Chrome (Android) version XX\r\n- [ ] Chrome (iOS) version XX\r\n- [ ] Firefox version XX\r\n- [ ] Safari (desktop) version XX\r\n- [ ] Safari (iOS) version XX\r\n- [ ] IE version XX\r\n- [ ] Edge version XX\r\n \r\nFor Tooling issues:\r\n- Node version: XX \u003c!-- run `node --version` -->\r\n- Platform: \u003c!-- Mac, Linux, Windows -->\r\n\r\nOthers:\r\n\u003c!-- Anything else relevant? Operating system version, IDE, package manager, HTTP server, ... -->\r\n\u003c/code>\u003c/pre>\r\n","author":{"url":"https://github.com/smnbbrv","@type":"Person","name":"smnbbrv"},"datePublished":"2018-03-28T09:46:50Z","url":"https://github.com/angular/angular/issues/23038"}
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:c6c6b552-3c13-7c5e-897e-1db633fb7333 |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | A9B8:96DDF:1C1F665:239A258:6B01502E |
| html-safe-nonce | 212c01211d878843c7ab917a72733da9a4cc6c5ebd54c1abfbf59d7566ecd7df |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBOUI4Ojk2RERGOjFDMUY2NjU6MjM5QTI1ODo2QjAxNTAyRSIsInZpc2l0b3JfaWQiOiIzOTczMDEyNTE2MzEyNzk3MjMwIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | 71454e83c6f88f8329a5dccfc624f5a8977c398480113ead135c9e1d386a4ef2 |
| hovercard-subject-tag | issue:309294353 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/angular/angular/23038/issue_layout |
| twitter:image | https://opengraph.githubassets.com/1e81751c8b8bb42f9da5a8911e04123896815cbcc5654a6610c2fac07042676d/angular/angular/issues/23038 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/1e81751c8b8bb42f9da5a8911e04123896815cbcc5654a6610c2fac07042676d/angular/angular/issues/23038 |
| og:image:alt | I'm submitting a... [ ] Regression (a behavior that used to work and stopped working in a new release) [ ] Bug report [x] Feature request [ ] Documentation issue or request [ ] Support request => P... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | smnbbrv |
| hostname | github.com |
| expected-hostname | github.com |
| None | cc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c |
| turbo-cache-control | no-preview |
| go-import | github.com/angular/angular git https://github.com/angular/angular.git |
| octolytics-dimension-user_id | 139426 |
| octolytics-dimension-user_login | angular |
| octolytics-dimension-repository_id | 24195339 |
| octolytics-dimension-repository_nwo | angular/angular |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 24195339 |
| octolytics-dimension-repository_network_root_nwo | angular/angular |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 8c77c9e8439031ad54c75a250694842892f693e1 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | issues |
Links:
Viewport: width=device-width