René's URL Explorer Experiment


Title: Pipeable operator for unsubscribing from observables in the components · Issue #23038 · angular/angular · GitHub

Open Graph Title: Pipeable operator for unsubscribing from observables in the components · Issue #23038 · angular/angular

X Title: Pipeable operator for unsubscribing from observables in the components · Issue #23038 · angular/angular

Description: I'm submitting a... [ ] Regression (a behavior that used to work and stopped working in a new release) [ ] Bug report [x] Feature request [ ] Documentation issue or request [ ] Support request => Please do not submit support request here...

Open Graph Description: I'm submitting a... [ ] Regression (a behavior that used to work and stopped working in a new release) [ ] Bug report [x] Feature request [ ] Documentation issue or request [ ] Support request => P...

X Description: I'm submitting a... [ ] Regression (a behavior that used to work and stopped working in a new release) [ ] Bug report [x] Feature request [ ] Documentation issue or request [ ] Support request ...

Opengraph URL: https://github.com/angular/angular/issues/23038

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Pipeable operator for unsubscribing from observables in the components","articleBody":"\u003c!--\r\nPLEASE HELP US PROCESS GITHUB ISSUES FASTER BY PROVIDING THE FOLLOWING INFORMATION.\r\n\r\nISSUES MISSING IMPORTANT INFORMATION MAY BE CLOSED WITHOUT INVESTIGATION.\r\n-->\r\n\r\n## I'm submitting a...\r\n\u003c!-- Check one of the following options with \"x\" -->\r\n\u003cpre>\u003ccode>\r\n[ ] Regression (a behavior that used to work and stopped working in a new release)\r\n[ ] Bug report  \u003c!-- Please search GitHub for a similar issue or PR before submitting -->\r\n[x] Feature request\r\n[ ] Documentation issue or request\r\n[ ] Support request => Please do not submit support request here, instead see https://github.com/angular/angular/blob/master/CONTRIBUTING.md#question\r\n\u003c/code>\u003c/pre>\r\n\r\n## Current behavior\r\n\u003c!-- Describe how the issue manifests. -->\r\nFor every observable I consume in the components I need to manually unsubscribe from it on component destruction.\r\n\r\nWhat does it mean:\r\n1. For every subscription I need to create a property on a component (or an array of those subscriptions)\r\n2. In `ngOnDestroy` I need to unsubscribe from all subscriptions above\r\n\r\nNormally this is a little bit painful. That's why I have a [helper library](https://github.com/smnbbrv/ngx-rx-collector) that creates a pipeable operator that tracks the component destruction and kinda extends standard `takeUntil` pipeable:\r\n\r\n```ts\r\nexport function untilDestroyed\u003cT>(componentInstance: any, destructorName = 'ngOnDestroy'): MonoTypeOperatorFunction\u003cT> {\r\n  if (!componentInstance[metaProperty]) {\r\n    const originalDestructor = componentInstance[destructorName];\r\n\r\n    if (!originalDestructor && aot) {\r\n      console.warn('untilDestroyed limitation: ngOnDestroy is not present on the component which is a problem for AoT. See https://github.com/angular/angular/issues/16023 for more details');\r\n    }\r\n\r\n    componentInstance[metaProperty] = new Subject();\r\n\r\n    componentInstance[destructorName] = function() {\r\n      if (originalDestructor) {\r\n        originalDestructor.call(componentInstance);\r\n      }\r\n\r\n      componentInstance[metaProperty].next();\r\n      componentInstance[metaProperty].complete();\r\n    };\r\n  }\r\n\r\n  return takeUntil(componentInstance[metaProperty]);\r\n}\r\n```\r\n\r\nEverything is cool, it is really comfortable to use as\r\n\r\n```ts\r\ninterval(1000).pipe(untilDestroyed(this)).subscribe(console.log.bind(console));\r\n```\r\n\r\nwhere `this` is a component instance.\r\n\r\nBut here comes AoT and forces to create an empty `ngOnDestroy` according to this issue https://github.com/angular/angular/issues/16023.\r\n\r\n## Expected behavior\r\n\u003c!-- Describe what the desired behavior would be. -->\r\n\r\n1. As long as now RxJS is very flexible with those pipeables, can we have a similar **standard** pipeable shipped by angular?\r\n2. Can we embed this pipeable under the hood to bind to the component destructor that one is not forced to write `ngOnDestroy`?\r\n\r\n## Minimal reproduction of the problem with instructions\r\n\u003c!--\r\nFor bug reports please provide the *STEPS TO REPRODUCE* and if possible a *MINIMAL DEMO* of the problem via\r\nhttps://stackblitz.com or similar (you can use this template as a starting point: https://stackblitz.com/fork/angular-gitter).\r\n-->\r\n\r\n## What is the motivation / use case for changing the behavior?\r\n\u003c!-- Describe the motivation or the concrete use case. -->\r\nI need to manually unsubscribe from every observable in `ngOnDestroy`.  Even using the custom pipeable I still need to create an empty `ngOnDestroy`. This could be done in a way better manner\r\n\r\n## Environment\r\n\r\n\u003cpre>\u003ccode>\r\nAngular version: >=5.0.0\r\n\u003c!-- Check whether this is still an issue in the most recent Angular version -->\r\n\r\nBrowser:\r\n- [ ] Chrome (desktop) version XX\r\n- [ ] Chrome (Android) version XX\r\n- [ ] Chrome (iOS) version XX\r\n- [ ] Firefox version XX\r\n- [ ] Safari (desktop) version XX\r\n- [ ] Safari (iOS) version XX\r\n- [ ] IE version XX\r\n- [ ] Edge version XX\r\n \r\nFor Tooling issues:\r\n- Node version: XX  \u003c!-- run `node --version` -->\r\n- Platform:  \u003c!-- Mac, Linux, Windows -->\r\n\r\nOthers:\r\n\u003c!-- Anything else relevant?  Operating system version, IDE, package manager, HTTP server, ... -->\r\n\u003c/code>\u003c/pre>\r\n","author":{"url":"https://github.com/smnbbrv","@type":"Person","name":"smnbbrv"},"datePublished":"2018-03-28T09:46:50Z","url":"https://github.com/angular/angular/issues/23038"}

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:c6c6b552-3c13-7c5e-897e-1db633fb7333
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-idA9B8:96DDF:1C1F665:239A258:6B01502E
html-safe-nonce212c01211d878843c7ab917a72733da9a4cc6c5ebd54c1abfbf59d7566ecd7df
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBOUI4Ojk2RERGOjFDMUY2NjU6MjM5QTI1ODo2QjAxNTAyRSIsInZpc2l0b3JfaWQiOiIzOTczMDEyNTE2MzEyNzk3MjMwIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac71454e83c6f88f8329a5dccfc624f5a8977c398480113ead135c9e1d386a4ef2
hovercard-subject-tagissue:309294353
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/angular/angular/23038/issue_layout
twitter:imagehttps://opengraph.githubassets.com/1e81751c8b8bb42f9da5a8911e04123896815cbcc5654a6610c2fac07042676d/angular/angular/issues/23038
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/1e81751c8b8bb42f9da5a8911e04123896815cbcc5654a6610c2fac07042676d/angular/angular/issues/23038
og:image:altI'm submitting a... [ ] Regression (a behavior that used to work and stopped working in a new release) [ ] Bug report [x] Feature request [ ] Documentation issue or request [ ] Support request => P...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamesmnbbrv
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-preview
go-importgithub.com/angular/angular git https://github.com/angular/angular.git
octolytics-dimension-user_id139426
octolytics-dimension-user_loginangular
octolytics-dimension-repository_id24195339
octolytics-dimension-repository_nwoangular/angular
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id24195339
octolytics-dimension-repository_network_root_nwoangular/angular
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-nameissues

Links:

Skip to contenthttps://github.com/angular/angular/issues/23038#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fissues%2F23038
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fissues%2F23038
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=angular%2Fangular
Reloadhttps://github.com/angular/angular/issues/23038
Reloadhttps://github.com/angular/angular/issues/23038
Reloadhttps://github.com/angular/angular/issues/23038
angularhttps://github.com/angular
angularhttps://github.com/angular/angular
Codehttps://github.com/angular/angular
Issues836 (836)https://github.com/angular/angular/issues
Pull requests141 (141)https://github.com/angular/angular/pulls
Discussionshttps://github.com/angular/angular/discussions
Actionshttps://github.com/angular/angular/actions
Projectshttps://github.com/angular/angular/projects
Security and quality40 (40)https://github.com/angular/angular/security
Insightshttps://github.com/angular/angular/insights
https://github.com/angular/angular
New issuehttps://github.com/login?return_to=https://github.com/angular/angular/issues/23038
New issuehttps://github.com/login?return_to=https://github.com/angular/angular/issues/23038
Pipeable operator for unsubscribing from observables in the componentshttps://github.com/angular/angular/issues/23038#top
area: coreIssues related to the framework runtimehttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20core%22
core: lifecycle hookshttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22core%3A%20lifecycle%20hooks%22
cross-cutting: observableshttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22cross-cutting%3A%20observables%22
featureLabel used to distinguish feature request from other issueshttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22feature%22
feature: under considerationFeature request for which voting has completed and the request is now under considerationhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22feature%3A%20under%20consideration%22
Backloghttps://github.com/angular/angular/milestone/82
https://github.com/smnbbrv
smnbbrvhttps://github.com/smnbbrv
on Mar 28, 2018https://github.com/angular/angular/issues/23038#issue-309294353
helper libraryhttps://github.com/smnbbrv/ngx-rx-collector
#16023https://github.com/angular/angular/issues/16023
Nexthttps://github.com/angular/angular/issues/23038?timeline_page=1
ngbothttps://github.com/apps/ngbot
needsTriagehttps://github.com/angular/angular/milestone/83
on Mar 28, 2018https://github.com/angular/angular/issues/23038#event-1545181031
https://github.com/bcandullo
bcandullohttps://github.com/bcandullo
on Mar 28, 2018https://github.com/angular/angular/issues/23038#issuecomment-376997132
https://github.com/smnbbrv
smnbbrvhttps://github.com/smnbbrv
on Mar 28, 2018https://github.com/angular/angular/issues/23038#issuecomment-377023010
@bcandullohttps://github.com/bcandullo
https://github.com/bcandullo
bcandullohttps://github.com/bcandullo
on Mar 28, 2018https://github.com/angular/angular/issues/23038#issuecomment-377026056
#3https://github.com/angular/angular/issues/3
https://github.com/wulfsberg
wulfsberghttps://github.com/wulfsberg
on Mar 28, 2018https://github.com/angular/angular/issues/23038#issuecomment-377073322
https://github.com/ericmartinezr
ericmartinezrhttps://github.com/ericmartinezr
on Mar 29, 2018https://github.com/angular/angular/issues/23038#issuecomment-377079147
#20682https://github.com/angular/angular/pull/20682
https://github.com/dawidgarus
dawidgarushttps://github.com/dawidgarus
on Mar 29, 2018https://github.com/angular/angular/issues/23038#issuecomment-377081269
https://github.com/smnbbrv
smnbbrvhttps://github.com/smnbbrv
on Mar 29, 2018https://github.com/angular/angular/issues/23038#issuecomment-377140124
@ericmartinezrhttps://github.com/ericmartinezr
IgorMinarhttps://github.com/IgorMinar
area: coreIssues related to the framework runtimehttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20core%22
on Mar 29, 2018https://github.com/angular/angular/issues/23038#event-1548956533
https://github.com/cedvdb
cedvdbhttps://github.com/cedvdb
on Mar 30, 2018https://github.com/angular/angular/issues/23038#issuecomment-377426978
mheveryhttps://github.com/mhevery
featureLabel used to distinguish feature request from other issueshttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22feature%22
on Apr 3, 2018https://github.com/angular/angular/issues/23038#event-1555234488
ngbothttps://github.com/apps/ngbot
needsTriagehttps://github.com/angular/angular/milestone/83
Backloghttps://github.com/angular/angular/milestone/82
on Apr 3, 2018https://github.com/angular/angular/issues/23038#event-1555234563
https://github.com/amcdnl
amcdnlhttps://github.com/amcdnl
on Apr 16, 2018https://github.com/angular/angular/issues/23038#issuecomment-381670075
https://netbasal.com/automagically-unsubscribe-in-angular-4487e9853a88https://netbasal.com/automagically-unsubscribe-in-angular-4487e9853a88
https://www.npmjs.com/package/take-until-destroyhttps://www.npmjs.com/package/take-until-destroy
https://github.com/NetanelBasal/ngx-take-until-destroyhttps://github.com/NetanelBasal/ngx-take-until-destroy
Angular compiler - custom decorators with ngOnDestroy does not work with AOT build #16023https://github.com/angular/angular/issues/16023
@robwormaldhttps://github.com/robwormald
https://github.com/NetanelBasal
NetanelBasalhttps://github.com/NetanelBasal
on Apr 16, 2018https://github.com/angular/angular/issues/23038#issuecomment-381708886
https://github.com/MickL
MickLhttps://github.com/MickL
on Apr 1, 2019https://github.com/angular/angular/issues/23038#issuecomment-478624577
#10185https://github.com/angular/angular/issues/10185
https://github.com/frankiDotNet
frankiDotNethttps://github.com/frankiDotNet
on Mar 6, 2020https://github.com/angular/angular/issues/23038#issuecomment-595657826
https://github.com/Bjeaurn
Bjeaurnhttps://github.com/Bjeaurn
on Mar 6, 2020https://github.com/angular/angular/issues/23038#issuecomment-595669041
https://github.com/smnbbrv
smnbbrvhttps://github.com/smnbbrv
on Mar 6, 2020https://github.com/angular/angular/issues/23038#issuecomment-595673932
https://github.com/frankiDotNet
frankiDotNethttps://github.com/frankiDotNet
on Mar 6, 2020https://github.com/angular/angular/issues/23038#issuecomment-595674606
https://github.com/Bjeaurn
Bjeaurnhttps://github.com/Bjeaurn
on Mar 6, 2020https://github.com/angular/angular/issues/23038#issuecomment-595726032
pkozlowski-opensourcehttps://github.com/pkozlowski-opensource
core: lifecycle hookshttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22core%3A%20lifecycle%20hooks%22
on Mar 14, 2020https://github.com/angular/angular/issues/23038#event-3129677207
pkozlowski-opensourcehttps://github.com/pkozlowski-opensource
cross-cutting: observableshttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22cross-cutting%3A%20observables%22
on Jul 27, 2020https://github.com/angular/angular/issues/23038#event-3589650678
angular-robothttps://github.com/apps/angular-robot
feature: under considerationFeature request for which voting has completed and the request is now under considerationhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22feature%3A%20under%20consideration%22
on Jun 4, 2021https://github.com/angular/angular/issues/23038#event-4843587161
https://github.com/fabioemoutinho
fabioemoutinhohttps://github.com/fabioemoutinho
on Sep 19, 2022https://github.com/angular/angular/issues/23038#issuecomment-1251418969
@pkozlowski-opensourcehttps://github.com/pkozlowski-opensource
https://github.com/JeanMeche
JeanMechehttps://github.com/JeanMeche
on Mar 16, 2023https://github.com/angular/angular/issues/23038#issuecomment-1472907510
This PRhttps://github.com/angular/angular/pull/49154/files#diff-508a78c7ae7456260190375c3b624cdd2fd5219aee48375c9d848ea2f3f95395
https://github.com/JeanMeche
JeanMechehttps://github.com/JeanMeche
on Feb 19, 2024https://github.com/angular/angular/issues/23038#issuecomment-1951520346
JeanMechehttps://github.com/JeanMeche
completedhttps://github.com/angular/angular/issues?q=is%3Aissue%20state%3Aclosed%20archived%3Afalse%20reason%3Acompleted
on Feb 19, 2024https://github.com/angular/angular/issues/23038#event-11842643201
https://github.com/apps/angular-automatic-lock-bot
angular-automatic-lock-bothttps://github.com/apps/angular-automatic-lock-bot
on Mar 21, 2024https://github.com/angular/angular/issues/23038#issuecomment-2010945055
automatic conversation locking policyhttps://github.com/angular/angular/blob/8f24bc9443b3872fe095d9f7f77b308a361a13b4/docs/GITHUB_PROCESS.md#conversation-locking
angular-automatic-lock-bothttps://github.com/apps/angular-automatic-lock-bot
on Mar 21, 2024https://github.com/angular/angular/issues/23038#event-12192971430
Sign up for freehttps://github.com/signup?return_to=https://github.com/angular/angular/issues/23038
Sign in to commenthttps://github.com/login?return_to=https://github.com/angular/angular/issues/23038
area: coreIssues related to the framework runtimehttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20core%22
core: lifecycle hookshttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22core%3A%20lifecycle%20hooks%22
cross-cutting: observableshttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22cross-cutting%3A%20observables%22
featureLabel used to distinguish feature request from other issueshttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22feature%22
feature: under considerationFeature request for which voting has completed and the request is now under considerationhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22feature%3A%20under%20consideration%22
BacklogNo due datehttps://github.com/angular/angular/milestone/82
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.