René's URL Explorer Experiment


Title: ngOnInit is not respecting inheritance with AOT when base class is from an external librairy using barrel files · Issue #22825 · angular/angular · GitHub

Open Graph Title: ngOnInit is not respecting inheritance with AOT when base class is from an external librairy using barrel files · Issue #22825 · angular/angular

X Title: ngOnInit is not respecting inheritance with AOT when base class is from an external librairy using barrel files · Issue #22825 · angular/angular

Description: I'm submitting a... [ ] Regression (a behavior that used to work and stopped working in a new release) [x] Bug report [ ] Feature request [ ] Documentation issue or request [ ] Support request => Please do not submit support request here...

Open Graph Description: I'm submitting a... [ ] Regression (a behavior that used to work and stopped working in a new release) [x] Bug report [ ] Feature request [ ] Documentation issue or request [ ] Support request => P...

X Description: I'm submitting a... [ ] Regression (a behavior that used to work and stopped working in a new release) [x] Bug report [ ] Feature request [ ] Documentation issue or request [ ] Support request ...

Opengraph URL: https://github.com/angular/angular/issues/22825

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"ngOnInit is not respecting inheritance with AOT when base class is from an external librairy using barrel files","articleBody":"## I'm submitting a...\r\n\u003cpre>\u003ccode>\r\n[ ] Regression (a behavior that used to work and stopped working in a new release)\r\n[x] Bug report  \u003c!-- Please search GitHub for a similar issue or PR before submitting -->\r\n[ ] Feature request\r\n[ ] Documentation issue or request\r\n[ ] Support request => Please do not submit support request here, instead see https://github.com/angular/angular/blob/master/CONTRIBUTING.md#question\r\n\u003c/code>\u003c/pre>\r\n\r\n## Current behavior\r\n\r\nWhen\r\n- I have a component base class (`SimpleCoreComponent1`) coming from an external npm library that implements `ngOnInit`\r\n- AND that class has been exported via barrel files (index.ts)\r\n- BUT that barrel file has been exported via implicit refererence to index.ts (`export * from './components1';` instead of `export * from './components1/index';`)\r\n- AND I have an angular app with component (`ForumsComponent`) that extends `SimpleCoreComponent1`\r\n- BUT i didn't explicitly reimplement the `ngOnInit` in the `ForumsComponent`\r\n- AND i run the app with AOT enabled (`ng server --aot`)\r\n\r\nThen\r\n- the `ngOnInit` of the base class is not invoked .\r\n\r\n## Expected behavior\r\n\r\nLifecycle hooks (ngOnInit, ngOnDestroy, etc) must be invoked even if the base class is defined in an external npm package using barrel files with `index.ts` not explicitly stated.\r\n\r\n## Minimal reproduction of the problem with instructions\r\n\u003c!--\r\nFor bug reports please provide the *STEPS TO REPRODUCE* and if possible a *MINIMAL DEMO* of the problem via\r\nhttps://stackblitz.com or similar (you can use this template as a starting point: https://stackblitz.com/fork/angular-gitter).\r\n-->\r\n*STEPS TO REPRODUCE*\r\n\r\n*Create the angular library*\r\n\r\n> Note: Sample projet library source code available on [github](https://github.com/instriker/bug-angular-aot-lib-1)\r\n\r\n1) Setup library projet using yeoman\r\n```bash\r\nnpm install -g yo@2.0.0\r\nnpm install -g generator-ngx-library@5.4.0\r\nmkdir demolibraryforaot\r\ncd demolibraryforaot\r\nyo ngx-library\r\n```\r\n\r\n2) Create this directory structure:\r\n\r\n```\r\nsrc\r\n|- index.ts\r\n|- Components1\r\n   |- index.ts\r\n   |- simple-core-component.ts\r\n|- Components2\r\n   |- index.ts\r\n   |- simple-core-component.ts\r\n   \r\n```\r\n\r\n3) Write the following code:\r\n```typescript\r\n// src/index.ts\r\nexport * from './components1';        // BUG: This export WON'T have the right .metadata.json exported:\r\nexport * from './components2/index';  // This export will have the right .metadata.json exported:\r\n\r\n// src/Components1/index.ts\r\nexport * from './simple-core-component';\r\n\r\n// src/Components1/simple-core-component.ts\r\nimport { OnInit } from '@angular/core';\r\n\r\nexport class SimpleCoreComponent1 implements OnInit {\r\n    ngOnInit(): void {\r\n        console.log('SimpleCoreComponent1.ngOnInit');\r\n    }\r\n}\r\n\r\n// src/Components2/index.ts\r\nexport * from './simple-core-component';\r\n\r\n// src/Components2/simple-core-component.ts\r\nimport { OnInit } from '@angular/core';\r\n\r\nexport class SimpleCoreComponent2 implements OnInit {\r\n    ngOnInit(): void {\r\n        console.log('SimpleCoreComponent2.ngOnInit');\r\n    }\r\n}\r\n```\r\n\r\n4) Create a package\r\n```bash\r\nnpm run start\r\n# Ignore the code coverage error\r\ncd dist\r\nnpm pack\r\n```\r\n\r\n*Create the angular app*\r\n\r\n> Note: Sample projet source code available on [github](https://github.com/instriker/bug-angular-aot-project-1)\r\n\r\n1) Create an angular app beside the angular library\r\n```bash\r\nng new angular-inh-aot-bug\r\n```\r\n\r\n2) Install dependencies\r\n```bash\r\ncd angular-inh-aot-bug\r\nnpm install\r\n```\r\n\r\n3) Install the npm package in the angular app\r\n```bash\r\n# Using locally built package:\r\nnpm install --save ../demolibraryforaot/dist/demolibraryforaot-0.0.1.tgz\r\n```\r\n\r\n4) Create a component in the angular app\r\n```bash\r\ncd src/app\r\nng generate component ForumsComponent\r\n```\r\n\r\n5) Edit ForumsComponent to extends SimpleCoreComponent1\r\n```typescript\r\nimport { Component } from '@angular/core';\r\nimport { SimpleCoreComponent1 } from 'demolibraryforaot';\r\n\r\n@Component({\r\n  selector: 'app-forums',\r\n  templateUrl: './forums.component.html',\r\n  styleUrls: ['./forums.component.css']\r\n})\r\nexport class ForumsComponentWithoutIndex extends SimpleCoreComponent1 {\r\n}\r\n```\r\n\r\n6) Add the ForumsComponent to the AppComponent.html:\r\n```html\r\n\u003capp-forums>\u003c/app-forums>\r\n```\r\n\r\n7) Start with AOT:\r\n```bash\r\nng serve --aot \r\n```\r\n\r\n8) Open browser and see the base class ngOnInit is not invoked (no logs in the console)\r\nOpen `http://localhost:4200` in chrome\r\n\r\n*Now extends SimpleCoreComponent2 instead of SimpleCoreComponent1*\r\n\r\nLook at the console log: you'll see the ngOnInit is now invoked. The reason seems to be that the .metadata.json of the library is OK when we have the `/index` in the export of the barrel file.\r\n\r\n## What is the motivation / use case for changing the behavior?\r\n\r\nWe have a lot of angular projects expected to start in the near future. We want to be able to extract some of the good recipes teams develops in a common librairy to help cross-project collaboration.\r\n\r\nThat bug is 'nasty', as it's easy to do this kind of error, and not obvious for people investigating that bug why their code is not invoked.\r\n\r\n## Environment\r\n\r\n\u003cpre>\u003ccode>\r\nAngular version: 5.2.8\r\n\r\nBrowser:\r\n- [x] Chrome (desktop) version 64.0.3282.186 \r\n- [ ] Chrome (Android) version XX\r\n- [ ] Chrome (iOS) version XX\r\n- [ ] Firefox version XX\r\n- [ ] Safari (desktop) version XX\r\n- [ ] Safari (iOS) version XX\r\n- [ ] IE version XX\r\n- [ ] Edge version XX\r\n \r\nFor Tooling issues:\r\n- Node version: 5.6.0\r\n- Platform:  Windows\r\n\r\nOthers:\r\n\u003c!-- Anything else relevant?  Operating system version, IDE, package manager, HTTP server, ... -->\r\n\u003c/code>\u003c/pre>\r\n","author":{"url":"https://github.com/instriker","@type":"Person","name":"instriker"},"datePublished":"2018-03-16T14:25:44Z","url":"https://github.com/angular/angular/issues/22825"}

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:7387dc09-947d-b43a-bdf1-aa507cd50404
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-idED50:3DD488:985531:C2A674:6B00F04E
html-safe-nonce03501832a69e968cae18b4c72e8764630dd34fa00663a821ad2c2151a9a1af15
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFRDUwOjNERDQ4ODo5ODU1MzE6QzJBNjc0OjZCMDBGMDRFIiwidmlzaXRvcl9pZCI6IjkxMTI0ODg0NjQyNDIyNDE2MTQiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmacaba2f5884c255603056c6afdb2302feb575eb15ba6de35e2ea078905da0d1d7b
hovercard-subject-tagissue:305947785
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/angular/angular/22825/issue_layout
twitter:imagehttps://opengraph.githubassets.com/c6849ddbfe310ffafe6916b3bbc8038000ed493f042b9add6b80d4cfcd2e7662/angular/angular/issues/22825
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/c6849ddbfe310ffafe6916b3bbc8038000ed493f042b9add6b80d4cfcd2e7662/angular/angular/issues/22825
og:image:altI'm submitting a... [ ] Regression (a behavior that used to work and stopped working in a new release) [x] Bug report [ ] Feature request [ ] Documentation issue or request [ ] Support request => P...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameinstriker
hostnamegithub.com
expected-hostnamegithub.com
None4ef498cbabcbe3c50befc7a5b743e7072ee770b4daf0e15e54801180d1fa91fc
turbo-cache-controlno-preview
go-importgithub.com/angular/angular git https://github.com/angular/angular.git
octolytics-dimension-user_id139426
octolytics-dimension-user_loginangular
octolytics-dimension-repository_id24195339
octolytics-dimension-repository_nwoangular/angular
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id24195339
octolytics-dimension-repository_network_root_nwoangular/angular
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release9983dd5da06943f833c971dd5b6bc988e2858be5
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-nameissues

Links:

Skip to contenthttps://github.com/angular/angular/issues/22825#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fissues%2F22825
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fissues%2F22825
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=angular%2Fangular
Reloadhttps://github.com/angular/angular/issues/22825
Reloadhttps://github.com/angular/angular/issues/22825
Reloadhttps://github.com/angular/angular/issues/22825
angularhttps://github.com/angular
angularhttps://github.com/angular/angular
Codehttps://github.com/angular/angular
Issues835 (835)https://github.com/angular/angular/issues
Pull requests140 (140)https://github.com/angular/angular/pulls
Discussionshttps://github.com/angular/angular/discussions
Actionshttps://github.com/angular/angular/actions
Projectshttps://github.com/angular/angular/projects
Security and quality40 (40)https://github.com/angular/angular/security
Insightshttps://github.com/angular/angular/insights
https://github.com/angular/angular
New issuehttps://github.com/login?return_to=https://github.com/angular/angular/issues/22825
New issuehttps://github.com/login?return_to=https://github.com/angular/angular/issues/22825
ngOnInit is not respecting inheritance with AOT when base class is from an external librairy using barrel fileshttps://github.com/angular/angular/issues/22825#top
area: compilerIssues related to `ngc`, Angular's template compilerhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20compiler%22
area: coreIssues related to the framework runtimehttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20core%22
core: component extension and customizationhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22core%3A%20component%20extension%20and%20customization%22
core: lifecycle hookshttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22core%3A%20lifecycle%20hooks%22
freq1: lowhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22freq1%3A%20low%22
type: bug/fixhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22type%3A%20bug%2Ffix%22
Backloghttps://github.com/angular/angular/milestone/82
https://github.com/instriker
instrikerhttps://github.com/instriker
on Mar 16, 2018https://github.com/angular/angular/issues/22825#issue-305947785
githubhttps://github.com/instriker/bug-angular-aot-lib-1
githubhttps://github.com/instriker/bug-angular-aot-project-1
ngbothttps://github.com/apps/ngbot
needsTriagehttps://github.com/angular/angular/milestone/83
on Mar 16, 2018https://github.com/angular/angular/issues/22825#event-1525634468
matskohttps://github.com/matsko
area: coreIssues related to the framework runtimehttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20core%22
on Mar 22, 2018https://github.com/angular/angular/issues/22825#event-1536078876
mheveryhttps://github.com/mhevery
type: bug/fixhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22type%3A%20bug%2Ffix%22
freq1: lowhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22freq1%3A%20low%22
severity3: brokenhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22severity3%3A%20broken%22
on Mar 29, 2018https://github.com/angular/angular/issues/22825#event-1548926588
ngbothttps://github.com/apps/ngbot
needsTriagehttps://github.com/angular/angular/milestone/83
Backloghttps://github.com/angular/angular/milestone/82
on Mar 29, 2018https://github.com/angular/angular/issues/22825#event-1548926640
https://github.com/DcsMarcRemolt
DcsMarcRemolthttps://github.com/DcsMarcRemolt
on Jun 28, 2018https://github.com/angular/angular/issues/22825#issuecomment-400947679
pkozlowski-opensourcehttps://github.com/pkozlowski-opensource
area: compilerIssues related to `ngc`, Angular's template compilerhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20compiler%22
core: component extension and customizationhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22core%3A%20component%20extension%20and%20customization%22
core: lifecycle hookshttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22core%3A%20lifecycle%20hooks%22
on Mar 14, 2020https://github.com/angular/angular/issues/22825#event-3129676158
JoostKhttps://github.com/JoostK
fixed by Ivyhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22fixed%20by%20Ivy%22
on Mar 15, 2020https://github.com/angular/angular/issues/22825#event-3130857940
https://github.com/JoostK
JoostKhttps://github.com/JoostK
on Mar 15, 2020https://github.com/angular/angular/issues/22825#issuecomment-599252574
JoostKhttps://github.com/JoostK
completedhttps://github.com/angular/angular/issues?q=is%3Aissue%20state%3Aclosed%20archived%3Afalse%20reason%3Acompleted
on Mar 15, 2020https://github.com/angular/angular/issues/22825#event-3130863233
https://github.com/apps/angular-automatic-lock-bot
angular-automatic-lock-bothttps://github.com/apps/angular-automatic-lock-bot
on Apr 15, 2020https://github.com/angular/angular/issues/22825#issuecomment-614130597
automatic conversation locking policyhttps://github.com/angular/angular/blob/67d80f/docs/GITHUB_PROCESS.md#conversation-locking
angular-automatic-lock-bothttps://github.com/apps/angular-automatic-lock-bot
on Apr 15, 2020https://github.com/angular/angular/issues/22825#event-3236208189
Sign up for freehttps://github.com/signup?return_to=https://github.com/angular/angular/issues/22825
Sign in to commenthttps://github.com/login?return_to=https://github.com/angular/angular/issues/22825
area: compilerIssues related to `ngc`, Angular's template compilerhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20compiler%22
area: coreIssues related to the framework runtimehttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20core%22
core: component extension and customizationhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22core%3A%20component%20extension%20and%20customization%22
core: lifecycle hookshttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22core%3A%20lifecycle%20hooks%22
freq1: lowhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22freq1%3A%20low%22
type: bug/fixhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22type%3A%20bug%2Ffix%22
BacklogNo due datehttps://github.com/angular/angular/milestone/82
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.