Title: ngOnInit is not respecting inheritance with AOT when base class is from an external librairy using barrel files · Issue #22825 · angular/angular · GitHub
Open Graph Title: ngOnInit is not respecting inheritance with AOT when base class is from an external librairy using barrel files · Issue #22825 · angular/angular
X Title: ngOnInit is not respecting inheritance with AOT when base class is from an external librairy using barrel files · Issue #22825 · angular/angular
Description: I'm submitting a... [ ] Regression (a behavior that used to work and stopped working in a new release) [x] Bug report [ ] Feature request [ ] Documentation issue or request [ ] Support request => Please do not submit support request here...
Open Graph Description: I'm submitting a... [ ] Regression (a behavior that used to work and stopped working in a new release) [x] Bug report [ ] Feature request [ ] Documentation issue or request [ ] Support request => P...
X Description: I'm submitting a... [ ] Regression (a behavior that used to work and stopped working in a new release) [x] Bug report [ ] Feature request [ ] Documentation issue or request [ ] Support request ...
Opengraph URL: https://github.com/angular/angular/issues/22825
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"ngOnInit is not respecting inheritance with AOT when base class is from an external librairy using barrel files","articleBody":"## I'm submitting a...\r\n\u003cpre>\u003ccode>\r\n[ ] Regression (a behavior that used to work and stopped working in a new release)\r\n[x] Bug report \u003c!-- Please search GitHub for a similar issue or PR before submitting -->\r\n[ ] Feature request\r\n[ ] Documentation issue or request\r\n[ ] Support request => Please do not submit support request here, instead see https://github.com/angular/angular/blob/master/CONTRIBUTING.md#question\r\n\u003c/code>\u003c/pre>\r\n\r\n## Current behavior\r\n\r\nWhen\r\n- I have a component base class (`SimpleCoreComponent1`) coming from an external npm library that implements `ngOnInit`\r\n- AND that class has been exported via barrel files (index.ts)\r\n- BUT that barrel file has been exported via implicit refererence to index.ts (`export * from './components1';` instead of `export * from './components1/index';`)\r\n- AND I have an angular app with component (`ForumsComponent`) that extends `SimpleCoreComponent1`\r\n- BUT i didn't explicitly reimplement the `ngOnInit` in the `ForumsComponent`\r\n- AND i run the app with AOT enabled (`ng server --aot`)\r\n\r\nThen\r\n- the `ngOnInit` of the base class is not invoked .\r\n\r\n## Expected behavior\r\n\r\nLifecycle hooks (ngOnInit, ngOnDestroy, etc) must be invoked even if the base class is defined in an external npm package using barrel files with `index.ts` not explicitly stated.\r\n\r\n## Minimal reproduction of the problem with instructions\r\n\u003c!--\r\nFor bug reports please provide the *STEPS TO REPRODUCE* and if possible a *MINIMAL DEMO* of the problem via\r\nhttps://stackblitz.com or similar (you can use this template as a starting point: https://stackblitz.com/fork/angular-gitter).\r\n-->\r\n*STEPS TO REPRODUCE*\r\n\r\n*Create the angular library*\r\n\r\n> Note: Sample projet library source code available on [github](https://github.com/instriker/bug-angular-aot-lib-1)\r\n\r\n1) Setup library projet using yeoman\r\n```bash\r\nnpm install -g yo@2.0.0\r\nnpm install -g generator-ngx-library@5.4.0\r\nmkdir demolibraryforaot\r\ncd demolibraryforaot\r\nyo ngx-library\r\n```\r\n\r\n2) Create this directory structure:\r\n\r\n```\r\nsrc\r\n|- index.ts\r\n|- Components1\r\n |- index.ts\r\n |- simple-core-component.ts\r\n|- Components2\r\n |- index.ts\r\n |- simple-core-component.ts\r\n \r\n```\r\n\r\n3) Write the following code:\r\n```typescript\r\n// src/index.ts\r\nexport * from './components1'; // BUG: This export WON'T have the right .metadata.json exported:\r\nexport * from './components2/index'; // This export will have the right .metadata.json exported:\r\n\r\n// src/Components1/index.ts\r\nexport * from './simple-core-component';\r\n\r\n// src/Components1/simple-core-component.ts\r\nimport { OnInit } from '@angular/core';\r\n\r\nexport class SimpleCoreComponent1 implements OnInit {\r\n ngOnInit(): void {\r\n console.log('SimpleCoreComponent1.ngOnInit');\r\n }\r\n}\r\n\r\n// src/Components2/index.ts\r\nexport * from './simple-core-component';\r\n\r\n// src/Components2/simple-core-component.ts\r\nimport { OnInit } from '@angular/core';\r\n\r\nexport class SimpleCoreComponent2 implements OnInit {\r\n ngOnInit(): void {\r\n console.log('SimpleCoreComponent2.ngOnInit');\r\n }\r\n}\r\n```\r\n\r\n4) Create a package\r\n```bash\r\nnpm run start\r\n# Ignore the code coverage error\r\ncd dist\r\nnpm pack\r\n```\r\n\r\n*Create the angular app*\r\n\r\n> Note: Sample projet source code available on [github](https://github.com/instriker/bug-angular-aot-project-1)\r\n\r\n1) Create an angular app beside the angular library\r\n```bash\r\nng new angular-inh-aot-bug\r\n```\r\n\r\n2) Install dependencies\r\n```bash\r\ncd angular-inh-aot-bug\r\nnpm install\r\n```\r\n\r\n3) Install the npm package in the angular app\r\n```bash\r\n# Using locally built package:\r\nnpm install --save ../demolibraryforaot/dist/demolibraryforaot-0.0.1.tgz\r\n```\r\n\r\n4) Create a component in the angular app\r\n```bash\r\ncd src/app\r\nng generate component ForumsComponent\r\n```\r\n\r\n5) Edit ForumsComponent to extends SimpleCoreComponent1\r\n```typescript\r\nimport { Component } from '@angular/core';\r\nimport { SimpleCoreComponent1 } from 'demolibraryforaot';\r\n\r\n@Component({\r\n selector: 'app-forums',\r\n templateUrl: './forums.component.html',\r\n styleUrls: ['./forums.component.css']\r\n})\r\nexport class ForumsComponentWithoutIndex extends SimpleCoreComponent1 {\r\n}\r\n```\r\n\r\n6) Add the ForumsComponent to the AppComponent.html:\r\n```html\r\n\u003capp-forums>\u003c/app-forums>\r\n```\r\n\r\n7) Start with AOT:\r\n```bash\r\nng serve --aot \r\n```\r\n\r\n8) Open browser and see the base class ngOnInit is not invoked (no logs in the console)\r\nOpen `http://localhost:4200` in chrome\r\n\r\n*Now extends SimpleCoreComponent2 instead of SimpleCoreComponent1*\r\n\r\nLook at the console log: you'll see the ngOnInit is now invoked. The reason seems to be that the .metadata.json of the library is OK when we have the `/index` in the export of the barrel file.\r\n\r\n## What is the motivation / use case for changing the behavior?\r\n\r\nWe have a lot of angular projects expected to start in the near future. We want to be able to extract some of the good recipes teams develops in a common librairy to help cross-project collaboration.\r\n\r\nThat bug is 'nasty', as it's easy to do this kind of error, and not obvious for people investigating that bug why their code is not invoked.\r\n\r\n## Environment\r\n\r\n\u003cpre>\u003ccode>\r\nAngular version: 5.2.8\r\n\r\nBrowser:\r\n- [x] Chrome (desktop) version 64.0.3282.186 \r\n- [ ] Chrome (Android) version XX\r\n- [ ] Chrome (iOS) version XX\r\n- [ ] Firefox version XX\r\n- [ ] Safari (desktop) version XX\r\n- [ ] Safari (iOS) version XX\r\n- [ ] IE version XX\r\n- [ ] Edge version XX\r\n \r\nFor Tooling issues:\r\n- Node version: 5.6.0\r\n- Platform: Windows\r\n\r\nOthers:\r\n\u003c!-- Anything else relevant? Operating system version, IDE, package manager, HTTP server, ... -->\r\n\u003c/code>\u003c/pre>\r\n","author":{"url":"https://github.com/instriker","@type":"Person","name":"instriker"},"datePublished":"2018-03-16T14:25:44Z","url":"https://github.com/angular/angular/issues/22825"}
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:7387dc09-947d-b43a-bdf1-aa507cd50404 |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | ED50:3DD488:985531:C2A674:6B00F04E |
| html-safe-nonce | 03501832a69e968cae18b4c72e8764630dd34fa00663a821ad2c2151a9a1af15 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFRDUwOjNERDQ4ODo5ODU1MzE6QzJBNjc0OjZCMDBGMDRFIiwidmlzaXRvcl9pZCI6IjkxMTI0ODg0NjQyNDIyNDE2MTQiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | aba2f5884c255603056c6afdb2302feb575eb15ba6de35e2ea078905da0d1d7b |
| hovercard-subject-tag | issue:305947785 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/angular/angular/22825/issue_layout |
| twitter:image | https://opengraph.githubassets.com/c6849ddbfe310ffafe6916b3bbc8038000ed493f042b9add6b80d4cfcd2e7662/angular/angular/issues/22825 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/c6849ddbfe310ffafe6916b3bbc8038000ed493f042b9add6b80d4cfcd2e7662/angular/angular/issues/22825 |
| og:image:alt | I'm submitting a... [ ] Regression (a behavior that used to work and stopped working in a new release) [x] Bug report [ ] Feature request [ ] Documentation issue or request [ ] Support request => P... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | instriker |
| hostname | github.com |
| expected-hostname | github.com |
| None | 4ef498cbabcbe3c50befc7a5b743e7072ee770b4daf0e15e54801180d1fa91fc |
| turbo-cache-control | no-preview |
| go-import | github.com/angular/angular git https://github.com/angular/angular.git |
| octolytics-dimension-user_id | 139426 |
| octolytics-dimension-user_login | angular |
| octolytics-dimension-repository_id | 24195339 |
| octolytics-dimension-repository_nwo | angular/angular |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 24195339 |
| octolytics-dimension-repository_network_root_nwo | angular/angular |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 9983dd5da06943f833c971dd5b6bc988e2858be5 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | issues |
Links:
Viewport: width=device-width