Title: Feature Request: Add 'newInstanceOf' to "providers" · Issue #22756 · angular/angular · GitHub
Open Graph Title: Feature Request: Add 'newInstanceOf' to "providers" · Issue #22756 · angular/angular
X Title: Feature Request: Add 'newInstanceOf' to "providers" · Issue #22756 · angular/angular
Description: I'm submitting a... [ ] Regression (a behavior that used to work and stopped working in a new release) [ ] Bug report [x] Feature request [ ] Documentation issue or request [ ] Support request => Please do not submit support request here...
Open Graph Description: I'm submitting a... [ ] Regression (a behavior that used to work and stopped working in a new release) [ ] Bug report [x] Feature request [ ] Documentation issue or request [ ] Support request => P...
X Description: I'm submitting a... [ ] Regression (a behavior that used to work and stopped working in a new release) [ ] Bug report [x] Feature request [ ] Documentation issue or request [ ] Support request ...
Opengraph URL: https://github.com/angular/angular/issues/22756
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Feature Request: Add 'newInstanceOf' to \"providers\"","articleBody":"\u003c!--\r\nPLEASE HELP US PROCESS GITHUB ISSUES FASTER BY PROVIDING THE FOLLOWING INFORMATION.\r\n\r\nISSUES MISSING IMPORTANT INFORMATION MAY BE CLOSED WITHOUT INVESTIGATION.\r\n-->\r\n\r\n## I'm submitting a...\r\n\u003c!-- Check one of the following options with \"x\" -->\r\n\u003cpre>\u003ccode>\r\n[ ] Regression (a behavior that used to work and stopped working in a new release)\r\n[ ] Bug report \u003c!-- Please search GitHub for a similar issue or PR before submitting -->\r\n[x] Feature request\r\n[ ] Documentation issue or request\r\n[ ] Support request => Please do not submit support request here, instead see https://github.com/angular/angular/blob/master/CONTRIBUTING.md#question\r\n\u003c/code>\u003c/pre>\r\n\r\n## Current behavior\r\nComponent providers does not have a way of getting a new instance of a module defined provider.\r\nThis makes component reuse difficult between projects, if a component needs a \"private instance\" of an otherwise global service.\r\n\r\n\r\n## Expected behavior\r\n\u003c!-- Describe what the desired behavior would be. -->\r\nIdeally, I'd like to be able to get a new instance of whatever `Service` is defined to be in the injector tree.\r\n\r\nI propose a `newInstanceOf` or `newInstance` keyword in the `provide` struct, that would walk up the tree and return a new instance of that class.\r\n\r\nI.e.\r\n```\r\n@Component({\r\n providers: [\r\n { provide: Service, newInstance: true }\r\n ])\r\n```\r\n\r\nor incase I want to rename the service token\r\n\r\n```\r\n@Component({\r\n providers: [\r\n { provide: new InjectionToken\u003cService>('LocalService'), newInstanceOf: Service }\r\n ])\r\n```\r\n\r\n\r\n## Minimal reproduction of the problem with instructions\r\n\u003c!--\r\nFor bug reports please provide the *STEPS TO REPRODUCE* and if possible a *MINIMAL DEMO* of the problem via\r\nhttps://stackblitz.com or similar (you can use this template as a starting point: https://stackblitz.com/fork/angular-gitter).\r\n-->\r\n0. Create new project with `ng new`\r\n1. Create two services, let one extend the other.\r\n ```\r\n @Injectable()\r\n export class Service {};\r\n\r\n @Injectable()\r\n export class BetterService extends Service {};\r\n ```\r\n2. In `app.module` provide the extended service as the base service. \r\n ` { provide: Service, useClass: BetterService } `\r\n3. in `app.module` add constructor with \r\n```\r\n constructor(service: Service) {\r\n console.log('module', service.constructor.name);\r\n }\r\n```\r\n4. In `app.component`, add to `@Component`\r\n```\r\n providers: [ Service ]\r\n```\r\n5. In `app.component add constructor\r\n```\r\n constructor(service: Service) {\r\n console.log('component', service.constructor.name);\r\n }\r\n```\r\n6. Run.\r\n\r\nObserve that console shows\r\nModule BetterService\r\nComponent Service\r\n\r\n## What is the motivation / use case for changing the behavior?\r\n\u003c!-- Describe the motivation or the concrete use case. -->\r\n\r\nWriting components or entire modules that can take be reused between projects, while being able to have new versions of services injected, even when those are used as private instances. Notably, the Component, as its being reused, should not have knowledge of what concrete implementations of `Service` is available, just that it needs a private instance of whatever acts on behalf of `Service` right now.\r\n\r\nConsider two services\r\n```\r\n - Service\r\n - BetterService extends Service\r\n```\r\n\r\nIn `app.module.ts` I can now define that 'Service' should provide 'BetterService'\r\n```\r\n { provide: Service, useClass: BetterService }\r\n```\r\n\r\nIn my component i need a new instance of whatever `Service` is defined to be, in the global scope, but as the component is a shared component, it should not know that `BetterService` exists.\r\n\r\n```\r\n@Component({\r\n providers: [\r\n { provide: Service, useClass: ??? }\r\n ])\r\n```\r\n\r\n\r\n\r\n## Environment\r\n\r\n\u003cpre>\u003ccode>\r\nAngular version: 5.2.3\r\n\u003c!-- Check whether this is still an issue in the most recent Angular version -->\r\n\r\nBrowser:\r\n- [ ] Chrome (desktop) version XX\r\n- [ ] Chrome (Android) version XX\r\n- [ ] Chrome (iOS) version XX\r\n- [ ] Firefox version XX\r\n- [ ] Safari (desktop) version XX\r\n- [ ] Safari (iOS) version XX\r\n- [ ] IE version XX\r\n- [ ] Edge version XX\r\n \r\nFor Tooling issues:\r\n- Node version: XX \u003c!-- run `node --version` -->\r\n- Platform: \u003c!-- Mac, Linux, Windows -->\r\n\r\nOthers:\r\n\u003c!-- Anything else relevant? Operating system version, IDE, package manager, HTTP server, ... -->\r\n\u003c/code>\u003c/pre>\r\n","author":{"url":"https://github.com/asgerjensen","@type":"Person","name":"asgerjensen"},"datePublished":"2018-03-14T08:50:08Z","url":"https://github.com/angular/angular/issues/22756"}
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:00c3cd58-f98f-191f-8580-fe5f768695b6 |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | BFCE:2F8EE0:16761:1D56F:6B0155B7 |
| html-safe-nonce | 575d90a864db15710e915e77959e150de8e03c5632d5ab5ca48b5941cd66d2d4 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCRkNFOjJGOEVFMDoxNjc2MToxRDU2Rjo2QjAxNTVCNyIsInZpc2l0b3JfaWQiOiI0NzQ1MDc4NTI2MDkxMjg1OTQzIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | 8e050243d8d7af21c84493606f592da1c7d1fc5222c7dc71f2b882f6e2bfbc58 |
| hovercard-subject-tag | issue:305068690 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/angular/angular/22756/issue_layout |
| twitter:image | https://opengraph.githubassets.com/303773d959537f10248d6506cf3ab908a61fb663be3df1271c2c4c8f754f98aa/angular/angular/issues/22756 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/303773d959537f10248d6506cf3ab908a61fb663be3df1271c2c4c8f754f98aa/angular/angular/issues/22756 |
| og:image:alt | I'm submitting a... [ ] Regression (a behavior that used to work and stopped working in a new release) [ ] Bug report [x] Feature request [ ] Documentation issue or request [ ] Support request => P... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | asgerjensen |
| hostname | github.com |
| expected-hostname | github.com |
| None | cc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c |
| turbo-cache-control | no-preview |
| go-import | github.com/angular/angular git https://github.com/angular/angular.git |
| octolytics-dimension-user_id | 139426 |
| octolytics-dimension-user_login | angular |
| octolytics-dimension-repository_id | 24195339 |
| octolytics-dimension-repository_nwo | angular/angular |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 24195339 |
| octolytics-dimension-repository_network_root_nwo | angular/angular |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 8c77c9e8439031ad54c75a250694842892f693e1 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | issues |
Links:
Viewport: width=device-width