René's URL Explorer Experiment


Title: Creating ROUTES with custom factory function ends up with "Cannot read property 'loadChildren' of undefined" error · Issue #22700 · angular/angular · GitHub

Open Graph Title: Creating ROUTES with custom factory function ends up with "Cannot read property 'loadChildren' of undefined" error · Issue #22700 · angular/angular

X Title: Creating ROUTES with custom factory function ends up with "Cannot read property 'loadChildren' of undefined" error · Issue #22700 · angular/angular

Description: I'm submitting a... [ ] Regression (a behavior that used to work and stopped working in a new release) [x] Bug report [ ] Feature request [ ] Documentation issue o...

Open Graph Description: I'm submitting a... [ ] Regression (a behavior that used to work and stopped working in a new release) [x] Bug report [ ] F...

X Description: I'm submitting a... [ ] Regression (a behavior that used to work and stopped working in a new release) [x] Bug report <!-- Please search GitHub for a similar issue or PR before submitting --...

Opengraph URL: https://github.com/angular/angular/issues/22700

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Creating ROUTES with custom factory function ends up with \"Cannot read property 'loadChildren' of undefined\" error","articleBody":"## I'm submitting a...\r\n\r\n```\r\n[ ] Regression (a behavior that used to work and stopped working in a new release)\r\n[x] Bug report  \u003c!-- Please search GitHub for a similar issue or PR before submitting -->\r\n[ ] Feature request\r\n[ ] Documentation issue or request\r\n[ ] Support request => Please do not submit support request here, instead see https://github.com/angular/angular/blob/master/CONTRIBUTING.md#question\r\n```\r\n\r\n## Current behavior\r\n\r\nWhen angular compiler finds a provider that defines `ROUTES`, but which doesn't have a `useValue` property, (because it has f.e. `useFactory` property instead) it fails with the following error:\r\n\r\n```\r\nERROR in TypeError: Cannot read property 'loadChildren' of undefined\r\n    at _collectLoadChildren (/Users/jtomaszewski/src/recruitee/rails/admin_app/node_modules/@angular/compiler/bundles/compiler.umd.js:29034:20)\r\n    at listLazyRoutes (/Users/jtomaszewski/src/recruitee/rails/admin_app/node_modules/@angular/compiler/bundles/compiler.umd.js:29009:49)\r\n    at AotCompiler.listLazyRoutes (/Users/jtomaszewski/src/recruitee/rails/admin_app/node_modules/@angular/compiler/bundles/compiler.umd.js:31150:51)\r\n    at AngularCompilerProgram.listLazyRoutes (/Users/jtomaszewski/src/recruitee/rails/admin_app/node_modules/@angular/compiler-cli/src/transformers/program.js:156:30)\r\n    at AngularCompilerPlugin._listLazyRoutesFromProgram (/Users/jtomaszewski/src/recruitee/rails/admin_app/node_modules/@ngtools/webpack/src/angular_compiler_plugin.js:304:38)\r\n    at Promise.resolve.then.then (/Users/jtomaszewski/src/recruitee/rails/admin_app/node_modules/@ngtools/webpack/src/angular_compiler_plugin.js:583:50)\r\n    at process._tickCallback (internal/process/next_tick.js:109:7)\r\nwebpack: Failed to compile.\r\n```\r\n\r\n## Expected behavior\r\n\r\nDefining a provider for `ROUTES` with other providers like f.e. `FactoryProvider` should just work.\r\n\r\n## Minimal reproduction of the problem with instructions\r\n\r\n1. Write your module like this:\r\n\r\n```ts\r\nimport { NgModule, NgModuleFactory, Compiler } from '@angular/core';\r\nimport { Routes, RouterModule, ROUTES } from '@angular/router';\r\n\r\nexport function MainRoutingLazyRoutesFactory(compiler: Compiler): Routes {\r\n  return [\r\n    {\r\n      path: 'dashboard',\r\n      loadChildren: () => {\r\n        return \u003cany>System.import('../features/dashboard/dashboard.module')\r\n          .then(({ DashboardFeatureModule }) => DashboardFeatureModule)\r\n          .then(ngModule => {\r\n            if (ngModule instanceof NgModuleFactory) {\r\n              return ngModule;\r\n            } else {\r\n              return compiler.compileModuleAsync(ngModule);\r\n            }\r\n          });\r\n      },\r\n    },\r\n  ];\r\n}\r\n\r\n@NgModule({\r\n  imports: [RouterModule],\r\n  exports: [RouterModule],\r\n  providers: [\r\n    {\r\n      provide: ROUTES,\r\n      multi: true,\r\n      deps: [Compiler],\r\n      useFactory: MainRoutingLazyRoutesFactory,\r\n    },\r\n  ],\r\n})\r\nexport class MainRoutingModule {}\r\n```\r\n\r\n2. Try to compile it, in either JiT or AoT mode.\r\n\r\n## What is the motivation / use case for changing the behavior?\r\n\r\nIt lets you to easily implement lazy loaded modules in your routes with your custom way.\r\n\r\n## Environment\r\n\r\n```\r\nnode 6.11.5\r\nnpm 5.6.0\r\nangular 5.2.8\r\n@ngtools/webpack 1.10.2\r\n```","author":{"url":"https://github.com/jtomaszewski","@type":"Person","name":"jtomaszewski"},"datePublished":"2018-03-10T21:44:24Z","url":"https://github.com/angular/angular/issues/22700"}

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:6cf2f32c-5ef3-91af-50dc-b21e0a101d21
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-idE6A0:1F2D:2206AD:2B3502:6B00FCA3
html-safe-nonce5d611d5c071e3981ab0a589a99cc163d38868c5a7819ec19c7a7848373cfa252
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFNkEwOjFGMkQ6MjIwNkFEOjJCMzUwMjo2QjAwRkNBMyIsInZpc2l0b3JfaWQiOiI3MjI0NTQzMDE5ODU1MzE0MDgzIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac2e6a18e68d903af8ee1201cf91af351b96a97bab51ce4dd834c50f384b303221
hovercard-subject-tagissue:304108106
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/angular/angular/22700/issue_layout
twitter:imagehttps://opengraph.githubassets.com/36f4237bc96cc4bf1778b17b7969c6359038eb6d97c24410d1aa8faf0d7e1c33/angular/angular/issues/22700
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/36f4237bc96cc4bf1778b17b7969c6359038eb6d97c24410d1aa8faf0d7e1c33/angular/angular/issues/22700
og:image:altI'm submitting a... [ ] Regression (a behavior that used to work and stopped working in a new release) [x] Bug report [ ] F...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamejtomaszewski
hostnamegithub.com
expected-hostnamegithub.com
Nonee208d86428ec00a57ade75058166297440e8128a01e5287c31a53dc042bbf187
turbo-cache-controlno-preview
go-importgithub.com/angular/angular git https://github.com/angular/angular.git
octolytics-dimension-user_id139426
octolytics-dimension-user_loginangular
octolytics-dimension-repository_id24195339
octolytics-dimension-repository_nwoangular/angular
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id24195339
octolytics-dimension-repository_network_root_nwoangular/angular
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release7dafd017fb7809a839c443dba08622af38e63c09
ui-targetcanary-2
theme-color#1e2327
color-schemelight dark
react-app-nameissues

Links:

Skip to contenthttps://github.com/angular/angular/issues/22700#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fissues%2F22700
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fissues%2F22700
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=angular%2Fangular
Reloadhttps://github.com/angular/angular/issues/22700
Reloadhttps://github.com/angular/angular/issues/22700
Reloadhttps://github.com/angular/angular/issues/22700
angularhttps://github.com/angular
angularhttps://github.com/angular/angular
Codehttps://github.com/angular/angular
Issues835 (835)https://github.com/angular/angular/issues
Pull requests141 (141)https://github.com/angular/angular/pulls
Discussionshttps://github.com/angular/angular/discussions
Actionshttps://github.com/angular/angular/actions
Projectshttps://github.com/angular/angular/projects
Security and quality40 (40)https://github.com/angular/angular/security
Insightshttps://github.com/angular/angular/insights
https://github.com/angular/angular
New issuehttps://github.com/login?return_to=https://github.com/angular/angular/issues/22700
New issuehttps://github.com/login?return_to=https://github.com/angular/angular/issues/22700
Creating ROUTES with custom factory function ends up with "Cannot read property 'loadChildren' of undefined" errorhttps://github.com/angular/angular/issues/22700#top
P5The team acknowledges the request but does not plan to address it, it remains open for discussionhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22P5%22
area: coreIssues related to the framework runtimehttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20core%22
freq1: lowhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22freq1%3A%20low%22
needs: clarificationThis issue needs additional clarification from the reporter before the team can investigate.https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22needs%3A%20clarification%22
type: bug/fixhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22type%3A%20bug%2Ffix%22
Backloghttps://github.com/angular/angular/milestone/82
https://github.com/jtomaszewski
jtomaszewskihttps://github.com/jtomaszewski
on Mar 10, 2018https://github.com/angular/angular/issues/22700#issue-304108106
Nexthttps://github.com/angular/angular/issues/22700?timeline_page=1
ngbothttps://github.com/apps/ngbot
needsTriagehttps://github.com/angular/angular/milestone/83
on Mar 10, 2018https://github.com/angular/angular/issues/22700#event-1514805586
https://github.com/jtomaszewski
jtomaszewskihttps://github.com/jtomaszewski
on Mar 10, 2018https://github.com/angular/angular/issues/22700#issuecomment-372069669
this codehttps://github.com/angular/angular/blob/c8a1a14b87e5907458e8e87021e47f9796cb3257/packages/compiler/src/aot/lazy_routes.ts#L28
angular/angular-cli#9913https://github.com/angular/angular-cli/issues/9913
karahttps://github.com/kara
area: routerhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20router%22
on Mar 12, 2018https://github.com/angular/angular/issues/22700#event-1515454329
https://github.com/jasonaden
jasonadenhttps://github.com/jasonaden
on Mar 16, 2018https://github.com/angular/angular/issues/22700#issuecomment-373853520
@jtomaszewskihttps://github.com/jtomaszewski
StackBlitzhttp://stackblitz/com
jasonadenhttps://github.com/jasonaden
state: Follow Uphttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22state%3A%20Follow%20Up%22
on Mar 16, 2018https://github.com/angular/angular/issues/22700#event-1526473779
https://github.com/emanuelpinho
emanuelpinhohttps://github.com/emanuelpinho
on Apr 10, 2018https://github.com/angular/angular/issues/22700#issuecomment-380071430
@jasonadenhttps://github.com/jasonaden
https://stackblitz.com/edit/angular-nxvknfhttps://stackblitz.com/edit/angular-nxvknf
jasonadenhttps://github.com/jasonaden
area: coreIssues related to the framework runtimehttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20core%22
area: routerhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20router%22
on Apr 10, 2018https://github.com/angular/angular/issues/22700#event-1567335315
https://github.com/jtomaszewski
jtomaszewskihttps://github.com/jtomaszewski
on Apr 14, 2018https://github.com/angular/angular/issues/22700#issuecomment-381326524
@jasonadenhttps://github.com/jasonaden
https://stackblitz.com/edit/angular-db84dhhttps://stackblitz.com/edit/angular-db84dh
https://user-images.githubusercontent.com/1862580/38768304-fed1c882-3ff1-11e8-9caf-ee99dc79672e.png
mheveryhttps://github.com/mhevery
type: bug/fixhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22type%3A%20bug%2Ffix%22
freq1: lowhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22freq1%3A%20low%22
severity3: brokenhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22severity3%3A%20broken%22
on May 3, 2018https://github.com/angular/angular/issues/22700#event-1608803577
ngbothttps://github.com/apps/ngbot
needsTriagehttps://github.com/angular/angular/milestone/83
Backloghttps://github.com/angular/angular/milestone/82
on May 3, 2018https://github.com/angular/angular/issues/22700#event-1608803640
https://github.com/doivosevic
doivosevichttps://github.com/doivosevic
on May 8, 2018https://github.com/angular/angular/issues/22700#issuecomment-387560635
jelbournhttps://github.com/jelbourn
P3An issue that is relevant to core functions, but does not impede progress. Important, but not urgenthttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22P3%22
on Oct 1, 2020https://github.com/angular/angular/issues/22700#event-3830247273
ngbothttps://github.com/apps/ngbot
Backloghttps://github.com/angular/angular/milestone/82
needsTriagehttps://github.com/angular/angular/milestone/83
on Oct 1, 2020https://github.com/angular/angular/issues/22700#event-3830247383
jelbournhttps://github.com/jelbourn
P3An issue that is relevant to core functions, but does not impede progress. Important, but not urgenthttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22P3%22
on Oct 1, 2020https://github.com/angular/angular/issues/22700#event-3830254715
ngbothttps://github.com/apps/ngbot
needsTriagehttps://github.com/angular/angular/milestone/83
Backloghttps://github.com/angular/angular/milestone/82
on Oct 1, 2020https://github.com/angular/angular/issues/22700#event-3830254815
jelbournhttps://github.com/jelbourn
P5The team acknowledges the request but does not plan to address it, it remains open for discussionhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22P5%22
needs: clarificationThis issue needs additional clarification from the reporter before the team can investigate.https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22needs%3A%20clarification%22
P3An issue that is relevant to core functions, but does not impede progress. Important, but not urgenthttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22P3%22
severity3: brokenhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22severity3%3A%20broken%22
state: Follow Uphttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22state%3A%20Follow%20Up%22
on Oct 1, 2020https://github.com/angular/angular/issues/22700#event-3830298584
https://github.com/JoostK
JoostKhttps://github.com/JoostK
on Sep 30, 2021https://github.com/angular/angular/issues/22700#issuecomment-931652165
#43591https://github.com/angular/angular/pull/43591
JoostKhttps://github.com/JoostK
completedhttps://github.com/angular/angular/issues?q=is%3Aissue%20state%3Aclosed%20archived%3Afalse%20reason%3Acompleted
on Sep 30, 2021https://github.com/angular/angular/issues/22700#event-5390281202
https://github.com/apps/angular-automatic-lock-bot
angular-automatic-lock-bothttps://github.com/apps/angular-automatic-lock-bot
on Oct 31, 2021https://github.com/angular/angular/issues/22700#issuecomment-955741742
automatic conversation locking policyhttps://github.com/angular/angular/blob/8f24bc9443b3872fe095d9f7f77b308a361a13b4/docs/GITHUB_PROCESS.md#conversation-locking
angular-automatic-lock-bothttps://github.com/apps/angular-automatic-lock-bot
on Oct 31, 2021https://github.com/angular/angular/issues/22700#event-5545407372
Sign up for freehttps://github.com/signup?return_to=https://github.com/angular/angular/issues/22700
Sign in to commenthttps://github.com/login?return_to=https://github.com/angular/angular/issues/22700
P5The team acknowledges the request but does not plan to address it, it remains open for discussionhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22P5%22
area: coreIssues related to the framework runtimehttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20core%22
freq1: lowhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22freq1%3A%20low%22
needs: clarificationThis issue needs additional clarification from the reporter before the team can investigate.https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22needs%3A%20clarification%22
type: bug/fixhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22type%3A%20bug%2Ffix%22
BacklogNo due datehttps://github.com/angular/angular/milestone/82
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.