Title: detectChanges is not updating host binding with OnPush · Issue #22560 · angular/angular · GitHub
Open Graph Title: detectChanges is not updating host binding with OnPush · Issue #22560 · angular/angular
X Title: detectChanges is not updating host binding with OnPush · Issue #22560 · angular/angular
Description: I'm submitting a... [ ] Regression (a behavior that used to work and stopped working in a new release) [x] Bug report [ ] Feature request [ ] Documentation issue or request [ ] Support request => Please do not submit support request here...
Open Graph Description: I'm submitting a... [ ] Regression (a behavior that used to work and stopped working in a new release) [x] Bug report [ ] Feature request [ ] Documentation issue or request [ ] Support request => P...
X Description: I'm submitting a... [ ] Regression (a behavior that used to work and stopped working in a new release) [x] Bug report [ ] Feature request [ ] Documentation issue or request [ ] Support request ...
Opengraph URL: https://github.com/angular/angular/issues/22560
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"detectChanges is not updating host binding with OnPush","articleBody":"## I'm submitting a...\r\n\u003cpre>\u003ccode>\r\n[ ] Regression (a behavior that used to work and stopped working in a new release)\r\n[x] Bug report \u003c!-- Please search GitHub for a similar issue or PR before submitting -->\r\n[ ] Feature request\r\n[ ] Documentation issue or request\r\n[ ] Support request => Please do not submit support request here, instead see https://github.com/angular/angular/blob/master/CONTRIBUTING.md#question\r\n\u003c/code>\u003c/pre>\r\n\r\n## Current behavior\r\nWhen using ControlValueAccessor interface and calling change detector `detectChanges` inside writeValue method, it is not updating host binding css class, but calling `markForCheck` does.\r\nAlso it is important to notice that this doesn't work only on first ngModel change, if I change it second time, then it is working fine.\r\n\r\nIn my example .has-value css class is not applied even if I call detectChanges.\r\n```js\r\n host: {\r\n '[class.has-value]': 'hasValue'\r\n },\r\n\r\n //...\r\n\r\n get hasValue() {\r\n return !!this.value;\r\n }\r\n\r\n writeValue(value) {\r\n console.log('writeValue', value);\r\n this.value = value;\r\n this._cd.detectChanges();\r\n\r\n // will work\r\n // this.cd.markForCheck();\r\n }\r\n```\r\ncalling markForCheck will trigger view to update, but this is bad because:\r\n1) detectChanges should update view in any way\r\n2) using markForCheck in this case complicates unit testing because fixture.detectChanges should be called minimum two times because of markForCheck\r\n\r\n## Expected behavior\r\ndetectChanges should always update all bindings correctly\r\n\r\n## Minimal reproduction of the problem with instructions\r\nhttps://stackblitz.com/edit/angular-host-binding-bug?file=app%2Fapp.component.ts\r\n\r\n\r\n## Environment\r\n\r\n\u003cpre>\u003ccode>\r\nAngular version: 5.x.x\r\n\r\nBrowser:\r\n- [x] Chrome (desktop) version XX\r\n \r\n\u003c/code>\u003c/pre>\r\n","author":{"url":"https://github.com/anjmao","@type":"Person","name":"anjmao"},"datePublished":"2018-03-02T21:30:05Z","url":"https://github.com/angular/angular/issues/22560"}
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:0ba75afb-d40c-ea39-e67b-614f6c19ac8b |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | E14C:11EACE:12EAB6D:1941008:6B01259F |
| html-safe-nonce | a8e1d4061f5f0635069ad002bdfa7cbfdf6c0426cd25484b70841edf6b36d098 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFMTRDOjExRUFDRToxMkVBQjZEOjE5NDEwMDg6NkIwMTI1OUYiLCJ2aXNpdG9yX2lkIjoiNDM3ODE0OTg1Nzg1NzE4NTE4MyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | dc9d9af6a9c2305f4f7d13f8784883a997c7d1549ad001062ed13e49a629c0e6 |
| hovercard-subject-tag | issue:301911053 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/angular/angular/22560/issue_layout |
| twitter:image | https://opengraph.githubassets.com/f6e8e40a4f88924f2649797abfc88d7d337676044a6ab26a44e006180fa006d0/angular/angular/issues/22560 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/f6e8e40a4f88924f2649797abfc88d7d337676044a6ab26a44e006180fa006d0/angular/angular/issues/22560 |
| og:image:alt | I'm submitting a... [ ] Regression (a behavior that used to work and stopped working in a new release) [x] Bug report [ ] Feature request [ ] Documentation issue or request [ ] Support request => P... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | anjmao |
| hostname | github.com |
| expected-hostname | github.com |
| None | cc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c |
| turbo-cache-control | no-preview |
| go-import | github.com/angular/angular git https://github.com/angular/angular.git |
| octolytics-dimension-user_id | 139426 |
| octolytics-dimension-user_login | angular |
| octolytics-dimension-repository_id | 24195339 |
| octolytics-dimension-repository_nwo | angular/angular |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 24195339 |
| octolytics-dimension-repository_network_root_nwo | angular/angular |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 8c77c9e8439031ad54c75a250694842892f693e1 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | issues |
Links:
Viewport: width=device-width