René's URL Explorer Experiment


Title: detectChanges is not updating host binding with OnPush · Issue #22560 · angular/angular · GitHub

Open Graph Title: detectChanges is not updating host binding with OnPush · Issue #22560 · angular/angular

X Title: detectChanges is not updating host binding with OnPush · Issue #22560 · angular/angular

Description: I'm submitting a... [ ] Regression (a behavior that used to work and stopped working in a new release) [x] Bug report [ ] Feature request [ ] Documentation issue or request [ ] Support request => Please do not submit support request here...

Open Graph Description: I'm submitting a... [ ] Regression (a behavior that used to work and stopped working in a new release) [x] Bug report [ ] Feature request [ ] Documentation issue or request [ ] Support request => P...

X Description: I'm submitting a... [ ] Regression (a behavior that used to work and stopped working in a new release) [x] Bug report [ ] Feature request [ ] Documentation issue or request [ ] Support request ...

Opengraph URL: https://github.com/angular/angular/issues/22560

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"detectChanges is not updating host binding with OnPush","articleBody":"## I'm submitting a...\r\n\u003cpre>\u003ccode>\r\n[ ] Regression (a behavior that used to work and stopped working in a new release)\r\n[x] Bug report  \u003c!-- Please search GitHub for a similar issue or PR before submitting -->\r\n[ ] Feature request\r\n[ ] Documentation issue or request\r\n[ ] Support request => Please do not submit support request here, instead see https://github.com/angular/angular/blob/master/CONTRIBUTING.md#question\r\n\u003c/code>\u003c/pre>\r\n\r\n## Current behavior\r\nWhen using ControlValueAccessor interface and calling change detector `detectChanges` inside writeValue method, it is not updating host binding css class, but calling `markForCheck` does.\r\nAlso it is important to notice that this doesn't work only on first ngModel change, if I change it second time, then it is working fine.\r\n\r\nIn my example .has-value css class is not applied even if I call detectChanges.\r\n```js\r\n  host: {\r\n      '[class.has-value]': 'hasValue'\r\n  },\r\n\r\n  //...\r\n\r\n  get hasValue() {\r\n    return !!this.value;\r\n  }\r\n\r\n  writeValue(value) {\r\n    console.log('writeValue', value);\r\n    this.value = value;\r\n    this._cd.detectChanges();\r\n\r\n    // will work\r\n    // this.cd.markForCheck();\r\n  }\r\n```\r\ncalling markForCheck will trigger view to update, but this is bad because:\r\n1) detectChanges should update view in any way\r\n2) using markForCheck in this case complicates unit testing because fixture.detectChanges should be called minimum two times because of markForCheck\r\n\r\n## Expected behavior\r\ndetectChanges should always update all bindings correctly\r\n\r\n## Minimal reproduction of the problem with instructions\r\nhttps://stackblitz.com/edit/angular-host-binding-bug?file=app%2Fapp.component.ts\r\n\r\n\r\n## Environment\r\n\r\n\u003cpre>\u003ccode>\r\nAngular version: 5.x.x\r\n\r\nBrowser:\r\n- [x] Chrome (desktop) version XX\r\n \r\n\u003c/code>\u003c/pre>\r\n","author":{"url":"https://github.com/anjmao","@type":"Person","name":"anjmao"},"datePublished":"2018-03-02T21:30:05Z","url":"https://github.com/angular/angular/issues/22560"}

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:0ba75afb-d40c-ea39-e67b-614f6c19ac8b
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-idE14C:11EACE:12EAB6D:1941008:6B01259F
html-safe-noncea8e1d4061f5f0635069ad002bdfa7cbfdf6c0426cd25484b70841edf6b36d098
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFMTRDOjExRUFDRToxMkVBQjZEOjE5NDEwMDg6NkIwMTI1OUYiLCJ2aXNpdG9yX2lkIjoiNDM3ODE0OTg1Nzg1NzE4NTE4MyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacdc9d9af6a9c2305f4f7d13f8784883a997c7d1549ad001062ed13e49a629c0e6
hovercard-subject-tagissue:301911053
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/angular/angular/22560/issue_layout
twitter:imagehttps://opengraph.githubassets.com/f6e8e40a4f88924f2649797abfc88d7d337676044a6ab26a44e006180fa006d0/angular/angular/issues/22560
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/f6e8e40a4f88924f2649797abfc88d7d337676044a6ab26a44e006180fa006d0/angular/angular/issues/22560
og:image:altI'm submitting a... [ ] Regression (a behavior that used to work and stopped working in a new release) [x] Bug report [ ] Feature request [ ] Documentation issue or request [ ] Support request => P...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameanjmao
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-preview
go-importgithub.com/angular/angular git https://github.com/angular/angular.git
octolytics-dimension-user_id139426
octolytics-dimension-user_loginangular
octolytics-dimension-repository_id24195339
octolytics-dimension-repository_nwoangular/angular
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id24195339
octolytics-dimension-repository_network_root_nwoangular/angular
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-nameissues

Links:

Skip to contenthttps://github.com/angular/angular/issues/22560#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fissues%2F22560
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fissues%2F22560
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=angular%2Fangular
Reloadhttps://github.com/angular/angular/issues/22560
Reloadhttps://github.com/angular/angular/issues/22560
Reloadhttps://github.com/angular/angular/issues/22560
angularhttps://github.com/angular
angularhttps://github.com/angular/angular
Codehttps://github.com/angular/angular
Issues835 (835)https://github.com/angular/angular/issues
Pull requests141 (141)https://github.com/angular/angular/pulls
Discussionshttps://github.com/angular/angular/discussions
Actionshttps://github.com/angular/angular/actions
Projectshttps://github.com/angular/angular/projects
Security and quality40 (40)https://github.com/angular/angular/security
Insightshttps://github.com/angular/angular/insights
https://github.com/angular/angular
New issuehttps://github.com/login?return_to=https://github.com/angular/angular/issues/22560
New issuehttps://github.com/login?return_to=https://github.com/angular/angular/issues/22560
detectChanges is not updating host binding with OnPushhttps://github.com/angular/angular/issues/22560#top
area: coreIssues related to the framework runtimehttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20core%22
needsTriagehttps://github.com/angular/angular/milestone/83
https://github.com/anjmao
anjmaohttps://github.com/anjmao
on Mar 2, 2018https://github.com/angular/angular/issues/22560#issue-301911053
https://stackblitz.com/edit/angular-host-binding-bug?file=app%2Fapp.component.tshttps://stackblitz.com/edit/angular-host-binding-bug?file=app%2Fapp.component.ts
alexeaglehttps://github.com/alexeagle
area: coreIssues related to the framework runtimehttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20core%22
on Mar 2, 2018https://github.com/angular/angular/issues/22560#event-1502088822
ngbothttps://github.com/apps/ngbot
needsTriagehttps://github.com/angular/angular/milestone/83
on Mar 2, 2018https://github.com/angular/angular/issues/22560#event-1502088889
https://github.com/alexzuza
alexzuzahttps://github.com/alexzuza
on Mar 3, 2018https://github.com/angular/angular/issues/22560#issuecomment-370140707
https://github.com/anjmao
anjmaohttps://github.com/anjmao
on Mar 3, 2018https://github.com/angular/angular/issues/22560#issuecomment-370182084
@alexzuzahttps://github.com/alexzuza
https://github.com/NikolayDonev
NikolayDonevhttps://github.com/NikolayDonev
on Mar 29, 2018https://github.com/angular/angular/issues/22560#issuecomment-377226649
https://github.com/mhevery
mheveryhttps://github.com/mhevery
on Mar 29, 2018https://github.com/angular/angular/issues/22560#issuecomment-377398693
mheveryhttps://github.com/mhevery
completedhttps://github.com/angular/angular/issues?q=is%3Aissue%20state%3Aclosed%20archived%3Afalse%20reason%3Acompleted
on Mar 29, 2018https://github.com/angular/angular/issues/22560#event-1548958648
https://github.com/david-garcia-garcia
david-garcia-garciahttps://github.com/david-garcia-garcia
on Mar 18, 2019https://github.com/angular/angular/issues/22560#issuecomment-473958144
https://github.com/apps/angular-automatic-lock-bot
angular-automatic-lock-bothttps://github.com/apps/angular-automatic-lock-bot
on Sep 14, 2019https://github.com/angular/angular/issues/22560#issuecomment-531510616
automatic conversation locking policyhttps://github.com/angular/angular/blob/67d80f/docs/GITHUB_PROCESS.md#conversation-locking
angular-automatic-lock-bothttps://github.com/apps/angular-automatic-lock-bot
on Sep 14, 2019https://github.com/angular/angular/issues/22560#event-2634318443
JeanMechehttps://github.com/JeanMeche
detectChanges() does not update HostBinding #40062https://github.com/angular/angular/issues/40062
on Sep 16, 2025https://github.com/angular/angular/issues/22560#event-19736542143
Sign up for freehttps://github.com/signup?return_to=https://github.com/angular/angular/issues/22560
Sign in to commenthttps://github.com/login?return_to=https://github.com/angular/angular/issues/22560
area: coreIssues related to the framework runtimehttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20core%22
needsTriageNo due datehttps://github.com/angular/angular/milestone/83
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.