René's URL Explorer Experiment


Title: Add location sync code for hash-based navigation from AngularJS · Issue #21995 · angular/angular · GitHub

Open Graph Title: Add location sync code for hash-based navigation from AngularJS · Issue #21995 · angular/angular

X Title: Add location sync code for hash-based navigation from AngularJS · Issue #21995 · angular/angular

Description: AnguarJS applications using hash-based URL navigation can encounter a problem after #21728 which added a value to history.state. In fact, AngularJS applications using hash-based URL navigation will encounter this problem any time somethi...

Open Graph Description: AnguarJS applications using hash-based URL navigation can encounter a problem after #21728 which added a value to history.state. In fact, AngularJS applications using hash-based URL navigation will...

X Description: AnguarJS applications using hash-based URL navigation can encounter a problem after #21728 which added a value to history.state. In fact, AngularJS applications using hash-based URL navigation will...

Opengraph URL: https://github.com/angular/angular/issues/21995

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Add location sync code for hash-based navigation from AngularJS","articleBody":"AnguarJS applications using hash-based URL navigation can encounter a problem after #21728 which added a value to `history.state`. In fact, AngularJS applications using hash-based URL navigation will encounter this problem any time something exists in `history.state`.\r\n\r\nIt turns out the browser publishes a `popstate` event when the hash on the URL changes. So that's how the Angular router was getting notified of URL changes caused by the AngularJS router when using hash-based URL navigation. Apps didn't need the \"upgrade\" code because of this.\r\n\r\nThe change applied in #21728 gives the option to pass a \"state\" to the history API calls for Angular's Location service. This is something AngularJS had, but was never implemented in Angular.\r\n\r\nThe router used these new APIs to store it's `navigationId` in the history API which allows us to sync the two routers much better. However, there was a side effect in AngularJS which is if it sees the history API had been used, it assumes you want to update location through the history API rather than location.hash or location.url (both of which will trigger the `popstate` event Angular's router hooks into). If you use the history API directly, a `popstate` isn't published and therefore we needed to add the sync code to keep the two routers in sync (this is similar code anyone using HTML5 URLs would already have done). That code looks slightly different to manage hash-based URLs, and we will need to add this solution to the `@angular/router/upgrade` package for other projects to take advantage of.\r\n\r\n","author":{"url":"https://github.com/jasonaden","@type":"Person","name":"jasonaden"},"datePublished":"2018-02-02T17:24:24Z","url":"https://github.com/angular/angular/issues/21995"}

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:2b32530d-c382-bf70-bec9-01531b586da3
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-idCD3A:21AC3F:21E1F14:2ADA1B7:6B015B40
html-safe-nonce21eb0dec76b52cf0647f1da39a2265b81e61aa8bfa4185df9956d53001b50f73
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDRDNBOjIxQUMzRjoyMUUxRjE0OjJBREExQjc6NkIwMTVCNDAiLCJ2aXNpdG9yX2lkIjoiMjU1OTU4NjMxMTYwMjI2NDg5NiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac93b88aed033be9abe8c4c06d25c38846b8f23fad4dd2a24ff413b3dd8c15c565
hovercard-subject-tagissue:293963468
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/angular/angular/21995/issue_layout
twitter:imagehttps://opengraph.githubassets.com/f6493f4ee2e791b58bbf717ddb21a1ffbf535143cfdf2aa14003a511a285b37c/angular/angular/issues/21995
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/f6493f4ee2e791b58bbf717ddb21a1ffbf535143cfdf2aa14003a511a285b37c/angular/angular/issues/21995
og:image:altAnguarJS applications using hash-based URL navigation can encounter a problem after #21728 which added a value to history.state. In fact, AngularJS applications using hash-based URL navigation will...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamejasonaden
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-preview
go-importgithub.com/angular/angular git https://github.com/angular/angular.git
octolytics-dimension-user_id139426
octolytics-dimension-user_loginangular
octolytics-dimension-repository_id24195339
octolytics-dimension-repository_nwoangular/angular
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id24195339
octolytics-dimension-repository_network_root_nwoangular/angular
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-nameissues

Links:

Skip to contenthttps://github.com/angular/angular/issues/21995#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fissues%2F21995
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fissues%2F21995
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=angular%2Fangular
Reloadhttps://github.com/angular/angular/issues/21995
Reloadhttps://github.com/angular/angular/issues/21995
Reloadhttps://github.com/angular/angular/issues/21995
angularhttps://github.com/angular
angularhttps://github.com/angular/angular
Codehttps://github.com/angular/angular
Issues836 (836)https://github.com/angular/angular/issues
Pull requests141 (141)https://github.com/angular/angular/pulls
Discussionshttps://github.com/angular/angular/discussions
Actionshttps://github.com/angular/angular/actions
Projectshttps://github.com/angular/angular/projects
Security and quality40 (40)https://github.com/angular/angular/security
Insightshttps://github.com/angular/angular/insights
https://github.com/angular/angular
New issuehttps://github.com/login?return_to=https://github.com/angular/angular/issues/21995
New issuehttps://github.com/login?return_to=https://github.com/angular/angular/issues/21995
Add location sync code for hash-based navigation from AngularJShttps://github.com/angular/angular/issues/21995#top
https://github.com/jasonaden
area: routerhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20router%22
freq3: highhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22freq3%3A%20high%22
regressionIndicates than the issue relates to something that worked in a previous versionhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22regression%22
type: bug/fixhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22type%3A%20bug%2Ffix%22
Backloghttps://github.com/angular/angular/milestone/82
https://github.com/jasonaden
jasonadenhttps://github.com/jasonaden
on Feb 2, 2018https://github.com/angular/angular/issues/21995#issue-293963468
#21728https://github.com/angular/angular/pull/21728
#21728https://github.com/angular/angular/pull/21728
Nexthttps://github.com/angular/angular/issues/21995?timeline_page=1
jasonadenhttps://github.com/jasonaden
type: bug/fixhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22type%3A%20bug%2Ffix%22
freq3: highhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22freq3%3A%20high%22
area: routerhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20router%22
regressionIndicates than the issue relates to something that worked in a previous versionhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22regression%22
on Feb 2, 2018https://github.com/angular/angular/issues/21995#event-1455524720
ngbothttps://github.com/apps/ngbot
Backloghttps://github.com/angular/angular/milestone/82
on Feb 2, 2018https://github.com/angular/angular/issues/21995#event-1455525139
ngbothttps://github.com/apps/ngbot
Backloghttps://github.com/angular/angular/milestone/82
needsTriagehttps://github.com/angular/angular/milestone/83
on Feb 26, 2018https://github.com/angular/angular/issues/21995#event-1492226482
https://github.com/jpzwarte
jpzwartehttps://github.com/jpzwarte
on Apr 27, 2018https://github.com/angular/angular/issues/21995#issuecomment-384972270
@jasonadenhttps://github.com/jasonaden
#23573https://github.com/angular/angular/issues/23573
https://github.com/vincentjames501
vincentjames501https://github.com/vincentjames501
on Jun 11, 2018https://github.com/angular/angular/issues/21995#issuecomment-396404190
jasonadenhttps://github.com/jasonaden
on Jun 19, 2018https://github.com/angular/angular/issues/21995#event-1689836333
jasonadenhttps://github.com/jasonaden
jira: synchttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22jira%3A%20sync%22
jira: synchttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22jira%3A%20sync%22
on Jul 16, 2018https://github.com/angular/angular/issues/21995#event-1736106109
jasonadenhttps://github.com/jasonaden
jira-synchttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22jira-sync%22
jira: synchttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22jira%3A%20sync%22
jira-synchttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22jira-sync%22
on Jul 19, 2018https://github.com/angular/angular/issues/21995#event-1743112779
jasonadenhttps://github.com/jasonaden
on Jul 26, 2018https://github.com/angular/angular/issues/21995#event-1755536856
jasonadenhttps://github.com/jasonaden
jira-synchttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22jira-sync%22
on Jul 26, 2018https://github.com/angular/angular/issues/21995#event-1755549018
IgorMinarhttps://github.com/IgorMinar
on Feb 20, 2019https://github.com/angular/angular/issues/21995#event-2150518690
feat(router): add hash-based navigation option to setUpLocationSync (#…https://github.com/angular/angular/commit/fc895ba1893d08813f931c8794c7db97782f1c36
#…https://github.com/angular/angular/pull/28609
fc895bahttps://github.com/angular/angular/commit/fc895ba1893d08813f931c8794c7db97782f1c36
feat(router): add hash-based navigation option to setUpLocationSync (#…https://github.com/angular/angular/commit/71d0eeb966843d372068bf69489da278ff7969fb
#…https://github.com/angular/angular/pull/28609
71d0eebhttps://github.com/angular/angular/commit/71d0eeb966843d372068bf69489da278ff7969fb
https://github.com/jasonaden
jasonadenhttps://github.com/jasonaden
on Feb 26, 2019https://github.com/angular/angular/issues/21995#issuecomment-467661589
#28609https://github.com/angular/angular/pull/28609
jasonadenhttps://github.com/jasonaden
completedhttps://github.com/angular/angular/issues?q=is%3Aissue%20state%3Aclosed%20archived%3Afalse%20reason%3Acompleted
on Feb 26, 2019https://github.com/angular/angular/issues/21995#event-2166494733
https://github.com/apps/angular-automatic-lock-bot
angular-automatic-lock-bothttps://github.com/apps/angular-automatic-lock-bot
on Sep 14, 2019https://github.com/angular/angular/issues/21995#issuecomment-531502568
automatic conversation locking policyhttps://github.com/angular/angular/blob/67d80f/docs/GITHUB_PROCESS.md#conversation-locking
angular-automatic-lock-bothttps://github.com/apps/angular-automatic-lock-bot
on Sep 14, 2019https://github.com/angular/angular/issues/21995#event-2634271175
Sign up for freehttps://github.com/signup?return_to=https://github.com/angular/angular/issues/21995
Sign in to commenthttps://github.com/login?return_to=https://github.com/angular/angular/issues/21995
jasonadenhttps://github.com/jasonaden
area: routerhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20router%22
freq3: highhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22freq3%3A%20high%22
regressionIndicates than the issue relates to something that worked in a previous versionhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22regression%22
type: bug/fixhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22type%3A%20bug%2Ffix%22
BacklogNo due datehttps://github.com/angular/angular/milestone/82
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.