René's URL Explorer Experiment


Title: setUpLocationSync causes an duplicate navigation events · Issue #21610 · angular/angular · GitHub

Open Graph Title: setUpLocationSync causes an duplicate navigation events · Issue #21610 · angular/angular

X Title: setUpLocationSync causes an duplicate navigation events · Issue #21610 · angular/angular

Description: Angular's router upgrade code provides a setUpLocationSync method which listens for AngularJS-initiated $locationChangeStart events, then calls Angular's router.navigateByUrl. The docs for this method state that "History.pushState does n...

Open Graph Description: Angular's router upgrade code provides a setUpLocationSync method which listens for AngularJS-initiated $locationChangeStart events, then calls Angular's router.navigateByUrl. The docs for this met...

X Description: Angular's router upgrade code provides a setUpLocationSync method which listens for AngularJS-initiated $locationChangeStart events, then calls Angular's router.navigateByUrl. The docs for ...

Opengraph URL: https://github.com/angular/angular/issues/21610

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"setUpLocationSync causes an duplicate navigation events","articleBody":"Angular's router upgrade code provides a setUpLocationSync method which listens for AngularJS-initiated $locationChangeStart events, then calls Angular's router.navigateByUrl. The docs for this method state that \"History.pushState does not fire onPopState, so the Angular location doesn't detect it. The workaround is to attach a location change listener\"(https://github.com/angular/angular/blob/e4c53f8529b88ea574f41010b3277374a6f42fe1/packages/router/upgrade/src/upgrade.ts#L55). Without this code, the Angular router does not respond to location changes initiated by AngularJS, regardless of whether the pages themselves are associated w/ AngularJS or Angular content. For example, AngularJS-based navigation links would fail to trigger a routing event between two Angular pages.\r\n\r\nWhile this code works for AngularJS-initiated location changes, it currently produces duplicate NavigationStart, etc. events for Angular-initiated changes. The AngularJS router sees that the browser location has changed and triggers a location change event, which in turn triggers an additional NavigationStart event in Angular. It appears that we need some way to trigger Angular navigation only for location changes that originate in AngularJS.\r\n\r\nThis issue is currently causing duplicate router events for any Angular-driven page transition in dual-router apps, which is a performance issue.","author":{"url":"https://github.com/bourey","@type":"Person","name":"bourey"},"datePublished":"2018-01-17T21:48:18Z","url":"https://github.com/angular/angular/issues/21610"}

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:39dfb7ef-627e-b966-78a8-59be2af3cbf2
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-idE2C6:2652DC:1E50452:26AA3F8:6B015161
html-safe-nonce4b39e726ac10288694ccd335c20dfbbc1f8325ee51e4cb9cf6fcce9e86077865
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFMkM2OjI2NTJEQzoxRTUwNDUyOjI2QUEzRjg6NkIwMTUxNjEiLCJ2aXNpdG9yX2lkIjoiMjgzMzQ3ODQ4NDg5NzEyNDcwNSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac35576c91537e810869fd34faecd3468d8b5a800ab34304c61b5d2a2803b43f9f
hovercard-subject-tagissue:289425467
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/angular/angular/21610/issue_layout
twitter:imagehttps://opengraph.githubassets.com/8c0b9b5490b93b588d5a104d5baa96f0ca94108bc3f6f185f4a1d01c33e614c3/angular/angular/issues/21610
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/8c0b9b5490b93b588d5a104d5baa96f0ca94108bc3f6f185f4a1d01c33e614c3/angular/angular/issues/21610
og:image:altAngular's router upgrade code provides a setUpLocationSync method which listens for AngularJS-initiated $locationChangeStart events, then calls Angular's router.navigateByUrl. The docs for this met...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamebourey
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-preview
go-importgithub.com/angular/angular git https://github.com/angular/angular.git
octolytics-dimension-user_id139426
octolytics-dimension-user_loginangular
octolytics-dimension-repository_id24195339
octolytics-dimension-repository_nwoangular/angular
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id24195339
octolytics-dimension-repository_network_root_nwoangular/angular
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-nameissues

Links:

Skip to contenthttps://github.com/angular/angular/issues/21610#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fissues%2F21610
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fissues%2F21610
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=angular%2Fangular
Reloadhttps://github.com/angular/angular/issues/21610
Reloadhttps://github.com/angular/angular/issues/21610
Reloadhttps://github.com/angular/angular/issues/21610
angularhttps://github.com/angular
angularhttps://github.com/angular/angular
Codehttps://github.com/angular/angular
Issues836 (836)https://github.com/angular/angular/issues
Pull requests141 (141)https://github.com/angular/angular/pulls
Discussionshttps://github.com/angular/angular/discussions
Actionshttps://github.com/angular/angular/actions
Projectshttps://github.com/angular/angular/projects
Security and quality40 (40)https://github.com/angular/angular/security
Insightshttps://github.com/angular/angular/insights
https://github.com/angular/angular
New issuehttps://github.com/login?return_to=https://github.com/angular/angular/issues/21610
New issuehttps://github.com/login?return_to=https://github.com/angular/angular/issues/21610
setUpLocationSync causes an duplicate navigation eventshttps://github.com/angular/angular/issues/21610#top
https://github.com/jasonaden
P3An issue that is relevant to core functions, but does not impede progress. Important, but not urgenthttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22P3%22
area: routerhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20router%22
freq3: highhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22freq3%3A%20high%22
hotlist: googlehttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22hotlist%3A%20google%22
state: confirmedhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22state%3A%20confirmed%22
type: bug/fixhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22type%3A%20bug%2Ffix%22
Backloghttps://github.com/angular/angular/milestone/82
https://github.com/bourey
boureyhttps://github.com/bourey
on Jan 17, 2018https://github.com/angular/angular/issues/21610#issue-289425467
angular/packages/router/upgrade/src/upgrade.tshttps://github.com/angular/angular/blob/e4c53f8529b88ea574f41010b3277374a6f42fe1/packages/router/upgrade/src/upgrade.ts#L55
e4c53f8https://github.com/angular/angular/commit/e4c53f8529b88ea574f41010b3277374a6f42fe1
Nexthttps://github.com/angular/angular/issues/21610?timeline_page=1
jasonadenhttps://github.com/jasonaden
freq3: highhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22freq3%3A%20high%22
regressionIndicates than the issue relates to something that worked in a previous versionhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22regression%22
area: routerhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20router%22
hotlist: googlehttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22hotlist%3A%20google%22
on Jan 19, 2018https://github.com/angular/angular/issues/21610#event-1433414460
https://github.com/aciccarello
aciccarellohttps://github.com/aciccarello
on Jan 23, 2018https://github.com/angular/angular/issues/21610#issuecomment-359619916
https://github.com/gkalpak
gkalpakhttps://github.com/gkalpak
on Jan 23, 2018https://github.com/angular/angular/issues/21610#issuecomment-359767546
@boureyhttps://github.com/bourey
ngUpgrade-statichttps://stackblitz.com/edit/ngupgradestatic-playground
ngUpgrade-litehttps://stackblitz.com/edit/ngupgradelite-playground
#20244https://github.com/angular/angular/pull/20244
@jasonadenhttps://github.com/jasonaden
https://github.com/aciccarello
aciccarellohttps://github.com/aciccarello
on Jan 23, 2018https://github.com/angular/angular/issues/21610#issuecomment-359875282
@gkalpakhttps://github.com/gkalpak
https://stackblitz.com/edit/ajc-angular-upgrade-locationsync-bughttps://stackblitz.com/edit/ajc-angular-upgrade-locationsync-bug
manughubhttps://github.com/manughub
type: bug/fixhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22type%3A%20bug%2Ffix%22
on Jan 23, 2018https://github.com/angular/angular/issues/21610#event-1438300636
ngbothttps://github.com/apps/ngbot
Backloghttps://github.com/angular/angular/milestone/82
on Jan 23, 2018https://github.com/angular/angular/issues/21610#event-1438300679
https://github.com/jasonaden
jasonadenhttps://github.com/jasonaden
on Jan 29, 2018https://github.com/angular/angular/issues/21610#issuecomment-361327369
@gkalpakhttps://github.com/gkalpak
jasonadenhttps://github.com/jasonaden
severity3: brokenhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22severity3%3A%20broken%22
regressionIndicates than the issue relates to something that worked in a previous versionhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22regression%22
on Jan 29, 2018https://github.com/angular/angular/issues/21610#event-1446876209
https://github.com/jasonaden
jasonadenhttps://github.com/jasonaden
on Jan 29, 2018https://github.com/angular/angular/issues/21610#issuecomment-361328642
#21728https://github.com/angular/angular/pull/21728
ngbothttps://github.com/apps/ngbot
Backloghttps://github.com/angular/angular/milestone/82
needsTriagehttps://github.com/angular/angular/milestone/83
on Feb 26, 2018https://github.com/angular/angular/issues/21610#event-1492231096
jelbournhttps://github.com/jelbourn
severity3: brokenhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22severity3%3A%20broken%22
on Oct 1, 2020https://github.com/angular/angular/issues/21610#event-3830826053
atscotthttps://github.com/atscott
on Oct 14, 2021https://github.com/angular/angular/issues/21610#event-5466923714
fix(upgrade): Do not trigger duplicate navigation events from Angular…https://github.com/atscott/angular/commit/5fd822da9eaf1273dfc486f5b41da728a34263a8
https://docs.github.com/articles/closing-issues-via-commit-messages
5fd822dhttps://github.com/atscott/angular/commit/5fd822da9eaf1273dfc486f5b41da728a34263a8
jessicajaniukhttps://github.com/jessicajaniuk
on Feb 2, 2022https://github.com/angular/angular/issues/21610#event-5998257296
fix(upgrade): Do not trigger duplicate navigation events from Angular…https://github.com/angular/angular/commit/b9aab0c87bcccb61167e92c1e910630afad67648
https://docs.github.com/articles/closing-issues-via-commit-messages
b9aab0chttps://github.com/angular/angular/commit/b9aab0c87bcccb61167e92c1e910630afad67648
jessicajaniukhttps://github.com/jessicajaniuk
completedhttps://github.com/angular/angular/issues?q=is%3Aissue%20state%3Aclosed%20archived%3Afalse%20reason%3Acompleted
202a1a5https://github.com/angular/angular/commit/202a1a56314af4ddb99c476f974536a10e390319
on Feb 2, 2022https://github.com/angular/angular/issues/21610#event-5998257522
https://github.com/apps/angular-automatic-lock-bot
angular-automatic-lock-bothttps://github.com/apps/angular-automatic-lock-bot
on Mar 5, 2022https://github.com/angular/angular/issues/21610#issuecomment-1059788737
automatic conversation locking policyhttps://github.com/angular/angular/blob/8f24bc9443b3872fe095d9f7f77b308a361a13b4/docs/GITHUB_PROCESS.md#conversation-locking
angular-automatic-lock-bothttps://github.com/apps/angular-automatic-lock-bot
on Mar 5, 2022https://github.com/angular/angular/issues/21610#event-6189593643
Sign up for freehttps://github.com/signup?return_to=https://github.com/angular/angular/issues/21610
Sign in to commenthttps://github.com/login?return_to=https://github.com/angular/angular/issues/21610
jasonadenhttps://github.com/jasonaden
P3An issue that is relevant to core functions, but does not impede progress. Important, but not urgenthttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22P3%22
area: routerhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20router%22
freq3: highhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22freq3%3A%20high%22
hotlist: googlehttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22hotlist%3A%20google%22
state: confirmedhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22state%3A%20confirmed%22
type: bug/fixhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22type%3A%20bug%2Ffix%22
BacklogNo due datehttps://github.com/angular/angular/milestone/82
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.