René's URL Explorer Experiment


Title: Child route guards should be evaluated **after** parent resolves · Issue #20805 · angular/angular · GitHub

Open Graph Title: Child route guards should be evaluated **after** parent resolves · Issue #20805 · angular/angular

X Title: Child route guards should be evaluated **after** parent resolves · Issue #20805 · angular/angular

Description: I'm submitting a... [ ] Regression (a behavior that used to work and stopped working in a new release) [ ] Bug report [x] Feature request [ ] Documentation issue or request [ ] Support request => Please do not submit support request here...

Open Graph Description: I'm submitting a... [ ] Regression (a behavior that used to work and stopped working in a new release) [ ] Bug report [x] Feature request [ ] Documentation issue or request [ ] Support request => P...

X Description: I'm submitting a... [ ] Regression (a behavior that used to work and stopped working in a new release) [ ] Bug report [x] Feature request [ ] Documentation issue or request [ ] Support request ...

Opengraph URL: https://github.com/angular/angular/issues/20805

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Child route guards should be evaluated **after** parent resolves","articleBody":"\u003c!--\r\nPLEASE HELP US PROCESS GITHUB ISSUES FASTER BY PROVIDING THE FOLLOWING INFORMATION.\r\n\r\nISSUES MISSING IMPORTANT INFORMATION MAY BE CLOSED WITHOUT INVESTIGATION.\r\n-->\r\n\r\n## I'm submitting a...\r\n\u003c!-- Check one of the following options with \"x\" -->\r\n\u003cpre>\u003ccode>\r\n[ ] Regression (a behavior that used to work and stopped working in a new release)\r\n[ ] Bug report  \u003c!-- Please search GitHub for a similar issue or PR before submitting -->\r\n[x] Feature request\r\n[ ] Documentation issue or request\r\n[ ] Support request => Please do not submit support request here, instead see https://github.com/angular/angular/blob/master/CONTRIBUTING.md#question\r\n\u003c/code>\u003c/pre>\r\n\r\n## Current behavior\r\n\u003c!-- Describe how the issue manifests. -->\r\n\r\nCurrently, child route guards have no access to parent route resolves, because resolves are being evaluated **after all guards have been dealt with no matter if these are in child or parent routes**.\r\n\r\n## Expected behavior\r\n\u003c!-- Describe what the desired behavior would be. -->\r\n\r\nChild route guards should be evaluated **after** the parent route resolves are finished.\r\n\r\n## What is the motivation / use case for changing the behavior?\r\n\u003c!-- Describe the motivation or the concrete use case. -->\r\n\r\nWhen dealing with more complicated nested route structure, current state of things results in writing unnecessary and increasingly more complicated code in deeper levels of routing.\r\n\r\nExample:\r\n\r\n- 3 kinds of entities: `Website`, `Organization`, and list of `News`\r\n- `Website` can have related `Organization`\r\n- News are only available, if `Website` has `Organization` set up, because these object are bound to both\r\n\r\nNow consider having a page with `News` detail which sits on `/website/:websiteId/news/:newsId`. As mentioned before, this can only be shown when `Website` has an `Organization` link, this means we need to add guard `WebsiteHasOrganizationGuard` on the news route level. Something like this:\r\n\r\n```\r\n{\r\n    path: '',\r\n    resolve: {\r\n        website: WebsiteResolver,\r\n        organization: WebsiteOrganizationResolver,\r\n    },\r\n    component: WebsiteComponent,\r\n    children: [\r\n        {\r\n            path: 'news-detail/:news',\r\n            pathMatch: 'full',\r\n            canActivate: [\r\n                WebsiteHasOrganizationGuard,\r\n            ],\r\n            children: [\r\n                {\r\n                    path: '',\r\n                    canActivate: [\r\n                        NewsExists,\r\n                    ],\r\n                    resolve: {\r\n                        news: NewsResolver,\r\n                    },\r\n                    component: NewsDetailComponent,\r\n                },\r\n            ]\r\n        }\r\n    ]\r\n}\r\n```\r\n\r\nIn order to show the news page, we need to evaluate both `WebsiteHasOrganizationGuard` and `NewsExists` guard. These are run according to proposed sequence: first parent, then child. Unfortunately, **none of these guards can take advantage of parent resolves of `website` and `organization`**. Since both `NewsExists` and `WebsiteHasOrganization` guards are triggered before the `WebsiteResolver` and `WebsiteOrganizationResolver`, we are forced to mimic logic of both of them in both guards in order to successfully evaluate them.\r\n\r\n**This is against DRY and gets increasingly more complicated within deep trees of nested routes.** Quite commonly, one needs to write single-use guards/resolvers that span multiple objects that relate on each other.\r\n\r\nIf parent resolves we're evaluated **before child guards**, we can easily share the resolved `Website` and `Organization` objects in the child guards without any boilerplate code.\r\n\r\n## Environment\r\n\r\n\u003cpre>\u003ccode>\r\nAngular version: 5.0.2\r\n\u003c!-- Check whether this is still an issue in the most recent Angular version -->\r\n\r\nBrowser:\r\n- Not related to browser version\r\n","author":{"url":"https://github.com/xaralis","@type":"Person","name":"xaralis"},"datePublished":"2017-12-05T16:59:36Z","url":"https://github.com/angular/angular/issues/20805"}

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:91bf6240-02ae-5617-2495-a2940b5db57a
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-idA908:10D9F8:D04C4F:11429CB:6B00F62F
html-safe-nonce2fd6042602b6b8642539e4c3ce9a095d76bcc47005b46aeb03b30364849038b4
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBOTA4OjEwRDlGODpEMDRDNEY6MTE0MjlDQjo2QjAwRjYyRiIsInZpc2l0b3JfaWQiOiIxNjk5NDM3NjY1MTEzNDA0OTc1IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac1af60442419323c5dd55fe3b2f212bfd3b8fe3ca68a4f0581bcbc28d7cd91ddf
hovercard-subject-tagissue:279452198
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/angular/angular/20805/issue_layout
twitter:imagehttps://opengraph.githubassets.com/bec4a64771617e94de64c0e07769112d9147f67679375dce8cff0c1209d0e483/angular/angular/issues/20805
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/bec4a64771617e94de64c0e07769112d9147f67679375dce8cff0c1209d0e483/angular/angular/issues/20805
og:image:altI'm submitting a... [ ] Regression (a behavior that used to work and stopped working in a new release) [ ] Bug report [x] Feature request [ ] Documentation issue or request [ ] Support request => P...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamexaralis
hostnamegithub.com
expected-hostnamegithub.com
None4ef498cbabcbe3c50befc7a5b743e7072ee770b4daf0e15e54801180d1fa91fc
turbo-cache-controlno-preview
go-importgithub.com/angular/angular git https://github.com/angular/angular.git
octolytics-dimension-user_id139426
octolytics-dimension-user_loginangular
octolytics-dimension-repository_id24195339
octolytics-dimension-repository_nwoangular/angular
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id24195339
octolytics-dimension-repository_network_root_nwoangular/angular
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release9983dd5da06943f833c971dd5b6bc988e2858be5
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-nameissues

Links:

Skip to contenthttps://github.com/angular/angular/issues/20805#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fissues%2F20805
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fissues%2F20805
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=angular%2Fangular
Reloadhttps://github.com/angular/angular/issues/20805
Reloadhttps://github.com/angular/angular/issues/20805
Reloadhttps://github.com/angular/angular/issues/20805
angularhttps://github.com/angular
angularhttps://github.com/angular/angular
Codehttps://github.com/angular/angular
Issues835 (835)https://github.com/angular/angular/issues
Pull requests141 (141)https://github.com/angular/angular/pulls
Discussionshttps://github.com/angular/angular/discussions
Actionshttps://github.com/angular/angular/actions
Projectshttps://github.com/angular/angular/projects
Security and quality40 (40)https://github.com/angular/angular/security
Insightshttps://github.com/angular/angular/insights
https://github.com/angular/angular
New issuehttps://github.com/login?return_to=https://github.com/angular/angular/issues/20805
New issuehttps://github.com/login?return_to=https://github.com/angular/angular/issues/20805
Child route guards should be evaluated **after** parent resolveshttps://github.com/angular/angular/issues/20805#top
area: routerhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20router%22
https://github.com/xaralis
xaralishttps://github.com/xaralis
on Dec 5, 2017https://github.com/angular/angular/issues/20805#issue-279452198
pkozlowski-opensourcehttps://github.com/pkozlowski-opensource
area: routerhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20router%22
on Dec 6, 2017https://github.com/angular/angular/issues/20805#event-1374342688
https://github.com/jasonaden
jasonadenhttps://github.com/jasonaden
on Dec 7, 2017https://github.com/angular/angular/issues/20805#issuecomment-350106463
jasonadenhttps://github.com/jasonaden
completedhttps://github.com/angular/angular/issues?q=is%3Aissue%20state%3Aclosed%20archived%3Afalse%20reason%3Acompleted
on Dec 7, 2017https://github.com/angular/angular/issues/20805#event-1377823797
https://github.com/chris13524
chris13524https://github.com/chris13524
on May 14, 2018https://github.com/angular/angular/issues/20805#issuecomment-388886023
https://github.com/chris13524
chris13524https://github.com/chris13524
on May 14, 2018https://github.com/angular/angular/issues/20805#issuecomment-388895733
https://github.com/xaralis
xaralishttps://github.com/xaralis
on May 14, 2018https://github.com/angular/angular/issues/20805#issuecomment-388904739
@chris13524https://github.com/chris13524
https://github.com/chris13524
chris13524https://github.com/chris13524
on May 14, 2018https://github.com/angular/angular/issues/20805#issuecomment-388905920
@xaralishttps://github.com/xaralis
https://github.com/xaralis
xaralishttps://github.com/xaralis
on May 14, 2018https://github.com/angular/angular/issues/20805#issuecomment-388912846
@chris13524https://github.com/chris13524
https://github.com/apps/angular-automatic-lock-bot
angular-automatic-lock-bothttps://github.com/apps/angular-automatic-lock-bot
on Sep 13, 2019https://github.com/angular/angular/issues/20805#issuecomment-531280873
automatic conversation locking policyhttps://github.com/angular/angular/blob/67d80f/docs/GITHUB_PROCESS.md#conversation-locking
angular-automatic-lock-bothttps://github.com/apps/angular-automatic-lock-bot
on Sep 13, 2019https://github.com/angular/angular/issues/20805#event-2632707057
Sign up for freehttps://github.com/signup?return_to=https://github.com/angular/angular/issues/20805
Sign in to commenthttps://github.com/login?return_to=https://github.com/angular/angular/issues/20805
area: routerhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20router%22
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.