Title: Changing baseHref in Angular along with the Upgrade Module to work with AngularJS router causes infinite redirect · Issue #20061 · angular/angular · GitHub
Open Graph Title: Changing baseHref in Angular along with the Upgrade Module to work with AngularJS router causes infinite redirect · Issue #20061 · angular/angular
X Title: Changing baseHref in Angular along with the Upgrade Module to work with AngularJS router causes infinite redirect · Issue #20061 · angular/angular
Description: I'm submitting a... [ ] Regression (a behavior that used to work and stopped working in a new release) [X] Bug report [ ] Feature request [ ] Documentation issue or request [ ] Support request => Please do not submit support request here...
Open Graph Description: I'm submitting a... [ ] Regression (a behavior that used to work and stopped working in a new release) [X] Bug report [ ] Feature request [ ] Documentation issue or request [ ] Support request => P...
X Description: I'm submitting a... [ ] Regression (a behavior that used to work and stopped working in a new release) [X] Bug report [ ] Feature request [ ] Documentation issue or request [ ] Support request ...
Opengraph URL: https://github.com/angular/angular/issues/20061
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Changing baseHref in Angular along with the Upgrade Module to work with AngularJS router causes infinite redirect","articleBody":"\u003c!--\r\nPLEASE HELP US PROCESS GITHUB ISSUES FASTER BY PROVIDING THE FOLLOWING INFORMATION.\r\n\r\nISSUES MISSING IMPORTANT INFORMATION MAY BE CLOSED WITHOUT INVESTIGATION.\r\n-->\r\n\r\n## I'm submitting a...\r\n\u003c!-- Check one of the following options with \"x\" -->\r\n\u003cpre>\u003ccode>\r\n[ ] Regression (a behavior that used to work and stopped working in a new release)\r\n[X] Bug report \u003c!-- Please search GitHub for a similar issue or PR before submitting -->\r\n[ ] Feature request\r\n[ ] Documentation issue or request\r\n[ ] Support request => Please do not submit support request here, instead see https://github.com/angular/angular/blob/master/CONTRIBUTING.md#question\r\n\u003c/code>\u003c/pre>\r\n\r\n## Current behavior\r\nIf using the Angular router and the AngularJS router together with the Upgrade Module you can define routes that each router will handle and the other router will, since the route is not defined, go to its sink state and not populate the router-outlet or ng-view respectively. This works great except for if you want to host your app anywhere but root. As soon as you define a baseHref things will go haywire and you get in a (seemingly) infinite redirect between the two frameworks. _(For more information on the project set-up you can visit Victor Savkin's [tutorial](https://blog.nrwl.io/using-ngupgrade-like-a-pro-lazy-loading-angularjs-applications-469819f5c86))_.\r\n\r\n\r\n## Expected behavior\r\nYou should be able to define a baseHref and have the two routers still play nice with each other just like they do when hosted at root.\r\n\r\n\r\n## Minimal reproduction of the problem with instructions\r\n\u003c!--\r\nFor bug reports please provide the *STEPS TO REPRODUCE* and if possible a *MINIMAL DEMO* of the problem via\r\nhttps://plnkr.co or similar (you can use this template as a starting point: http://plnkr.co/edit/tpl:AvJOMERrnz94ekVua0u5).\r\n-->\r\n\r\nDetailed steps along with some things I've tried to fix the problem are on [StackOverflow](https://stackoverflow.com/questions/46899392/changing-basehref-in-angular-along-with-the-upgrade-module-to-work-with-angularj) but to summarize:\r\n\r\n* Clone the [repo](https://github.com/zbuhler/ngUpgradeBaseHref) _(bare bones Angular-CLI project demonstrating the issue. I would have used plunker but SystemJS appears to rely on the ```\u003cbase>``` tag which makes it so I can't demonstrate the problem)_\r\n * ```npm install```\r\n * ```ng serve```\r\n * Navigate to [http://localhost:4200](http://localhost:4200)\r\n * View it working normally by clicking back and forth on any of the links.\r\n * Change the .angular-cli.json file like so adding a baseHref-\r\n```\r\n\"defaults\": {\r\n\"styleExt\": \"css\",\r\n\"component\": {\r\n},\r\n\"build\": {\r\n \"baseHref\": \"/\"\r\n}\r\n```\r\nto\r\n```\r\n\"defaults\": {\r\n\"styleExt\": \"css\",\r\n\"component\": {\r\n},\r\n\"build\": {\r\n \"baseHref\": \"/sub/\"\r\n}\r\n```\r\n * See it break when clicking on any of the two AngularJS links (navigate from Angular to an AngularJS page)\r\n\r\n## What is the motivation / use case for changing the behavior?\r\n\u003c!-- Describe the motivation or the concrete use case. -->\r\nNot everyone's app is hosted at root and you should be able to use routing along with the Upgrade Module whether it is or not.\r\n\r\n## Environment\r\n\r\n\u003cpre>\u003ccode>\r\nAngular version: 4.4.6 (using CLI Project)\r\n\u003c!-- Check whether this is still an issue in the most recent Angular version -->\r\n\r\nBrowser:\r\n- [X] Chrome (desktop) version 61.0.3163.100\r\n- [ ] Chrome (Android) version XX\r\n- [ ] Chrome (iOS) version XX\r\n- [X] Firefox version 55.0\r\n- [X] Safari (desktop) version 11.0\r\n- [ ] Safari (iOS) version XX\r\n- [ ] IE version XX\r\n- [ ] Edge version XX\r\n \r\nFor Tooling issues:\r\n- Node version: XX \u003c!-- run `node --version` -->\r\n- Platform: \u003c!-- Mac, Linux, Windows -->\r\n\r\nOthers:\r\n\u003c!-- Anything else relevant? Operating system version, IDE, package manager, HTTP server, ... -->\r\n\u003c/code>\u003c/pre>\r\n\r\nTo aid in debugging I have enableTracing: true in the app module and some console.log statements in AngularJS for the $locationChangeStart and $locationChangeSuccess events so you can see the order of events regarding navigation.\r\n","author":{"url":"https://github.com/zbuhler","@type":"Person","name":"zbuhler"},"datePublished":"2017-10-31T17:22:02Z","url":"https://github.com/angular/angular/issues/20061"}
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:ccb9b1f3-1eee-5e4e-73e5-e35c88290504 |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | A72E:149F72:62383:850B2:6B015C6B |
| html-safe-nonce | 0243a60d0946612ed72772e56f25cd36096e0aca5de0db91cf7c04d4d14b61e9 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBNzJFOjE0OUY3Mjo2MjM4Mzo4NTBCMjo2QjAxNUM2QiIsInZpc2l0b3JfaWQiOiIzNTcyNjA3MjEwODIxMzQ0MzYzIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | ba3ceac79d796ee50caa9fe7684e310940ded1770db71f7cfa2d28f8a57dd39a |
| hovercard-subject-tag | issue:270046344 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/angular/angular/20061/issue_layout |
| twitter:image | https://opengraph.githubassets.com/c285663f16280cd1288cfb212aa451bbc94bc741348038a2229772594ac040e5/angular/angular/issues/20061 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/c285663f16280cd1288cfb212aa451bbc94bc741348038a2229772594ac040e5/angular/angular/issues/20061 |
| og:image:alt | I'm submitting a... [ ] Regression (a behavior that used to work and stopped working in a new release) [X] Bug report [ ] Feature request [ ] Documentation issue or request [ ] Support request => P... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | zbuhler |
| hostname | github.com |
| expected-hostname | github.com |
| None | cc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c |
| turbo-cache-control | no-preview |
| go-import | github.com/angular/angular git https://github.com/angular/angular.git |
| octolytics-dimension-user_id | 139426 |
| octolytics-dimension-user_login | angular |
| octolytics-dimension-repository_id | 24195339 |
| octolytics-dimension-repository_nwo | angular/angular |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 24195339 |
| octolytics-dimension-repository_network_root_nwo | angular/angular |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 8c77c9e8439031ad54c75a250694842892f693e1 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | issues |
Links:
Viewport: width=device-width