René's URL Explorer Experiment


Title: Changing baseHref in Angular along with the Upgrade Module to work with AngularJS router causes infinite redirect · Issue #20061 · angular/angular · GitHub

Open Graph Title: Changing baseHref in Angular along with the Upgrade Module to work with AngularJS router causes infinite redirect · Issue #20061 · angular/angular

X Title: Changing baseHref in Angular along with the Upgrade Module to work with AngularJS router causes infinite redirect · Issue #20061 · angular/angular

Description: I'm submitting a... [ ] Regression (a behavior that used to work and stopped working in a new release) [X] Bug report [ ] Feature request [ ] Documentation issue or request [ ] Support request => Please do not submit support request here...

Open Graph Description: I'm submitting a... [ ] Regression (a behavior that used to work and stopped working in a new release) [X] Bug report [ ] Feature request [ ] Documentation issue or request [ ] Support request => P...

X Description: I'm submitting a... [ ] Regression (a behavior that used to work and stopped working in a new release) [X] Bug report [ ] Feature request [ ] Documentation issue or request [ ] Support request ...

Opengraph URL: https://github.com/angular/angular/issues/20061

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Changing baseHref in Angular along with the Upgrade Module to work with AngularJS router causes infinite redirect","articleBody":"\u003c!--\r\nPLEASE HELP US PROCESS GITHUB ISSUES FASTER BY PROVIDING THE FOLLOWING INFORMATION.\r\n\r\nISSUES MISSING IMPORTANT INFORMATION MAY BE CLOSED WITHOUT INVESTIGATION.\r\n-->\r\n\r\n## I'm submitting a...\r\n\u003c!-- Check one of the following options with \"x\" -->\r\n\u003cpre>\u003ccode>\r\n[ ] Regression (a behavior that used to work and stopped working in a new release)\r\n[X] Bug report  \u003c!-- Please search GitHub for a similar issue or PR before submitting -->\r\n[ ] Feature request\r\n[ ] Documentation issue or request\r\n[ ] Support request => Please do not submit support request here, instead see https://github.com/angular/angular/blob/master/CONTRIBUTING.md#question\r\n\u003c/code>\u003c/pre>\r\n\r\n## Current behavior\r\nIf using the Angular router and the AngularJS router together with the Upgrade Module you can define routes that each router will handle and the other router will, since the route is not defined, go to its sink state and not populate the router-outlet or ng-view respectively. This works great except for if you want to host your app anywhere but root. As soon as you define a baseHref things will go haywire and you get in a (seemingly) infinite redirect between the two frameworks. _(For more information on the project set-up you can visit Victor Savkin's [tutorial](https://blog.nrwl.io/using-ngupgrade-like-a-pro-lazy-loading-angularjs-applications-469819f5c86))_.\r\n\r\n\r\n## Expected behavior\r\nYou should be able to define a baseHref and have the two routers still play nice with each other just like they do when hosted at root.\r\n\r\n\r\n## Minimal reproduction of the problem with instructions\r\n\u003c!--\r\nFor bug reports please provide the *STEPS TO REPRODUCE* and if possible a *MINIMAL DEMO* of the problem via\r\nhttps://plnkr.co or similar (you can use this template as a starting point: http://plnkr.co/edit/tpl:AvJOMERrnz94ekVua0u5).\r\n-->\r\n\r\nDetailed steps along with some things I've tried to fix the problem are on [StackOverflow](https://stackoverflow.com/questions/46899392/changing-basehref-in-angular-along-with-the-upgrade-module-to-work-with-angularj) but to summarize:\r\n\r\n* Clone the [repo](https://github.com/zbuhler/ngUpgradeBaseHref) _(bare bones Angular-CLI project demonstrating the issue. I would have used plunker but SystemJS appears to rely on the ```\u003cbase>``` tag which makes it so I can't demonstrate the problem)_\r\n * ```npm install```\r\n * ```ng serve```\r\n * Navigate to [http://localhost:4200](http://localhost:4200)\r\n * View it working normally by clicking back and forth on any of the links.\r\n * Change the .angular-cli.json file like so adding a baseHref-\r\n```\r\n\"defaults\": {\r\n\"styleExt\": \"css\",\r\n\"component\": {\r\n},\r\n\"build\": {\r\n  \"baseHref\": \"/\"\r\n}\r\n```\r\nto\r\n```\r\n\"defaults\": {\r\n\"styleExt\": \"css\",\r\n\"component\": {\r\n},\r\n\"build\": {\r\n  \"baseHref\": \"/sub/\"\r\n}\r\n```\r\n * See it break when clicking on any of the two AngularJS links (navigate from Angular to an AngularJS page)\r\n\r\n## What is the motivation / use case for changing the behavior?\r\n\u003c!-- Describe the motivation or the concrete use case. -->\r\nNot everyone's app is hosted at root and you should be able to use routing along with the Upgrade Module whether it is or not.\r\n\r\n## Environment\r\n\r\n\u003cpre>\u003ccode>\r\nAngular version: 4.4.6 (using CLI Project)\r\n\u003c!-- Check whether this is still an issue in the most recent Angular version -->\r\n\r\nBrowser:\r\n- [X] Chrome (desktop) version 61.0.3163.100\r\n- [ ] Chrome (Android) version XX\r\n- [ ] Chrome (iOS) version XX\r\n- [X] Firefox version 55.0\r\n- [X] Safari (desktop) version 11.0\r\n- [ ] Safari (iOS) version XX\r\n- [ ] IE version XX\r\n- [ ] Edge version XX\r\n \r\nFor Tooling issues:\r\n- Node version: XX  \u003c!-- run `node --version` -->\r\n- Platform:  \u003c!-- Mac, Linux, Windows -->\r\n\r\nOthers:\r\n\u003c!-- Anything else relevant?  Operating system version, IDE, package manager, HTTP server, ... -->\r\n\u003c/code>\u003c/pre>\r\n\r\nTo aid in debugging I have enableTracing: true in the app module and some console.log statements in AngularJS for the $locationChangeStart and $locationChangeSuccess events so you can see the order of events regarding navigation.\r\n","author":{"url":"https://github.com/zbuhler","@type":"Person","name":"zbuhler"},"datePublished":"2017-10-31T17:22:02Z","url":"https://github.com/angular/angular/issues/20061"}

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:ccb9b1f3-1eee-5e4e-73e5-e35c88290504
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-idA72E:149F72:62383:850B2:6B015C6B
html-safe-nonce0243a60d0946612ed72772e56f25cd36096e0aca5de0db91cf7c04d4d14b61e9
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBNzJFOjE0OUY3Mjo2MjM4Mzo4NTBCMjo2QjAxNUM2QiIsInZpc2l0b3JfaWQiOiIzNTcyNjA3MjEwODIxMzQ0MzYzIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmacba3ceac79d796ee50caa9fe7684e310940ded1770db71f7cfa2d28f8a57dd39a
hovercard-subject-tagissue:270046344
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/angular/angular/20061/issue_layout
twitter:imagehttps://opengraph.githubassets.com/c285663f16280cd1288cfb212aa451bbc94bc741348038a2229772594ac040e5/angular/angular/issues/20061
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/c285663f16280cd1288cfb212aa451bbc94bc741348038a2229772594ac040e5/angular/angular/issues/20061
og:image:altI'm submitting a... [ ] Regression (a behavior that used to work and stopped working in a new release) [X] Bug report [ ] Feature request [ ] Documentation issue or request [ ] Support request => P...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamezbuhler
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-preview
go-importgithub.com/angular/angular git https://github.com/angular/angular.git
octolytics-dimension-user_id139426
octolytics-dimension-user_loginangular
octolytics-dimension-repository_id24195339
octolytics-dimension-repository_nwoangular/angular
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id24195339
octolytics-dimension-repository_network_root_nwoangular/angular
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-nameissues

Links:

Skip to contenthttps://github.com/angular/angular/issues/20061#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fissues%2F20061
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fissues%2F20061
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=angular%2Fangular
Reloadhttps://github.com/angular/angular/issues/20061
Reloadhttps://github.com/angular/angular/issues/20061
Reloadhttps://github.com/angular/angular/issues/20061
angularhttps://github.com/angular
angularhttps://github.com/angular/angular
Codehttps://github.com/angular/angular
Issues836 (836)https://github.com/angular/angular/issues
Pull requests141 (141)https://github.com/angular/angular/pulls
Discussionshttps://github.com/angular/angular/discussions
Actionshttps://github.com/angular/angular/actions
Projectshttps://github.com/angular/angular/projects
Security and quality40 (40)https://github.com/angular/angular/security
Insightshttps://github.com/angular/angular/insights
https://github.com/angular/angular
New issuehttps://github.com/login?return_to=https://github.com/angular/angular/issues/20061
New issuehttps://github.com/login?return_to=https://github.com/angular/angular/issues/20061
Changing baseHref in Angular along with the Upgrade Module to work with AngularJS router causes infinite redirecthttps://github.com/angular/angular/issues/20061#top
area: routerhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20router%22
freq2: mediumhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22freq2%3A%20medium%22
type: bug/fixhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22type%3A%20bug%2Ffix%22
Backloghttps://github.com/angular/angular/milestone/82
https://github.com/zbuhler
zbuhlerhttps://github.com/zbuhler
on Oct 31, 2017https://github.com/angular/angular/issues/20061#issue-270046344
tutorialhttps://blog.nrwl.io/using-ngupgrade-like-a-pro-lazy-loading-angularjs-applications-469819f5c86
StackOverflowhttps://stackoverflow.com/questions/46899392/changing-basehref-in-angular-along-with-the-upgrade-module-to-work-with-angularj
repohttps://github.com/zbuhler/ngUpgradeBaseHref
http://localhost:4200http://localhost:4200
Nexthttps://github.com/angular/angular/issues/20061?timeline_page=1
https://github.com/zbuhler
zbuhlerhttps://github.com/zbuhler
on Nov 8, 2017https://github.com/angular/angular/issues/20061#issuecomment-342906284
https://github.com/observstream
observstreamhttps://github.com/observstream
on Nov 9, 2017https://github.com/angular/angular/issues/20061#issuecomment-343049594
jasonadenhttps://github.com/jasonaden
area: routerhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20router%22
comp: upgrade/statichttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22comp%3A%20upgrade%2Fstatic%22
type: bug/fixhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22type%3A%20bug%2Ffix%22
on Nov 9, 2017https://github.com/angular/angular/issues/20061#event-1334890804
https://github.com/observstream
observstreamhttps://github.com/observstream
on Nov 10, 2017https://github.com/angular/angular/issues/20061#issuecomment-343484161
zbuhlerhttps://github.com/zbuhler
on Nov 15, 2017https://github.com/angular/angular/issues/20061#event-1344018994
fix(upgrade): account for baseHref when calling navigateByUrlhttps://github.com/zbuhler/angular/commit/0e07cb14326d0e6b0ae2f9df643d90458dad01ac
https://docs.github.com/articles/closing-issues-via-commit-messages
0e07cb1https://github.com/zbuhler/angular/commit/0e07cb14326d0e6b0ae2f9df643d90458dad01ac
jasonadenhttps://github.com/jasonaden
freq2: mediumhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22freq2%3A%20medium%22
severity3: brokenhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22severity3%3A%20broken%22
on Nov 30, 2017https://github.com/angular/angular/issues/20061#event-1366747899
ngbothttps://github.com/apps/ngbot
Backloghttps://github.com/angular/angular/milestone/82
on Jan 23, 2018https://github.com/angular/angular/issues/20061#event-1437536653
ngbothttps://github.com/apps/ngbot
Backloghttps://github.com/angular/angular/milestone/82
on Feb 26, 2018https://github.com/angular/angular/issues/20061#event-1492254216
ngbothttps://github.com/apps/ngbot
needsTriagehttps://github.com/angular/angular/milestone/83
Backloghttps://github.com/angular/angular/milestone/82
on Feb 28, 2018https://github.com/angular/angular/issues/20061#event-1496010636
gkalpakhttps://github.com/gkalpak
on Aug 6, 2018https://github.com/angular/angular/issues/20061#event-1772515900
fix(router): take base uri into account in `setUpLocationSync()`https://github.com/observstream/angular/commit/f37a640e045811bab8de9d29dfaf1c3140d2f80c
https://docs.github.com/articles/closing-issues-via-commit-messages
f37a640https://github.com/observstream/angular/commit/f37a640e045811bab8de9d29dfaf1c3140d2f80c
karahttps://github.com/kara
completedhttps://github.com/angular/angular/issues?q=is%3Aissue%20state%3Aclosed%20archived%3Afalse%20reason%3Acompleted
ba1e25fhttps://github.com/angular/angular/commit/ba1e25f53ff867f2caaa3eb3377abfdbea6fedeb
on Aug 6, 2018https://github.com/angular/angular/issues/20061#event-1773539239
karahttps://github.com/kara
on Aug 6, 2018https://github.com/angular/angular/issues/20061#event-1773539272
fix(router): take base uri into account in `setUpLocationSync()` (#20244https://github.com/angular/angular/commit/ae9b4e6fa73b0af48962cb76e0388e161c1e609a
#20244https://github.com/angular/angular/pull/20244
https://docs.github.com/articles/closing-issues-via-commit-messages
ae9b4e6https://github.com/angular/angular/commit/ae9b4e6fa73b0af48962cb76e0388e161c1e609a
https://github.com/apps/angular-automatic-lock-bot
angular-automatic-lock-bothttps://github.com/apps/angular-automatic-lock-bot
on Sep 13, 2019https://github.com/angular/angular/issues/20061#issuecomment-531409180
automatic conversation locking policyhttps://github.com/angular/angular/blob/67d80f/docs/GITHUB_PROCESS.md#conversation-locking
angular-automatic-lock-bothttps://github.com/apps/angular-automatic-lock-bot
on Sep 13, 2019https://github.com/angular/angular/issues/20061#event-2633701282
adhambaouzhttps://github.com/adhambaouz
on Nov 20, 2026https://github.com/angular/angular/issues/20061#event-36822240796
fix(router): take base uri into account in `setUpLocationSync()` (ang…https://github.com/adhambaouz/angular/commit/2fe29f91e54678febd32ab76244fce0d85fb849f
ang…https://github.com/angular/angular/pull/20244
https://docs.github.com/articles/closing-issues-via-commit-messages
2fe29f9https://github.com/adhambaouz/angular/commit/2fe29f91e54678febd32ab76244fce0d85fb849f
Sign up for freehttps://github.com/signup?return_to=https://github.com/angular/angular/issues/20061
Sign in to commenthttps://github.com/login?return_to=https://github.com/angular/angular/issues/20061
area: routerhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20router%22
freq2: mediumhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22freq2%3A%20medium%22
type: bug/fixhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22type%3A%20bug%2Ffix%22
BacklogNo due datehttps://github.com/angular/angular/milestone/82
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.