Title: Feature Request: Unify the toBoolean behavior for boolean attributes · Issue #19929 · angular/angular · GitHub
Open Graph Title: Feature Request: Unify the toBoolean behavior for boolean attributes · Issue #19929 · angular/angular
X Title: Feature Request: Unify the toBoolean behavior for boolean attributes · Issue #19929 · angular/angular
Description: I'm submitting a... [ ] Regression (a behavior that used to work and stopped working in a new release) [ ] Bug report [x] Feature request [ ] Documentation issue or request [ ] Support request => Please do not submit support request here...
Open Graph Description: I'm submitting a... [ ] Regression (a behavior that used to work and stopped working in a new release) [ ] Bug report [x] Feature request [ ] Documentation issue or request [ ] Support request => P...
X Description: I'm submitting a... [ ] Regression (a behavior that used to work and stopped working in a new release) [ ] Bug report [x] Feature request [ ] Documentation issue or request [ ] Support request ...
Opengraph URL: https://github.com/angular/angular/issues/19929
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Feature Request: Unify the toBoolean behavior for boolean attributes","articleBody":"\u003c!--\r\nPLEASE HELP US PROCESS GITHUB ISSUES FASTER BY PROVIDING THE FOLLOWING INFORMATION.\r\n\r\nISSUES MISSING IMPORTANT INFORMATION MAY BE CLOSED WITHOUT INVESTIGATION.\r\n-->\r\n\r\n## I'm submitting a...\r\n\u003c!-- Check one of the following options with \"x\" -->\r\n\u003cpre>\u003ccode>\r\n[ ] Regression (a behavior that used to work and stopped working in a new release)\r\n[ ] Bug report \u003c!-- Please search GitHub for a similar issue or PR before submitting -->\r\n[x] Feature request\r\n[ ] Documentation issue or request\r\n[ ] Support request => Please do not submit support request here, instead see https://github.com/angular/angular/blob/master/CONTRIBUTING.md#question\r\n\u003c/code>\u003c/pre>\r\n\r\n## Current behavior\r\n\u003c!-- Describe how the issue manifests. -->\r\n\r\n**Warning: this issue may be pedantic.**\r\n\r\nDifferent directives are using different mechanism to convert string to boolean.\r\n\r\nIn [`NgModel`](https://github.com/angular/angular/blob/master/packages/forms/src/directives/ng_model.ts#L263), the conversion is:\r\n\r\n```typescript\r\nconst isDisabled = disabledValue === '' || (disabledValue && disabledValue !== 'false');\r\n```\r\n\r\nWhile in [`RequiredValidator `](https://github.com/angular/angular/blob/master/packages/forms/src/directives/validators.ts#L89):\r\n\r\n```typescript\r\nthis._required = value != null && value !== false && `${value}` !== 'false';\r\n```\r\n\r\nAnd in [`EmailValidator `](https://github.com/angular/angular/blob/master/packages/forms/src/directives/validators.ts#L158):\r\n\r\n```typescript\r\nthis._enabled = value === '' || value === true || value === 'true';\r\n```\r\n\r\nSo that the result is:\r\n\r\nPattern |`[disabled]`|`[required]`|`[email]`\r\n-------------------------------|------------|------------|---------\r\n`\u003celement attribute>` |`true` |`true` |`true`\r\n`\u003celement attribute=\"true\">` |`true` |`true` |`true`\r\n`\u003celement attribute=\"false\">` |`false` |`false` |`false`\r\n`\u003celement attribute=\"foo\">` |`true` |`true` |`false`\r\n`\u003celement [attribute]=\"true\">`|`true` |`true` |`true`\r\n`\u003celement [attribute]=\"false\">`|`false` |`false` |`false`\r\n`\u003celement [attribute]=\"null\">`|`false` |`false` |`false`\r\n`\u003celement [attribute]=\"0\">`|`false` |`true` |`false`\r\n`\u003celement [attribute]=\"1\">`|`true` |`true` |`false`\r\n`\u003celement [attribute]=\"{}\">`|`true` |`true` |`false`\r\n`\u003celement [attribute]=\"{toString:()=>'false'}\">`|`true` |`false` |`false`\r\n\r\n*The object definition is inlined just for demonstration.*\r\n\r\n## Expected behavior\r\n\u003c!-- Describe what the desired behavior would be. -->\r\n\r\nAngular should provide a unified mechanism for string -> boolean transformation in boolean attributes.\r\n\r\n\r\n## Minimal reproduction of the problem with instructions\r\n\u003c!--\r\nFor bug reports please provide the *STEPS TO REPRODUCE* and if possible a *MINIMAL DEMO* of the problem via\r\nhttps://plnkr.co or similar (you can use this template as a starting point: http://plnkr.co/edit/tpl:AvJOMERrnz94ekVua0u5).\r\n-->\r\nLikely not needed as a one-line code in console.\r\n\r\n## What is the motivation / use case for changing the behavior?\r\n\u003c!-- Describe the motivation or the concrete use case. -->\r\n\r\nAngular should provide a guideline for how to covert string to boolean in boolean attributes.\r\n\r\n## Environment\r\n\r\n\u003cpre>\u003ccode>\r\nAngular version: 5.0.0-rc.5\r\n\u003c!-- Check whether this is still an issue in the most recent Angular version -->\r\n\r\nBrowser:\r\n- [x] Chrome (desktop) version XX\r\n- [x] Chrome (Android) version XX\r\n- [x] Chrome (iOS) version XX\r\n- [x] Firefox version XX\r\n- [x] Safari (desktop) version XX\r\n- [x] Safari (iOS) version XX\r\n- [x] IE version XX\r\n- [x] Edge version XX\r\n \r\nFor Tooling issues:\r\n- Node version: XX \u003c!-- run `node --version` -->\r\n- Platform: \u003c!-- Mac, Linux, Windows -->\r\n\r\nOthers:\r\n\u003c!-- Anything else relevant? Operating system version, IDE, package manager, HTTP server, ... -->\r\n\u003c/code>\u003c/pre>\r\n\r\nAnother question is that `NgModel#disbaled` is declared as `boolean` while still accepts `string` value (by design for empty string), is it expected? (Consider we'll have type-checking for inputs some day)","author":{"url":"https://github.com/trotyl","@type":"Person","name":"trotyl"},"datePublished":"2017-10-25T15:27:52Z","url":"https://github.com/angular/angular/issues/19929"}
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:5ca59b02-6c1d-66d3-d36d-3c2cbddcd452 |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | A156:842EC:1930F55:2195116:6B015102 |
| html-safe-nonce | 5b5eec4000370e101491d2548f963f76ea21dcb13d4e6cb53867bdab3db9998d |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBMTU2Ojg0MkVDOjE5MzBGNTU6MjE5NTExNjo2QjAxNTEwMiIsInZpc2l0b3JfaWQiOiIxOTIwMDQ5MzczMjM3MDM5MzYyIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | 1839ff0c53185e1331f4515a54cd8fb9ec7d02888ff8ed5bdba241670bf5d4ba |
| hovercard-subject-tag | issue:268442581 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/angular/angular/19929/issue_layout |
| twitter:image | https://opengraph.githubassets.com/aa60810953afd7b30c9d16eb1d700a61f1c5fb2d605ee967238dfa81501bf45c/angular/angular/issues/19929 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/aa60810953afd7b30c9d16eb1d700a61f1c5fb2d605ee967238dfa81501bf45c/angular/angular/issues/19929 |
| og:image:alt | I'm submitting a... [ ] Regression (a behavior that used to work and stopped working in a new release) [ ] Bug report [x] Feature request [ ] Documentation issue or request [ ] Support request => P... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | trotyl |
| hostname | github.com |
| expected-hostname | github.com |
| None | cc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c |
| turbo-cache-control | no-preview |
| go-import | github.com/angular/angular git https://github.com/angular/angular.git |
| octolytics-dimension-user_id | 139426 |
| octolytics-dimension-user_login | angular |
| octolytics-dimension-repository_id | 24195339 |
| octolytics-dimension-repository_nwo | angular/angular |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 24195339 |
| octolytics-dimension-repository_network_root_nwo | angular/angular |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 8c77c9e8439031ad54c75a250694842892f693e1 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | issues |
Links:
Viewport: width=device-width