René's URL Explorer Experiment


Title: Feature Request: Unify the toBoolean behavior for boolean attributes · Issue #19929 · angular/angular · GitHub

Open Graph Title: Feature Request: Unify the toBoolean behavior for boolean attributes · Issue #19929 · angular/angular

X Title: Feature Request: Unify the toBoolean behavior for boolean attributes · Issue #19929 · angular/angular

Description: I'm submitting a... [ ] Regression (a behavior that used to work and stopped working in a new release) [ ] Bug report [x] Feature request [ ] Documentation issue or request [ ] Support request => Please do not submit support request here...

Open Graph Description: I'm submitting a... [ ] Regression (a behavior that used to work and stopped working in a new release) [ ] Bug report [x] Feature request [ ] Documentation issue or request [ ] Support request => P...

X Description: I'm submitting a... [ ] Regression (a behavior that used to work and stopped working in a new release) [ ] Bug report [x] Feature request [ ] Documentation issue or request [ ] Support request ...

Opengraph URL: https://github.com/angular/angular/issues/19929

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Feature Request: Unify the toBoolean behavior for boolean attributes","articleBody":"\u003c!--\r\nPLEASE HELP US PROCESS GITHUB ISSUES FASTER BY PROVIDING THE FOLLOWING INFORMATION.\r\n\r\nISSUES MISSING IMPORTANT INFORMATION MAY BE CLOSED WITHOUT INVESTIGATION.\r\n-->\r\n\r\n## I'm submitting a...\r\n\u003c!-- Check one of the following options with \"x\" -->\r\n\u003cpre>\u003ccode>\r\n[ ] Regression (a behavior that used to work and stopped working in a new release)\r\n[ ] Bug report  \u003c!-- Please search GitHub for a similar issue or PR before submitting -->\r\n[x] Feature request\r\n[ ] Documentation issue or request\r\n[ ] Support request => Please do not submit support request here, instead see https://github.com/angular/angular/blob/master/CONTRIBUTING.md#question\r\n\u003c/code>\u003c/pre>\r\n\r\n## Current behavior\r\n\u003c!-- Describe how the issue manifests. -->\r\n\r\n**Warning: this issue may be pedantic.**\r\n\r\nDifferent directives are using different mechanism to convert string to boolean.\r\n\r\nIn [`NgModel`](https://github.com/angular/angular/blob/master/packages/forms/src/directives/ng_model.ts#L263), the conversion is:\r\n\r\n```typescript\r\nconst isDisabled = disabledValue === '' || (disabledValue && disabledValue !== 'false');\r\n```\r\n\r\nWhile in  [`RequiredValidator `](https://github.com/angular/angular/blob/master/packages/forms/src/directives/validators.ts#L89):\r\n\r\n```typescript\r\nthis._required = value != null && value !== false && `${value}` !== 'false';\r\n```\r\n\r\nAnd in [`EmailValidator `](https://github.com/angular/angular/blob/master/packages/forms/src/directives/validators.ts#L158):\r\n\r\n```typescript\r\nthis._enabled = value === '' || value === true || value === 'true';\r\n```\r\n\r\nSo that the result is:\r\n\r\nPattern                                       |`[disabled]`|`[required]`|`[email]`\r\n-------------------------------|------------|------------|---------\r\n`\u003celement attribute>`              |`true`          |`true`          |`true`\r\n`\u003celement attribute=\"true\">`  |`true`          |`true`          |`true`\r\n`\u003celement attribute=\"false\">` |`false`         |`false`        |`false`\r\n`\u003celement attribute=\"foo\">`    |`true`         |`true`          |`false`\r\n`\u003celement [attribute]=\"true\">`|`true`         |`true`          |`true`\r\n`\u003celement [attribute]=\"false\">`|`false`         |`false`        |`false`\r\n`\u003celement [attribute]=\"null\">`|`false`         |`false`        |`false`\r\n`\u003celement [attribute]=\"0\">`|`false`         |`true`        |`false`\r\n`\u003celement [attribute]=\"1\">`|`true`         |`true`        |`false`\r\n`\u003celement [attribute]=\"{}\">`|`true`         |`true`        |`false`\r\n`\u003celement [attribute]=\"{toString:()=>'false'}\">`|`true`         |`false`        |`false`\r\n\r\n*The object definition is inlined just for demonstration.*\r\n\r\n## Expected behavior\r\n\u003c!-- Describe what the desired behavior would be. -->\r\n\r\nAngular should provide a unified mechanism for string -> boolean transformation in boolean attributes.\r\n\r\n\r\n## Minimal reproduction of the problem with instructions\r\n\u003c!--\r\nFor bug reports please provide the *STEPS TO REPRODUCE* and if possible a *MINIMAL DEMO* of the problem via\r\nhttps://plnkr.co or similar (you can use this template as a starting point: http://plnkr.co/edit/tpl:AvJOMERrnz94ekVua0u5).\r\n-->\r\nLikely not needed as a one-line code in console.\r\n\r\n## What is the motivation / use case for changing the behavior?\r\n\u003c!-- Describe the motivation or the concrete use case. -->\r\n\r\nAngular should provide a guideline for how to covert string to boolean in boolean attributes.\r\n\r\n## Environment\r\n\r\n\u003cpre>\u003ccode>\r\nAngular version: 5.0.0-rc.5\r\n\u003c!-- Check whether this is still an issue in the most recent Angular version -->\r\n\r\nBrowser:\r\n- [x] Chrome (desktop) version XX\r\n- [x] Chrome (Android) version XX\r\n- [x] Chrome (iOS) version XX\r\n- [x] Firefox version XX\r\n- [x] Safari (desktop) version XX\r\n- [x] Safari (iOS) version XX\r\n- [x] IE version XX\r\n- [x] Edge version XX\r\n \r\nFor Tooling issues:\r\n- Node version: XX  \u003c!-- run `node --version` -->\r\n- Platform:  \u003c!-- Mac, Linux, Windows -->\r\n\r\nOthers:\r\n\u003c!-- Anything else relevant?  Operating system version, IDE, package manager, HTTP server, ... -->\r\n\u003c/code>\u003c/pre>\r\n\r\nAnother question is that `NgModel#disbaled` is declared as `boolean` while still accepts `string` value (by design for empty string), is it expected? (Consider we'll have type-checking for inputs some day)","author":{"url":"https://github.com/trotyl","@type":"Person","name":"trotyl"},"datePublished":"2017-10-25T15:27:52Z","url":"https://github.com/angular/angular/issues/19929"}

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:5ca59b02-6c1d-66d3-d36d-3c2cbddcd452
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-idA156:842EC:1930F55:2195116:6B015102
html-safe-nonce5b5eec4000370e101491d2548f963f76ea21dcb13d4e6cb53867bdab3db9998d
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBMTU2Ojg0MkVDOjE5MzBGNTU6MjE5NTExNjo2QjAxNTEwMiIsInZpc2l0b3JfaWQiOiIxOTIwMDQ5MzczMjM3MDM5MzYyIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac1839ff0c53185e1331f4515a54cd8fb9ec7d02888ff8ed5bdba241670bf5d4ba
hovercard-subject-tagissue:268442581
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/angular/angular/19929/issue_layout
twitter:imagehttps://opengraph.githubassets.com/aa60810953afd7b30c9d16eb1d700a61f1c5fb2d605ee967238dfa81501bf45c/angular/angular/issues/19929
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/aa60810953afd7b30c9d16eb1d700a61f1c5fb2d605ee967238dfa81501bf45c/angular/angular/issues/19929
og:image:altI'm submitting a... [ ] Regression (a behavior that used to work and stopped working in a new release) [ ] Bug report [x] Feature request [ ] Documentation issue or request [ ] Support request => P...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernametrotyl
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-preview
go-importgithub.com/angular/angular git https://github.com/angular/angular.git
octolytics-dimension-user_id139426
octolytics-dimension-user_loginangular
octolytics-dimension-repository_id24195339
octolytics-dimension-repository_nwoangular/angular
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id24195339
octolytics-dimension-repository_network_root_nwoangular/angular
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-nameissues

Links:

Skip to contenthttps://github.com/angular/angular/issues/19929#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fissues%2F19929
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fissues%2F19929
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=angular%2Fangular
Reloadhttps://github.com/angular/angular/issues/19929
Reloadhttps://github.com/angular/angular/issues/19929
Reloadhttps://github.com/angular/angular/issues/19929
angularhttps://github.com/angular
angularhttps://github.com/angular/angular
Codehttps://github.com/angular/angular
Issues836 (836)https://github.com/angular/angular/issues
Pull requests141 (141)https://github.com/angular/angular/pulls
Discussionshttps://github.com/angular/angular/discussions
Actionshttps://github.com/angular/angular/actions
Projectshttps://github.com/angular/angular/projects
Security and quality40 (40)https://github.com/angular/angular/security
Insightshttps://github.com/angular/angular/insights
https://github.com/angular/angular
New issuehttps://github.com/login?return_to=https://github.com/angular/angular/issues/19929
New issuehttps://github.com/login?return_to=https://github.com/angular/angular/issues/19929
Feature Request: Unify the toBoolean behavior for boolean attributeshttps://github.com/angular/angular/issues/19929#top
P4A relatively minor issue that is not relevant to core functionshttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22P4%22
area: coreIssues related to the framework runtimehttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20core%22
core: binding & interpolationIssue related to property/attribute binding or text interpolationhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22core%3A%20binding%20%26%20interpolation%22
featureLabel used to distinguish feature request from other issueshttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22feature%22
freq2: mediumhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22freq2%3A%20medium%22
Backloghttps://github.com/angular/angular/milestone/82
https://github.com/trotyl
trotylhttps://github.com/trotyl
on Oct 25, 2017https://github.com/angular/angular/issues/19929#issue-268442581
NgModelhttps://github.com/angular/angular/blob/master/packages/forms/src/directives/ng_model.ts#L263
RequiredValidator https://github.com/angular/angular/blob/master/packages/forms/src/directives/validators.ts#L89
EmailValidator https://github.com/angular/angular/blob/master/packages/forms/src/directives/validators.ts#L158
https://github.com/dawidgarus
dawidgarushttps://github.com/dawidgarus
on Oct 25, 2017https://github.com/angular/angular/issues/19929#issuecomment-339383553
https://github.com/trotyl
trotylhttps://github.com/trotyl
on Oct 25, 2017https://github.com/angular/angular/issues/19929#issuecomment-339392282
#5761https://github.com/angular/angular/pull/5761
#14761https://github.com/angular/angular/issues/14761
https://github.com/trotyl
trotylhttps://github.com/trotyl
on Oct 25, 2017https://github.com/angular/angular/issues/19929#issuecomment-339394500
@dawidgarushttps://github.com/dawidgarus
#8968https://github.com/angular/angular/issues/8968
https://github.com/LinboLen
LinboLenhttps://github.com/LinboLen
on Oct 26, 2017https://github.com/angular/angular/issues/19929#issuecomment-339626459
matskohttps://github.com/matsko
area: coreIssues related to the framework runtimehttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20core%22
severity1: confusinghttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22severity1%3A%20confusing%22
freq2: mediumhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22freq2%3A%20medium%22
on Oct 26, 2017https://github.com/angular/angular/issues/19929#event-1312870957
chuckjazhttps://github.com/chuckjaz
featureLabel used to distinguish feature request from other issueshttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22feature%22
on Nov 6, 2017https://github.com/angular/angular/issues/19929#event-1328215230
ngbothttps://github.com/apps/ngbot
Backloghttps://github.com/angular/angular/milestone/82
on Jan 23, 2018https://github.com/angular/angular/issues/19929#event-1437537383
https://github.com/alan-agius4
alan-agius4https://github.com/alan-agius4
on Feb 9, 2018https://github.com/angular/angular/issues/19929#issuecomment-364424955
https://github.com/angular/material2/tree/17cc4a198f336e8ebefbb2710d8e80df2595db7e/src/cdk/coercionhttps://github.com/angular/material2/tree/17cc4a198f336e8ebefbb2710d8e80df2595db7e/src/cdk/coercion
https://github.com/trotyl
trotylhttps://github.com/trotyl
on Feb 9, 2018https://github.com/angular/angular/issues/19929#issuecomment-364425719
@alan-agius4https://github.com/alan-agius4
pkozlowski-opensourcehttps://github.com/pkozlowski-opensource
core: binding & interpolationIssue related to property/attribute binding or text interpolationhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22core%3A%20binding%20%26%20interpolation%22
on Mar 12, 2020https://github.com/angular/angular/issues/19929#event-3124333666
jelbournhttps://github.com/jelbourn
P4A relatively minor issue that is not relevant to core functionshttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22P4%22
severity1: confusinghttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22severity1%3A%20confusing%22
on Oct 1, 2020https://github.com/angular/angular/issues/19929#event-3830199223
https://github.com/apps/angular-robot
angular-robothttps://github.com/apps/angular-robot
on Jun 4, 2021https://github.com/angular/angular/issues/19929#issuecomment-854778326
documentationhttps://github.com/angular/angular/blob/e29eb8abfbfdfb793e08ac88e14b7ba6d2ff2136/docs/GITHUB_PROCESS.md#feature-request-process
angular-robothttps://github.com/apps/angular-robot
votes requiredhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22votes%20required%22
on Jun 4, 2021https://github.com/angular/angular/issues/19929#event-4843566185
https://github.com/apps/angular-robot
angular-robothttps://github.com/apps/angular-robot
on Jun 24, 2021https://github.com/angular/angular/issues/19929#issuecomment-867664754
communityhttps://angular.io/resources?category=community
packagehttps://angular.io/guide/creating-libraries
documentationhttps://github.com/angular/angular/blob/e29eb8abfbfdfb793e08ac88e14b7ba6d2ff2136/docs/GITHUB_PROCESS.md#feature-request-process
angular-robothttps://github.com/apps/angular-robot
insufficient voteshttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22insufficient%20votes%22
on Jun 24, 2021https://github.com/angular/angular/issues/19929#event-4934833501
AndrewKushnirhttps://github.com/AndrewKushnir
completedhttps://github.com/angular/angular/issues?q=is%3Aissue%20state%3Aclosed%20archived%3Afalse%20reason%3Acompleted
on Mar 28, 2022https://github.com/angular/angular/issues/19929#event-6322313776
https://github.com/apps/angular-automatic-lock-bot
angular-automatic-lock-bothttps://github.com/apps/angular-automatic-lock-bot
on Apr 28, 2022https://github.com/angular/angular/issues/19929#issuecomment-1112392924
automatic conversation locking policyhttps://github.com/angular/angular/blob/8f24bc9443b3872fe095d9f7f77b308a361a13b4/docs/GITHUB_PROCESS.md#conversation-locking
angular-automatic-lock-bothttps://github.com/apps/angular-automatic-lock-bot
on Apr 28, 2022https://github.com/angular/angular/issues/19929#event-6516469246
Sign up for freehttps://github.com/signup?return_to=https://github.com/angular/angular/issues/19929
Sign in to commenthttps://github.com/login?return_to=https://github.com/angular/angular/issues/19929
P4A relatively minor issue that is not relevant to core functionshttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22P4%22
area: coreIssues related to the framework runtimehttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20core%22
core: binding & interpolationIssue related to property/attribute binding or text interpolationhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22core%3A%20binding%20%26%20interpolation%22
featureLabel used to distinguish feature request from other issueshttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22feature%22
freq2: mediumhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22freq2%3A%20medium%22
BacklogNo due datehttps://github.com/angular/angular/milestone/82
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.