Title: SelectControlValueAccessor.compareWith: 25 tests for 5 options seems excessive · Issue #19723 · angular/angular · GitHub
Open Graph Title: SelectControlValueAccessor.compareWith: 25 tests for 5 options seems excessive · Issue #19723 · angular/angular
X Title: SelectControlValueAccessor.compareWith: 25 tests for 5 options seems excessive · Issue #19723 · angular/angular
Description: I'm submitting a... [ ] Regression (a behavior that used to work and stopped working in a new release) [x] Bug report [ ] Feature request [ ] Documentation issue or request [ ] Support request => Please do not submit support request here...
Open Graph Description: I'm submitting a... [ ] Regression (a behavior that used to work and stopped working in a new release) [x] Bug report [ ] Feature request [ ] Documentation issue or request [ ] Support request => P...
X Description: I'm submitting a... [ ] Regression (a behavior that used to work and stopped working in a new release) [x] Bug report [ ] Feature request [ ] Documentation issue or request [ ] Support request ...
Opengraph URL: https://github.com/angular/angular/issues/19723
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"SelectControlValueAccessor.compareWith: 25 tests for 5 options seems excessive","articleBody":"\u003c!--\r\nPLEASE HELP US PROCESS GITHUB ISSUES FASTER BY PROVIDING THE FOLLOWING INFORMATION.\r\n\r\nISSUES MISSING IMPORTANT INFORMATION MAY BE CLOSED WITHOUT INVESTIGATION.\r\n-->\r\n\r\n## I'm submitting a...\r\n\u003c!-- Check one of the following options with \"x\" -->\r\n\u003cpre>\u003ccode>\r\n[ ] Regression (a behavior that used to work and stopped working in a new release)\r\n[x] Bug report \u003c!-- Please search GitHub for a similar issue or PR before submitting -->\r\n[ ] Feature request\r\n[ ] Documentation issue or request\r\n[ ] Support request => Please do not submit support request here, instead see https://github.com/angular/angular/blob/master/CONTRIBUTING.md#question\r\n\u003c/code>\u003c/pre>\r\n\r\n## Current behavior\r\n\u003c!-- Describe how the issue manifests. -->\r\n\r\nWhen using `compareWith` on a `\u003cselect>` with only 5 options, `compareWith` function is being called 25 times.\r\n\r\nOn initialization of the form, 15 runs are tested against `undefined`, 5 against `null` and 5 against an object.\r\n\r\nOn refresh of the option list, 25 runs are tested against an object in a peculiar order.\r\n\r\nThis happens both in development and production.\r\n\r\n## Expected behavior\r\n\u003c!-- Describe what the desired behavior would be. -->\r\nI would expect it to test between 1 and max. 5 times depending on the selected option\r\n\r\n\r\n## Minimal reproduction of the problem with instructions\r\n\u003c!--\r\nFor bug reports please provide the *STEPS TO REPRODUCE* and if possible a *MINIMAL DEMO* of the problem via\r\nhttps://plnkr.co or similar (you can use this template as a starting point: http://plnkr.co/edit/tpl:AvJOMERrnz94ekVua0u5).\r\n-->\r\n[demo plunker](https://embed.plnkr.co/rSGExdIewdJpshDs7tSw/) See console for output.\r\n\r\n## What is the motivation / use case for changing the behavior?\r\n\u003c!-- Describe the motivation or the concrete use case. -->\r\nPerformance\r\n\r\n## Environment\r\n\r\n\u003cpre>\u003ccode>\r\nAngular version: 4.4.5\r\n\u003c!-- Check whether this is still an issue in the most recent Angular version -->\r\n\r\nBrowser:\r\n- [x] Chrome (desktop) version 61.0.3163.100 (Official Build) (64-bit)\r\n- [ ] Chrome (Android) version XX\r\n- [ ] Chrome (iOS) version XX\r\n- [ ] Firefox version XX\r\n- [ ] Safari (desktop) version XX\r\n- [ ] Safari (iOS) version XX\r\n- [ ] IE version XX\r\n- [ ] Edge version XX\r\n- [x] Electron version 1.7.8\r\n\r\nFor Tooling issues:\r\n- Node version: v8.5.0 \u003c!-- run `node --version` -->\r\n- Platform: Windows 10 \u003c!-- Mac, Linux, Windows --> \r\n\r\nOthers:\r\n\u003c!-- Anything else relevant? Operating system version, IDE, package manager, HTTP server, ... -->\r\n\u003c/code>\u003c/pre>\r\n","author":{"url":"https://github.com/pamtbaau","@type":"Person","name":"pamtbaau"},"datePublished":"2017-10-14T10:01:06Z","url":"https://github.com/angular/angular/issues/19723"}
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:65b6ed8b-4a7f-ae29-69c7-8b5c209df8b3 |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | D27C:34CAB:186B7DA:1F27265:6B01479F |
| html-safe-nonce | dba3d40094410dd7a72c4405ec8fbbd0afb2460a29c0cda8180012ad3828ed10 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEMjdDOjM0Q0FCOjE4NkI3REE6MUYyNzI2NTo2QjAxNDc5RiIsInZpc2l0b3JfaWQiOiIxNzExODY0NTQ2MzcxMzU3NzUiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | f732f7c5cd823ee168d6d6dc762ebf853efba5abe7b899e9ffbb0a5c2bb544d3 |
| hovercard-subject-tag | issue:265479972 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/angular/angular/19723/issue_layout |
| twitter:image | https://opengraph.githubassets.com/05efa06978445b3ef3c4fed358099ab7cbffa8367621b50910df4cedd282fab9/angular/angular/issues/19723 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/05efa06978445b3ef3c4fed358099ab7cbffa8367621b50910df4cedd282fab9/angular/angular/issues/19723 |
| og:image:alt | I'm submitting a... [ ] Regression (a behavior that used to work and stopped working in a new release) [x] Bug report [ ] Feature request [ ] Documentation issue or request [ ] Support request => P... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | pamtbaau |
| hostname | github.com |
| expected-hostname | github.com |
| None | cc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c |
| turbo-cache-control | no-preview |
| go-import | github.com/angular/angular git https://github.com/angular/angular.git |
| octolytics-dimension-user_id | 139426 |
| octolytics-dimension-user_login | angular |
| octolytics-dimension-repository_id | 24195339 |
| octolytics-dimension-repository_nwo | angular/angular |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 24195339 |
| octolytics-dimension-repository_network_root_nwo | angular/angular |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 8c77c9e8439031ad54c75a250694842892f693e1 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | issues |
Links:
Viewport: width=device-width