René's URL Explorer Experiment


Title: SelectControlValueAccessor.compareWith: 25 tests for 5 options seems excessive · Issue #19723 · angular/angular · GitHub

Open Graph Title: SelectControlValueAccessor.compareWith: 25 tests for 5 options seems excessive · Issue #19723 · angular/angular

X Title: SelectControlValueAccessor.compareWith: 25 tests for 5 options seems excessive · Issue #19723 · angular/angular

Description: I'm submitting a... [ ] Regression (a behavior that used to work and stopped working in a new release) [x] Bug report [ ] Feature request [ ] Documentation issue or request [ ] Support request => Please do not submit support request here...

Open Graph Description: I'm submitting a... [ ] Regression (a behavior that used to work and stopped working in a new release) [x] Bug report [ ] Feature request [ ] Documentation issue or request [ ] Support request => P...

X Description: I'm submitting a... [ ] Regression (a behavior that used to work and stopped working in a new release) [x] Bug report [ ] Feature request [ ] Documentation issue or request [ ] Support request ...

Opengraph URL: https://github.com/angular/angular/issues/19723

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"SelectControlValueAccessor.compareWith: 25 tests for 5 options seems excessive","articleBody":"\u003c!--\r\nPLEASE HELP US PROCESS GITHUB ISSUES FASTER BY PROVIDING THE FOLLOWING INFORMATION.\r\n\r\nISSUES MISSING IMPORTANT INFORMATION MAY BE CLOSED WITHOUT INVESTIGATION.\r\n-->\r\n\r\n## I'm submitting a...\r\n\u003c!-- Check one of the following options with \"x\" -->\r\n\u003cpre>\u003ccode>\r\n[ ] Regression (a behavior that used to work and stopped working in a new release)\r\n[x] Bug report  \u003c!-- Please search GitHub for a similar issue or PR before submitting -->\r\n[ ] Feature request\r\n[ ] Documentation issue or request\r\n[ ] Support request => Please do not submit support request here, instead see https://github.com/angular/angular/blob/master/CONTRIBUTING.md#question\r\n\u003c/code>\u003c/pre>\r\n\r\n## Current behavior\r\n\u003c!-- Describe how the issue manifests. -->\r\n\r\nWhen using `compareWith` on a `\u003cselect>` with only 5 options, `compareWith` function is being called 25 times.\r\n\r\nOn initialization of the form, 15 runs are tested against `undefined`, 5 against `null` and 5 against an object.\r\n\r\nOn refresh of the option list, 25 runs are tested against an object in a peculiar order.\r\n\r\nThis happens both in development and production.\r\n\r\n## Expected behavior\r\n\u003c!-- Describe what the desired behavior would be. -->\r\nI would expect it to test between 1 and max. 5 times depending on the selected option\r\n\r\n\r\n## Minimal reproduction of the problem with instructions\r\n\u003c!--\r\nFor bug reports please provide the *STEPS TO REPRODUCE* and if possible a *MINIMAL DEMO* of the problem via\r\nhttps://plnkr.co or similar (you can use this template as a starting point: http://plnkr.co/edit/tpl:AvJOMERrnz94ekVua0u5).\r\n-->\r\n[demo plunker](https://embed.plnkr.co/rSGExdIewdJpshDs7tSw/) See console for output.\r\n\r\n## What is the motivation / use case for changing the behavior?\r\n\u003c!-- Describe the motivation or the concrete use case. -->\r\nPerformance\r\n\r\n## Environment\r\n\r\n\u003cpre>\u003ccode>\r\nAngular version: 4.4.5\r\n\u003c!-- Check whether this is still an issue in the most recent Angular version -->\r\n\r\nBrowser:\r\n- [x] Chrome (desktop) version 61.0.3163.100 (Official Build) (64-bit)\r\n- [ ] Chrome (Android) version XX\r\n- [ ] Chrome (iOS) version XX\r\n- [ ] Firefox version XX\r\n- [ ] Safari (desktop) version XX\r\n- [ ] Safari (iOS) version XX\r\n- [ ] IE version XX\r\n- [ ] Edge version XX\r\n- [x] Electron version 1.7.8\r\n\r\nFor Tooling issues:\r\n- Node version:  v8.5.0 \u003c!-- run `node --version` -->\r\n- Platform:  Windows 10 \u003c!-- Mac, Linux, Windows --> \r\n\r\nOthers:\r\n\u003c!-- Anything else relevant?  Operating system version, IDE, package manager, HTTP server, ... -->\r\n\u003c/code>\u003c/pre>\r\n","author":{"url":"https://github.com/pamtbaau","@type":"Person","name":"pamtbaau"},"datePublished":"2017-10-14T10:01:06Z","url":"https://github.com/angular/angular/issues/19723"}

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:65b6ed8b-4a7f-ae29-69c7-8b5c209df8b3
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-idD27C:34CAB:186B7DA:1F27265:6B01479F
html-safe-noncedba3d40094410dd7a72c4405ec8fbbd0afb2460a29c0cda8180012ad3828ed10
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEMjdDOjM0Q0FCOjE4NkI3REE6MUYyNzI2NTo2QjAxNDc5RiIsInZpc2l0b3JfaWQiOiIxNzExODY0NTQ2MzcxMzU3NzUiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmacf732f7c5cd823ee168d6d6dc762ebf853efba5abe7b899e9ffbb0a5c2bb544d3
hovercard-subject-tagissue:265479972
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/angular/angular/19723/issue_layout
twitter:imagehttps://opengraph.githubassets.com/05efa06978445b3ef3c4fed358099ab7cbffa8367621b50910df4cedd282fab9/angular/angular/issues/19723
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/05efa06978445b3ef3c4fed358099ab7cbffa8367621b50910df4cedd282fab9/angular/angular/issues/19723
og:image:altI'm submitting a... [ ] Regression (a behavior that used to work and stopped working in a new release) [x] Bug report [ ] Feature request [ ] Documentation issue or request [ ] Support request => P...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamepamtbaau
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-preview
go-importgithub.com/angular/angular git https://github.com/angular/angular.git
octolytics-dimension-user_id139426
octolytics-dimension-user_loginangular
octolytics-dimension-repository_id24195339
octolytics-dimension-repository_nwoangular/angular
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id24195339
octolytics-dimension-repository_network_root_nwoangular/angular
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-nameissues

Links:

Skip to contenthttps://github.com/angular/angular/issues/19723#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fissues%2F19723
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fissues%2F19723
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=angular%2Fangular
Reloadhttps://github.com/angular/angular/issues/19723
Reloadhttps://github.com/angular/angular/issues/19723
Reloadhttps://github.com/angular/angular/issues/19723
angularhttps://github.com/angular
angularhttps://github.com/angular/angular
Codehttps://github.com/angular/angular
Issues836 (836)https://github.com/angular/angular/issues
Pull requests141 (141)https://github.com/angular/angular/pulls
Discussionshttps://github.com/angular/angular/discussions
Actionshttps://github.com/angular/angular/actions
Projectshttps://github.com/angular/angular/projects
Security and quality40 (40)https://github.com/angular/angular/security
Insightshttps://github.com/angular/angular/insights
https://github.com/angular/angular
New issuehttps://github.com/login?return_to=https://github.com/angular/angular/issues/19723
New issuehttps://github.com/login?return_to=https://github.com/angular/angular/issues/19723
SelectControlValueAccessor.compareWith: 25 tests for 5 options seems excessivehttps://github.com/angular/angular/issues/19723#top
P4A relatively minor issue that is not relevant to core functionshttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22P4%22
area: formshttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20forms%22
freq2: mediumhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22freq2%3A%20medium%22
refactoringIssue that involves refactoring or code-cleanuphttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22refactoring%22
Backloghttps://github.com/angular/angular/milestone/82
https://github.com/pamtbaau
pamtbaauhttps://github.com/pamtbaau
on Oct 14, 2017https://github.com/angular/angular/issues/19723#issue-265479972
demo plunkerhttps://embed.plnkr.co/rSGExdIewdJpshDs7tSw/
https://github.com/Toxicable
Toxicablehttps://github.com/Toxicable
on Oct 14, 2017https://github.com/angular/angular/issues/19723#issuecomment-336655942
https://github.com/pamtbaau
pamtbaauhttps://github.com/pamtbaau
on Oct 14, 2017https://github.com/angular/angular/issues/19723#issuecomment-336660187
tboschhttps://github.com/tbosch
area: formshttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20forms%22
on Oct 16, 2017https://github.com/angular/angular/issues/19723#event-1295156075
karahttps://github.com/kara
freq2: mediumhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22freq2%3A%20medium%22
severity2: inconvenienthttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22severity2%3A%20inconvenient%22
refactoringIssue that involves refactoring or code-cleanuphttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22refactoring%22
hotlist: angular-core-teamhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22hotlist%3A%20angular-core-team%22
on Dec 5, 2017https://github.com/angular/angular/issues/19723#event-1371646902
https://github.com/kara
karahttps://github.com/kara
on Dec 5, 2017https://github.com/angular/angular/issues/19723#issuecomment-349150003
IgorMinarhttps://github.com/IgorMinar
type: bug/fixhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22type%3A%20bug%2Ffix%22
on Jan 24, 2018https://github.com/angular/angular/issues/19723#event-1438522648
ngbothttps://github.com/apps/ngbot
Backloghttps://github.com/angular/angular/milestone/82
on Jan 24, 2018https://github.com/angular/angular/issues/19723#event-1438522707
AndrewKushnirhttps://github.com/AndrewKushnir
state: needs more investigationhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22state%3A%20needs%20more%20investigation%22
triage #1https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22triage%20%231%22
type: bug/fixhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22type%3A%20bug%2Ffix%22
state: needs more investigationhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22state%3A%20needs%20more%20investigation%22
on May 27, 2020https://github.com/angular/angular/issues/19723#event-3379607353
jelbournhttps://github.com/jelbourn
hotlist: angular-core-teamhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22hotlist%3A%20angular-core-team%22
on Sep 22, 2020https://github.com/angular/angular/issues/19723#event-3793768461
jelbournhttps://github.com/jelbourn
P4A relatively minor issue that is not relevant to core functionshttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22P4%22
severity2: inconvenienthttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22severity2%3A%20inconvenient%22
on Oct 1, 2020https://github.com/angular/angular/issues/19723#event-3830212959
https://github.com/AndrewKushnir
AndrewKushnirhttps://github.com/AndrewKushnir
on Mar 23, 2021https://github.com/angular/angular/issues/19723#issuecomment-805357971
#41330https://github.com/angular/angular/issues/41330
AndrewKushnirhttps://github.com/AndrewKushnir
completedhttps://github.com/angular/angular/issues?q=is%3Aissue%20state%3Aclosed%20archived%3Afalse%20reason%3Acompleted
on Mar 23, 2021https://github.com/angular/angular/issues/19723#event-4499063777
https://github.com/apps/angular-automatic-lock-bot
angular-automatic-lock-bothttps://github.com/apps/angular-automatic-lock-bot
on Apr 23, 2021https://github.com/angular/angular/issues/19723#issuecomment-825762617
automatic conversation locking policyhttps://github.com/angular/angular/blob/8f24bc9443b3872fe095d9f7f77b308a361a13b4/docs/GITHUB_PROCESS.md#conversation-locking
angular-automatic-lock-bothttps://github.com/apps/angular-automatic-lock-bot
on Apr 23, 2021https://github.com/angular/angular/issues/19723#event-4637750863
Sign up for freehttps://github.com/signup?return_to=https://github.com/angular/angular/issues/19723
Sign in to commenthttps://github.com/login?return_to=https://github.com/angular/angular/issues/19723
P4A relatively minor issue that is not relevant to core functionshttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22P4%22
area: formshttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20forms%22
freq2: mediumhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22freq2%3A%20medium%22
refactoringIssue that involves refactoring or code-cleanuphttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22refactoring%22
BacklogNo due datehttps://github.com/angular/angular/milestone/82
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.