René's URL Explorer Experiment


Title: Updating disabled state after replacing FormGroup. · Issue #18381 · angular/angular · GitHub

Open Graph Title: Updating disabled state after replacing FormGroup. · Issue #18381 · angular/angular

X Title: Updating disabled state after replacing FormGroup. · Issue #18381 · angular/angular

Description: I'm submitting a... [ ] Regression (a behavior that used to work and stopped working in a new release) [x] Bug report [ ] Feature request [ ] Documentation issue or request [ ] Support request => Please do not submit support request here...

Open Graph Description: I'm submitting a... [ ] Regression (a behavior that used to work and stopped working in a new release) [x] Bug report [ ] Feature request [ ] Documentation issue or request [ ] Support request => P...

X Description: I'm submitting a... [ ] Regression (a behavior that used to work and stopped working in a new release) [x] Bug report [ ] Feature request [ ] Documentation issue or request [ ] Support request ...

Opengraph URL: https://github.com/angular/angular/issues/18381

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Updating disabled state after replacing FormGroup.","articleBody":"## I'm submitting a...\r\n\u003cpre>\u003ccode>\r\n[ ] Regression (a behavior that used to work and stopped working in a new release)\r\n[x] Bug report  \u003c!-- Please search GitHub for a similar issue or PR before submitting -->\r\n[ ] Feature request\r\n[ ] Documentation issue or request\r\n[ ] Support request => Please do not submit support request here, instead see https://github.com/angular/angular/blob/master/CONTRIBUTING.md#question\r\n\u003c/code>\u003c/pre>\r\n\r\n## Current behavior\r\nWhen I try to replace FormGroup that is bound to template, disabled state of controls isn't updated.\r\nI know, that I can use enable() and disable() methods, but in my case I'm generating complete FormGroups and I have to replace them.\r\n\r\nFor now I'm using workaround which crawls through whole AbstractControls tree and runs enable() and disable() methods but I believe it should be fixed in better way inside framework.\r\n\r\n## Expected behavior\r\nProperly refreshed DOM when I toggle control's state using new instance of FormGroup.\r\n\r\n\r\n## Minimal reproduction of the problem with instructions\r\n1. Open related plunker: https://plnkr.co/edit/XSp2RhwBEEPylQub8W0L?p=preview\r\n2. Click on 'Two enabled fields' button. Title select hasn't changed state to enabled.\r\n3. Click on 'Two disabled fields' button. Name input hasn't changed state to disabled.\r\n\r\nAfter each step value and state are updated inside connected FormControl (printed values) but change of disabled/enabled state is not propagated to DOM.\r\n\r\nI created second plunker with one small change, I'm binding controls using [formControl] instead of formControlName and it behaves slightly different: it hasn't got any problems with switching state to disabled but it can't return to enabled state. Link: http://plnkr.co/edit/Xipc02DXwcv5y5gPmexo?p=preview\r\n\r\n## What is the motivation / use case for changing the behavior?\r\nI need a clean way to replace FormGroups containing FormControls with disabled/enabled DOM state that corresponds to FormControl state.\r\n\r\n\r\n## Environment\r\n\r\n\u003cpre>\u003ccode>\r\nAngular version: 4.3.0-beta.0\r\n\r\nBrowser:\r\n- [x] Chrome (desktop) version 59.0.3071.115\r\n- [x] Firefox version 54.0.1\r\n- [x] IE version 11\r\n \r\nFor Tooling issues:\r\n- Node version: v6.9.5\r\n- Platform:  Windows","author":{"url":"https://github.com/dgluszczyk","@type":"Person","name":"dgluszczyk"},"datePublished":"2017-07-27T15:32:12Z","url":"https://github.com/angular/angular/issues/18381"}

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:61c32d72-813b-fa5e-94e1-66d6fefb5a07
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-idC3AC:1F2D:108B303:14E6A20:6B014BD0
html-safe-nonce28d1a74114c9ad372c3ad89be130afca214b3ea7107c81888c2581d87af11b41
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDM0FDOjFGMkQ6MTA4QjMwMzoxNEU2QTIwOjZCMDE0QkQwIiwidmlzaXRvcl9pZCI6IjEyOTkwNzM5OTQwMTIyOTI2NCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacef2442227d94593342deadfc06b42d533a5a849ee6df05446936b050483d44e6
hovercard-subject-tagissue:246080572
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/angular/angular/18381/issue_layout
twitter:imagehttps://opengraph.githubassets.com/676c3203812786e24ad652068ecdfdaeba782490f6e4431af889ccef55c89c2e/angular/angular/issues/18381
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/676c3203812786e24ad652068ecdfdaeba782490f6e4431af889ccef55c89c2e/angular/angular/issues/18381
og:image:altI'm submitting a... [ ] Regression (a behavior that used to work and stopped working in a new release) [x] Bug report [ ] Feature request [ ] Documentation issue or request [ ] Support request => P...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamedgluszczyk
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-preview
go-importgithub.com/angular/angular git https://github.com/angular/angular.git
octolytics-dimension-user_id139426
octolytics-dimension-user_loginangular
octolytics-dimension-repository_id24195339
octolytics-dimension-repository_nwoangular/angular
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id24195339
octolytics-dimension-repository_network_root_nwoangular/angular
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetcanary-2
theme-color#1e2327
color-schemelight dark
react-app-nameissues

Links:

Skip to contenthttps://github.com/angular/angular/issues/18381#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fissues%2F18381
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fissues%2F18381
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=angular%2Fangular
Reloadhttps://github.com/angular/angular/issues/18381
Reloadhttps://github.com/angular/angular/issues/18381
Reloadhttps://github.com/angular/angular/issues/18381
angularhttps://github.com/angular
angularhttps://github.com/angular/angular
Codehttps://github.com/angular/angular
Issues836 (836)https://github.com/angular/angular/issues
Pull requests141 (141)https://github.com/angular/angular/pulls
Discussionshttps://github.com/angular/angular/discussions
Actionshttps://github.com/angular/angular/actions
Projectshttps://github.com/angular/angular/projects
Security and quality40 (40)https://github.com/angular/angular/security
Insightshttps://github.com/angular/angular/insights
https://github.com/angular/angular
New issuehttps://github.com/login?return_to=https://github.com/angular/angular/issues/18381
New issuehttps://github.com/login?return_to=https://github.com/angular/angular/issues/18381
Updating disabled state after replacing FormGroup.https://github.com/angular/angular/issues/18381#top
area: formshttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20forms%22
type: bug/fixhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22type%3A%20bug%2Ffix%22
https://github.com/dgluszczyk
dgluszczykhttps://github.com/dgluszczyk
on Jul 27, 2017https://github.com/angular/angular/issues/18381#issue-246080572
https://plnkr.co/edit/XSp2RhwBEEPylQub8W0L?p=previewhttps://plnkr.co/edit/XSp2RhwBEEPylQub8W0L?p=preview
http://plnkr.co/edit/Xipc02DXwcv5y5gPmexo?p=previewhttp://plnkr.co/edit/Xipc02DXwcv5y5gPmexo?p=preview
alxhubhttps://github.com/alxhub
area: formshttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20forms%22
type: bug/fixhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22type%3A%20bug%2Ffix%22
on Jul 31, 2017https://github.com/angular/angular/issues/18381#event-1186443605
https://github.com/TheRemjx01
TheRemjx01https://github.com/TheRemjx01
on Aug 3, 2017https://github.com/angular/angular/issues/18381#issuecomment-319898508
https://github.com/dzonatan
dzonatanhttps://github.com/dzonatan
on Aug 16, 2017https://github.com/angular/angular/issues/18381#issuecomment-322880803
#17806https://github.com/angular/angular/issues/17806
#18575https://github.com/angular/angular/pull/18575
https://github.com/kara
karahttps://github.com/kara
on Dec 12, 2017https://github.com/angular/angular/issues/18381#issuecomment-351228048
#17806https://github.com/angular/angular/issues/17806
karahttps://github.com/kara
completedhttps://github.com/angular/angular/issues?q=is%3Aissue%20state%3Aclosed%20archived%3Afalse%20reason%3Acompleted
on Dec 12, 2017https://github.com/angular/angular/issues/18381#event-1384634659
https://github.com/apps/angular-automatic-lock-bot
angular-automatic-lock-bothttps://github.com/apps/angular-automatic-lock-bot
on Sep 13, 2019https://github.com/angular/angular/issues/18381#issuecomment-531064441
automatic conversation locking policyhttps://github.com/angular/angular/blob/67d80f/docs/GITHUB_PROCESS.md#conversation-locking
angular-automatic-lock-bothttps://github.com/apps/angular-automatic-lock-bot
on Sep 13, 2019https://github.com/angular/angular/issues/18381#event-2630971198
Sign up for freehttps://github.com/signup?return_to=https://github.com/angular/angular/issues/18381
Sign in to commenthttps://github.com/login?return_to=https://github.com/angular/angular/issues/18381
area: formshttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20forms%22
type: bug/fixhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22type%3A%20bug%2Ffix%22
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.