Title: Updating disabled state after replacing FormGroup. · Issue #18381 · angular/angular · GitHub
Open Graph Title: Updating disabled state after replacing FormGroup. · Issue #18381 · angular/angular
X Title: Updating disabled state after replacing FormGroup. · Issue #18381 · angular/angular
Description: I'm submitting a... [ ] Regression (a behavior that used to work and stopped working in a new release) [x] Bug report [ ] Feature request [ ] Documentation issue or request [ ] Support request => Please do not submit support request here...
Open Graph Description: I'm submitting a... [ ] Regression (a behavior that used to work and stopped working in a new release) [x] Bug report [ ] Feature request [ ] Documentation issue or request [ ] Support request => P...
X Description: I'm submitting a... [ ] Regression (a behavior that used to work and stopped working in a new release) [x] Bug report [ ] Feature request [ ] Documentation issue or request [ ] Support request ...
Opengraph URL: https://github.com/angular/angular/issues/18381
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Updating disabled state after replacing FormGroup.","articleBody":"## I'm submitting a...\r\n\u003cpre>\u003ccode>\r\n[ ] Regression (a behavior that used to work and stopped working in a new release)\r\n[x] Bug report \u003c!-- Please search GitHub for a similar issue or PR before submitting -->\r\n[ ] Feature request\r\n[ ] Documentation issue or request\r\n[ ] Support request => Please do not submit support request here, instead see https://github.com/angular/angular/blob/master/CONTRIBUTING.md#question\r\n\u003c/code>\u003c/pre>\r\n\r\n## Current behavior\r\nWhen I try to replace FormGroup that is bound to template, disabled state of controls isn't updated.\r\nI know, that I can use enable() and disable() methods, but in my case I'm generating complete FormGroups and I have to replace them.\r\n\r\nFor now I'm using workaround which crawls through whole AbstractControls tree and runs enable() and disable() methods but I believe it should be fixed in better way inside framework.\r\n\r\n## Expected behavior\r\nProperly refreshed DOM when I toggle control's state using new instance of FormGroup.\r\n\r\n\r\n## Minimal reproduction of the problem with instructions\r\n1. Open related plunker: https://plnkr.co/edit/XSp2RhwBEEPylQub8W0L?p=preview\r\n2. Click on 'Two enabled fields' button. Title select hasn't changed state to enabled.\r\n3. Click on 'Two disabled fields' button. Name input hasn't changed state to disabled.\r\n\r\nAfter each step value and state are updated inside connected FormControl (printed values) but change of disabled/enabled state is not propagated to DOM.\r\n\r\nI created second plunker with one small change, I'm binding controls using [formControl] instead of formControlName and it behaves slightly different: it hasn't got any problems with switching state to disabled but it can't return to enabled state. Link: http://plnkr.co/edit/Xipc02DXwcv5y5gPmexo?p=preview\r\n\r\n## What is the motivation / use case for changing the behavior?\r\nI need a clean way to replace FormGroups containing FormControls with disabled/enabled DOM state that corresponds to FormControl state.\r\n\r\n\r\n## Environment\r\n\r\n\u003cpre>\u003ccode>\r\nAngular version: 4.3.0-beta.0\r\n\r\nBrowser:\r\n- [x] Chrome (desktop) version 59.0.3071.115\r\n- [x] Firefox version 54.0.1\r\n- [x] IE version 11\r\n \r\nFor Tooling issues:\r\n- Node version: v6.9.5\r\n- Platform: Windows","author":{"url":"https://github.com/dgluszczyk","@type":"Person","name":"dgluszczyk"},"datePublished":"2017-07-27T15:32:12Z","url":"https://github.com/angular/angular/issues/18381"}
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:61c32d72-813b-fa5e-94e1-66d6fefb5a07 |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | C3AC:1F2D:108B303:14E6A20:6B014BD0 |
| html-safe-nonce | 28d1a74114c9ad372c3ad89be130afca214b3ea7107c81888c2581d87af11b41 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDM0FDOjFGMkQ6MTA4QjMwMzoxNEU2QTIwOjZCMDE0QkQwIiwidmlzaXRvcl9pZCI6IjEyOTkwNzM5OTQwMTIyOTI2NCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | ef2442227d94593342deadfc06b42d533a5a849ee6df05446936b050483d44e6 |
| hovercard-subject-tag | issue:246080572 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/angular/angular/18381/issue_layout |
| twitter:image | https://opengraph.githubassets.com/676c3203812786e24ad652068ecdfdaeba782490f6e4431af889ccef55c89c2e/angular/angular/issues/18381 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/676c3203812786e24ad652068ecdfdaeba782490f6e4431af889ccef55c89c2e/angular/angular/issues/18381 |
| og:image:alt | I'm submitting a... [ ] Regression (a behavior that used to work and stopped working in a new release) [x] Bug report [ ] Feature request [ ] Documentation issue or request [ ] Support request => P... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | dgluszczyk |
| hostname | github.com |
| expected-hostname | github.com |
| None | cc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c |
| turbo-cache-control | no-preview |
| go-import | github.com/angular/angular git https://github.com/angular/angular.git |
| octolytics-dimension-user_id | 139426 |
| octolytics-dimension-user_login | angular |
| octolytics-dimension-repository_id | 24195339 |
| octolytics-dimension-repository_nwo | angular/angular |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 24195339 |
| octolytics-dimension-repository_network_root_nwo | angular/angular |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 8c77c9e8439031ad54c75a250694842892f693e1 |
| ui-target | canary-2 |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | issues |
Links:
Viewport: width=device-width