Title: Router navigation triggered twice after manual change in browser URL · Issue #18366 · angular/angular · GitHub
Open Graph Title: Router navigation triggered twice after manual change in browser URL · Issue #18366 · angular/angular
X Title: Router navigation triggered twice after manual change in browser URL · Issue #18366 · angular/angular
Description: I'm submitting a... [ ] Regression (a behavior that used to work and stopped working in a new release) [x] Bug report [ ] Feature request [ ] Documentation issue or request [ ] Support request => Please do not submit support request here...
Open Graph Description: I'm submitting a... [ ] Regression (a behavior that used to work and stopped working in a new release) [x] Bug report [ ] Feature request [ ] Documentation issue or request [ ] Support request => P...
X Description: I'm submitting a... [ ] Regression (a behavior that used to work and stopped working in a new release) [x] Bug report [ ] Feature request [ ] Documentation issue or request [ ] Support request ...
Opengraph URL: https://github.com/angular/angular/issues/18366
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Router navigation triggered twice after manual change in browser URL","articleBody":"\u003c!--\r\nPLEASE HELP US PROCESS GITHUB ISSUES FASTER BY PROVIDING THE FOLLOWING INFORMATION.\r\n\r\nISSUES MISSING IMPORTANT INFORMATION MAY BE CLOSED WITHOUT INVESTIGATION.\r\n-->\r\n\r\n## I'm submitting a...\r\n\u003c!-- Check one of the following options with \"x\" -->\r\n\u003cpre>\u003ccode>\r\n[ ] Regression (a behavior that used to work and stopped working in a new release)\r\n[x] Bug report \u003c!-- Please search GitHub for a similar issue or PR before submitting -->\r\n[ ] Feature request\r\n[ ] Documentation issue or request\r\n[ ] Support request => Please do not submit support request here, instead see https://github.com/angular/angular/blob/master/CONTRIBUTING.md#question\r\n\u003c/code>\u003c/pre>\r\n\r\n## Current behavior\r\n\u003c!-- Describe how the issue manifests. -->\r\nConsider two routes with a master / detail pattern like `/crisis-center` and `/crisis-center/:id`.\r\n```typescript\r\nconst crisisCenterRoutes: Routes = [\r\n {\r\n path: '',\r\n component: CrisisCenterComponent,\r\n children: [\r\n {\r\n path: '',\r\n component: CrisisListComponent,\r\n children: [\r\n {\r\n path: ':id',\r\n component: CrisisDetailComponent,\r\n canDeactivate: [CanDeactivateGuard],\r\n resolve: {\r\n crisis: CrisisDetailResolver\r\n }\r\n },\r\n {\r\n path: '',\r\n component: CrisisCenterHomeComponent\r\n }\r\n ]\r\n }\r\n ]\r\n }\r\n];\r\n``` \r\nYou might want to redirect the master path to a particular `id`. This can be done in `CrisisCenterHomeComponent`, like so:\r\n\r\n```typescript\r\n@Component({\r\n template: `\r\n \u003cp>Welcome to the Crisis Center\u003c/p>\r\n `\r\n})\r\nexport class CrisisCenterHomeComponent {\r\n constructor(private route: ActivatedRoute, private router: Router) {\r\n this.router.navigate([1], {relativeTo: this.route});\r\n }\r\n}\r\n```\r\n\r\nOr with a `CanActivate` guard:\r\n\r\n```typescript\r\n@Injectable()\r\nexport class RedirectionGuard implements CanActivate {\r\n \r\n constructor(private router: Router) { }\r\n \r\n canActivate() {\r\n this.router.navigate(['/crisis-center', 1]);\r\n return false;\r\n }\r\n}\r\n```\r\nBoth solution work but **when changing the URL manually in the browser URL bar**, router triggers two navigation events:\r\n\r\n\r\n\r\n\r\n## Expected behavior\r\n\u003c!-- Describe what the desired behavior would be. -->\r\nRouter should trigger only one navigation event, as it does when navigating _programmatically_ (meaning not changing manually the URL).\r\n\r\n## Minimal reproduction of the problem with instructions\r\n\u003c!--\r\nFor bug reports please provide the *STEPS TO REPRODUCE* and if possible a *MINIMAL DEMO* of the problem via\r\nhttps://plnkr.co or similar (you can use this template as a starting point: http://plnkr.co/edit/tpl:AvJOMERrnz94ekVua0u5).\r\n-->\r\n\r\n[Demo with component redirection](https://plnkr.co/edit/GKZP1v30IUgQYfa41qZD?p=preview)\r\n[Demo with guard redirection](https://plnkr.co/edit/cWlG7dYK8OpjU3IGT17X?p=preview)\r\n\r\nSteps to reproduce:\r\n\r\n- Open one of the plunker above\r\n- Launch preview in a separated window to be able to change manually the URL\r\n- Click on item 2 of crisis list\r\n- Open console and clear its ouput\r\n- Change URL directly in the browser bar to go '/crisis-center/'\r\n- Check the console output and the multiple \"Navigation start\" event to '/crisis-center/' even after first redirection\r\n- Repeat the test but instead of changing the URL, click on \"Go To Crisis Center Home\" link above the list to see that it's working when navigating programmatically\r\n\r\n## What is the motivation / use case for changing the behavior?\r\n\u003c!-- Describe the motivation or the concrete use case. -->\r\nI described a very simple example of the bug but I have currently a use case where this behaviour is very difficult to deal with, for a quite simple feature.\r\n\r\n## Environment\r\n\r\n\u003cpre>\u003ccode>\r\nAngular version: 4.3.1\r\n\u003c!-- Check whether this is still an issue in the most recent Angular version -->\r\n\r\nBrowser:\r\n- [x] Chrome (desktop) version 60\r\n \r\nFor Tooling issues:\r\n- Node version: v6.11.1 \u003c!-- run `node --version` -->\r\n- Platform: Linux\r\n\u003c/code>\u003c/pre>\r\n","author":{"url":"https://github.com/etiennecrb","@type":"Person","name":"etiennecrb"},"datePublished":"2017-07-27T08:42:48Z","url":"https://github.com/angular/angular/issues/18366"}
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:970bfd26-e0fc-9ce4-5806-17e7aa63a79a |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | E93C:311640:10A32BE:152EE21:6B011699 |
| html-safe-nonce | 6db26ec84252c5eebb4f14f1be8621a0aea4f5dc8098b7e6f57fba5d0480294b |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFOTNDOjMxMTY0MDoxMEEzMkJFOjE1MkVFMjE6NkIwMTE2OTkiLCJ2aXNpdG9yX2lkIjoiNzI1MDQwODY3NDQxNjQ2NTU2MSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | a20c11ff8a93854e1b6911baf34253c341024016980203766bcfc6a2a58e689b |
| hovercard-subject-tag | issue:245967404 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/angular/angular/18366/issue_layout |
| twitter:image | https://opengraph.githubassets.com/55093bd4670b0511c58c4f06e325496aec03ab0400dcc47483f4ab96be36f4df/angular/angular/issues/18366 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/55093bd4670b0511c58c4f06e325496aec03ab0400dcc47483f4ab96be36f4df/angular/angular/issues/18366 |
| og:image:alt | I'm submitting a... [ ] Regression (a behavior that used to work and stopped working in a new release) [x] Bug report [ ] Feature request [ ] Documentation issue or request [ ] Support request => P... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | etiennecrb |
| hostname | github.com |
| expected-hostname | github.com |
| None | cc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c |
| turbo-cache-control | no-preview |
| go-import | github.com/angular/angular git https://github.com/angular/angular.git |
| octolytics-dimension-user_id | 139426 |
| octolytics-dimension-user_login | angular |
| octolytics-dimension-repository_id | 24195339 |
| octolytics-dimension-repository_nwo | angular/angular |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 24195339 |
| octolytics-dimension-repository_network_root_nwo | angular/angular |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 8c77c9e8439031ad54c75a250694842892f693e1 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | issues |
Links:
Viewport: width=device-width