René's URL Explorer Experiment


Title: checkBindingNoChanges does not get unwrapped old values when checking for ExpressionChangedAfterItHasBeenCheckedError · Issue #18129 · angular/angular · GitHub

Open Graph Title: checkBindingNoChanges does not get unwrapped old values when checking for ExpressionChangedAfterItHasBeenCheckedError · Issue #18129 · angular/angular

X Title: checkBindingNoChanges does not get unwrapped old values when checking for ExpressionChangedAfterItHasBeenCheckedError · Issue #18129 · angular/angular

Description: I'm submitting a... [ ] Regression (a behavior that used to work and stopped working in a new release) [x] Bug report [ ] Feature request [ ] Documentation issue or request [ ] Support request => Please do not submit support request here...

Open Graph Description: I'm submitting a... [ ] Regression (a behavior that used to work and stopped working in a new release) [x] Bug report [ ] Feature request [ ] Documentation issue or request [ ] Support request => P...

X Description: I'm submitting a... [ ] Regression (a behavior that used to work and stopped working in a new release) [x] Bug report [ ] Feature request [ ] Documentation issue or request [ ] Support request ...

Opengraph URL: https://github.com/angular/angular/issues/18129

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"checkBindingNoChanges does not get unwrapped old values when checking for ExpressionChangedAfterItHasBeenCheckedError","articleBody":"## I'm submitting a...\r\n\u003c!-- Check one of the following options with \"x\" -->\r\n\u003cpre>\u003ccode>\r\n[ ] Regression (a behavior that used to work and stopped working in a new release)\r\n[x] Bug report  \u003c!-- Please search GitHub for a similar issue or PR before submitting -->\r\n[ ] Feature request\r\n[ ] Documentation issue or request\r\n[ ] Support request => Please do not submit support request here, instead see https://github.com/angular/angular/blob/master/CONTRIBUTING.md#question\r\n\u003c/code>\u003c/pre>\r\n\r\n## Current behavior\r\n\u003c!-- Describe how the issue manifests. -->\r\n\r\nWhen using impure pipes, the value is wrapped, for example with `async`.\r\nSometimes this makes the developer mode of Angular throw the error `ExpressionChangedAfterItHasBeenCheckedError` because `checkBindingNoChanges` gets a wrapped value as the old value and an unwrapped value as the new value even though they did not change (I simply looked at the values via the chromium debugger)\r\n\r\n## Expected behavior\r\n\u003c!-- Describe what the desired behavior would be. -->\r\n\r\nEither `checkBindingNoChanges` should unwrap values if needed or get unwrapped values from its caller.\r\n\r\n## Minimal reproduction of the problem with instructions\r\n\r\nCouldn't reproduce it: I think it happens in some complex scenario where the order of initialisation of the component and the moment data is received via an observable is not usual.\r\n\r\nNote that my observables are initialized in `ngOnInit` and simply bound in the template via `obs$ | async` without anything else specific. I don't see how it could be simpler than that, none of the usual ways of fixing `ExpressionChangedAfterItHasBeenCheckedError` can even be applied!\r\n\r\nI guess the problem existed before but since 4.2.x the checks are stricter and now the problem shows itself.\r\n\r\n## Environment\r\n\r\n\u003cpre>\u003ccode>\r\nAngular version: 4.2.6\r\n\u003c!-- Check whether this is still an issue in the most recent Angular version -->\r\n\r\nBrowser:\r\n- [x] Chrome (desktop) version XX\r\n- [ ] Chrome (Android) version XX\r\n- [ ] Chrome (iOS) version XX\r\n- [ ] Firefox version XX\r\n- [ ] Safari (desktop) version XX\r\n- [ ] Safari (iOS) version XX\r\n- [ ] IE version XX\r\n- [ ] Edge version XX\r\n \r\nFor Tooling issues:\r\n- Node version: XX  \u003c!-- run `node --version` -->\r\n- Platform:  \u003c!-- Mac, Linux, Windows -->\r\n\r\nOthers:\r\n\u003c!-- Anything else relevant?  Operating system version, IDE, package manager, HTTP server, ... -->\r\n\u003c/code>\u003c/pre>\r\n","author":{"url":"https://github.com/victornoel","@type":"Person","name":"victornoel"},"datePublished":"2017-07-14T18:01:17Z","url":"https://github.com/angular/angular/issues/18129"}

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:24f480a0-c6ff-fe02-cf89-17f94c2821e2
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-idA1FC:2679E9:16FA71F:1E99C8E:6B0142FF
html-safe-nonce9f03bf1dbdda714426a8a386b40941920c3e7ceaaa11645888111b77e30e7801
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBMUZDOjI2NzlFOToxNkZBNzFGOjFFOTlDOEU6NkIwMTQyRkYiLCJ2aXNpdG9yX2lkIjoiODUxNzAzOTIzMjAyNjQ5MzY5NiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac0819cd0423f55be3881be0d0944c0f7ecadc98c82bb97ea34409779b80291ee2
hovercard-subject-tagissue:243068442
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/angular/angular/18129/issue_layout
twitter:imagehttps://opengraph.githubassets.com/18e9cdfbf6d6c3f566ae362bbad60f13d262f908a574a0efbc3c5eca5fcece9f/angular/angular/issues/18129
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/18e9cdfbf6d6c3f566ae362bbad60f13d262f908a574a0efbc3c5eca5fcece9f/angular/angular/issues/18129
og:image:altI'm submitting a... [ ] Regression (a behavior that used to work and stopped working in a new release) [x] Bug report [ ] Feature request [ ] Documentation issue or request [ ] Support request => P...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamevictornoel
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-preview
go-importgithub.com/angular/angular git https://github.com/angular/angular.git
octolytics-dimension-user_id139426
octolytics-dimension-user_loginangular
octolytics-dimension-repository_id24195339
octolytics-dimension-repository_nwoangular/angular
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id24195339
octolytics-dimension-repository_network_root_nwoangular/angular
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-nameissues

Links:

Skip to contenthttps://github.com/angular/angular/issues/18129#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fissues%2F18129
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fissues%2F18129
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=angular%2Fangular
Reloadhttps://github.com/angular/angular/issues/18129
Reloadhttps://github.com/angular/angular/issues/18129
Reloadhttps://github.com/angular/angular/issues/18129
angularhttps://github.com/angular
angularhttps://github.com/angular/angular
Codehttps://github.com/angular/angular
Issues836 (836)https://github.com/angular/angular/issues
Pull requests141 (141)https://github.com/angular/angular/pulls
Discussionshttps://github.com/angular/angular/discussions
Actionshttps://github.com/angular/angular/actions
Projectshttps://github.com/angular/angular/projects
Security and quality40 (40)https://github.com/angular/angular/security
Insightshttps://github.com/angular/angular/insights
https://github.com/angular/angular
New issuehttps://github.com/login?return_to=https://github.com/angular/angular/issues/18129
New issuehttps://github.com/login?return_to=https://github.com/angular/angular/issues/18129
checkBindingNoChanges does not get unwrapped old values when checking for ExpressionChangedAfterItHasBeenCheckedErrorhttps://github.com/angular/angular/issues/18129#top
area: coreIssues related to the framework runtimehttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20core%22
core: change detectionhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22core%3A%20change%20detection%22
freq2: mediumhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22freq2%3A%20medium%22
type: bug/fixhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22type%3A%20bug%2Ffix%22
Backloghttps://github.com/angular/angular/milestone/82
https://github.com/victornoel
victornoelhttps://github.com/victornoel
on Jul 14, 2017https://github.com/angular/angular/issues/18129#issue-243068442
Nexthttps://github.com/angular/angular/issues/18129?timeline_page=1
https://github.com/victornoel
victornoelhttps://github.com/victornoel
on Jul 16, 2017https://github.com/angular/angular/issues/18129#issuecomment-315601088
alxhubhttps://github.com/alxhub
area: coreIssues related to the framework runtimehttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20core%22
type: bug/fixhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22type%3A%20bug%2Ffix%22
on Jul 19, 2017https://github.com/angular/angular/issues/18129#event-1169354919
https://github.com/sliekens
sliekenshttps://github.com/sliekens
on Jul 20, 2017https://github.com/angular/angular/issues/18129#issuecomment-316668041
https://user-images.githubusercontent.com/1583241/28413955-ca23a9c8-6d49-11e7-8ed3-509216e0b6a4.png
https://github.com/sliekens
sliekenshttps://github.com/sliekens
on Jul 20, 2017https://github.com/angular/angular/issues/18129#issuecomment-316676837
https://github.com/victornoel
victornoelhttps://github.com/victornoel
on Jul 20, 2017https://github.com/angular/angular/issues/18129#issuecomment-316678508
https://github.com/sliekens
sliekenshttps://github.com/sliekens
on Jul 20, 2017https://github.com/angular/angular/issues/18129#issuecomment-316682981
https://github.com/victornoel
victornoelhttps://github.com/victornoel
on Jul 23, 2017https://github.com/angular/angular/issues/18129#issuecomment-317249872
@tboschhttps://github.com/tbosch
https://github.com/angular/angular/blob/master/packages/core/src/view/util.ts#L30https://github.com/angular/angular/blob/master/packages/core/src/view/util.ts#L30
https://github.com/angular/angular/blob/master/packages/core/src/view/util.ts#L94https://github.com/angular/angular/blob/master/packages/core/src/view/util.ts#L94
https://github.com/angular/angular/blob/master/packages/core/src/view/view.ts#L443https://github.com/angular/angular/blob/master/packages/core/src/view/view.ts#L443
https://github.com/victornoel
victornoelhttps://github.com/victornoel
on Jul 23, 2017https://github.com/angular/angular/issues/18129#issuecomment-317253235
https://github.com/dmurat
dmurathttps://github.com/dmurat
on Aug 1, 2017https://github.com/angular/angular/issues/18129#issuecomment-319458630
commenthttps://github.com/angular/angular/issues/15721#issuecomment-292274913
https://github.com/dmurat
dmurathttps://github.com/dmurat
on Aug 3, 2017https://github.com/angular/angular/issues/18129#issuecomment-320099321
https://github.com/abierbaum
abierbaumhttps://github.com/abierbaum
on Aug 18, 2017https://github.com/angular/angular/issues/18129#issuecomment-323413561
https://github.com/nename0
nename0https://github.com/nename0
on Aug 18, 2017https://github.com/angular/angular/issues/18129#issuecomment-323417211
https://github.com/victornoel
victornoelhttps://github.com/victornoel
on Aug 21, 2017https://github.com/angular/angular/issues/18129#issuecomment-323695641
@robwormaldhttps://github.com/robwormald
#17572https://github.com/angular/angular/issues/17572
https://github.com/victornoel
victornoelhttps://github.com/victornoel
on Aug 31, 2017https://github.com/angular/angular/issues/18129#issuecomment-326214472
@alxhubhttps://github.com/alxhub
https://github.com/guyjsx
guyjsxhttps://github.com/guyjsx
on Jan 16, 2018https://github.com/angular/angular/issues/18129#issuecomment-358137583
https://github.com/sliekens
sliekenshttps://github.com/sliekens
on Jan 21, 2018https://github.com/angular/angular/issues/18129#issuecomment-359282443
a previous commenthttps://github.com/angular/angular/issues/18129#issuecomment-326801192
ngbothttps://github.com/apps/ngbot
Backloghttps://github.com/angular/angular/milestone/82
on Jan 23, 2018https://github.com/angular/angular/issues/18129#event-1437573094
trotylhttps://github.com/trotyl
on Oct 15, 2018https://github.com/angular/angular/issues/18129#event-1904181471
fix(core): not throw when old value is wrapped while new value is sam…https://github.com/trotyl/angular/commit/73939c3713614dbd6db60d3312e64ef5be083944
https://docs.github.com/articles/closing-issues-via-commit-messages
73939c3https://github.com/trotyl/angular/commit/73939c3713614dbd6db60d3312e64ef5be083944
https://github.com/TrevorKarjanis
TrevorKarjanishttps://github.com/TrevorKarjanis
on Jun 21, 2019https://github.com/angular/angular/issues/18129#issuecomment-504578329
https://github.com/raduungurean
raduungureanhttps://github.com/raduungurean
on Jul 25, 2019https://github.com/angular/angular/issues/18129#issuecomment-515050476
@victornoelhttps://github.com/victornoel
https://github.com/miguelalvarezi
miguelalvarezihttps://github.com/miguelalvarezi
on Nov 14, 2019https://github.com/angular/angular/issues/18129#issuecomment-553947690
this answer in SOhttps://stackoverflow.com/a/56664783/2747568
pkozlowski-opensourcehttps://github.com/pkozlowski-opensource
core: change detectionhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22core%3A%20change%20detection%22
on Mar 12, 2020https://github.com/angular/angular/issues/18129#event-3123460370
https://github.com/atscott
atscotthttps://github.com/atscott
on Sep 11, 2020https://github.com/angular/angular/issues/18129#issuecomment-691200953
#36633https://github.com/angular/angular/pull/36633
#36819https://github.com/angular/angular/pull/36819
atscotthttps://github.com/atscott
completedhttps://github.com/angular/angular/issues?q=is%3Aissue%20state%3Aclosed%20archived%3Afalse%20reason%3Acompleted
on Sep 11, 2020https://github.com/angular/angular/issues/18129#event-3757116392
https://github.com/apps/angular-automatic-lock-bot
angular-automatic-lock-bothttps://github.com/apps/angular-automatic-lock-bot
on Oct 12, 2020https://github.com/angular/angular/issues/18129#issuecomment-707220524
automatic conversation locking policyhttps://github.com/angular/angular/blob/67d80f/docs/GITHUB_PROCESS.md#conversation-locking
angular-automatic-lock-bothttps://github.com/apps/angular-automatic-lock-bot
on Oct 12, 2020https://github.com/angular/angular/issues/18129#event-3867413470
Sign up for freehttps://github.com/signup?return_to=https://github.com/angular/angular/issues/18129
Sign in to commenthttps://github.com/login?return_to=https://github.com/angular/angular/issues/18129
area: coreIssues related to the framework runtimehttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20core%22
core: change detectionhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22core%3A%20change%20detection%22
freq2: mediumhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22freq2%3A%20medium%22
type: bug/fixhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22type%3A%20bug%2Ffix%22
BacklogNo due datehttps://github.com/angular/angular/milestone/82
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.