Title: Router tutorial tour of heroes lacks milestone stackblitz/executable/downloads · Issue #17794 · angular/angular · GitHub
Open Graph Title: Router tutorial tour of heroes lacks milestone stackblitz/executable/downloads · Issue #17794 · angular/angular
X Title: Router tutorial tour of heroes lacks milestone stackblitz/executable/downloads · Issue #17794 · angular/angular
Description: I'm submitting a ... [ ] Regression (behavior that used to work and stopped working in a new release) [ ] Bug report [ ] Feature request [x] Documentation issue or request [ ] Support request => Please do not submit support request here,...
Open Graph Description: I'm submitting a ... [ ] Regression (behavior that used to work and stopped working in a new release) [ ] Bug report [ ] Feature request [x] Documentation issue or request [ ] Support request => Pl...
X Description: I'm submitting a ... [ ] Regression (behavior that used to work and stopped working in a new release) [ ] Bug report [ ] Feature request [x] Documentation issue or request [ ] Support request =...
Opengraph URL: https://github.com/angular/angular/issues/17794
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Router tutorial tour of heroes lacks milestone stackblitz/executable/downloads","articleBody":"\u003c!--\r\nPLEASE HELP US PROCESS GITHUB ISSUES FASTER BY PROVIDING THE FOLLOWING INFORMATION.\r\n\r\nISSUES MISSING IMPORTANT INFORMATION MIGHT BE CLOSED WITHOUT INVESTIGATION.\r\n-->\r\n\r\n## I'm submitting a ...\r\n\u003c!-- Check one of the following options with \"x\" -->\r\n\u003cpre>\u003ccode>\r\n[ ] Regression (behavior that used to work and stopped working in a new release)\r\n[ ] Bug report \u003c!-- Please search github for a similar issue or PR before submitting -->\r\n[ ] Feature request\r\n[x] Documentation issue or request\r\n[ ] Support request => Please do not submit support request here, instead see https://github.com/angular/angular/blob/master/CONTRIBUTING.md#question\r\n\u003c/code>\u003c/pre>\r\n\r\n## Current behavior\r\n\u003c!-- Describe how the issue manifests. -->\r\nThe link you download is a zip file. With a setup that probably relates to the 'end game'.\r\nIf you want to download and run and gradually add code, nothing jives.\r\nFurthermore, it's not a CLI project, which adds to the confusion. See my comment here:\r\nhttps://stackoverflow.com/questions/44779294/\r\n\r\nAdditionally for milestone 3 wrap up\r\nhttps://angular.io/guide/router#milestone-3-wrap-up\r\nyou haven't even included \r\nimport { BrowserAnimationsModule } from '@angular/platform-browser/animations';\r\nin app-module.ts in tabbed sources \r\nor in imports: [ ...BrowserAnimationsModule] \r\nFolder structure + tabbed sources makes no reference to animations.ts \r\n\r\nBy milestone 5 \r\nhttps://angular.io/guide/router#component-less-route-grouping-routes-without-a-component\r\nI'd completely lost the plot...\r\nNone of source in download syncs to anything. app-modules.ts\r\n\r\nzipped download has these extra imports:\r\nimport { BrowserAnimationsModule } from '@angular/platform-browser/animations';\r\nimport { Router } from '@angular/router';\r\nimport { ComposeMessageComponent } from './compose-message.component';\r\nimport { LoginRoutingModule } from './login-routing.module';\r\nimport { LoginComponent } from './login.component';\r\n\r\nwebsite makes reference to:\r\nimport { AdminModule } from './admin/admin.module';\r\nThat's never used in zipped download.\r\n\r\nLater in Milestone 6\r\nhttps://angular.io/guide/router#preloading-background-loading-of-feature-areas\r\napp-module.ts more closely resembles zip. But AdminModule is no more...\r\n..\r\nI actually had to do a top down search of the web page for 'AdminModule' to realise that it had been lazy loaded via. This more than anything makes the case for needing versions you can check out of git. and be able to diff them..\r\nloadChildren: 'app/admin/admin.module#AdminModule'\r\nI'd missed the vital bit of info here on a first read thru:\r\nhttps://angular.io/guide/router#lazy-loading-route-configuration\r\n\r\nAdditionally - not sure if this was a deliberate mistake.. but setting of session id only ever appears in url if you've gone to admin page before attempting to login...\r\n\r\n## Expected behavior\r\n\u003c!-- Describe what the desired behavior would be. -->\r\nYou have several points throughout the code that you can pull the code from a git repo, so you can manually add the code from the appropriate starting point and be able to follow along and better cement an understanding by 'doing' rather than 'reading'\r\n\r\nFor milestone 3:\r\ncorrected app.modules.ts in tabs and also add animations.ts to tab & source folders.\r\n\r\n## Minimal reproduction of the problem with instructions\r\n\u003c!--\r\nFor bug reports please provide the *STEPS TO REPRODUCE* and if possible a *MINIMAL DEMO* of the problem via\r\nhttps://plnkr.co or similar (you can use this template as a starting point: http://plnkr.co/edit/tpl:AvJOMERrnz94ekVua0u5).\r\n-->\r\nJust try downloading the zip and find this in app.module.ts.\r\nimport { RouterModule, Routes } from '@angular/router';\r\n\r\n## What is the motivation / use case for changing the behavior?\r\n\u003c!-- Describe the motivation or the concrete use case. -->\r\nMake it so I can code along and better understand, rather than dry reading exercise.\r\n\r\n## Please tell us about your environment\r\n@angular/cli: 1.1.3\r\n node: 8.1.2\r\n os: darwin x64\r\n @angular/animations: 4.2.4\r\n @angular/common: 4.2.4\r\n @angular/compiler: 4.2.4\r\n @angular/compiler-cli: 4.2.4\r\n @angular/core: 4.2.4\r\n @angular/forms: 4.2.4\r\n @angular/http: 4.2.4\r\n @angular/platform-browser: 4.2.4\r\n @angular/platform-browser-dynamic: 4.2.4\r\n @angular/platform-server: 4.2.4\r\n @angular/router: 4.2.4\r\n @angular/tsc-wrapped: 4.2.4\r\n @angular/upgrade: 4.2.4\r\n @angular/cli: 1.1.3\r\n\u003cpre>\u003ccode>\r\nAngular version: X.Y.Z\r\n\u003c!-- Check whether this is still an issue in the most recent Angular version -->\r\n@angular/cli: 1.1.3\r\nnode: 8.1.2\r\nos: darwin x64\r\n\r\nBrowser:\r\n- [ x] Chrome (desktop) version Version 59.0.3071.115 Mac OS X Sierra 10.12.5\r\n- [ ] Chrome (Android) version XX\r\n- [ ] Chrome (iOS) version XX\r\n- [ ] Firefox version XX\r\n- [ ] Safari (desktop) version XX\r\n- [ ] Safari (iOS) version XX\r\n- [ ] IE version XX\r\n- [ ] Edge version XX\r\n \r\nFor Tooling issues:\r\n- Node version: 8.1.2\r\n- Platform: Mac\r\n\r\nOthers:\r\n\u003c!-- Anything else relevant? Operating system version, IDE, package manager, HTTP server, ... -->\r\n\u003c/code>\u003c/pre>\r\n","author":{"url":"https://github.com/jgfet","@type":"Person","name":"jgfet"},"datePublished":"2017-06-27T14:40:44Z","url":"https://github.com/angular/angular/issues/17794"}
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:2ee75fe1-26fb-4376-009f-b82b238cddce |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | AA68:358871:1213322:17DA58E:6B0114DF |
| html-safe-nonce | 406ae6eb7d1ba6223a8feaa5738e5afd53a5870e19f33cab0e6e0e42aafc25a6 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBQTY4OjM1ODg3MToxMjEzMzIyOjE3REE1OEU6NkIwMTE0REYiLCJ2aXNpdG9yX2lkIjoiNzk5OTk4NjQ2NzM2MTMzMDQwMCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | fdc0f572c16683114f244e10b3533c11771e953f0cb4f98ad266d458269a7e49 |
| hovercard-subject-tag | issue:238874862 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/angular/angular/17794/issue_layout |
| twitter:image | https://opengraph.githubassets.com/64d36de4a12f2944f3a558fc3c292ad24ab574d7f226921081e063f0a91db392/angular/angular/issues/17794 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/64d36de4a12f2944f3a558fc3c292ad24ab574d7f226921081e063f0a91db392/angular/angular/issues/17794 |
| og:image:alt | I'm submitting a ... [ ] Regression (behavior that used to work and stopped working in a new release) [ ] Bug report [ ] Feature request [x] Documentation issue or request [ ] Support request => Pl... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | jgfet |
| hostname | github.com |
| expected-hostname | github.com |
| None | cb7fa109eca7d4156c889f474306b0e91336055e9adf8fd4684b61e49094d124 |
| turbo-cache-control | no-preview |
| go-import | github.com/angular/angular git https://github.com/angular/angular.git |
| octolytics-dimension-user_id | 139426 |
| octolytics-dimension-user_login | angular |
| octolytics-dimension-repository_id | 24195339 |
| octolytics-dimension-repository_nwo | angular/angular |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 24195339 |
| octolytics-dimension-repository_network_root_nwo | angular/angular |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 2b59d31a4e44f08b7af67a4b67f8fd0af3befe2a |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | issues |
Links:
Viewport: width=device-width