Title: V4.2.0 router events timing · Issue #17473 · angular/angular · GitHub
Open Graph Title: V4.2.0 router events timing · Issue #17473 · angular/angular
X Title: V4.2.0 router events timing · Issue #17473 · angular/angular
Description: I'm submitting a ... (check one with "x") [x] bug report => search github for a similar issue or PR before submitting [ ] feature request [ ] support request => Please do not submit support request here, instead see https://github.com/an...
Open Graph Description: I'm submitting a ... (check one with "x") [x] bug report => search github for a similar issue or PR before submitting [ ] feature request [ ] support request => Please do not submit support request...
X Description: I'm submitting a ... (check one with "x") [x] bug report => search github for a similar issue or PR before submitting [ ] feature request [ ] support request => Please do not su...
Opengraph URL: https://github.com/angular/angular/issues/17473
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"V4.2.0 router events timing ","articleBody":"\u003c!--\r\nIF YOU DON'T FILL OUT THE FOLLOWING INFORMATION WE MIGHT CLOSE YOUR ISSUE WITHOUT INVESTIGATING\r\n-->\r\n\r\n**I'm submitting a ...** (check one with \"x\")\r\n```\r\n[x] bug report => search github for a similar issue or PR before submitting\r\n[ ] feature request\r\n[ ] support request => Please do not submit support request here, instead see https://github.com/angular/angular/blob/master/CONTRIBUTING.md#question\r\n```\r\n\r\n**Current behavior**\r\nsince version 4.2.0 (4.2.0-rc.0 is broken, 4.2.0-beta.1 works) ngOnInit of Components are called only after router events are already been handled.\r\nwe have an application that contains components that register to router on their ngOnInit(). till version 4.1.3 we used to get a the events of the router on ngOnInit() but it seems that this behavior was changed.\r\nalso it seems that App.Module components _do_ get the router events on ngOnInit(), but lower level modules don't. it is a great deal to us as the Router event is kind of an entry point for the entire module.\r\n\r\n\r\n**Expected behavior**\r\nsame as v4.1.3 get notified for router events after ngOnInit() was called.\r\n\r\n**Minimal reproduction of the problem with instructions**\r\nhttps://plnkr.co/q9z9Rn \r\nsee \"Sub Module component router events\" doesnt get router events at all\r\n\r\n**What is the motivation / use case for changing the behavior?**\r\nthis is a breaking change \r\n\r\n**Please tell us about your environment:**\r\n@angular/cli: 1.0.0\r\nnode: 8.0.0\r\nos: win32 x64\r\n@angular/animations: 4.2.2\r\n@angular/common: 4.2.2\r\n@angular/compiler: 4.2.2\r\n@angular/core: 4.2.2\r\n@angular/forms: 4.2.2\r\n@angular/http: 4.2.2\r\n@angular/platform-browser: 4.2.2\r\n@angular/platform-browser-dynamic: 4.2.2\r\n@angular/router: 4.2.2\r\n@angular/cli: 4.2.2\r\n@angular/compiler-cli: 4.2.2\r\n@angular/language-service: 4.2.2\r\n\r\n\r\n* **Browser:** [all]\r\n\u003c!-- All browsers where this could be reproduced -->\r\n \r\n* **Language:** [ TypeScript 2.3]\r\n\r\n\r\n","author":{"url":"https://github.com/AmirSasson","@type":"Person","name":"AmirSasson"},"datePublished":"2017-06-13T16:29:52Z","url":"https://github.com/angular/angular/issues/17473"}
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:d661b1e4-1315-9bb2-b98a-cee7f68bc9cf |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | AE3C:34DB8F:1A4157F:230E6D8:6B015E80 |
| html-safe-nonce | 9650b012d0cdec0c0493008a16205d62b2404c21f09f1331fedffc71876038f0 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBRTNDOjM0REI4RjoxQTQxNTdGOjIzMEU2RDg6NkIwMTVFODAiLCJ2aXNpdG9yX2lkIjoiODA1NzE4NTQwMjk5NTQzMzA4OCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 40f9209bc063bb8697e8c1e32304b556bfb032bef402a108036adf798256ad9e |
| hovercard-subject-tag | issue:235613554 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/angular/angular/17473/issue_layout |
| twitter:image | https://opengraph.githubassets.com/f70ad76c6efc146a2483c6da9d17a5e7b598b6e25e07e717b4328180bd53b272/angular/angular/issues/17473 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/f70ad76c6efc146a2483c6da9d17a5e7b598b6e25e07e717b4328180bd53b272/angular/angular/issues/17473 |
| og:image:alt | I'm submitting a ... (check one with "x") [x] bug report => search github for a similar issue or PR before submitting [ ] feature request [ ] support request => Please do not submit support request... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | AmirSasson |
| hostname | github.com |
| expected-hostname | github.com |
| None | cc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c |
| turbo-cache-control | no-preview |
| go-import | github.com/angular/angular git https://github.com/angular/angular.git |
| octolytics-dimension-user_id | 139426 |
| octolytics-dimension-user_login | angular |
| octolytics-dimension-repository_id | 24195339 |
| octolytics-dimension-repository_nwo | angular/angular |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 24195339 |
| octolytics-dimension-repository_network_root_nwo | angular/angular |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 8c77c9e8439031ad54c75a250694842892f693e1 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | issues |
Links:
Viewport: width=device-width