René's URL Explorer Experiment


Title: NavigationExtras not evaluated on NavigationCancel for initial Route · Issue #16796 · angular/angular · GitHub

Open Graph Title: NavigationExtras not evaluated on NavigationCancel for initial Route · Issue #16796 · angular/angular

X Title: NavigationExtras not evaluated on NavigationCancel for initial Route · Issue #16796 · angular/angular

Description: I'm submitting a ... (check one with "x") [x] bug report => search github for a similar issue or PR before submitting [ ] feature request [ ] support request => Please do not submit support request here, instead see https://github.com/an...

Open Graph Description: I'm submitting a ... (check one with "x") [x] bug report => search github for a similar issue or PR before submitting [ ] feature request [ ] support request => Please do not submit support request...

X Description: I'm submitting a ... (check one with "x") [x] bug report => search github for a similar issue or PR before submitting [ ] feature request [ ] support request => Please do not su...

Opengraph URL: https://github.com/angular/angular/issues/16796

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"NavigationExtras not evaluated on NavigationCancel for initial Route","articleBody":"\u003c!--\nIF YOU DON'T FILL OUT THE FOLLOWING INFORMATION WE MIGHT CLOSE YOUR ISSUE WITHOUT INVESTIGATING\n-->\n\n**I'm submitting a ...**  (check one with \"x\")\n```\n[x] bug report => search github for a similar issue or PR before submitting\n[ ] feature request\n[ ] support request => Please do not submit support request here, instead see https://github.com/angular/angular/blob/master/CONTRIBUTING.md#question\n```\n\n**Current behavior**\n\u003c!-- Describe how the bug manifests. -->\n\nIn the case where the Route contains `{path: '', redirectTo: '/home'}`:\n\n1. Navigate to a guarded url from a new window so that the app is loaded for the first time to this url\n2. Have the Guard deny the route activation\n3. The Router will then navigate back to the previous route which is defaulted to `/` when initialised\n4. No Router Parts will be evaluated on the new location of `/` such as `redirectTo` and instead of being redirected to `/home` and loading that page, it will be blank as no components are specified for `/`\n\nThis isn't an issue if the app has already been loaded in the tab as the router will have already redirected from `/` to `/home` and `/home` will be `currentUrlTree` for which the Router returns to.\n\n**Expected behavior**\n\u003c!-- Describe what the behavior would be without the bug. -->\nAt step `4.` above, evaulate the router parts for the route.\n\n**Minimal reproduction of the problem with instructions**\n\u003c!--\nIf the current behavior is a bug or you can illustrate your feature request better with an example, \nplease provide the *STEPS TO REPRODUCE* and if possible a *MINIMAL DEMO* of the problem via\nhttps://plnkr.co or similar (you can use this template as a starting point: http://plnkr.co/edit/tpl:AvJOMERrnz94ekVua0u5).\n-->\n\nHave routes setup:\n```typescript\nconst routes: Routes = [\n  {path: '' redirectTo: '/home', pathMatch: 'full'},\n  {path: 'home', component: HomeComponent},\n  {path: 'guardedendpoint', component: GuardedEndpointComponent, canActivate: [EndpointGuard]}, \n];\n```\nand the `EndpointGuard.canActivate` returns `false`\n\n1. Navigate browser to `/#/guardedendpoint` in a new tab (so that the app loads to this url, rather than navigating to it)\n2. `EndpointGuard` will deny the naviation, so a `NavigationCancel` event will fire from `Router.events`\n3. `Router` will [`resetUrlToCurrentUrlTree`](https://github.com/angular/angular/blob/master/packages/router/src/router.ts#L729) to the [`rawUrlTree`](https://github.com/angular/angular/blob/master/packages/router/src/router.ts#L275-L276) which is [initialised](https://github.com/angular/angular/blob/master/packages/router/src/url_tree.ts#L13) to the root path of `/`\n4. `Router` will then navigate to this route but won't check the `Routes` configuration (because it assumes it was already checked and parsed when it was initially navigated to though in this case, it wasn't) for the `redirectTo` parameter and so will display an empty page and won't redirect\n\n**What is the motivation / use case for changing the behavior?**\n\u003c!-- Describe the motivation or the concrete use case -->\nRouter will now follow any redirects (or other Router Parts) on the root path instead of ignoring them\n\nThe work around I am using is to `subscribe` to `Router.events` `Subject` and if the navigation is cancelled (`Router/NavigationCancel`) is emitted with an `id` of `1` (where it is the first route), I am queuing naviation to `/` so that the router will then know to `redirectTo` using the following code\n\n```typescript\nexport class AppModule {\n  constructor(router: Router){\n    var routerEvents$ = router.events.subscribe((message) => {\n      if(message.id === 1 && message instanceof NavigationCancel){ //if first navigation and it is cancelled\n        router.navigate(['']); //nav to '' so that redirects will be applied!\n        routerEvents$.unsubscribe();\n      } else if(message.id > 1) routerEvents$.unsubscribe(); \n    });\n  }\n}\n```\n\n* **Angular Router version:** 3.4.8\n\u003c!-- Check whether this is still an issue in the most recent Angular version -->\n\n* **Language:** TypeScript 2.2","author":{"url":"https://github.com/GusGold","@type":"Person","name":"GusGold"},"datePublished":"2017-05-15T13:45:26Z","url":"https://github.com/angular/angular/issues/16796"}

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:494cbcd3-1c18-85c5-69d6-0818f9c95374
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-idB3A6:25A204:DE2B8B:125961B:6B00FB9A
html-safe-nonce3891069f5cbeba2968f31cbcf965b48c277cc413556b9f47a1db7a675e9ccd36
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCM0E2OjI1QTIwNDpERTJCOEI6MTI1OTYxQjo2QjAwRkI5QSIsInZpc2l0b3JfaWQiOiI4OTg5OTQ0NTg2MjAxNzkxMzg2IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac494000fb4d0c42195862def02d9f2960461ca82eb7fcdf512c924e1e87f1e785
hovercard-subject-tagissue:228719888
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/angular/angular/16796/issue_layout
twitter:imagehttps://opengraph.githubassets.com/5835b8687c83ea0ca7d02fa7634079142cc44ddceed4aef6221783c31f90ddab/angular/angular/issues/16796
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/5835b8687c83ea0ca7d02fa7634079142cc44ddceed4aef6221783c31f90ddab/angular/angular/issues/16796
og:image:altI'm submitting a ... (check one with "x") [x] bug report => search github for a similar issue or PR before submitting [ ] feature request [ ] support request => Please do not submit support request...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameGusGold
hostnamegithub.com
expected-hostnamegithub.com
Nonee208d86428ec00a57ade75058166297440e8128a01e5287c31a53dc042bbf187
turbo-cache-controlno-preview
go-importgithub.com/angular/angular git https://github.com/angular/angular.git
octolytics-dimension-user_id139426
octolytics-dimension-user_loginangular
octolytics-dimension-repository_id24195339
octolytics-dimension-repository_nwoangular/angular
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id24195339
octolytics-dimension-repository_network_root_nwoangular/angular
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release7dafd017fb7809a839c443dba08622af38e63c09
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-nameissues

Links:

Skip to contenthttps://github.com/angular/angular/issues/16796#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fissues%2F16796
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fissues%2F16796
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=angular%2Fangular
Reloadhttps://github.com/angular/angular/issues/16796
Reloadhttps://github.com/angular/angular/issues/16796
Reloadhttps://github.com/angular/angular/issues/16796
angularhttps://github.com/angular
angularhttps://github.com/angular/angular
Codehttps://github.com/angular/angular
Issues835 (835)https://github.com/angular/angular/issues
Pull requests141 (141)https://github.com/angular/angular/pulls
Discussionshttps://github.com/angular/angular/discussions
Actionshttps://github.com/angular/angular/actions
Projectshttps://github.com/angular/angular/projects
Security and quality40 (40)https://github.com/angular/angular/security
Insightshttps://github.com/angular/angular/insights
https://github.com/angular/angular
New issuehttps://github.com/login?return_to=https://github.com/angular/angular/issues/16796
New issuehttps://github.com/login?return_to=https://github.com/angular/angular/issues/16796
NavigationExtras not evaluated on NavigationCancel for initial Routehttps://github.com/angular/angular/issues/16796#top
area: routerhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20router%22
https://github.com/GusGold
GusGoldhttps://github.com/GusGold
on May 15, 2017https://github.com/angular/angular/issues/16796#issue-228719888
resetUrlToCurrentUrlTreehttps://github.com/angular/angular/blob/master/packages/router/src/router.ts#L729
rawUrlTreehttps://github.com/angular/angular/blob/master/packages/router/src/router.ts#L275-L276
initialisedhttps://github.com/angular/angular/blob/master/packages/router/src/url_tree.ts#L13
GusGoldhttps://github.com/GusGold
on May 15, 2017https://github.com/angular/angular/issues/16796#event-1082273882
jasonadenhttps://github.com/jasonaden
area: routerhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20router%22
on May 15, 2017https://github.com/angular/angular/issues/16796#event-1082833669
https://github.com/jasonaden
jasonadenhttps://github.com/jasonaden
on Dec 12, 2017https://github.com/angular/angular/issues/16796#issuecomment-351229472
#20803https://github.com/angular/angular/pull/20803
jasonadenhttps://github.com/jasonaden
completedhttps://github.com/angular/angular/issues?q=is%3Aissue%20state%3Aclosed%20archived%3Afalse%20reason%3Acompleted
on Dec 12, 2017https://github.com/angular/angular/issues/16796#event-1384642978
https://github.com/apps/angular-automatic-lock-bot
angular-automatic-lock-bothttps://github.com/apps/angular-automatic-lock-bot
on Sep 13, 2019https://github.com/angular/angular/issues/16796#issuecomment-531064477
automatic conversation locking policyhttps://github.com/angular/angular/blob/67d80f/docs/GITHUB_PROCESS.md#conversation-locking
angular-automatic-lock-bothttps://github.com/apps/angular-automatic-lock-bot
on Sep 13, 2019https://github.com/angular/angular/issues/16796#event-2630971407
Sign up for freehttps://github.com/signup?return_to=https://github.com/angular/angular/issues/16796
Sign in to commenthttps://github.com/login?return_to=https://github.com/angular/angular/issues/16796
area: routerhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20router%22
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.