René's URL Explorer Experiment


Title: Instance bound methods do not work as hooks · Issue #16478 · angular/angular · GitHub

Open Graph Title: Instance bound methods do not work as hooks · Issue #16478 · angular/angular

X Title: Instance bound methods do not work as hooks · Issue #16478 · angular/angular

Description: I'm submitting a ... (check one with "x") [x] bug report => search github for a similar issue or PR before submitting [x] feature request [ ] support request => Please do not submit support request here, instead see https://github.com/an...

Open Graph Description: I'm submitting a ... (check one with "x") [x] bug report => search github for a similar issue or PR before submitting [x] feature request [ ] support request => Please do not submit support request...

X Description: I'm submitting a ... (check one with "x") [x] bug report => search github for a similar issue or PR before submitting [x] feature request [ ] support request => Please do not su...

Opengraph URL: https://github.com/angular/angular/issues/16478

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Instance bound methods do not work as hooks","articleBody":"**I'm submitting a ...**  (check one with \"x\")\r\n```\r\n[x] bug report => search github for a similar issue or PR before submitting\r\n[x] feature request\r\n[ ] support request => Please do not submit support request here, instead see https://github.com/angular/angular/blob/master/CONTRIBUTING.md#question\r\n```\r\n\r\nInstance bound methods do not work as hooks. Here is a little code sample:\r\n\r\n```typescript\r\n import { Component } from '@angular/core';\r\n\r\n  @Component({\r\n    selector: 'my-app',\r\n    template: '\u003ch1>Hello {{name}}\u003c/h1>'\r\n  })\r\n  export class AppComponent { \r\n    name = 'Angular'; \r\n    \r\n    ngOnInit = () => {\r\n      this.name = 'World';\r\n    }\r\n  }\r\n```\r\n\r\n**Current behavior**\r\nHook is not executed, \"Hello Angular\" is displayed.\r\n\r\n**Expected behavior**\r\nHook should be executed, and we would see \"Hello World\" instead. Or (if it is by design) - some message would be much appreciated in DEV mode. Smth like, \"You are trying to use instance bound method for hooks. It will not work.\"\r\n\r\nIn the documentation i found only this note: \r\n\r\n> Angular instead inspects directive and component classes and calls the hook methods if they are defined. Angular finds and calls methods like ngOnInit(), with or without the interfaces.\r\n\r\nWhich is explaining it in some manner, but intention is not clear still.\r\n\r\n**Minimal reproduction of the problem with instructions**\r\nStackOverflow discussion: \r\nhttp://stackoverflow.com/questions/43677584/angular2-instance-bound-methods-does-not-work-as-hooks\r\n\r\nPlunkr: https://plnkr.co/edit/aZ1CYkDn06KUENmDW3a3?p=preview\r\n\r\n**What is the motivation / use case for changing the behavior?**\r\nIt is kinda not transparent why Angular is behaving like that. I assume that it is **by design** for performance reasons. But it would be nice to mention that explicitly and provide a message for DEV mode to prevent others from spending time on such thing.\r\n\r\nBTW, React is behaving in a predictable manner: \r\n\r\n```js\r\nconst { render } = ReactDOM;\r\n\r\nclass MyComponent extends React.Component {\r\n  state = {\r\n    name: 'Angular',\r\n  };\r\n  \r\n  componentWillMount = () => {\r\n    this.state.name = 'React';\r\n  }\r\n  \r\n  render = () => {\r\n    return \u003ch1>Hello! {this.state.name}\u003c/h1>;\r\n  }\r\n}\r\n\r\nrender(\r\n  \u003cMyComponent />, \r\n  document.getElementById('app')\r\n);\r\n```\r\n\r\nHook is called and it displays \"Hello! React\" as you would expect.\r\n\r\nJSBin for exploration: https://jsbin.com/yavokur/1/edit?js,output\r\n\r\n**Please tell us about your environment:**\r\nOSX El Capitan 10.11.6\r\nVSCode\r\nExpress-based node.js server\r\n\r\n* **Angular version:** 2.0.X\r\nangular: 4.1.0\r\n\r\n* **Browser:** [all | Chrome XX | Firefox XX | IE XX | Safari XX | Mobile Chrome XX | Android X.X Web Browser | iOS XX Safari | iOS XX UIWebView | iOS XX WKWebView ]\r\n\u003c!-- All browsers where this could be reproduced -->\r\nALL\r\n \r\n* **Language:** [all | TypeScript X.X | ES6/7 | ES5]\r\nTypeScript 2.3+\r\n\r\n* **Node (for AoT issues):** `node --version` =   \r\nnode: 4.7.3","author":{"url":"https://github.com/ValeriiVasin","@type":"Person","name":"ValeriiVasin"},"datePublished":"2017-05-02T16:11:03Z","url":"https://github.com/angular/angular/issues/16478"}

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:40963bd7-66fe-c3ca-91df-0c6fe3f72a3f
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-idB3DE:2D2F2F:1CC3AEF:24C5B90:6B014A47
html-safe-noncee895b0602fd682ac635b22996ac8e02931044669ff72dd59821907f338f8382d
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCM0RFOjJEMkYyRjoxQ0MzQUVGOjI0QzVCOTA6NkIwMTRBNDciLCJ2aXNpdG9yX2lkIjoiMTY1ODY2Mjc4MzIwMzQ5NDQ3MSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac4709a9ea22153758f8a5d47292215b88da528e5a5c573d24c12d6433b3de74dc
hovercard-subject-tagissue:225744667
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/angular/angular/16478/issue_layout
twitter:imagehttps://opengraph.githubassets.com/e043da97f7f3f98a73f1a81a6a44423633b5fd7313dcf91673e95f18b73a9b65/angular/angular/issues/16478
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/e043da97f7f3f98a73f1a81a6a44423633b5fd7313dcf91673e95f18b73a9b65/angular/angular/issues/16478
og:image:altI'm submitting a ... (check one with "x") [x] bug report => search github for a similar issue or PR before submitting [x] feature request [ ] support request => Please do not submit support request...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameValeriiVasin
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-preview
go-importgithub.com/angular/angular git https://github.com/angular/angular.git
octolytics-dimension-user_id139426
octolytics-dimension-user_loginangular
octolytics-dimension-repository_id24195339
octolytics-dimension-repository_nwoangular/angular
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id24195339
octolytics-dimension-repository_network_root_nwoangular/angular
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-nameissues

Links:

Skip to contenthttps://github.com/angular/angular/issues/16478#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fissues%2F16478
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fissues%2F16478
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=angular%2Fangular
Reloadhttps://github.com/angular/angular/issues/16478
Reloadhttps://github.com/angular/angular/issues/16478
Reloadhttps://github.com/angular/angular/issues/16478
angularhttps://github.com/angular
angularhttps://github.com/angular/angular
Codehttps://github.com/angular/angular
Issues836 (836)https://github.com/angular/angular/issues
Pull requests141 (141)https://github.com/angular/angular/pulls
Discussionshttps://github.com/angular/angular/discussions
Actionshttps://github.com/angular/angular/actions
Projectshttps://github.com/angular/angular/projects
Security and quality40 (40)https://github.com/angular/angular/security
Insightshttps://github.com/angular/angular/insights
https://github.com/angular/angular
New issuehttps://github.com/login?return_to=https://github.com/angular/angular/issues/16478
New issuehttps://github.com/login?return_to=https://github.com/angular/angular/issues/16478
Instance bound methods do not work as hookshttps://github.com/angular/angular/issues/16478#top
area: coreIssues related to the framework runtimehttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20core%22
core: lifecycle hookshttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22core%3A%20lifecycle%20hooks%22
featureLabel used to distinguish feature request from other issueshttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22feature%22
Backloghttps://github.com/angular/angular/milestone/82
https://github.com/ValeriiVasin
ValeriiVasinhttps://github.com/ValeriiVasin
on May 2, 2017https://github.com/angular/angular/issues/16478#issue-225744667
http://stackoverflow.com/questions/43677584/angular2-instance-bound-methods-does-not-work-as-hookshttp://stackoverflow.com/questions/43677584/angular2-instance-bound-methods-does-not-work-as-hooks
https://plnkr.co/edit/aZ1CYkDn06KUENmDW3a3?p=previewhttps://plnkr.co/edit/aZ1CYkDn06KUENmDW3a3?p=preview
https://jsbin.com/yavokur/1/edit?js,outputhttps://jsbin.com/yavokur/1/edit?js,output
matskohttps://github.com/matsko
area: coreIssues related to the framework runtimehttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20core%22
type: bug/fixhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22type%3A%20bug%2Ffix%22
on May 3, 2017https://github.com/angular/angular/issues/16478#event-1067801997
chuckjazhttps://github.com/chuckjaz
featureLabel used to distinguish feature request from other issueshttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22feature%22
type: bug/fixhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22type%3A%20bug%2Ffix%22
on Nov 28, 2017https://github.com/angular/angular/issues/16478#event-1362527348
ngbothttps://github.com/apps/ngbot
Backloghttps://github.com/angular/angular/milestone/82
on Jan 23, 2018https://github.com/angular/angular/issues/16478#event-1437586415
https://github.com/trotyl
trotylhttps://github.com/trotyl
on Jul 23, 2018https://github.com/angular/angular/issues/16478#issuecomment-406950074
#7270https://github.com/angular/angular/issues/7270
pkozlowski-opensourcehttps://github.com/pkozlowski-opensource
core: lifecycle hookshttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22core%3A%20lifecycle%20hooks%22
on Mar 12, 2020https://github.com/angular/angular/issues/16478#event-3123211780
https://github.com/ValeriiVasin
ValeriiVasinhttps://github.com/ValeriiVasin
on Oct 4, 2020https://github.com/angular/angular/issues/16478#issuecomment-703212599
herehttps://github.com/angular/angular/issues/7270#issuecomment-201137617
ValeriiVasinhttps://github.com/ValeriiVasin
completedhttps://github.com/angular/angular/issues?q=is%3Aissue%20state%3Aclosed%20archived%3Afalse%20reason%3Acompleted
on Oct 4, 2020https://github.com/angular/angular/issues/16478#event-3837279973
https://github.com/apps/angular-automatic-lock-bot
angular-automatic-lock-bothttps://github.com/apps/angular-automatic-lock-bot
on Nov 4, 2020https://github.com/angular/angular/issues/16478#issuecomment-721836722
automatic conversation locking policyhttps://github.com/angular/angular/blob/8f24bc9443b3872fe095d9f7f77b308a361a13b4/docs/GITHUB_PROCESS.md#conversation-locking
angular-automatic-lock-bothttps://github.com/apps/angular-automatic-lock-bot
on Nov 4, 2020https://github.com/angular/angular/issues/16478#event-3958438310
Sign up for freehttps://github.com/signup?return_to=https://github.com/angular/angular/issues/16478
Sign in to commenthttps://github.com/login?return_to=https://github.com/angular/angular/issues/16478
area: coreIssues related to the framework runtimehttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20core%22
core: lifecycle hookshttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22core%3A%20lifecycle%20hooks%22
featureLabel used to distinguish feature request from other issueshttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22feature%22
BacklogNo due datehttps://github.com/angular/angular/milestone/82
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.