Title: Instance bound methods do not work as hooks · Issue #16478 · angular/angular · GitHub
Open Graph Title: Instance bound methods do not work as hooks · Issue #16478 · angular/angular
X Title: Instance bound methods do not work as hooks · Issue #16478 · angular/angular
Description: I'm submitting a ... (check one with "x") [x] bug report => search github for a similar issue or PR before submitting [x] feature request [ ] support request => Please do not submit support request here, instead see https://github.com/an...
Open Graph Description: I'm submitting a ... (check one with "x") [x] bug report => search github for a similar issue or PR before submitting [x] feature request [ ] support request => Please do not submit support request...
X Description: I'm submitting a ... (check one with "x") [x] bug report => search github for a similar issue or PR before submitting [x] feature request [ ] support request => Please do not su...
Opengraph URL: https://github.com/angular/angular/issues/16478
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Instance bound methods do not work as hooks","articleBody":"**I'm submitting a ...** (check one with \"x\")\r\n```\r\n[x] bug report => search github for a similar issue or PR before submitting\r\n[x] feature request\r\n[ ] support request => Please do not submit support request here, instead see https://github.com/angular/angular/blob/master/CONTRIBUTING.md#question\r\n```\r\n\r\nInstance bound methods do not work as hooks. Here is a little code sample:\r\n\r\n```typescript\r\n import { Component } from '@angular/core';\r\n\r\n @Component({\r\n selector: 'my-app',\r\n template: '\u003ch1>Hello {{name}}\u003c/h1>'\r\n })\r\n export class AppComponent { \r\n name = 'Angular'; \r\n \r\n ngOnInit = () => {\r\n this.name = 'World';\r\n }\r\n }\r\n```\r\n\r\n**Current behavior**\r\nHook is not executed, \"Hello Angular\" is displayed.\r\n\r\n**Expected behavior**\r\nHook should be executed, and we would see \"Hello World\" instead. Or (if it is by design) - some message would be much appreciated in DEV mode. Smth like, \"You are trying to use instance bound method for hooks. It will not work.\"\r\n\r\nIn the documentation i found only this note: \r\n\r\n> Angular instead inspects directive and component classes and calls the hook methods if they are defined. Angular finds and calls methods like ngOnInit(), with or without the interfaces.\r\n\r\nWhich is explaining it in some manner, but intention is not clear still.\r\n\r\n**Minimal reproduction of the problem with instructions**\r\nStackOverflow discussion: \r\nhttp://stackoverflow.com/questions/43677584/angular2-instance-bound-methods-does-not-work-as-hooks\r\n\r\nPlunkr: https://plnkr.co/edit/aZ1CYkDn06KUENmDW3a3?p=preview\r\n\r\n**What is the motivation / use case for changing the behavior?**\r\nIt is kinda not transparent why Angular is behaving like that. I assume that it is **by design** for performance reasons. But it would be nice to mention that explicitly and provide a message for DEV mode to prevent others from spending time on such thing.\r\n\r\nBTW, React is behaving in a predictable manner: \r\n\r\n```js\r\nconst { render } = ReactDOM;\r\n\r\nclass MyComponent extends React.Component {\r\n state = {\r\n name: 'Angular',\r\n };\r\n \r\n componentWillMount = () => {\r\n this.state.name = 'React';\r\n }\r\n \r\n render = () => {\r\n return \u003ch1>Hello! {this.state.name}\u003c/h1>;\r\n }\r\n}\r\n\r\nrender(\r\n \u003cMyComponent />, \r\n document.getElementById('app')\r\n);\r\n```\r\n\r\nHook is called and it displays \"Hello! React\" as you would expect.\r\n\r\nJSBin for exploration: https://jsbin.com/yavokur/1/edit?js,output\r\n\r\n**Please tell us about your environment:**\r\nOSX El Capitan 10.11.6\r\nVSCode\r\nExpress-based node.js server\r\n\r\n* **Angular version:** 2.0.X\r\nangular: 4.1.0\r\n\r\n* **Browser:** [all | Chrome XX | Firefox XX | IE XX | Safari XX | Mobile Chrome XX | Android X.X Web Browser | iOS XX Safari | iOS XX UIWebView | iOS XX WKWebView ]\r\n\u003c!-- All browsers where this could be reproduced -->\r\nALL\r\n \r\n* **Language:** [all | TypeScript X.X | ES6/7 | ES5]\r\nTypeScript 2.3+\r\n\r\n* **Node (for AoT issues):** `node --version` = \r\nnode: 4.7.3","author":{"url":"https://github.com/ValeriiVasin","@type":"Person","name":"ValeriiVasin"},"datePublished":"2017-05-02T16:11:03Z","url":"https://github.com/angular/angular/issues/16478"}
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:40963bd7-66fe-c3ca-91df-0c6fe3f72a3f |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | B3DE:2D2F2F:1CC3AEF:24C5B90:6B014A47 |
| html-safe-nonce | e895b0602fd682ac635b22996ac8e02931044669ff72dd59821907f338f8382d |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCM0RFOjJEMkYyRjoxQ0MzQUVGOjI0QzVCOTA6NkIwMTRBNDciLCJ2aXNpdG9yX2lkIjoiMTY1ODY2Mjc4MzIwMzQ5NDQ3MSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 4709a9ea22153758f8a5d47292215b88da528e5a5c573d24c12d6433b3de74dc |
| hovercard-subject-tag | issue:225744667 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/angular/angular/16478/issue_layout |
| twitter:image | https://opengraph.githubassets.com/e043da97f7f3f98a73f1a81a6a44423633b5fd7313dcf91673e95f18b73a9b65/angular/angular/issues/16478 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/e043da97f7f3f98a73f1a81a6a44423633b5fd7313dcf91673e95f18b73a9b65/angular/angular/issues/16478 |
| og:image:alt | I'm submitting a ... (check one with "x") [x] bug report => search github for a similar issue or PR before submitting [x] feature request [ ] support request => Please do not submit support request... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | ValeriiVasin |
| hostname | github.com |
| expected-hostname | github.com |
| None | cc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c |
| turbo-cache-control | no-preview |
| go-import | github.com/angular/angular git https://github.com/angular/angular.git |
| octolytics-dimension-user_id | 139426 |
| octolytics-dimension-user_login | angular |
| octolytics-dimension-repository_id | 24195339 |
| octolytics-dimension-repository_nwo | angular/angular |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 24195339 |
| octolytics-dimension-repository_network_root_nwo | angular/angular |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 8c77c9e8439031ad54c75a250694842892f693e1 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | issues |
Links:
Viewport: width=device-width