Title: make SCHEMAS extendable · Issue #16306 · angular/angular · GitHub
Open Graph Title: make SCHEMAS extendable · Issue #16306 · angular/angular
X Title: make SCHEMAS extendable · Issue #16306 · angular/angular
Description: I'm submitting a ... (check one with "x") [ ] bug report => search github for a similar issue or PR before submitting [x] feature request [ ] support request => Please do not submit support request here, instead see https://github.com/an...
Open Graph Description: I'm submitting a ... (check one with "x") [ ] bug report => search github for a similar issue or PR before submitting [x] feature request [ ] support request => Please do not submit support request...
X Description: I'm submitting a ... (check one with "x") [ ] bug report => search github for a similar issue or PR before submitting [x] feature request [ ] support request => Please do not su...
Opengraph URL: https://github.com/angular/angular/issues/16306
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"make SCHEMAS extendable","articleBody":"\u003c!--\r\nIF YOU DON'T FILL OUT THE FOLLOWING INFORMATION WE MIGHT CLOSE YOUR ISSUE WITHOUT INVESTIGATING\r\n-->\r\n\r\n**I'm submitting a ...** (check one with \"x\")\r\n```\r\n[ ] bug report => search github for a similar issue or PR before submitting\r\n[x] feature request\r\n[ ] support request => Please do not submit support request here, instead see https://github.com/angular/angular/blob/master/CONTRIBUTING.md#question\r\n```\r\n\r\n**Current behavior**\r\n\u003c!-- Describe how the bug manifests. -->\r\n\r\nnow schemas are not extendable, only hard-coded `CUSTOM_ELEMENT_SCHEMA` and `NO_ERRORS_SCHEMA` available. if a user want to add new schema, they have to modify `DomElementSchemaRegistry.hasElement`,`DomElementSchemaRegistry.prototype.hasProperty` or other compiler methods to do it. like this\r\nhttps://github.com/moecube/electron-schema/blob/master/index.ts\r\n\r\n**Expected behavior**\r\n\u003c!-- Describe what the behavior would be without the bug. -->\r\n\r\nhttps://github.com/angular/angular/blob/5b141fbf2789e6629083afd1d4678a2ba1ae6ab3/packages/compiler/src/schema/dom_element_schema_registry.ts#L287\r\n\r\nmake `DomElementSchemaRegistry.hasElement`,`DomElementSchemaRegistry.prototype.hasProperty` and other compiler methods to read schemaMetas not only name, but also some contents, for example, a `string[]` like SCHEMA defined in https://github.com/angular/angular/blob/5b141fbf2789e6629083afd1d4678a2ba1ae6ab3/packages/compiler/src/schema/dom_element_schema_registry.ts#L79\r\n\r\nthen user can just declare something like \r\n```TypeScript\r\nconst ELECTRON_SCHEMA = ['webview^[HTMLElement]|src,...']\r\n```\r\nthen put it in ngModule.schemas .\r\n```TypeScript\r\n@NgModule({\r\n // ...\r\n schemas: [ELECTRON_SCHEMA]\r\n})\r\nexport class AppModule {\r\n}\r\n```\r\n\r\nfor more clearly, it could be a interface rather than a string, like..\r\n```TypeScript\r\ninterface SchemaData {\r\n tagName: string\r\n type: string\r\n attributes: string[]\r\n ... // other security-related fields\r\n}\r\n```\r\nfor more dynamic use, it could also be a function-based interface, it can combined with normal SchemaMetadata interface, for example:\r\n```TypeScript\r\ninterface SchemaMeta {\r\n name: string\r\n hasElement?(tagName, schemaMetas): boolean\r\n hasProperty?(tagName, propName, schemaMetas): boolean\r\n ... // other security-related methods\r\n}\r\n```\r\nthen `CUSTOM_ELEMENTS_SCHEMA` and `NO_ERROES_SCHEMA` could also be a normal SchemaMeta, and don't need hard-code in compiler, like\r\n\r\n```TypeScript\r\nclass NO_ERROES_SCHEMA implements SchemaMetadata {\r\n name: 'no-errors-schema'\r\n hasElement(tagName, schemaMetas) {return true}\r\n hasProperty(tagName, propName, schemaMetas) {return true}\r\n}\r\n```","author":{"url":"https://github.com/zh99998","@type":"Person","name":"zh99998"},"datePublished":"2017-04-25T08:59:45Z","url":"https://github.com/angular/angular/issues/16306"}
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:e73d3f53-663b-e7b1-1814-c217d361d006 |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | AF4C:23CF06:1890702:1F63308:6B013132 |
| html-safe-nonce | 60cced14cab186855d1ea8acd666571bee660588afc13464f4037872bbf77025 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBRjRDOjIzQ0YwNjoxODkwNzAyOjFGNjMzMDg6NkIwMTMxMzIiLCJ2aXNpdG9yX2lkIjoiNDA3OTcyNjMwNDU0MTM1NjMzOCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | c2727c1c53c2a96e52b663199463c69de24d0618c9b4a51784e1f3b3f9a48d32 |
| hovercard-subject-tag | issue:224068245 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/angular/angular/16306/issue_layout |
| twitter:image | https://opengraph.githubassets.com/81ce165ba1edd7990e926d4bc0f3cbbc22204d49323ffe793a1c26ca23c68237/angular/angular/issues/16306 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/81ce165ba1edd7990e926d4bc0f3cbbc22204d49323ffe793a1c26ca23c68237/angular/angular/issues/16306 |
| og:image:alt | I'm submitting a ... (check one with "x") [ ] bug report => search github for a similar issue or PR before submitting [x] feature request [ ] support request => Please do not submit support request... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | zh99998 |
| hostname | github.com |
| expected-hostname | github.com |
| None | cc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c |
| turbo-cache-control | no-preview |
| go-import | github.com/angular/angular git https://github.com/angular/angular.git |
| octolytics-dimension-user_id | 139426 |
| octolytics-dimension-user_login | angular |
| octolytics-dimension-repository_id | 24195339 |
| octolytics-dimension-repository_nwo | angular/angular |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 24195339 |
| octolytics-dimension-repository_network_root_nwo | angular/angular |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 8c77c9e8439031ad54c75a250694842892f693e1 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | issues |
Links:
Viewport: width=device-width