René's URL Explorer Experiment


Title: CanActivate guards on child routes run before parent CanActivate guards finish · Issue #15670 · angular/angular · GitHub

Open Graph Title: CanActivate guards on child routes run before parent CanActivate guards finish · Issue #15670 · angular/angular

X Title: CanActivate guards on child routes run before parent CanActivate guards finish · Issue #15670 · angular/angular

Description: I'm submitting a ... (check one with "x") [X] bug report => search github for a similar issue or PR before submitting [ ] feature request [ ] support request => Please do not submit support request here, instead see https://github.com/an...

Open Graph Description: I'm submitting a ... (check one with "x") [X] bug report => search github for a similar issue or PR before submitting [ ] feature request [ ] support request => Please do not submit support request...

X Description: I'm submitting a ... (check one with "x") [X] bug report => search github for a similar issue or PR before submitting [ ] feature request [ ] support request => Please do not su...

Opengraph URL: https://github.com/angular/angular/issues/15670

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"CanActivate guards on child routes run before parent CanActivate guards finish","articleBody":"\u003c!--\nIF YOU DON'T FILL OUT THE FOLLOWING INFORMATION WE MIGHT CLOSE YOUR ISSUE WITHOUT INVESTIGATING\n-->\n\n**I'm submitting a ...**  (check one with \"x\")\n```\n[X] bug report => search github for a similar issue or PR before submitting\n[ ] feature request\n[ ] support request => Please do not submit support request here, instead see https://github.com/angular/angular/blob/master/CONTRIBUTING.md#question\n```\n\n**Current behavior**\nWhen both a route and it's parent have an asynchronous `canActivate` guard, and the child is navigated to directly, both guards are run at same time.\n\n**Expected behavior**\nThe parent's `canActivate` guard should run before the child's guard.  If the parent's guard is unsuccessful the child guard should not be run.  If a route defines multiple `canActivate` guards, those can/should be run in parallel.\n\n**Minimal reproduction of the problem with instructions**\nhttp://plnkr.co/edit/s4R0INS7qjuFnRpyD8eF?p=preview\n\nPlunker has a nested route `/parent/child`.  Both have guards that simply wait and then return true.  Each guard logs its start/end as well as a tick once per second to a logging service that is displayed in the root component.\n\nClick 'Go to Child` to trigger both the Parent Guard and the Child guard at the same time, and observe that they process simultaneously in the log.\n\n**What is the motivation / use case for changing the behavior?**\n\nIn my athepp, `ParentGuard` checks to see if the user is authenticated and redirects accordingly, and `ChildGuard` loads protected data. Right now, my child guard cannot assume the user is logged in, so I have to duplicate logic from the authorization guard to wait for the user to be loaded. When I have a grandchild route, that has to duplicate logic from two parent guards.  I would like to be able to separate concerns more rather than duplicate auth logic in all my guards.\n\n**Please tell us about your environment:**\n\u003c!-- Operating system, IDE, package manager, HTTP server, ... -->\n\n* **Angular version:** 4.0.1\n\u003c!-- Check whether this is still an issue in the most recent Angular version -->","author":{"url":"https://github.com/adharris","@type":"Person","name":"adharris"},"datePublished":"2017-03-31T16:15:50Z","url":"https://github.com/angular/angular/issues/15670"}

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:ec66f238-18f7-8cca-f84f-cb52effc5112
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-id8E06:2DBB21:C12FA7:102B06B:6B00FA2D
html-safe-nonce1e5067f728bec961348a5774c9432a776e863e89919bcef150e121569c96378f
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4RTA2OjJEQkIyMTpDMTJGQTc6MTAyQjA2Qjo2QjAwRkEyRCIsInZpc2l0b3JfaWQiOiI4NTI4OTgzODI4MTM0NDI3MTgyIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmacc52ce46e64034576ba3b41c7c7ab464be09cdfef287a63d5629b64757447e4d2
hovercard-subject-tagissue:218549949
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/angular/angular/15670/issue_layout
twitter:imagehttps://opengraph.githubassets.com/78d0cbd96d1fc8d2f63bfb4581575ffc75047322c0fc1e4b1cbbf4fbdd267dd6/angular/angular/issues/15670
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/78d0cbd96d1fc8d2f63bfb4581575ffc75047322c0fc1e4b1cbbf4fbdd267dd6/angular/angular/issues/15670
og:image:altI'm submitting a ... (check one with "x") [X] bug report => search github for a similar issue or PR before submitting [ ] feature request [ ] support request => Please do not submit support request...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameadharris
hostnamegithub.com
expected-hostnamegithub.com
Nonee208d86428ec00a57ade75058166297440e8128a01e5287c31a53dc042bbf187
turbo-cache-controlno-preview
go-importgithub.com/angular/angular git https://github.com/angular/angular.git
octolytics-dimension-user_id139426
octolytics-dimension-user_loginangular
octolytics-dimension-repository_id24195339
octolytics-dimension-repository_nwoangular/angular
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id24195339
octolytics-dimension-repository_network_root_nwoangular/angular
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release7dafd017fb7809a839c443dba08622af38e63c09
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-nameissues

Links:

Skip to contenthttps://github.com/angular/angular/issues/15670#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fissues%2F15670
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fissues%2F15670
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=angular%2Fangular
Reloadhttps://github.com/angular/angular/issues/15670
Reloadhttps://github.com/angular/angular/issues/15670
Reloadhttps://github.com/angular/angular/issues/15670
angularhttps://github.com/angular
angularhttps://github.com/angular/angular
Codehttps://github.com/angular/angular
Issues835 (835)https://github.com/angular/angular/issues
Pull requests141 (141)https://github.com/angular/angular/pulls
Discussionshttps://github.com/angular/angular/discussions
Actionshttps://github.com/angular/angular/actions
Projectshttps://github.com/angular/angular/projects
Security and quality40 (40)https://github.com/angular/angular/security
Insightshttps://github.com/angular/angular/insights
https://github.com/angular/angular
New issuehttps://github.com/login?return_to=https://github.com/angular/angular/issues/15670
New issuehttps://github.com/login?return_to=https://github.com/angular/angular/issues/15670
CanActivate guards on child routes run before parent CanActivate guards finishhttps://github.com/angular/angular/issues/15670#top
area: routerhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20router%22
type: bug/fixhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22type%3A%20bug%2Ffix%22
https://github.com/adharris
adharrishttps://github.com/adharris
on Mar 31, 2017https://github.com/angular/angular/issues/15670#issue-218549949
http://plnkr.co/edit/s4R0INS7qjuFnRpyD8eF?p=previewhttp://plnkr.co/edit/s4R0INS7qjuFnRpyD8eF?p=preview
pkozlowski-opensourcehttps://github.com/pkozlowski-opensource
area: routerhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20router%22
type: bug/fixhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22type%3A%20bug%2Ffix%22
on Mar 31, 2017https://github.com/angular/angular/issues/15670#event-1024539980
jasonadenhttps://github.com/jasonaden
on Apr 13, 2017https://github.com/angular/angular/issues/15670#event-1042456045
https://github.com/jdell64
jdell64https://github.com/jdell64
on May 13, 2017https://github.com/angular/angular/issues/15670#issuecomment-301213706
https://github.com/Drabc
Drabchttps://github.com/Drabc
on Jun 7, 2017https://github.com/angular/angular/issues/15670#issuecomment-306793999
https://github.com/jdell64
jdell64https://github.com/jdell64
on Jun 9, 2017https://github.com/angular/angular/issues/15670#issuecomment-307393379
https://github.com/kevinvanhove
kevinvanhovehttps://github.com/kevinvanhove
on Jun 14, 2017https://github.com/angular/angular/issues/15670#issuecomment-308508253
https://angular.io/guide/router#canactivatechild-guarding-child-routeshttps://angular.io/guide/router#canactivatechild-guarding-child-routes
https://github.com/jnapier
jnapierhttps://github.com/jnapier
on Jun 21, 2017https://github.com/angular/angular/issues/15670#issuecomment-310236130
@DzmitryShylovichhttps://github.com/DzmitryShylovich
https://github.com/kevinvanhove
kevinvanhovehttps://github.com/kevinvanhove
on Jun 22, 2017https://github.com/angular/angular/issues/15670#issuecomment-310355242
https://github.com/Drabc
Drabchttps://github.com/Drabc
on Jun 23, 2017https://github.com/angular/angular/issues/15670#issuecomment-310673022
https://github.com/onurcipe
onurcipehttps://github.com/onurcipe
on Jul 12, 2017https://github.com/angular/angular/issues/15670#issuecomment-314782698
jasonadenhttps://github.com/jasonaden
on Jul 26, 2017https://github.com/angular/angular/issues/15670#event-1180316474
fix(router): child CanActivate guard should wait for parent to completehttps://github.com/jasonaden/angular/commit/f5d9f773cbd30f2d78e3e420925e8852b2da9839
https://docs.github.com/articles/closing-issues-via-commit-messages
f5d9f77https://github.com/jasonaden/angular/commit/f5d9f773cbd30f2d78e3e420925e8852b2da9839
mheveryhttps://github.com/mhevery
completedhttps://github.com/angular/angular/issues?q=is%3Aissue%20state%3Aclosed%20archived%3Afalse%20reason%3Acompleted
086f4aahttps://github.com/angular/angular/commit/086f4aa72c8b7251f6e53db503b1793a4c9772fd
on Jul 26, 2017https://github.com/angular/angular/issues/15670#event-1180823618
mheveryhttps://github.com/mhevery
on Jul 26, 2017https://github.com/angular/angular/issues/15670#event-1180824218
fix(router): child CanActivate guard should wait for parent to comple…https://github.com/angular/angular/commit/b9e32c833aa27765ea2bff0463fe898c780ee506
https://docs.github.com/articles/closing-issues-via-commit-messages
b9e32c8https://github.com/angular/angular/commit/b9e32c833aa27765ea2bff0463fe898c780ee506
asnowwolfhttps://github.com/asnowwolf
on Aug 11, 2017https://github.com/angular/angular/issues/15670#event-1201914330
fix(router): child CanActivate guard should wait for parent to comple…https://github.com/asnowwolf/angular/commit/49a75138b77dba2cd6999e4a0289a0c18b12166b
https://docs.github.com/articles/closing-issues-via-commit-messages
49a7513https://github.com/asnowwolf/angular/commit/49a75138b77dba2cd6999e4a0289a0c18b12166b
juleskremerhttps://github.com/juleskremer
on Aug 26, 2017https://github.com/angular/angular/issues/15670#event-1222301240
fix(router): child CanActivate guard should wait for parent to comple…https://github.com/juleskremer/angular/commit/0e6622eee7458a42126dbf041945782d191b76b8
https://docs.github.com/articles/closing-issues-via-commit-messages
0e6622ehttps://github.com/juleskremer/angular/commit/0e6622eee7458a42126dbf041945782d191b76b8
fix(router): child CanActivate guard should wait for parent to comple…https://github.com/juleskremer/angular/commit/50376d4a434e8d52082b1843cc52510aff80a734
https://docs.github.com/articles/closing-issues-via-commit-messages
50376d4https://github.com/juleskremer/angular/commit/50376d4a434e8d52082b1843cc52510aff80a734
https://github.com/iBeriaLab
iBeriaLabhttps://github.com/iBeriaLab
on Oct 31, 2017https://github.com/angular/angular/issues/15670#issuecomment-340839569
https://github.com/lppedd
lppeddhttps://github.com/lppedd
on Jun 21, 2019https://github.com/angular/angular/issues/15670#issuecomment-504473737
https://github.com/brandon-sigao
brandon-sigaohttps://github.com/brandon-sigao
on Jul 9, 2019https://github.com/angular/angular/issues/15670#issuecomment-509726979
https://github.com/richardsengers
richardsengershttps://github.com/richardsengers
on Aug 6, 2019https://github.com/angular/angular/issues/15670#issuecomment-518561323
richardsengershttps://github.com/richardsengers
jasonadenhttps://github.com/jasonaden
on Aug 6, 2019https://github.com/angular/angular/issues/15670#event-2535863439
https://github.com/apps/angular-automatic-lock-bot
angular-automatic-lock-bothttps://github.com/apps/angular-automatic-lock-bot
on Sep 15, 2019https://github.com/angular/angular/issues/15670#issuecomment-531551486
automatic conversation locking policyhttps://github.com/angular/angular/blob/67d80f/docs/GITHUB_PROCESS.md#conversation-locking
angular-automatic-lock-bothttps://github.com/apps/angular-automatic-lock-bot
on Sep 15, 2019https://github.com/angular/angular/issues/15670#event-2634566373
Sign up for freehttps://github.com/signup?return_to=https://github.com/angular/angular/issues/15670
Sign in to commenthttps://github.com/login?return_to=https://github.com/angular/angular/issues/15670
area: routerhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20router%22
type: bug/fixhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22type%3A%20bug%2Ffix%22
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.