René's URL Explorer Experiment


Title: Allow view creation during change detection · Issue #15634 · angular/angular · GitHub

Open Graph Title: Allow view creation during change detection · Issue #15634 · angular/angular

X Title: Allow view creation during change detection · Issue #15634 · angular/angular

Description: I'm submitting a ... (check one with "x") [x] bug report => search github for a similar issue or PR before submitting Current behavior Creating dynamically a new view from a lifecycle hook (ex.: ngOnInit) will result in the following err...

Open Graph Description: I'm submitting a ... (check one with "x") [x] bug report => search github for a similar issue or PR before submitting Current behavior Creating dynamically a new view from a lifecycle hook (ex.: ng...

X Description: I'm submitting a ... (check one with "x") [x] bug report => search github for a similar issue or PR before submitting Current behavior Creating dynamically a new view from a lifecy...

Opengraph URL: https://github.com/angular/angular/issues/15634

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Allow view creation during change detection","articleBody":"\r\n**I'm submitting a ...**  (check one with \"x\")\r\n```\r\n[x] bug report => search github for a similar issue or PR before submitting\r\n```\r\n\r\n**Current behavior**\r\n\r\nCreating dynamically a new view from a lifecycle hook (ex.: `ngOnInit`) will result in the following error:\r\n\r\n> ExpressionChangedAfterItHasBeenCheckedError: Expression has changed after it was checked. Previous value: 'xxx'. Current value: 'yyy'. It seems like the view has been created after its parent and its children have been dirty checked. Has it been created in a change detection hook ?\r\n\r\n**Expected behavior**\r\n\r\nDynamically created views should be change detected \"inline\" if possible (as right now), but if we cannot do this, we should change detect them at then end of the current run, and not throw the mentioned error.\r\n\r\n**Minimal reproduction of the problem with instructions**\r\n\r\nhttps://plnkr.co/edit/uh4oxxA3Yq6i45SA52SS?p=preview\r\n\r\n**What is the motivation / use case for changing the behavior?**\r\n\r\nThere are legitimate use-cases where a new view needs to be created from a lifecycle hook, ex.: opening a modal window from the `ngOnInit` lifecycle hook. This was initially reported on ng-bootstrap side via https://github.com/ng-bootstrap/ng-bootstrap/issues/1159\r\n\r\nThe pb was discussed with @tbosch and the issue is opened as the result of this discussion.\r\n\r\n* **Angular version:** \r\n\r\n2.3.x, 4.0.X\r\n\r\n* **Browser:** \r\n\r\nall\r\n \r\n* **Language:** \r\n\r\nall","author":{"url":"https://github.com/pkozlowski-opensource","@type":"Person","name":"pkozlowski-opensource"},"datePublished":"2017-03-30T18:54:05Z","url":"https://github.com/angular/angular/issues/15634"}

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:8c617369-45de-2084-a3ce-4f049927da94
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-id940A:2270F4:1611927:1D52F1F:6B0137D5
html-safe-nonce39dd981c1436ab882054dfed90a5354ce070af01abed2589f1bbc94ec7c4a3e9
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5NDBBOjIyNzBGNDoxNjExOTI3OjFENTJGMUY6NkIwMTM3RDUiLCJ2aXNpdG9yX2lkIjoiODU4OTIzNTE0MTE5MTIxOTE1NyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac2a785a9e97bf09ef1e3a243681eb4f10562fce857caece9943d103aabe07ee4a
hovercard-subject-tagissue:218293955
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/angular/angular/15634/issue_layout
twitter:imagehttps://opengraph.githubassets.com/21cbe630bd894c672e3c8d0c0ed199b60671703a3298a398e83604b8dabf7b8b/angular/angular/issues/15634
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/21cbe630bd894c672e3c8d0c0ed199b60671703a3298a398e83604b8dabf7b8b/angular/angular/issues/15634
og:image:altI'm submitting a ... (check one with "x") [x] bug report => search github for a similar issue or PR before submitting Current behavior Creating dynamically a new view from a lifecycle hook (ex.: ng...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamepkozlowski-opensource
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-preview
go-importgithub.com/angular/angular git https://github.com/angular/angular.git
octolytics-dimension-user_id139426
octolytics-dimension-user_loginangular
octolytics-dimension-repository_id24195339
octolytics-dimension-repository_nwoangular/angular
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id24195339
octolytics-dimension-repository_network_root_nwoangular/angular
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-nameissues

Links:

Skip to contenthttps://github.com/angular/angular/issues/15634#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fissues%2F15634
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fissues%2F15634
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=angular%2Fangular
Reloadhttps://github.com/angular/angular/issues/15634
Reloadhttps://github.com/angular/angular/issues/15634
Reloadhttps://github.com/angular/angular/issues/15634
angularhttps://github.com/angular
angularhttps://github.com/angular/angular
Codehttps://github.com/angular/angular
Issues836 (836)https://github.com/angular/angular/issues
Pull requests141 (141)https://github.com/angular/angular/pulls
Discussionshttps://github.com/angular/angular/discussions
Actionshttps://github.com/angular/angular/actions
Projectshttps://github.com/angular/angular/projects
Security and quality40 (40)https://github.com/angular/angular/security
Insightshttps://github.com/angular/angular/insights
https://github.com/angular/angular
New issuehttps://github.com/login?return_to=https://github.com/angular/angular/issues/15634
New issuehttps://github.com/login?return_to=https://github.com/angular/angular/issues/15634
Allow view creation during change detectionhttps://github.com/angular/angular/issues/15634#top
area: coreIssues related to the framework runtimehttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20core%22
core: change detectionhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22core%3A%20change%20detection%22
featureLabel used to distinguish feature request from other issueshttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22feature%22
Backloghttps://github.com/angular/angular/milestone/82
https://github.com/pkozlowski-opensource
pkozlowski-opensourcehttps://github.com/pkozlowski-opensource
on Mar 30, 2017https://github.com/angular/angular/issues/15634#issue-218293955
https://plnkr.co/edit/uh4oxxA3Yq6i45SA52SS?p=previewhttps://plnkr.co/edit/uh4oxxA3Yq6i45SA52SS?p=preview
ng-bootstrap/ng-bootstrap#1159https://github.com/ng-bootstrap/ng-bootstrap/issues/1159
@tboschhttps://github.com/tbosch
Nexthttps://github.com/angular/angular/issues/15634?timeline_page=1
pkozlowski-opensourcehttps://github.com/pkozlowski-opensource
area: coreIssues related to the framework runtimehttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20core%22
severity1: confusinghttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22severity1%3A%20confusing%22
type: bug/fixhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22type%3A%20bug%2Ffix%22
on Mar 30, 2017https://github.com/angular/angular/issues/15634#event-1022889213
https://github.com/squadwuschel
squadwuschelhttps://github.com/squadwuschel
on Jun 12, 2017https://github.com/angular/angular/issues/15634#issuecomment-307701138
https://github.com/tytskyi
tytskyihttps://github.com/tytskyi
on Jun 12, 2017https://github.com/angular/angular/issues/15634#issuecomment-307719325
https://plnkr.co/edit/o7xY1pBO9wY5ssIdW66s?p=previewhttps://plnkr.co/edit/o7xY1pBO9wY5ssIdW66s?p=preview
https://github.com/victornoel
victornoelhttps://github.com/victornoel
on Jul 16, 2017https://github.com/angular/angular/issues/15634#issuecomment-315601614
@tytskyihttps://github.com/tytskyi
https://github.com/Martin-Luft
Martin-Lufthttps://github.com/Martin-Luft
on Jul 17, 2017https://github.com/angular/angular/issues/15634#issuecomment-315685496
#17572 (comment)https://github.com/angular/angular/issues/17572#issuecomment-311589290
https://github.com/dgroh
dgrohhttps://github.com/dgroh
on Jul 24, 2017https://github.com/angular/angular/issues/15634#issuecomment-317572617
https://github.com/maxisam
maxisamhttps://github.com/maxisam
on Jul 25, 2017https://github.com/angular/angular/issues/15634#issuecomment-317897250
@dgrohhttps://github.com/dgroh
https://github.com/wulfsberg
wulfsberghttps://github.com/wulfsberg
on Aug 1, 2017https://github.com/angular/angular/issues/15634#issuecomment-319341840
joelrahmanhttps://github.com/joelrahman
on Aug 21, 2017https://github.com/angular/angular/issues/15634#event-1213418682
Trigger modal from promise to workaround angular/angular#15634https://github.com/ANU-WALD/afms/commit/2ce7d1e434a33b74f2d7661589700b36c89b7b0d
angular/angular#15634https://github.com/angular/angular/issues/15634
2ce7d1ehttps://github.com/ANU-WALD/afms/commit/2ce7d1e434a33b74f2d7661589700b36c89b7b0d
https://github.com/petebacondarwin
petebacondarwinhttps://github.com/petebacondarwin
on Nov 9, 2020https://github.com/angular/angular/issues/15634#issuecomment-724176111
angular/packages/core/src/render3/instructions/change_detection.tshttps://github.com/angular/angular/blob/d1ea1f4c7f3358b730b0d94e65b00bc28cae279c/packages/core/src/render3/instructions/change_detection.ts#L27-L42
d1ea1f4https://github.com/angular/angular/commit/d1ea1f4c7f3358b730b0d94e65b00bc28cae279c
petebacondarwinhttps://github.com/petebacondarwin
freq1: lowhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22freq1%3A%20low%22
type: bug/fixhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22type%3A%20bug%2Ffix%22
on Jan 21, 2021https://github.com/angular/angular/issues/15634#event-4232301813
https://github.com/sheikhziadahmed
sheikhziadahmedhttps://github.com/sheikhziadahmed
on Jun 9, 2021https://github.com/angular/angular/issues/15634#issuecomment-857471352
https://github.com/all2pie
all2piehttps://github.com/all2pie
on Aug 23, 2021https://github.com/angular/angular/issues/15634#issuecomment-903715790
https://github.com/jsdevtom
jsdevtomhttps://github.com/jsdevtom
on Nov 1, 2021https://github.com/angular/angular/issues/15634#issuecomment-956331363
@markanyehttps://github.com/markanye
jessicajaniukhttps://github.com/jessicajaniuk
featureLabel used to distinguish feature request from other issueshttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22feature%22
P2The issue is important to a large percentage of users, with a workaroundhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22P2%22
on Feb 8, 2022https://github.com/angular/angular/issues/15634#event-6023172763
https://github.com/danielsuter
danielsuterhttps://github.com/danielsuter
on Nov 6, 2022https://github.com/angular/angular/issues/15634#issuecomment-1304837000
https://github.com/atscott
atscotthttps://github.com/atscott
on Dec 15, 2023https://github.com/angular/angular/issues/15634#issuecomment-1857088086
606de51https://github.com/angular/angular/commit/606de5166e33affd7bd53d1ad86c11afa3cdbe21
#53022 (comment)https://github.com/angular/angular/pull/53022#issuecomment-1850817532
atscotthttps://github.com/atscott
on Mar 6, 2024https://github.com/angular/angular/issues/15634#event-12033523501
fix(core): Ensure views marked for check are refreshed during change …https://github.com/atscott/angular/commit/a4090e8d6b07dad4a27b3e38161243d5e0b940a6
https://docs.github.com/articles/closing-issues-via-commit-messages
a4090e8https://github.com/atscott/angular/commit/a4090e8d6b07dad4a27b3e38161243d5e0b940a6
atscotthttps://github.com/atscott
completedhttps://github.com/angular/angular/issues?q=is%3Aissue%20state%3Aclosed%20archived%3Afalse%20reason%3Acompleted
ad045efhttps://github.com/angular/angular/commit/ad045efd4b1565e01c14399998143538ebfbfd99
on Mar 6, 2024https://github.com/angular/angular/issues/15634#event-12034789570
angular-robothttps://github.com/angular-robot
on Mar 7, 2024https://github.com/angular/angular/issues/15634#event-12034907218
fix(core): Ensure views marked for check are refreshed during change …https://github.com/angular-robot/angular/commit/ad045efd4b1565e01c14399998143538ebfbfd99
https://docs.github.com/articles/closing-issues-via-commit-messages
ad045efhttps://github.com/angular-robot/angular/commit/ad045efd4b1565e01c14399998143538ebfbfd99
https://github.com/apps/angular-automatic-lock-bot
angular-automatic-lock-bothttps://github.com/apps/angular-automatic-lock-bot
on Apr 6, 2024https://github.com/angular/angular/issues/15634#issuecomment-2040803528
automatic conversation locking policyhttps://github.com/angular/angular/blob/8f24bc9443b3872fe095d9f7f77b308a361a13b4/docs/GITHUB_PROCESS.md#conversation-locking
angular-automatic-lock-bothttps://github.com/apps/angular-automatic-lock-bot
on Apr 6, 2024https://github.com/angular/angular/issues/15634#event-12380198454
Sign up for freehttps://github.com/signup?return_to=https://github.com/angular/angular/issues/15634
Sign in to commenthttps://github.com/login?return_to=https://github.com/angular/angular/issues/15634
area: coreIssues related to the framework runtimehttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20core%22
core: change detectionhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22core%3A%20change%20detection%22
featureLabel used to distinguish feature request from other issueshttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22feature%22
BacklogNo due datehttps://github.com/angular/angular/milestone/82
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.