Title: @ContentChildren memory leak with ngTemplateOutlet · Issue #14919 · angular/angular · GitHub
Open Graph Title: @ContentChildren memory leak with ngTemplateOutlet · Issue #14919 · angular/angular
X Title: @ContentChildren memory leak with ngTemplateOutlet · Issue #14919 · angular/angular
Description: I'm submitting a ... (check one with "x") [x] bug report => search github for a similar issue or PR before submitting [ ] feature request [ ] support request => Please do not submit support request here, instead see https://github.com/an...
Open Graph Description: I'm submitting a ... (check one with "x") [x] bug report => search github for a similar issue or PR before submitting [ ] feature request [ ] support request => Please do not submit support request...
X Description: I'm submitting a ... (check one with "x") [x] bug report => search github for a similar issue or PR before submitting [ ] feature request [ ] support request => Please do not su...
Opengraph URL: https://github.com/angular/angular/issues/14919
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"@ContentChildren memory leak with ngTemplateOutlet","articleBody":"\u003c!--\r\nIF YOU DON'T FILL OUT THE FOLLOWING INFORMATION WE MIGHT CLOSE YOUR ISSUE WITHOUT INVESTIGATING\r\n-->\r\n\r\n**I'm submitting a ...** (check one with \"x\")\r\n```\r\n[x] bug report => search github for a similar issue or PR before submitting\r\n[ ] feature request\r\n[ ] support request => Please do not submit support request here, instead see https://github.com/angular/angular/blob/master/CONTRIBUTING.md#question\r\n```\r\n\r\n**Current behavior**\r\n\u003c!-- Describe how the bug manifests. -->\r\n`@ContentChildren` somehow gets hold of children that are passed in a template and instantiated through `[ngTemplateOutlet]`, and never gets rid of them even if they are destroyed.\r\n\r\n**Expected behavior**\r\n\u003c!-- Describe what the behavior would be without the bug. -->\r\nI am not sure what the correct behavior for `@ContentChildren` here is (should it see the children or not?) but either way it should not keep a reference to destroyed children. This creates potentially a large memory leak.\r\n\r\n**Minimal reproduction of the problem with instructions**\r\n\u003c!--\r\nIf the current behavior is a bug or you can illustrate your feature request better with an example, \r\nplease provide the *STEPS TO REPRODUCE* and if possible a *MINIMAL DEMO* of the problem via\r\nhttps://plnkr.co or similar (you can use this template as a starting point: http://plnkr.co/edit/tpl:AvJOMERrnz94ekVua0u5).\r\n-->\r\nhttp://plnkr.co/edit/esib13wg0pTmzVEKhNNM?p=preview\r\nClick on the button a few times, you will see that the QueryList keeps growing. On further inspection, you could see that the children in the list are the ones that were destroyed on each previous toggle.\r\n\r\n* **Angular version:** 2.4.9\r\n\u003c!-- Check whether this is still an issue in the most recent Angular version -->\r\n\r\n* **Browser:** all\r\n\u003c!-- All browsers where this could be reproduced -->\r\n \r\n* **Language:** all\r\n","author":{"url":"https://github.com/youdz","@type":"Person","name":"youdz"},"datePublished":"2017-03-04T02:04:46Z","url":"https://github.com/angular/angular/issues/14919"}
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:12c6e0ee-da75-cdf1-3c8a-0db9cf4702ea |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | DAD6:2F9AA4:BF5C:1018C:6B015A35 |
| html-safe-nonce | a890c47b26ec7cb9d4921732955a6ad8f27c2207c2d7ff6b6898e6313b0e535f |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEQUQ2OjJGOUFBNDpCRjVDOjEwMThDOjZCMDE1QTM1IiwidmlzaXRvcl9pZCI6Ijg2ODU5ODA3Mzk4MjI1MDg1OTciLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 5e5ed038b24f562f6e6a2de54c1125cea75eeb066284bb4874f4a275a807b10d |
| hovercard-subject-tag | issue:211846355 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/angular/angular/14919/issue_layout |
| twitter:image | https://opengraph.githubassets.com/dc6b4cd3b032d545ed34b8b0a5dc03c0dc054eb9324151d0587ea3b9e3119914/angular/angular/issues/14919 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/dc6b4cd3b032d545ed34b8b0a5dc03c0dc054eb9324151d0587ea3b9e3119914/angular/angular/issues/14919 |
| og:image:alt | I'm submitting a ... (check one with "x") [x] bug report => search github for a similar issue or PR before submitting [ ] feature request [ ] support request => Please do not submit support request... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | youdz |
| hostname | github.com |
| expected-hostname | github.com |
| None | cc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c |
| turbo-cache-control | no-preview |
| go-import | github.com/angular/angular git https://github.com/angular/angular.git |
| octolytics-dimension-user_id | 139426 |
| octolytics-dimension-user_login | angular |
| octolytics-dimension-repository_id | 24195339 |
| octolytics-dimension-repository_nwo | angular/angular |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 24195339 |
| octolytics-dimension-repository_network_root_nwo | angular/angular |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 8c77c9e8439031ad54c75a250694842892f693e1 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | issues |
Links:
Viewport: width=device-width