Title: Confusing DI behavior for ChangeDetectorRef · Issue #14656 · angular/angular · GitHub
Open Graph Title: Confusing DI behavior for ChangeDetectorRef · Issue #14656 · angular/angular
X Title: Confusing DI behavior for ChangeDetectorRef · Issue #14656 · angular/angular
Description: I'm submitting a ... (check one with "x") [x] bug report => search github for a similar issue or PR before submitting [ ] feature request [ ] support request => Please do not submit support request here, instead see https://github.com/an...
Open Graph Description: I'm submitting a ... (check one with "x") [x] bug report => search github for a similar issue or PR before submitting [ ] feature request [ ] support request => Please do not submit support request...
X Description: I'm submitting a ... (check one with "x") [x] bug report => search github for a similar issue or PR before submitting [ ] feature request [ ] support request => Please do not su...
Opengraph URL: https://github.com/angular/angular/issues/14656
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Confusing DI behavior for ChangeDetectorRef","articleBody":"**I'm submitting a ...** (check one with \"x\")\r\n```\r\n[x] bug report => search github for a similar issue or PR before submitting\r\n[ ] feature request\r\n[ ] support request => Please do not submit support request here, instead see https://github.com/angular/angular/blob/master/CONTRIBUTING.md#question\r\n```\r\n\r\n**Current behavior**\r\nI'm not sure this is a bug. If it is, please fix. If not, please clarify the documentation OR (preferrably imo) change the behavior.\r\n\r\nThis works (no exception thrown)\r\n```typescript\r\n@Injectable()\r\nclass MySvc {\r\n constructor(cdr:ChangeDetectorRef) {}\r\n}\r\n\r\n@Component({\r\n ...\r\n providers: [MySvc]\r\n}) \r\nclass MyComponent {\r\n constructor() {m:MySvc}\r\n}\r\n```\r\n\r\n...whereas this doesn't (it throws a NoProviderError)\r\n\r\n```typescript\r\n// app.module.ts\r\n@NgModule({\r\n ...,\r\n providers: [{\r\n provide: MyService,\r\n deps: [ChangeDetectorRef],\r\n useFactory: cdr => new MyService(cdr)\r\n }]\r\n})\r\n\r\n// my-component.ts\r\n@Component({...}) \r\nclass MyComponent {\r\n constructor() {m:MySvc}\r\n}\r\n```\r\n\r\nFurthermore, this results in an error (which also seems surprising)\r\n\r\n```typescript\r\n@Component({...})\r\nclass MyComponent {\r\n constructor(inj:Injector, cdRef:ChangeDetectorRef) {\r\n inj.get(ChangeDetectorRef);\r\n }\r\n}\r\n```\r\n\r\n**Expected behavior**\r\nI would expect all these things to work. But it seems `ChangeDetectorRef` (and other types close to view creation?) are special. They aren't injected normally and sometimes work and sometimes not, with very surprising results. \r\n\r\nSo wish list is, in priority order:\r\n1. Make changes so that these examples actually work, by always providing the `ChangeDetectorRef` (and potentially other injectables) to the component injector.\r\n2. Document which classes are special and why\r\n\r\n**What is the motivation / use case for changing the behavior?**\r\nI, and others, find it strange and run into confusing behavior.\r\n\r\n* **Angular version:** \r\n2.4.2\r\n","author":{"url":"https://github.com/staeke","@type":"Person","name":"staeke"},"datePublished":"2017-02-22T22:35:16Z","url":"https://github.com/angular/angular/issues/14656"}
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:a3e6f96a-0a57-a9f4-bfb3-6b70c21ddea7 |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | C100:A99C2:1F0D83D:2786A25:6B015281 |
| html-safe-nonce | a21d66c1dd50fc87791a2d4ead044bace27369d016d16c13d415669f2a59d1e8 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDMTAwOkE5OUMyOjFGMEQ4M0Q6Mjc4NkEyNTo2QjAxNTI4MSIsInZpc2l0b3JfaWQiOiI3ODEwODc1ODk2MjIyNTM2MzIxIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | 99c6fa3054474171e4b7f8f716b5937963a4dd4102b04171c3414895b99846db |
| hovercard-subject-tag | issue:209603660 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/angular/angular/14656/issue_layout |
| twitter:image | https://opengraph.githubassets.com/6a3f3089e71d4507861454e49c1970e9a8fe4b93a68a12cbff52ffdffdae0e23/angular/angular/issues/14656 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/6a3f3089e71d4507861454e49c1970e9a8fe4b93a68a12cbff52ffdffdae0e23/angular/angular/issues/14656 |
| og:image:alt | I'm submitting a ... (check one with "x") [x] bug report => search github for a similar issue or PR before submitting [ ] feature request [ ] support request => Please do not submit support request... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | staeke |
| hostname | github.com |
| expected-hostname | github.com |
| None | cc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c |
| turbo-cache-control | no-preview |
| go-import | github.com/angular/angular git https://github.com/angular/angular.git |
| octolytics-dimension-user_id | 139426 |
| octolytics-dimension-user_login | angular |
| octolytics-dimension-repository_id | 24195339 |
| octolytics-dimension-repository_nwo | angular/angular |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 24195339 |
| octolytics-dimension-repository_network_root_nwo | angular/angular |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 8c77c9e8439031ad54c75a250694842892f693e1 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | issues |
Links:
Viewport: width=device-width