Title: Angular 1 unit tests fail with Angular 2 components using downgradeComponents · Issue #14263 · angular/angular · GitHub
Open Graph Title: Angular 1 unit tests fail with Angular 2 components using downgradeComponents · Issue #14263 · angular/angular
X Title: Angular 1 unit tests fail with Angular 2 components using downgradeComponents · Issue #14263 · angular/angular
Description: I'm submitting a ... (check one with "x") [x] bug report => search github for a similar issue or PR before submitting [ ] feature request [ ] support request => Please do not submit support request here, instead see https://github.com/an...
Open Graph Description: I'm submitting a ... (check one with "x") [x] bug report => search github for a similar issue or PR before submitting [ ] feature request [ ] support request => Please do not submit support request...
X Description: I'm submitting a ... (check one with "x") [x] bug report => search github for a similar issue or PR before submitting [ ] feature request [ ] support request => Please do not su...
Opengraph URL: https://github.com/angular/angular/issues/14263
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Angular 1 unit tests fail with Angular 2 components using downgradeComponents","articleBody":"\u003c!--\r\nIF YOU DON'T FILL OUT THE FOLLOWING INFORMATION WE MIGHT CLOSE YOUR ISSUE WITHOUT INVESTIGATING\r\n-->\r\n\r\n**I'm submitting a ...** (check one with \"x\")\r\n```\r\n[x] bug report => search github for a similar issue or PR before submitting\r\n[ ] feature request\r\n[ ] support request => Please do not submit support request here, instead see https://github.com/angular/angular/blob/master/CONTRIBUTING.md#question\r\n```\r\n\r\n**Current behavior**\r\n\u003c!-- Describe how the bug manifests. -->\r\nWe are using the current documented way of downgrading Angular 2 components with the `UpgradeModule` for use in an Angular 1 hybrid app, specifically an angular 1 component. We have unit tests that uses `$compile` to create an element with our angular 1 component which itself uses a downgraded angular 2 component, which is downgraded with `downgradeComponent` in the static upgrade as opposed to the one in `UpgradeAdapter`. This works with interacting with the app in the browser. However, an error pops up in the unit test that says `Error: [$injector:unpr] Unknown Provider $$angularInjectorProvider`.\r\n\r\nThe error was previous documented here:\r\nhttp://stackoverflow.com/questions/41128236/angular-2-unknown-provider-angularinjectorprovider-when-unit-testing-with\r\n\r\nA possible hacky solution here was to call `beforeEach(angular.mock.module('$$UpgradeModule'))`. While the error is gone, the unit tests still fail because changes are not being detected in the downgraded angular 2 component.\r\n\r\nThere seems to a fix in 2fc056098804e660a6788802291fd99a979ef62e that fixed the issue in #5462, but that is for the `UpgradeAdapter` and not for `UpgradeModule`.\r\n\r\n**Expected behavior**\r\n\u003c!-- Describe what the behavior would be without the bug. -->\r\n\r\nExisting angular 1 unit tests should be able to test angular 1 components that have angular 2 downgraded components without failing.\r\n\r\n**Minimal reproduction of the problem with instructions**\r\n\u003c!--\r\nIf the current behavior is a bug or you can illustrate your feature request better with an example, \r\nplease provide the *STEPS TO REPRODUCE* and if possible a *MINIMAL DEMO* of the problem via\r\nhttps://plnkr.co or similar (you can use this template as a starting point: http://plnkr.co/edit/tpl:AvJOMERrnz94ekVua0u5).\r\n-->\r\n\r\n**What is the motivation / use case for changing the behavior?**\r\n\u003c!-- Describe the motivation or the concrete use case -->\r\n\r\n**Please tell us about your environment:**\r\n\u003c!-- Operating system, IDE, package manager, HTTP server, ... -->\r\n\r\n* **Angular version:** 2.0.X\r\n\u003c!-- Check whether this is still an issue in the most recent Angular version -->\r\n\r\n* **Browser:** [all | Chrome XX | Firefox XX | IE XX | Safari XX | Mobile Chrome XX | Android X.X Web Browser | iOS XX Safari | iOS XX UIWebView | iOS XX WKWebView ]\r\n\u003c!-- All browsers where this could be reproduced -->\r\n \r\n* **Language:** [all | TypeScript X.X | ES6/7 | ES5]\r\n\r\n* **Node (for AoT issues):** `node --version` = \r\n","author":{"url":"https://github.com/Rhathe","@type":"Person","name":"Rhathe"},"datePublished":"2017-02-02T23:50:56Z","url":"https://github.com/angular/angular/issues/14263"}
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:a0b6e16c-05a1-8341-9523-b29912bba551 |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | DA4C:2AAD2E:31503CC:41D458B:6B01EF9A |
| html-safe-nonce | a016b7543d757f92db2ed86fb59b556de56d9b31711b0d0deae06e8c114a605a |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEQTRDOjJBQUQyRTozMTUwM0NDOjQxRDQ1OEI6NkIwMUVGOUEiLCJ2aXNpdG9yX2lkIjoiODIyNDk4Mjk4OTIwMTg2MjU1NCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 14350efa98342f31f4e913076ea86bae87aadc1c6d913e40aad9a9d4c95c487f |
| hovercard-subject-tag | issue:205032988 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/angular/angular/14263/issue_layout |
| twitter:image | https://opengraph.githubassets.com/55ba4050f218a94e48dc28601d2cb2c24ed34ef7224453060a278faced5d72f2/angular/angular/issues/14263 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/55ba4050f218a94e48dc28601d2cb2c24ed34ef7224453060a278faced5d72f2/angular/angular/issues/14263 |
| og:image:alt | I'm submitting a ... (check one with "x") [x] bug report => search github for a similar issue or PR before submitting [ ] feature request [ ] support request => Please do not submit support request... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | Rhathe |
| hostname | github.com |
| expected-hostname | github.com |
| None | 87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456 |
| turbo-cache-control | no-preview |
| go-import | github.com/angular/angular git https://github.com/angular/angular.git |
| octolytics-dimension-user_id | 139426 |
| octolytics-dimension-user_login | angular |
| octolytics-dimension-repository_id | 24195339 |
| octolytics-dimension-repository_nwo | angular/angular |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 24195339 |
| octolytics-dimension-repository_network_root_nwo | angular/angular |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 423dbb54c5e7bfecc838eb387c1435eb3d0e760d |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | issues |
Links:
Viewport: width=device-width