René's URL Explorer Experiment


Title: Angular 1 unit tests fail with Angular 2 components using downgradeComponents · Issue #14263 · angular/angular · GitHub

Open Graph Title: Angular 1 unit tests fail with Angular 2 components using downgradeComponents · Issue #14263 · angular/angular

X Title: Angular 1 unit tests fail with Angular 2 components using downgradeComponents · Issue #14263 · angular/angular

Description: I'm submitting a ... (check one with "x") [x] bug report => search github for a similar issue or PR before submitting [ ] feature request [ ] support request => Please do not submit support request here, instead see https://github.com/an...

Open Graph Description: I'm submitting a ... (check one with "x") [x] bug report => search github for a similar issue or PR before submitting [ ] feature request [ ] support request => Please do not submit support request...

X Description: I'm submitting a ... (check one with "x") [x] bug report => search github for a similar issue or PR before submitting [ ] feature request [ ] support request => Please do not su...

Opengraph URL: https://github.com/angular/angular/issues/14263

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Angular 1 unit tests fail with Angular 2 components using downgradeComponents","articleBody":"\u003c!--\r\nIF YOU DON'T FILL OUT THE FOLLOWING INFORMATION WE MIGHT CLOSE YOUR ISSUE WITHOUT INVESTIGATING\r\n-->\r\n\r\n**I'm submitting a ...**  (check one with \"x\")\r\n```\r\n[x] bug report => search github for a similar issue or PR before submitting\r\n[ ] feature request\r\n[ ] support request => Please do not submit support request here, instead see https://github.com/angular/angular/blob/master/CONTRIBUTING.md#question\r\n```\r\n\r\n**Current behavior**\r\n\u003c!-- Describe how the bug manifests. -->\r\nWe are using the current documented way of downgrading Angular 2 components with the `UpgradeModule` for use in an Angular 1 hybrid app, specifically an angular 1 component. We have unit tests that uses `$compile` to create an element with our angular 1 component which itself uses a downgraded angular 2 component, which is downgraded with `downgradeComponent` in the static upgrade as opposed to the one in `UpgradeAdapter`. This works with interacting with the app in the browser. However, an error pops up in the unit test that says `Error: [$injector:unpr] Unknown Provider $$angularInjectorProvider`.\r\n\r\nThe error was previous documented here:\r\nhttp://stackoverflow.com/questions/41128236/angular-2-unknown-provider-angularinjectorprovider-when-unit-testing-with\r\n\r\nA possible hacky solution here was to call `beforeEach(angular.mock.module('$$UpgradeModule'))`. While the error is gone, the unit tests still fail because changes are not being detected in the downgraded angular 2 component.\r\n\r\nThere seems to a fix in 2fc056098804e660a6788802291fd99a979ef62e that fixed the issue in #5462, but that is for the `UpgradeAdapter` and not for `UpgradeModule`.\r\n\r\n**Expected behavior**\r\n\u003c!-- Describe what the behavior would be without the bug. -->\r\n\r\nExisting angular 1 unit tests should be able to test angular 1 components that have angular 2 downgraded components without failing.\r\n\r\n**Minimal reproduction of the problem with instructions**\r\n\u003c!--\r\nIf the current behavior is a bug or you can illustrate your feature request better with an example, \r\nplease provide the *STEPS TO REPRODUCE* and if possible a *MINIMAL DEMO* of the problem via\r\nhttps://plnkr.co or similar (you can use this template as a starting point: http://plnkr.co/edit/tpl:AvJOMERrnz94ekVua0u5).\r\n-->\r\n\r\n**What is the motivation / use case for changing the behavior?**\r\n\u003c!-- Describe the motivation or the concrete use case -->\r\n\r\n**Please tell us about your environment:**\r\n\u003c!-- Operating system, IDE, package manager, HTTP server, ... -->\r\n\r\n* **Angular version:** 2.0.X\r\n\u003c!-- Check whether this is still an issue in the most recent Angular version -->\r\n\r\n* **Browser:** [all | Chrome XX | Firefox XX | IE XX | Safari XX | Mobile Chrome XX | Android X.X Web Browser | iOS XX Safari | iOS XX UIWebView | iOS XX WKWebView ]\r\n\u003c!-- All browsers where this could be reproduced -->\r\n \r\n* **Language:** [all | TypeScript X.X | ES6/7 | ES5]\r\n\r\n* **Node (for AoT issues):** `node --version` =   \r\n","author":{"url":"https://github.com/Rhathe","@type":"Person","name":"Rhathe"},"datePublished":"2017-02-02T23:50:56Z","url":"https://github.com/angular/angular/issues/14263"}

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:a0b6e16c-05a1-8341-9523-b29912bba551
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-idDA4C:2AAD2E:31503CC:41D458B:6B01EF9A
html-safe-noncea016b7543d757f92db2ed86fb59b556de56d9b31711b0d0deae06e8c114a605a
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEQTRDOjJBQUQyRTozMTUwM0NDOjQxRDQ1OEI6NkIwMUVGOUEiLCJ2aXNpdG9yX2lkIjoiODIyNDk4Mjk4OTIwMTg2MjU1NCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac14350efa98342f31f4e913076ea86bae87aadc1c6d913e40aad9a9d4c95c487f
hovercard-subject-tagissue:205032988
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/angular/angular/14263/issue_layout
twitter:imagehttps://opengraph.githubassets.com/55ba4050f218a94e48dc28601d2cb2c24ed34ef7224453060a278faced5d72f2/angular/angular/issues/14263
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/55ba4050f218a94e48dc28601d2cb2c24ed34ef7224453060a278faced5d72f2/angular/angular/issues/14263
og:image:altI'm submitting a ... (check one with "x") [x] bug report => search github for a similar issue or PR before submitting [ ] feature request [ ] support request => Please do not submit support request...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameRhathe
hostnamegithub.com
expected-hostnamegithub.com
None87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456
turbo-cache-controlno-preview
go-importgithub.com/angular/angular git https://github.com/angular/angular.git
octolytics-dimension-user_id139426
octolytics-dimension-user_loginangular
octolytics-dimension-repository_id24195339
octolytics-dimension-repository_nwoangular/angular
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id24195339
octolytics-dimension-repository_network_root_nwoangular/angular
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release423dbb54c5e7bfecc838eb387c1435eb3d0e760d
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-nameissues

Links:

Skip to contenthttps://github.com/angular/angular/issues/14263#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fissues%2F14263
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fissues%2F14263
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=angular%2Fangular
Reloadhttps://github.com/angular/angular/issues/14263
Reloadhttps://github.com/angular/angular/issues/14263
Reloadhttps://github.com/angular/angular/issues/14263
angularhttps://github.com/angular
angularhttps://github.com/angular/angular
Codehttps://github.com/angular/angular
Issues835 (835)https://github.com/angular/angular/issues
Pull requests142 (142)https://github.com/angular/angular/pulls
Discussionshttps://github.com/angular/angular/discussions
Actionshttps://github.com/angular/angular/actions
Projectshttps://github.com/angular/angular/projects
Security and quality40 (40)https://github.com/angular/angular/security
Insightshttps://github.com/angular/angular/insights
https://github.com/angular/angular
New issuehttps://github.com/login?return_to=https://github.com/angular/angular/issues/14263
New issuehttps://github.com/login?return_to=https://github.com/angular/angular/issues/14263
Angular 1 unit tests fail with Angular 2 components using downgradeComponentshttps://github.com/angular/angular/issues/14263#top
https://github.com/Rhathe
Rhathehttps://github.com/Rhathe
on Feb 2, 2017https://github.com/angular/angular/issues/14263#issue-205032988
http://stackoverflow.com/questions/41128236/angular-2-unknown-provider-angularinjectorprovider-when-unit-testing-withhttp://stackoverflow.com/questions/41128236/angular-2-unknown-provider-angularinjectorprovider-when-unit-testing-with
2fc0560https://github.com/angular/angular/commit/2fc056098804e660a6788802291fd99a979ef62e
#5462https://github.com/angular/angular/issues/5462
https://github.com/jwoos
jwooshttps://github.com/jwoos
on Feb 3, 2017https://github.com/angular/angular/issues/14263#issuecomment-277384489
https://github.com/sshev
sshevhttps://github.com/sshev
on Feb 7, 2017https://github.com/angular/angular/issues/14263#issuecomment-277984421
https://github.com/dkanev
dkanevhttps://github.com/dkanev
on Feb 7, 2017https://github.com/angular/angular/issues/14263#issuecomment-278031740
https://github.com/ronwang01
ronwang01https://github.com/ronwang01
on Feb 14, 2017https://github.com/angular/angular/issues/14263#issuecomment-279789833
https://github.com/djpark
djparkhttps://github.com/djpark
on Feb 15, 2017https://github.com/angular/angular/issues/14263#issuecomment-279885841
https://github.com/idoglik6
idoglik6https://github.com/idoglik6
on Mar 1, 2017https://github.com/angular/angular/issues/14263#issuecomment-283303668
https://github.com/bh86
bh86https://github.com/bh86
on Mar 1, 2017https://github.com/angular/angular/issues/14263#issuecomment-283317493
https://github.com/ninaneter
ninaneterhttps://github.com/ninaneter
on Mar 1, 2017https://github.com/angular/angular/issues/14263#issuecomment-283317714
https://github.com/moanrose
moanrosehttps://github.com/moanrose
on Mar 13, 2017https://github.com/angular/angular/issues/14263#issuecomment-286038147
tboschhttps://github.com/tbosch
comp: upgrade/statichttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22comp%3A%20upgrade%2Fstatic%22
on Apr 10, 2017https://github.com/angular/angular/issues/14263#event-1036946629
https://github.com/amosuro
amosurohttps://github.com/amosuro
on May 12, 2017https://github.com/angular/angular/issues/14263#issuecomment-301023010
https://github.com/nikolay-lesko
nikolay-leskohttps://github.com/nikolay-lesko
on May 15, 2017https://github.com/angular/angular/issues/14263#issuecomment-301429186
https://github.com/gkalpak
gkalpakhttps://github.com/gkalpak
on Jul 4, 2017https://github.com/angular/angular/issues/14263#issuecomment-312956211
#16848https://github.com/angular/angular/pull/16848
https://github.com/gkalpak
gkalpakhttps://github.com/gkalpak
on Dec 15, 2017https://github.com/angular/angular/issues/14263#issuecomment-351992328
#16848https://github.com/angular/angular/pull/16848
gkalpakhttps://github.com/gkalpak
completedhttps://github.com/angular/angular/issues?q=is%3Aissue%20state%3Aclosed%20archived%3Afalse%20reason%3Acompleted
on Dec 15, 2017https://github.com/angular/angular/issues/14263#event-1389510557
https://github.com/apps/angular-automatic-lock-bot
angular-automatic-lock-bothttps://github.com/apps/angular-automatic-lock-bot
on Sep 13, 2019https://github.com/angular/angular/issues/14263#issuecomment-531069445
automatic conversation locking policyhttps://github.com/angular/angular/blob/67d80f/docs/GITHUB_PROCESS.md#conversation-locking
angular-automatic-lock-bothttps://github.com/apps/angular-automatic-lock-bot
on Sep 13, 2019https://github.com/angular/angular/issues/14263#event-2631004512
Sign up for freehttps://github.com/signup?return_to=https://github.com/angular/angular/issues/14263
Sign in to commenthttps://github.com/login?return_to=https://github.com/angular/angular/issues/14263
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.