Title: select html element doesn't react to changes of model in component code. · Issue #14121 · angular/angular · GitHub
Open Graph Title: select html element doesn't react to changes of model in component code. · Issue #14121 · angular/angular
X Title: select html element doesn't react to changes of model in component code. · Issue #14121 · angular/angular
Description: I'm submitting a ... (check one with "x") [x ] bug report => search github for a similar issue or PR before submitting [ ] feature request [ ] support request => Please do not submit support request here, instead see https://github.com/a...
Open Graph Description: I'm submitting a ... (check one with "x") [x ] bug report => search github for a similar issue or PR before submitting [ ] feature request [ ] support request => Please do not submit support reques...
X Description: I'm submitting a ... (check one with "x") [x ] bug report => search github for a similar issue or PR before submitting [ ] feature request [ ] support request => Please do not s...
Opengraph URL: https://github.com/angular/angular/issues/14121
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"select html element doesn't react to changes of model in component code.","articleBody":"\u003c!--\r\nIF YOU DON'T FILL OUT THE FOLLOWING INFORMATION WE MIGHT CLOSE YOUR ISSUE WITHOUT INVESTIGATING\r\n-->\r\n\r\n**I'm submitting a ...** (check one with \"x\")\r\n```\r\n[x ] bug report => search github for a similar issue or PR before submitting\r\n[ ] feature request\r\n[ ] support request => Please do not submit support request here, instead see https://github.com/angular/angular/blob/master/CONTRIBUTING.md#question\r\n```\r\n\r\n**Current behavior**\r\n\u003c!-- Describe how the bug manifests. -->\r\n\r\n `select` HTML element doesn't react to changes of model (like when we do `this.selectedValue = obj;` in component, when in template we have `[(ngModel)]=\"selectedValue\"`). Therefore, initial `select` value is not proper.\r\n\r\n**Expected behavior**\r\n\u003c!-- Describe what the behavior would be without the bug. -->\r\n\r\nThis code should initialize value of `select` HTML element properly, i.e. listen to `selectedValue` changes and select proper option.\r\n\r\n**Minimal reproduction of the problem with instructions**\r\n\u003c!--\r\nIf the current behavior is a bug or you can illustrate your feature request better with an example, \r\nplease provide the *STEPS TO REPRODUCE* and if possible a *MINIMAL DEMO* of the problem via\r\nhttps://plnkr.co or similar (you can use this template as a starting point: http://plnkr.co/edit/tpl:AvJOMERrnz94ekVua0u5).\r\n-->\r\n\r\nI have the next code\r\n\r\n**choice-input.view.html**\r\n```javascript\r\n\u003cselect *ngIf=\"!options.multiple\" class=\"form-control\" [(ngModel)]=\"selectedValue\" (blur)=\"onTouchedCallback()\">\r\n \u003coption value=\"\" [disabled]=\"options.required\" [ngValue]=\"null\">No value\u003c/option>\r\n \u003coption *ngFor=\"let choice of options.choices\" [ngValue]=\"choice.value\">{{choice.label | trans }}\u003c/option>\r\n\u003c/select>\r\n```\r\n\r\n**choice-input.component.ts**\r\n```\r\nimport {Component, forwardRef, Input, Renderer, ViewChild, ElementRef} from \"@angular/core\";\r\nimport {ControlValueAccessor, NG_VALUE_ACCESSOR} from \"@angular/forms\";\r\nimport * as _ from \"lodash\";\r\nimport {ModelStore} from \"../../sio-model-module/store/model.store\";\r\nimport {QueryClient} from \"../../sio-dynamic-list-module/client/query.client\";\r\nimport {QueryResult} from \"../../sio-dynamic-list-module/model/query-result.interface\";\r\nimport {ReplaySubject} from \"rxjs/ReplaySubject\";\r\nimport {QueryRequest} from \"../../sio-dynamic-list-module/model/query-request.interface\";\r\n\r\n\r\n@Component(\r\n {\r\n selector: 'sio-form-choice-input',\r\n templateUrl: 'choice-input.view.html',\r\n providers: [\r\n { provide: NG_VALUE_ACCESSOR, useExisting: forwardRef(() => ChoiceInputComponent), multi: true }\r\n ]\r\n }\r\n)\r\nexport class ChoiceInputComponent implements ControlValueAccessor\r\n{\r\n protected choices: any[];\r\n protected selected: any;\r\n\r\n protected defaults: any = {\r\n choices: [],\r\n multiple: false,\r\n expanded: false,\r\n };\r\n\r\n _options: any;\r\n\r\n protected onChangeCallback: (value: any) => void = (() => {}); // Empty callback (does nothing)\r\n protected onTouchedCallback: () => void = (() => {}); // Empty callback (does nothing)\r\n\r\n protected onChoicesLoaded: ReplaySubject\u003cany> = new ReplaySubject\u003cany>(1);\r\n\r\n constructor(protected modelStore: ModelStore, protected renderer: Renderer, protected queryClient: QueryClient)\r\n {\r\n }\r\n\r\n @Input('options')\r\n get options(): any\r\n {\r\n return this._options;\r\n }\r\n\r\n set options(options: any)\r\n {\r\n this._options = _.extend({}, this.defaults, options);\r\n\r\n this.loadChoiceItems();\r\n }\r\n\r\n get selectedValue(): any {\r\n return this.selected;\r\n };\r\n\r\n set selectedValue(newValue: any) {\r\n if (!_.isEqual(newValue, this.selected)) {\r\n this.writeValue(newValue);\r\n this.onChangeCallback(newValue);\r\n }\r\n };\r\n\r\n writeValue(newValue: any)\r\n {\r\n // Wait until possible choices are loaded and then set current choice\r\n\r\n this.onChoicesLoaded.subscribe((status) => {\r\n if (_.isEqual(newValue, this.selected)) {\r\n return;\r\n }\r\n\r\n this.selected = newValue;\r\n });\r\n }\r\n\r\n registerOnChange(fn: any)\r\n {\r\n this.onChangeCallback = fn;\r\n }\r\n\r\n registerOnTouched(fn: any)\r\n {\r\n this.onTouchedCallback = fn;\r\n }\r\n\r\n private loadChoiceItems()\r\n {\r\n // Some complicated logic for loading this.options.choices\r\n // After it is done, this.onChoicesLoaded.next('loaded.choices.query.model'); is being executed \r\n }\r\n}\r\n```\r\n\r\n**What is the motivation / use case for changing the behavior?**\r\n\u003c!-- Describe the motivation or the concrete use case -->\r\nI want to make `select` html element work with objects that have structure `{id:'some-id',modelId:'some-other-id'}` without any additional effort with binding/updating values from my side.\r\n\r\n**Please tell us about your environment:**\r\n\u003c!-- Operating system, IDE, package manager, HTTP server, ... -->\r\n\r\n* **Angular version:** 2.4.5\r\n\u003c!-- Check whether this is still an issue in the most recent Angular version -->\r\n\r\n* **Browser:** [all | Chrome XX | Firefox XX | IE XX | Safari XX | Mobile Chrome XX | Android X.X Web Browser | iOS XX Safari | iOS XX UIWebView | iOS XX WKWebView ]\r\n\u003c!-- All browsers where this could be reproduced -->\r\nall \r\n\r\n* **Language:** [all | TypeScript X.X | ES6/7 | ES5]\r\nTypeScript 2.1.5\r\n\r\n* **Node (for AoT issues):** `node --version` = \r\n7.4.0","author":{"url":"https://github.com/dmytro-y-dev","@type":"Person","name":"dmytro-y-dev"},"datePublished":"2017-01-26T17:55:18Z","url":"https://github.com/angular/angular/issues/14121"}
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:86053b45-c7c0-f8d7-76fd-e9ea8fc1ee21 |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | C39C:25598F:13BE5D4:1A11B5C:6B0122C7 |
| html-safe-nonce | 606535efdc64ce8b5ed4f56d39af38dc698cf2be9894a8385b900dfd2ffefcbc |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDMzlDOjI1NTk4RjoxM0JFNUQ0OjFBMTFCNUM6NkIwMTIyQzciLCJ2aXNpdG9yX2lkIjoiOTkxODY1NTQ4OTQ4ODU1NzUiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | a16db8f3eab53c5ce01c2f0dc46f96ee83bf70d42e3436a3c29dea7cb638dd2b |
| hovercard-subject-tag | issue:203442453 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/angular/angular/14121/issue_layout |
| twitter:image | https://opengraph.githubassets.com/bef771e813656a67e1d43e043a8e3c3e85f144734cd5c061578ef3affcd24d36/angular/angular/issues/14121 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/bef771e813656a67e1d43e043a8e3c3e85f144734cd5c061578ef3affcd24d36/angular/angular/issues/14121 |
| og:image:alt | I'm submitting a ... (check one with "x") [x ] bug report => search github for a similar issue or PR before submitting [ ] feature request [ ] support request => Please do not submit support reques... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | dmytro-y-dev |
| hostname | github.com |
| expected-hostname | github.com |
| None | cc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c |
| turbo-cache-control | no-preview |
| go-import | github.com/angular/angular git https://github.com/angular/angular.git |
| octolytics-dimension-user_id | 139426 |
| octolytics-dimension-user_login | angular |
| octolytics-dimension-repository_id | 24195339 |
| octolytics-dimension-repository_nwo | angular/angular |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 24195339 |
| octolytics-dimension-repository_network_root_nwo | angular/angular |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 8c77c9e8439031ad54c75a250694842892f693e1 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | issues |
Links:
Viewport: width=device-width