René's URL Explorer Experiment


Title: select html element doesn't react to changes of model in component code. · Issue #14121 · angular/angular · GitHub

Open Graph Title: select html element doesn't react to changes of model in component code. · Issue #14121 · angular/angular

X Title: select html element doesn't react to changes of model in component code. · Issue #14121 · angular/angular

Description: I'm submitting a ... (check one with "x") [x ] bug report => search github for a similar issue or PR before submitting [ ] feature request [ ] support request => Please do not submit support request here, instead see https://github.com/a...

Open Graph Description: I'm submitting a ... (check one with "x") [x ] bug report => search github for a similar issue or PR before submitting [ ] feature request [ ] support request => Please do not submit support reques...

X Description: I'm submitting a ... (check one with "x") [x ] bug report => search github for a similar issue or PR before submitting [ ] feature request [ ] support request => Please do not s...

Opengraph URL: https://github.com/angular/angular/issues/14121

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"select  html element doesn't react to changes of model in component code.","articleBody":"\u003c!--\r\nIF YOU DON'T FILL OUT THE FOLLOWING INFORMATION WE MIGHT CLOSE YOUR ISSUE WITHOUT INVESTIGATING\r\n-->\r\n\r\n**I'm submitting a ...**  (check one with \"x\")\r\n```\r\n[x ] bug report => search github for a similar issue or PR before submitting\r\n[ ] feature request\r\n[ ] support request => Please do not submit support request here, instead see https://github.com/angular/angular/blob/master/CONTRIBUTING.md#question\r\n```\r\n\r\n**Current behavior**\r\n\u003c!-- Describe how the bug manifests. -->\r\n\r\n `select` HTML element doesn't react to changes of model (like when we do `this.selectedValue = obj;` in component, when in template we have `[(ngModel)]=\"selectedValue\"`). Therefore, initial `select` value is not proper.\r\n\r\n**Expected behavior**\r\n\u003c!-- Describe what the behavior would be without the bug. -->\r\n\r\nThis code should initialize value of `select` HTML element properly, i.e. listen to `selectedValue` changes and select proper option.\r\n\r\n**Minimal reproduction of the problem with instructions**\r\n\u003c!--\r\nIf the current behavior is a bug or you can illustrate your feature request better with an example, \r\nplease provide the *STEPS TO REPRODUCE* and if possible a *MINIMAL DEMO* of the problem via\r\nhttps://plnkr.co or similar (you can use this template as a starting point: http://plnkr.co/edit/tpl:AvJOMERrnz94ekVua0u5).\r\n-->\r\n\r\nI have the next code\r\n\r\n**choice-input.view.html**\r\n```javascript\r\n\u003cselect *ngIf=\"!options.multiple\" class=\"form-control\" [(ngModel)]=\"selectedValue\" (blur)=\"onTouchedCallback()\">\r\n        \u003coption value=\"\" [disabled]=\"options.required\" [ngValue]=\"null\">No value\u003c/option>\r\n        \u003coption *ngFor=\"let choice of options.choices\" [ngValue]=\"choice.value\">{{choice.label | trans }}\u003c/option>\r\n\u003c/select>\r\n```\r\n\r\n**choice-input.component.ts**\r\n```\r\nimport {Component, forwardRef, Input, Renderer, ViewChild, ElementRef} from \"@angular/core\";\r\nimport {ControlValueAccessor, NG_VALUE_ACCESSOR} from \"@angular/forms\";\r\nimport * as _ from \"lodash\";\r\nimport {ModelStore} from \"../../sio-model-module/store/model.store\";\r\nimport {QueryClient} from \"../../sio-dynamic-list-module/client/query.client\";\r\nimport {QueryResult} from \"../../sio-dynamic-list-module/model/query-result.interface\";\r\nimport {ReplaySubject} from \"rxjs/ReplaySubject\";\r\nimport {QueryRequest} from \"../../sio-dynamic-list-module/model/query-request.interface\";\r\n\r\n\r\n@Component(\r\n    {\r\n        selector:    'sio-form-choice-input',\r\n        templateUrl: 'choice-input.view.html',\r\n        providers: [\r\n            { provide: NG_VALUE_ACCESSOR, useExisting: forwardRef(() => ChoiceInputComponent), multi: true }\r\n        ]\r\n    }\r\n)\r\nexport class ChoiceInputComponent implements ControlValueAccessor\r\n{\r\n    protected choices: any[];\r\n    protected selected: any;\r\n\r\n    protected defaults: any = {\r\n        choices:  [],\r\n        multiple: false,\r\n        expanded: false,\r\n    };\r\n\r\n    _options: any;\r\n\r\n    protected onChangeCallback:  (value: any) => void = (() => {}); // Empty callback (does nothing)\r\n    protected onTouchedCallback: () => void           = (() => {}); // Empty callback (does nothing)\r\n\r\n    protected onChoicesLoaded: ReplaySubject\u003cany> = new ReplaySubject\u003cany>(1);\r\n\r\n    constructor(protected modelStore: ModelStore, protected renderer: Renderer, protected queryClient: QueryClient)\r\n    {\r\n    }\r\n\r\n    @Input('options')\r\n    get options(): any\r\n    {\r\n        return this._options;\r\n    }\r\n\r\n    set options(options: any)\r\n    {\r\n        this._options = _.extend({}, this.defaults, options);\r\n\r\n        this.loadChoiceItems();\r\n    }\r\n\r\n    get selectedValue(): any {\r\n        return this.selected;\r\n    };\r\n\r\n    set selectedValue(newValue: any) {\r\n        if (!_.isEqual(newValue, this.selected)) {\r\n            this.writeValue(newValue);\r\n            this.onChangeCallback(newValue);\r\n        }\r\n    };\r\n\r\n    writeValue(newValue: any)\r\n    {\r\n        // Wait until possible choices are loaded and then set current choice\r\n\r\n        this.onChoicesLoaded.subscribe((status) => {\r\n            if (_.isEqual(newValue, this.selected)) {\r\n                return;\r\n            }\r\n\r\n            this.selected = newValue;\r\n        });\r\n    }\r\n\r\n    registerOnChange(fn: any)\r\n    {\r\n        this.onChangeCallback = fn;\r\n    }\r\n\r\n    registerOnTouched(fn: any)\r\n    {\r\n        this.onTouchedCallback = fn;\r\n    }\r\n\r\n    private loadChoiceItems()\r\n    {\r\n       // Some complicated logic for loading this.options.choices\r\n       // After it is done, this.onChoicesLoaded.next('loaded.choices.query.model'); is being executed \r\n    }\r\n}\r\n```\r\n\r\n**What is the motivation / use case for changing the behavior?**\r\n\u003c!-- Describe the motivation or the concrete use case -->\r\nI want to make `select` html element work with objects that have structure `{id:'some-id',modelId:'some-other-id'}` without any additional effort with binding/updating values from my side.\r\n\r\n**Please tell us about your environment:**\r\n\u003c!-- Operating system, IDE, package manager, HTTP server, ... -->\r\n\r\n* **Angular version:** 2.4.5\r\n\u003c!-- Check whether this is still an issue in the most recent Angular version -->\r\n\r\n* **Browser:** [all | Chrome XX | Firefox XX | IE XX | Safari XX | Mobile Chrome XX | Android X.X Web Browser | iOS XX Safari | iOS XX UIWebView | iOS XX WKWebView ]\r\n\u003c!-- All browsers where this could be reproduced -->\r\nall \r\n\r\n* **Language:** [all | TypeScript X.X | ES6/7 | ES5]\r\nTypeScript 2.1.5\r\n\r\n* **Node (for AoT issues):** `node --version` =   \r\n7.4.0","author":{"url":"https://github.com/dmytro-y-dev","@type":"Person","name":"dmytro-y-dev"},"datePublished":"2017-01-26T17:55:18Z","url":"https://github.com/angular/angular/issues/14121"}

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:86053b45-c7c0-f8d7-76fd-e9ea8fc1ee21
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-idC39C:25598F:13BE5D4:1A11B5C:6B0122C7
html-safe-nonce606535efdc64ce8b5ed4f56d39af38dc698cf2be9894a8385b900dfd2ffefcbc
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDMzlDOjI1NTk4RjoxM0JFNUQ0OjFBMTFCNUM6NkIwMTIyQzciLCJ2aXNpdG9yX2lkIjoiOTkxODY1NTQ4OTQ4ODU1NzUiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmaca16db8f3eab53c5ce01c2f0dc46f96ee83bf70d42e3436a3c29dea7cb638dd2b
hovercard-subject-tagissue:203442453
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/angular/angular/14121/issue_layout
twitter:imagehttps://opengraph.githubassets.com/bef771e813656a67e1d43e043a8e3c3e85f144734cd5c061578ef3affcd24d36/angular/angular/issues/14121
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/bef771e813656a67e1d43e043a8e3c3e85f144734cd5c061578ef3affcd24d36/angular/angular/issues/14121
og:image:altI'm submitting a ... (check one with "x") [x ] bug report => search github for a similar issue or PR before submitting [ ] feature request [ ] support request => Please do not submit support reques...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamedmytro-y-dev
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-preview
go-importgithub.com/angular/angular git https://github.com/angular/angular.git
octolytics-dimension-user_id139426
octolytics-dimension-user_loginangular
octolytics-dimension-repository_id24195339
octolytics-dimension-repository_nwoangular/angular
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id24195339
octolytics-dimension-repository_network_root_nwoangular/angular
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-nameissues

Links:

Skip to contenthttps://github.com/angular/angular/issues/14121#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fissues%2F14121
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fissues%2F14121
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=angular%2Fangular
Reloadhttps://github.com/angular/angular/issues/14121
Reloadhttps://github.com/angular/angular/issues/14121
Reloadhttps://github.com/angular/angular/issues/14121
angularhttps://github.com/angular
angularhttps://github.com/angular/angular
Codehttps://github.com/angular/angular
Issues835 (835)https://github.com/angular/angular/issues
Pull requests141 (141)https://github.com/angular/angular/pulls
Discussionshttps://github.com/angular/angular/discussions
Actionshttps://github.com/angular/angular/actions
Projectshttps://github.com/angular/angular/projects
Security and quality40 (40)https://github.com/angular/angular/security
Insightshttps://github.com/angular/angular/insights
https://github.com/angular/angular
New issuehttps://github.com/login?return_to=https://github.com/angular/angular/issues/14121
New issuehttps://github.com/login?return_to=https://github.com/angular/angular/issues/14121
select html element doesn't react to changes of model in component code.https://github.com/angular/angular/issues/14121#top
https://github.com/dmytro-y-dev
dmytro-y-devhttps://github.com/dmytro-y-dev
on Jan 26, 2017https://github.com/angular/angular/issues/14121#issue-203442453
https://github.com/DzmitryShylovich
DzmitryShylovichhttps://github.com/DzmitryShylovich
on Jan 26, 2017https://github.com/angular/angular/issues/14121#issuecomment-275462135
#13349https://github.com/angular/angular/pull/13349
https://github.com/dmytro-y-dev
dmytro-y-devhttps://github.com/dmytro-y-dev
on Jan 26, 2017https://github.com/angular/angular/issues/14121#issuecomment-275503686
angular/components#2250 (comment)https://github.com/angular/components/issues/2250#issuecomment-274904991
#13349https://github.com/angular/angular/pull/13349
https://github.com/DzmitryShylovich
DzmitryShylovichhttps://github.com/DzmitryShylovich
on Feb 1, 2017https://github.com/angular/angular/issues/14121#issuecomment-276596183
@pkozlowski-opensourcehttps://github.com/pkozlowski-opensource
#13349https://github.com/angular/angular/pull/13349
pkozlowski-opensourcehttps://github.com/pkozlowski-opensource
completedhttps://github.com/angular/angular/issues?q=is%3Aissue%20state%3Aclosed%20archived%3Afalse%20reason%3Acompleted
on Feb 1, 2017https://github.com/angular/angular/issues/14121#event-944391178
https://github.com/apps/angular-automatic-lock-bot
angular-automatic-lock-bothttps://github.com/apps/angular-automatic-lock-bot
on Sep 10, 2019https://github.com/angular/angular/issues/14121#issuecomment-530037392
automatic conversation locking policyhttps://github.com/angular/angular/blob/67d80f/docs/GITHUB_PROCESS.md#conversation-locking
angular-automatic-lock-bothttps://github.com/apps/angular-automatic-lock-bot
on Sep 10, 2019https://github.com/angular/angular/issues/14121#event-2623068202
Sign up for freehttps://github.com/signup?return_to=https://github.com/angular/angular/issues/14121
Sign in to commenthttps://github.com/login?return_to=https://github.com/angular/angular/issues/14121
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.