René's URL Explorer Experiment


Title: AoT compiler does not recognize type Window (possibly issue with global variables and/or TypeScript built-in libs) · Issue #14050 · angular/angular · GitHub

Open Graph Title: AoT compiler does not recognize type Window (possibly issue with global variables and/or TypeScript built-in libs) · Issue #14050 · angular/angular

X Title: AoT compiler does not recognize type Window (possibly issue with global variables and/or TypeScript built-in libs) · Issue #14050 · angular/angular

Description: I'm submitting a ... (check one with "x") [x] bug report => search github for a similar issue or PR before submitting [ ] feature request [ ] support request => Please do not submit support request here, instead see https://github.com/an...

Open Graph Description: I'm submitting a ... (check one with "x") [x] bug report => search github for a similar issue or PR before submitting [ ] feature request [ ] support request => Please do not submit support request...

X Description: I'm submitting a ... (check one with "x") [x] bug report => search github for a similar issue or PR before submitting [ ] feature request [ ] support request => Please do not su...

Opengraph URL: https://github.com/angular/angular/issues/14050

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"AoT compiler does not recognize type Window (possibly issue with global variables and/or TypeScript built-in libs)","articleBody":"\u003c!--\r\nIF YOU DON'T FILL OUT THE FOLLOWING INFORMATION WE MIGHT CLOSE YOUR ISSUE WITHOUT INVESTIGATING\r\n-->\r\n\r\n**I'm submitting a ...**  (check one with \"x\")\r\n```\r\n[x] bug report => search github for a similar issue or PR before submitting\r\n[ ] feature request\r\n[ ] support request => Please do not submit support request here, instead see https://github.com/angular/angular/blob/master/CONTRIBUTING.md#question\r\n```\r\n\r\n**Current behavior**\r\n\u003c!-- Describe how the bug manifests. -->\r\n\r\nThe following would fail:\r\n\r\n```\r\nexport function getWindow() { return window; }\r\n\r\n@NgModule({\r\n  declarations: [\r\n    AppComponent,\r\n    SimpleRouteComponent\r\n  ],\r\n  imports: [\r\n    BrowserModule,\r\n    FormsModule,\r\n    HttpModule,\r\n    AppRoutingModule\r\n  ],\r\n  providers: [\r\n    {provide: 'window', useFactory: getWindow}\r\n  ],\r\n  bootstrap: [AppComponent]\r\n})\r\nexport class AppModule {\r\n  constructor(@Inject('window') w: Window) {\r\n    console.log(w);\r\n  }\r\n\r\n}\r\n```\r\n\r\nWith error\r\n\r\n> ERROR in Error encountered resolving symbol values statically. Could not resolve type Window (position 29:36 in the original .ts file), resolving symbol AppModule in /Users/Meligy/Code/github/Meligy/routing-angular-cli/src/app/app.module.ts\r\n\r\n**Expected behavior**\r\n\u003c!-- Describe what the behavior would be without the bug. -->\r\n\r\nI'd expect the AoT compiler to be able to understand \r\n\r\n**Minimal reproduction of the problem with instructions**\r\n\u003c!--\r\nIf the current behavior is a bug or you can illustrate your feature request better with an example, \r\nplease provide the *STEPS TO REPRODUCE* and if possible a *MINIMAL DEMO* of the problem via\r\nhttps://plnkr.co or similar (you can use this template as a starting point: http://plnkr.co/edit/tpl:AvJOMERrnz94ekVua0u5).\r\n-->\r\n\r\n1. Create a new app using latest Angular CLI\r\n2. Go to `AppModule`, modify `providers` and add `constructor` as shown above\r\n3. Run `npm start -- --aot`\r\n\r\n**What is the motivation / use case for changing the behavior?**\r\n\u003c!-- Describe the motivation or the concrete use case -->\r\n\r\nI want to be able to test the places where I happen to have to use `window`. I still want to have type safety for my calls to it.\r\n\r\n**Please tell us about your environment:**\r\n\u003c!-- Operating system, IDE, package manager, HTTP server, ... -->\r\n\r\nMac OS latest\r\n\r\nRunning `npm run ng -- version` returns:\r\n\r\n```\r\nangular-cli: 1.0.0-beta.26\r\nnode: 6.9.1\r\nos: darwin x64\r\n@angular/common: 2.4.4\r\n@angular/compiler: 2.4.4\r\n@angular/core: 2.4.4\r\n@angular/forms: 2.4.4\r\n@angular/http: 2.4.4\r\n@angular/platform-browser: 2.4.4\r\n@angular/platform-browser-dynamic: 2.4.4\r\n@angular/router: 3.4.4\r\n@angular/compiler-cli: 2.4.4\r\n```\r\n\r\nThings to note:\r\n\r\n  - The type `Window` is declared in default TypeScript lib `dom`.\r\n  - The libs `[\"es6\", \"dom\"]` are already added by default in my project (default Angular CLI layout)\r\n  - I also tried to reference the file `node_modules/typescript/lib/lib.dom.d.ts` directly in several ways, and that didn't seem to help\r\n\r\n\r\nPlease note that the code WORKS JUST FINE when I'm not using AoT.\r\n\r\nThat's `npm start` works, and `npm start -- --aot` fails (`npm start` here equals `ng serve`)\r\n\r\n* **Angular version:** 2.0.X\r\n\u003c!-- Check whether this is still an issue in the most recent Angular version -->\r\n\r\nAngular 2.4.4 as shown above.\r\n\r\n* **Browser:** [all | Chrome XX | Firefox XX | IE XX | Safari XX | Mobile Chrome XX | Android X.X Web Browser | iOS XX Safari | iOS XX UIWebView | iOS XX WKWebView ]\r\n\u003c!-- All browsers where this could be reproduced -->\r\n\r\nTested in Chrome, but the error comes in Terminal anyway.\r\n \r\n* **Language:** [all | TypeScript X.X | ES6/7 | ES5]\r\n\r\nTypeScript 2.0.10\r\n\r\n* **Node (for AoT issues):** `node --version` =   \r\nnode: 6.9.1","author":{"url":"https://github.com/Meligy","@type":"Person","name":"Meligy"},"datePublished":"2017-01-21T11:28:30Z","url":"https://github.com/angular/angular/issues/14050"}

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:c847a2bd-39e8-dcd8-54a4-2f76de8b143e
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-idD008:EDA7A:54617E:6D030B:6B00DAFF
html-safe-nonce7b95e344af379b7612b970e3c15a72da46fcc1bb92563435c97b1304a2818f32
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEMDA4OkVEQTdBOjU0NjE3RTo2RDAzMEI6NkIwMERBRkYiLCJ2aXNpdG9yX2lkIjoiODQ3MzQ4NTQ2NzYyMTMxNzM3NSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac6b66638c3e60bc2893b7aa6318d39e452834ae7c9e589343955b92057b0f6be3
hovercard-subject-tagissue:202310251
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/angular/angular/14050/issue_layout
twitter:imagehttps://opengraph.githubassets.com/acdd1c023f9a158f07c8dea7a95651ba73e8ed59ad088a4694dade202b0d55df/angular/angular/issues/14050
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/acdd1c023f9a158f07c8dea7a95651ba73e8ed59ad088a4694dade202b0d55df/angular/angular/issues/14050
og:image:altI'm submitting a ... (check one with "x") [x] bug report => search github for a similar issue or PR before submitting [ ] feature request [ ] support request => Please do not submit support request...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameMeligy
hostnamegithub.com
expected-hostnamegithub.com
Nonea481f62a1e04c9b9bdcb5628230682c66d59006f5b13b080f79cba84a176905b
turbo-cache-controlno-preview
go-importgithub.com/angular/angular git https://github.com/angular/angular.git
octolytics-dimension-user_id139426
octolytics-dimension-user_loginangular
octolytics-dimension-repository_id24195339
octolytics-dimension-repository_nwoangular/angular
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id24195339
octolytics-dimension-repository_network_root_nwoangular/angular
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release84c8c5cc25e2fb7f2308428458538436baecc6d2
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-nameissues

Links:

Skip to contenthttps://github.com/angular/angular/issues/14050#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fissues%2F14050
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fissues%2F14050
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=angular%2Fangular
Reloadhttps://github.com/angular/angular/issues/14050
Reloadhttps://github.com/angular/angular/issues/14050
Reloadhttps://github.com/angular/angular/issues/14050
angularhttps://github.com/angular
angularhttps://github.com/angular/angular
Codehttps://github.com/angular/angular
Issues835 (835)https://github.com/angular/angular/issues
Pull requests139 (139)https://github.com/angular/angular/pulls
Discussionshttps://github.com/angular/angular/discussions
Actionshttps://github.com/angular/angular/actions
Projectshttps://github.com/angular/angular/projects
Security and quality40 (40)https://github.com/angular/angular/security
Insightshttps://github.com/angular/angular/insights
https://github.com/angular/angular
New issuehttps://github.com/login?return_to=https://github.com/angular/angular/issues/14050
New issuehttps://github.com/login?return_to=https://github.com/angular/angular/issues/14050
AoT compiler does not recognize type Window (possibly issue with global variables and/or TypeScript built-in libs)https://github.com/angular/angular/issues/14050#top
https://github.com/Meligy
Meligyhttps://github.com/Meligy
on Jan 21, 2017https://github.com/angular/angular/issues/14050#issue-202310251
https://github.com/DzmitryShylovich
DzmitryShylovichhttps://github.com/DzmitryShylovich
on Jan 21, 2017https://github.com/angular/angular/issues/14050#issuecomment-274258334
@Injecthttps://github.com/Inject
#12631https://github.com/angular/angular/issues/12631
https://github.com/Meligy
Meligyhttps://github.com/Meligy
on Jan 21, 2017https://github.com/angular/angular/issues/14050#issuecomment-274259531
@DzmitryShylovichhttps://github.com/DzmitryShylovich
https://github.com/Meligy
Meligyhttps://github.com/Meligy
on Jan 21, 2017https://github.com/angular/angular/issues/14050#issuecomment-274259665
https://github.com/Meligy
Meligyhttps://github.com/Meligy
on Jan 21, 2017https://github.com/angular/angular/issues/14050#issuecomment-274259854
#12631https://github.com/angular/angular/issues/12631
Meligyhttps://github.com/Meligy
completedhttps://github.com/angular/angular/issues?q=is%3Aissue%20state%3Aclosed%20archived%3Afalse%20reason%3Acompleted
on Jan 21, 2017https://github.com/angular/angular/issues/14050#event-931678560
https://github.com/DzmitryShylovich
DzmitryShylovichhttps://github.com/DzmitryShylovich
on Jan 21, 2017https://github.com/angular/angular/issues/14050#issuecomment-274259871
https://github.com/Meligy
Meligyhttps://github.com/Meligy
on Jan 21, 2017https://github.com/angular/angular/issues/14050#issuecomment-274260023
https://github.com/apps/angular-automatic-lock-bot
angular-automatic-lock-bothttps://github.com/apps/angular-automatic-lock-bot
on Sep 10, 2019https://github.com/angular/angular/issues/14050#issuecomment-529988047
automatic conversation locking policyhttps://github.com/angular/angular/blob/67d80f/docs/GITHUB_PROCESS.md#conversation-locking
angular-automatic-lock-bothttps://github.com/apps/angular-automatic-lock-bot
on Sep 10, 2019https://github.com/angular/angular/issues/14050#event-2622686108
Sign up for freehttps://github.com/signup?return_to=https://github.com/angular/angular/issues/14050
Sign in to commenthttps://github.com/login?return_to=https://github.com/angular/angular/issues/14050
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.