René's URL Explorer Experiment


Title: [compiler-cli] Change references from NgModule to NgModuleFactory at build-time · Issue #14005 · angular/angular · GitHub

Open Graph Title: [compiler-cli] Change references from NgModule to NgModuleFactory at build-time · Issue #14005 · angular/angular

X Title: [compiler-cli] Change references from NgModule to NgModuleFactory at build-time · Issue #14005 · angular/angular

Description: I'm submitting a ... (check one with "x") [ ] bug report => search github for a similar issue or PR before submitting [x] feature request [ ] support request => Please do not submit support request here, instead see https://github.com/an...

Open Graph Description: I'm submitting a ... (check one with "x") [ ] bug report => search github for a similar issue or PR before submitting [x] feature request [ ] support request => Please do not submit support request...

X Description: I'm submitting a ... (check one with "x") [ ] bug report => search github for a similar issue or PR before submitting [x] feature request [ ] support request => Please do not su...

Opengraph URL: https://github.com/angular/angular/issues/14005

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"[compiler-cli] Change references from NgModule to NgModuleFactory at build-time","articleBody":"**I'm submitting a ...**  (check one with \"x\")\r\n```\r\n[ ] bug report => search github for a similar issue or PR before submitting\r\n[x] feature request\r\n[ ] support request => Please do not submit support request here, instead see https://github.com/angular/angular/blob/master/CONTRIBUTING.md#question\r\n```\r\n\r\n**Current behavior**\r\nFrom the discussion https://github.com/angular/angular/issues/11075 and PR https://github.com/angular/angular/pull/13909#issuecomment-273705042.\r\n\r\nSo let me wrap up these discussions. It's possible to encapsulate routes in a feature module like this.\r\n\r\n```js\r\nimport { Routes, RouterModule, PreloadAllModules } from '@angular/router';\r\nimport { HomeComponent } from './home/home.component';\r\nimport { ProfileModule } from './profile/profile.module';\r\n\r\nexport function loadProfileModule() {\r\n\treturn ProfileModule;\r\n}\r\n\r\nexport const routes: Routes = [\r\n\t{ path: '', component: HomeComponent, pathMatch: 'full' },\r\n\t{ path: 'profile', loadChildren: loadProfileModule}\r\n];\r\n\r\nexport const routing = RouterModule.forRoot(routes);\r\n```\r\n\r\nThe `ProfileModule` on its turn has child routes as well. This isn't meant for lazy loading, it's just a way of letting the profile module decide how the routing internally is done.\r\n\r\nHowever, currently this feature is not usable with AoT. The reason is pointed out by @DzmitryShylovich and is that after AoT, we should return the module factory instead of the module like this.\r\n\r\n```js\r\nimport { Routes, RouterModule, PreloadAllModules } from '@angular/router';\r\nimport { HomeComponent } from './home/home.component';\r\nimport { ProfileModuleNgFactory } from '../compiled/src/app/profile.module.ngfactory';\r\n\r\nexport function loadProfileModule() {\r\n\treturn ProfileModuleNgFactory;\r\n}\r\n\r\nexport const routes: Routes = [\r\n\t{ path: '', component: HomeComponent, pathMatch: 'full' },\r\n\t{ path: 'profile', loadChildren: loadProfileModule}\r\n];\r\n\r\nexport const routing = RouterModule.forRoot(routes);\r\n```\r\n\r\nCurrently, this requires manual steps or another build tool to change the references from `NgModule` to `NgModuleFactory`.\r\n\r\n**Expected behavior**\r\nI guess this is a perfect fit for the `compiler-cli` to do instead of a manual process or another gulp/npm task.\r\n\r\n**Minimal reproduction of the problem with instructions**\r\nI created a quick example [here](https://github.com/SamVerschueren/ng2-hello-world-routing/tree/load-children).\r\n\r\n1. `git clone https://github.com/SamVerschueren/ng2-hello-world-routing`\r\n2. `cd ng2-hello-world-routing`\r\n3. `git checkout load-children`\r\n4. `npm install`\r\n\r\nIf you run `npm start`, you will notice that you can navigate from `Home` to `Contact` and back while it uses [the approach mentioned in the initial post](https://github.com/SamVerschueren/ng2-hello-world-routing/blob/load-children/app/app.routing.ts).\r\n\r\nNow if you build it with `npm run build`, it will output a production bundle in the `builds` directory. So navigate to that directory and start a local server (`http-server`, `lite-server`, ...). Open the url and open devtools. If you click on `Contact`, it will fail to load and shows an error about [`r.create`](https://github.com/angular/angular/blob/master/modules/%40angular/router/src/router_config_loader.ts#L35) not being a function.\r\n\r\n**What is the motivation / use case for changing the behavior?**\r\nIf this would be possible, it would make life of developers who are targetting for production with AoT a lot easier and would actually make this feature usuable. Currently it doesn't feel usuable because of the manual steps that has to be performed in order to use it. So either you don't use it when compiling with AoT, or you don't compile with AoT.\r\n\r\n**Please tell us about your environment:**\r\nmacOS, VS Code, npm/yarn, http-server\r\n\r\n* **Angular version:** 2.4.3\r\n\r\n* **Browser:** all\r\n \r\n* **Language:** TypeScript\r\n\r\n* **Node (for AoT issues):** `node --version` =  v6.9.1\r\n","author":{"url":"https://github.com/SamVerschueren","@type":"Person","name":"SamVerschueren"},"datePublished":"2017-01-19T08:16:48Z","url":"https://github.com/angular/angular/issues/14005"}

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:09201b6a-4d68-8517-f20c-2ea3fa985bed
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-id92DE:305B07:1627C98:1D3B202:6B013083
html-safe-noncecc39999dae3213f9a6f88f98d17b78b8b08b813c58d30874b67901defcc4fbec
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5MkRFOjMwNUIwNzoxNjI3Qzk4OjFEM0IyMDI6NkIwMTMwODMiLCJ2aXNpdG9yX2lkIjoiMjk1NjEwNDU2NDMxNjY0NzU1NSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac14c01af48140847f96467a4d5820034937c0d20f24fd41de78336f89f07a7038
hovercard-subject-tagissue:201791180
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/angular/angular/14005/issue_layout
twitter:imagehttps://opengraph.githubassets.com/087bfac6068e8a3f0fd0af055a5a987c0ef886698c9625679e010ce74db465ff/angular/angular/issues/14005
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/087bfac6068e8a3f0fd0af055a5a987c0ef886698c9625679e010ce74db465ff/angular/angular/issues/14005
og:image:altI'm submitting a ... (check one with "x") [ ] bug report => search github for a similar issue or PR before submitting [x] feature request [ ] support request => Please do not submit support request...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameSamVerschueren
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-preview
go-importgithub.com/angular/angular git https://github.com/angular/angular.git
octolytics-dimension-user_id139426
octolytics-dimension-user_loginangular
octolytics-dimension-repository_id24195339
octolytics-dimension-repository_nwoangular/angular
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id24195339
octolytics-dimension-repository_network_root_nwoangular/angular
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-nameissues

Links:

Skip to contenthttps://github.com/angular/angular/issues/14005#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fissues%2F14005
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fissues%2F14005
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=angular%2Fangular
Reloadhttps://github.com/angular/angular/issues/14005
Reloadhttps://github.com/angular/angular/issues/14005
Reloadhttps://github.com/angular/angular/issues/14005
angularhttps://github.com/angular
angularhttps://github.com/angular/angular
Codehttps://github.com/angular/angular
Issues836 (836)https://github.com/angular/angular/issues
Pull requests141 (141)https://github.com/angular/angular/pulls
Discussionshttps://github.com/angular/angular/discussions
Actionshttps://github.com/angular/angular/actions
Projectshttps://github.com/angular/angular/projects
Security and quality40 (40)https://github.com/angular/angular/security
Insightshttps://github.com/angular/angular/insights
https://github.com/angular/angular
New issuehttps://github.com/login?return_to=https://github.com/angular/angular/issues/14005
New issuehttps://github.com/login?return_to=https://github.com/angular/angular/issues/14005
[compiler-cli] Change references from NgModule to NgModuleFactory at build-timehttps://github.com/angular/angular/issues/14005#top
https://github.com/SamVerschueren
SamVerschuerenhttps://github.com/SamVerschueren
on Jan 19, 2017https://github.com/angular/angular/issues/14005#issue-201791180
#11075https://github.com/angular/angular/issues/11075
#13909 (comment)https://github.com/angular/angular/pull/13909#issuecomment-273705042
@DzmitryShylovichhttps://github.com/DzmitryShylovich
herehttps://github.com/SamVerschueren/ng2-hello-world-routing/tree/load-children
the approach mentioned in the initial posthttps://github.com/SamVerschueren/ng2-hello-world-routing/blob/load-children/app/app.routing.ts
r.createhttps://github.com/angular/angular/blob/master/modules/%40angular/router/src/router_config_loader.ts#L35
https://github.com/DzmitryShylovich
DzmitryShylovichhttps://github.com/DzmitryShylovich
on Jan 24, 2017https://github.com/angular/angular/issues/14005#issuecomment-274663068
#13909 (comment)https://github.com/angular/angular/pull/13909#issuecomment-274650555
https://github.com/DzmitryShylovich
DzmitryShylovichhttps://github.com/DzmitryShylovich
on Jan 25, 2017https://github.com/angular/angular/issues/14005#issuecomment-275038792
@SamVerschuerenhttps://github.com/SamVerschueren
https://github.com/SamVerschueren
SamVerschuerenhttps://github.com/SamVerschueren
on Jan 25, 2017https://github.com/angular/angular/issues/14005#issuecomment-275041554
angular/angular-cli#4192 (comment)https://github.com/angular/angular-cli/issues/4192#issuecomment-274775116
@DzmitryShylovichhttps://github.com/DzmitryShylovich
SamVerschuerenhttps://github.com/SamVerschueren
completedhttps://github.com/angular/angular/issues?q=is%3Aissue%20state%3Aclosed%20archived%3Afalse%20reason%3Acompleted
on Jan 25, 2017https://github.com/angular/angular/issues/14005#event-935736458
https://github.com/1456118242
1456118242https://github.com/1456118242
on Mar 26, 2018https://github.com/angular/angular/issues/14005#issuecomment-376347270
@DzmitryShylovichhttps://github.com/DzmitryShylovich
https://github.com/apps/angular-automatic-lock-bot
angular-automatic-lock-bothttps://github.com/apps/angular-automatic-lock-bot
on Sep 13, 2019https://github.com/angular/angular/issues/14005#issuecomment-531199846
automatic conversation locking policyhttps://github.com/angular/angular/blob/67d80f/docs/GITHUB_PROCESS.md#conversation-locking
angular-automatic-lock-bothttps://github.com/apps/angular-automatic-lock-bot
on Sep 13, 2019https://github.com/angular/angular/issues/14005#event-2632015791
Sign up for freehttps://github.com/signup?return_to=https://github.com/angular/angular/issues/14005
Sign in to commenthttps://github.com/login?return_to=https://github.com/angular/angular/issues/14005
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.