René's URL Explorer Experiment


Title: DI feature: lifecycle hooks for services, especially OnDestroy · Issue #13618 · angular/angular · GitHub

Open Graph Title: DI feature: lifecycle hooks for services, especially OnDestroy · Issue #13618 · angular/angular

X Title: DI feature: lifecycle hooks for services, especially OnDestroy · Issue #13618 · angular/angular

Description: I'm submitting a ... (check one with "x") [ ] bug report [x] feature request [ ] support request Current behavior When destroying an injector, Angular has no way AFAIK to inform the service instances in the injector that they are doomed....

Open Graph Description: I'm submitting a ... (check one with "x") [ ] bug report [x] feature request [ ] support request Current behavior When destroying an injector, Angular has no way AFAIK to inform the service instanc...

X Description: I'm submitting a ... (check one with "x") [ ] bug report [x] feature request [ ] support request Current behavior When destroying an injector, Angular has no way AFAIK to inform the s...

Opengraph URL: https://github.com/angular/angular/issues/13618

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"DI feature: lifecycle hooks for services, especially OnDestroy","articleBody":"**I'm submitting a ...**  (check one with \"x\")\r\n```\r\n[ ] bug report \r\n[x] feature request\r\n[ ] support request \r\n```\r\n\r\n**Current behavior**\r\n\r\nWhen destroying an injector, Angular has no way AFAIK to inform the service instances in the injector that they are doomed.\r\n\r\nIf a service is holding valuable resources (e.g., a message bus holding subscriptions) it doesn't know to let go.\r\n\r\n**Expected behavior**\r\n\r\nIf the service has an `ngOnDestroy`, Angular should call it as it destroys/releases its hold on an injector (e.g., when destroying a component).\r\n\r\nIs this safe? Only if the service is created by the injector ... which isn't _always_ the case ( almost anything except `useClass`).\r\n\r\nOTOH, if the developer adds an `ngOnDestroy` method, she should expect it to be called and not put her service in compromising position.\r\n\r\nOn balance, I think its a useful feature, with no obvious substitution, and one *consistent with disposable patterns in other languages*.\r\n\r\np.s.:  The only other lc-hook that makes sense is `ngOnInit` and the developer can easily compensate for its lack. I can't think of workaround for the lack of `ngOnDestroy`.\r\n\r\n\u003c!-- Operating system, IDE, package manager, HTTP server, ... -->\r\nAll\r\n\r\n* **Angular version:** 2.3.0\r\n\u003c!-- Check whether this is still an issue in the most recent Angular version -->\r\n\r\n* **Browser:** [all ]\r\n\u003c!-- All browsers where this could be reproduced -->\r\n \r\n* **Language:** [all ]\r\n","author":{"url":"https://github.com/wardbell","@type":"Person","name":"wardbell"},"datePublished":"2016-12-21T20:03:48Z","url":"https://github.com/angular/angular/issues/13618"}

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:0c62ffcc-d6df-e598-db95-7875c3017d4e
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-idE6DA:2E3FEE:1BE13D8:234D7AE:6B015286
html-safe-noncece8909e2a9c88d8f3788f2644c9c6fcbdb5c66bdb38afccd06e1dee60d84ea50
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFNkRBOjJFM0ZFRToxQkUxM0Q4OjIzNEQ3QUU6NkIwMTUyODYiLCJ2aXNpdG9yX2lkIjoiNDYxMDIxNzg0NTc4MjA0MTIyMiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac0cb185890a38ceab68ce9ae476b5780fc316e0e71abca9230c9598a1863dbbb1
hovercard-subject-tagissue:197020617
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/angular/angular/13618/issue_layout
twitter:imagehttps://opengraph.githubassets.com/15e1632295f05335546d706f6210936f7f6b1052198afce3bb36544ce23ea25d/angular/angular/issues/13618
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/15e1632295f05335546d706f6210936f7f6b1052198afce3bb36544ce23ea25d/angular/angular/issues/13618
og:image:altI'm submitting a ... (check one with "x") [ ] bug report [x] feature request [ ] support request Current behavior When destroying an injector, Angular has no way AFAIK to inform the service instanc...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamewardbell
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-preview
go-importgithub.com/angular/angular git https://github.com/angular/angular.git
octolytics-dimension-user_id139426
octolytics-dimension-user_loginangular
octolytics-dimension-repository_id24195339
octolytics-dimension-repository_nwoangular/angular
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id24195339
octolytics-dimension-repository_network_root_nwoangular/angular
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-nameissues

Links:

Skip to contenthttps://github.com/angular/angular/issues/13618#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fissues%2F13618
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fissues%2F13618
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=angular%2Fangular
Reloadhttps://github.com/angular/angular/issues/13618
Reloadhttps://github.com/angular/angular/issues/13618
Reloadhttps://github.com/angular/angular/issues/13618
angularhttps://github.com/angular
angularhttps://github.com/angular/angular
Codehttps://github.com/angular/angular
Issues836 (836)https://github.com/angular/angular/issues
Pull requests141 (141)https://github.com/angular/angular/pulls
Discussionshttps://github.com/angular/angular/discussions
Actionshttps://github.com/angular/angular/actions
Projectshttps://github.com/angular/angular/projects
Security and quality40 (40)https://github.com/angular/angular/security
Insightshttps://github.com/angular/angular/insights
https://github.com/angular/angular
New issuehttps://github.com/login?return_to=https://github.com/angular/angular/issues/13618
New issuehttps://github.com/login?return_to=https://github.com/angular/angular/issues/13618
DI feature: lifecycle hooks for services, especially OnDestroyhttps://github.com/angular/angular/issues/13618#top
https://github.com/wardbell
wardbellhttps://github.com/wardbell
on Dec 21, 2016https://github.com/angular/angular/issues/13618#issue-197020617
https://github.com/DzmitryShylovich
DzmitryShylovichhttps://github.com/DzmitryShylovich
on Dec 21, 2016https://github.com/angular/angular/issues/13618#issuecomment-268625617
#13369https://github.com/angular/angular/pull/13369
https://github.com/wardbell
wardbellhttps://github.com/wardbell
on Dec 21, 2016https://github.com/angular/angular/issues/13618#issuecomment-268627195
wardbellhttps://github.com/wardbell
completedhttps://github.com/angular/angular/issues?q=is%3Aissue%20state%3Aclosed%20archived%3Afalse%20reason%3Acompleted
on Dec 21, 2016https://github.com/angular/angular/issues/13618#event-902121911
https://github.com/apps/angular-automatic-lock-bot
angular-automatic-lock-bothttps://github.com/apps/angular-automatic-lock-bot
on Sep 10, 2019https://github.com/angular/angular/issues/13618#issuecomment-529909156
automatic conversation locking policyhttps://github.com/angular/angular/blob/67d80f/docs/GITHUB_PROCESS.md#conversation-locking
angular-automatic-lock-bothttps://github.com/apps/angular-automatic-lock-bot
on Sep 10, 2019https://github.com/angular/angular/issues/13618#event-2622037881
Sign up for freehttps://github.com/signup?return_to=https://github.com/angular/angular/issues/13618
Sign in to commenthttps://github.com/login?return_to=https://github.com/angular/angular/issues/13618
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.