René's URL Explorer Experiment


Title: AOT: add support for extending expressions in classes · Issue #13436 · angular/angular · GitHub

Open Graph Title: AOT: add support for extending expressions in classes · Issue #13436 · angular/angular

X Title: AOT: add support for extending expressions in classes · Issue #13436 · angular/angular

Description: I'm submitting a feature request [ ] bug report => search github for a similar issue or PR before submitting [X ] feature request [ ] support request => Please do not submit support request here, instead see https://github.com/angular/an...

Open Graph Description: I'm submitting a feature request [ ] bug report => search github for a similar issue or PR before submitting [X ] feature request [ ] support request => Please do not submit support request here, i...

X Description: I'm submitting a feature request [ ] bug report => search github for a similar issue or PR before submitting [X ] feature request [ ] support request => Please do not submit support reque...

Opengraph URL: https://github.com/angular/angular/issues/13436

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"AOT: add support for extending expressions in classes","articleBody":"**I'm submitting a feature request**\r\n```\r\n[ ] bug report => search github for a similar issue or PR before submitting\r\n[X ] feature request\r\n[ ] support request => Please do not submit support request here, instead see https://github.com/angular/angular/blob/master/CONTRIBUTING.md#question\r\n```\r\n\r\n**Current behavior**\r\nCurrently the AOT doesn't allow any functions to be within an annotation though this same rule applies to classes it seems. Meaning the following fully compatible typescript 1.6+ code, copied from the typescript What's new section (https://github.com/Microsoft/TypeScript/wiki/What's-new-in-TypeScript#extending-expressions), isn't allowed by the AOT:\r\n\r\n```javascript\r\nclass ThingA {\r\n    getGreeting() { return \"Hello from A\"; }\r\n}\r\n\r\ninterface GreeterConstructor {\r\n    new (): ThingA;\r\n}\r\n\r\nfunction getGreeterBase(): GreeterConstructor {\r\n    return ThingA;\r\n}\r\n\r\nclass Test extends getGreeterBase() {\r\n    sayHello() {\r\n        console.log(this.getGreeting());\r\n    }\r\n}\r\n```\r\n\r\nThe area were this has manifested for me is in the use of immutablejs'es `Record` class (https://facebook.github.io/immutable-js/docs/#/Record):\r\n\r\n```javascript\r\nexport class ModelA extends Record({name: ''}) {\r\n     name: string\r\n}\r\n```\r\n\r\nWhich is something the AOT really doesn't like and throws an error on. \r\n\r\n**Expected behavior**\r\nI'm not sure if the above is by design (though based on the response I got on gitter it would seem so) and due to this fact it's a feature request and not a bug report.  I would just like to know if it's by design or if there is a chance it will be altered, as it will influence the decisions I have to make going forwards when it comes to Ngrx/Store + ImmutableJS etc. \r\n\r\n**What is the motivation / use case for changing the behavior?**\r\nThe main reason I would like this changed is that it would bring the AOT in line with the regular Typescript compiler. While I understand functions directly inside of an annotation isn't something you would want I find it weird that the AOT parts here from the Typescript standard (which isn't clearly documented anywhere as far as I can tell).\r\n\r\n* **Angular version:** 2.0.X\r\n2.3.0\r\n \r\n* **Language:** [all | TypeScript X.X | ES6/7 | ES5]\r\nTypescript 2.0.10\r\n\r\n* **Node (for AoT issues):** `node --version` =   \r\n4.2.2","author":{"url":"https://github.com/nschipperbrainsmith","@type":"Person","name":"nschipperbrainsmith"},"datePublished":"2016-12-13T18:15:19Z","url":"https://github.com/angular/angular/issues/13436"}

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:a50c7301-6e8e-88c0-8751-12a948429be9
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-id8F02:3DF0BE:7CB23A:A3ACBF:6B00DAFB
html-safe-noncec1bb4f4d9c7cd2529226d1b9be7aa904dfd5b45ebacb121e70f5c7553c3c87a4
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4RjAyOjNERjBCRTo3Q0IyM0E6QTNBQ0JGOjZCMDBEQUZCIiwidmlzaXRvcl9pZCI6IjI1NzUzNTg4NDg4NTIzNTE3MzkiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmacf8e1d250d697569f91955689fbb072f70b519c9c3c8b2527f4455175547119b6
hovercard-subject-tagissue:195328235
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/angular/angular/13436/issue_layout
twitter:imagehttps://opengraph.githubassets.com/40d4fe7c29a680bb7bc84ab4a24f04bee84c5f5d064ea86bb70128bd40a1dd51/angular/angular/issues/13436
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/40d4fe7c29a680bb7bc84ab4a24f04bee84c5f5d064ea86bb70128bd40a1dd51/angular/angular/issues/13436
og:image:altI'm submitting a feature request [ ] bug report => search github for a similar issue or PR before submitting [X ] feature request [ ] support request => Please do not submit support request here, i...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamenschipperbrainsmith
hostnamegithub.com
expected-hostnamegithub.com
Nonea481f62a1e04c9b9bdcb5628230682c66d59006f5b13b080f79cba84a176905b
turbo-cache-controlno-preview
go-importgithub.com/angular/angular git https://github.com/angular/angular.git
octolytics-dimension-user_id139426
octolytics-dimension-user_loginangular
octolytics-dimension-repository_id24195339
octolytics-dimension-repository_nwoangular/angular
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id24195339
octolytics-dimension-repository_network_root_nwoangular/angular
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release84c8c5cc25e2fb7f2308428458538436baecc6d2
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-nameissues

Links:

Skip to contenthttps://github.com/angular/angular/issues/13436#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fissues%2F13436
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fissues%2F13436
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=angular%2Fangular
Reloadhttps://github.com/angular/angular/issues/13436
Reloadhttps://github.com/angular/angular/issues/13436
Reloadhttps://github.com/angular/angular/issues/13436
angularhttps://github.com/angular
angularhttps://github.com/angular/angular
Codehttps://github.com/angular/angular
Issues835 (835)https://github.com/angular/angular/issues
Pull requests139 (139)https://github.com/angular/angular/pulls
Discussionshttps://github.com/angular/angular/discussions
Actionshttps://github.com/angular/angular/actions
Projectshttps://github.com/angular/angular/projects
Security and quality40 (40)https://github.com/angular/angular/security
Insightshttps://github.com/angular/angular/insights
https://github.com/angular/angular
New issuehttps://github.com/login?return_to=https://github.com/angular/angular/issues/13436
New issuehttps://github.com/login?return_to=https://github.com/angular/angular/issues/13436
AOT: add support for extending expressions in classeshttps://github.com/angular/angular/issues/13436#top
area: coreIssues related to the framework runtimehttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20core%22
https://github.com/nschipperbrainsmith
nschipperbrainsmithhttps://github.com/nschipperbrainsmith
on Dec 13, 2016https://github.com/angular/angular/issues/13436#issue-195328235
https://github.com/Microsoft/TypeScript/wiki/What's-new-in-TypeScript#extending-expressionshttps://github.com/Microsoft/TypeScript/wiki/What's-new-in-TypeScript#extending-expressions
https://facebook.github.io/immutable-js/docs/#/Recordhttps://facebook.github.io/immutable-js/docs/#/Record
Nexthttps://github.com/angular/angular/issues/13436?timeline_page=1
chuckjazhttps://github.com/chuckjaz
area: coreIssues related to the framework runtimehttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20core%22
on Dec 13, 2016https://github.com/angular/angular/issues/13436#event-892500105
https://github.com/robwormald
robwormaldhttps://github.com/robwormald
on Dec 14, 2016https://github.com/angular/angular/issues/13436#issuecomment-266968925
https://github.com/nschipperbrainsmith
nschipperbrainsmithhttps://github.com/nschipperbrainsmith
on Dec 14, 2016https://github.com/angular/angular/issues/13436#issuecomment-266971675
@robwormaldhttps://github.com/robwormald
https://github.com/nschipperbrainsmith
nschipperbrainsmithhttps://github.com/nschipperbrainsmith
on Dec 15, 2016https://github.com/angular/angular/issues/13436#issuecomment-267361943
@robwormaldhttps://github.com/robwormald
https://github.com/tbosch
tboschhttps://github.com/tbosch
on Dec 28, 2016https://github.com/angular/angular/issues/13436#issuecomment-269531219
tboschhttps://github.com/tbosch
flag: can be closed?https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22flag%3A%20can%20be%20closed%3F%22
on Dec 28, 2016https://github.com/angular/angular/issues/13436#event-906816150
https://github.com/nschipperbrainsmith
nschipperbrainsmithhttps://github.com/nschipperbrainsmith
on Dec 28, 2016https://github.com/angular/angular/issues/13436#issuecomment-269542344
@tboschhttps://github.com/tbosch
https://bitbucket.org/schippie/aot-13436/overviewhttps://bitbucket.org/schippie/aot-13436/overview
https://github.com/zahlprish
zahlprishhttps://github.com/zahlprish
on Dec 29, 2016https://github.com/angular/angular/issues/13436#issuecomment-269695036
https://github.com/nschipperbrainsmith
nschipperbrainsmithhttps://github.com/nschipperbrainsmith
on Dec 29, 2016https://github.com/angular/angular/issues/13436#issuecomment-269695331
@zahlprishhttps://github.com/zahlprish
https://github.com/tbosch
tboschhttps://github.com/tbosch
on Dec 29, 2016https://github.com/angular/angular/issues/13436#issuecomment-269711117
https://github.com/nschipperbrainsmith
nschipperbrainsmithhttps://github.com/nschipperbrainsmith
on Dec 30, 2016https://github.com/angular/angular/issues/13436#issuecomment-269806504
@tboschhttps://github.com/tbosch
https://github.com/nschipperbrainsmith
nschipperbrainsmithhttps://github.com/nschipperbrainsmith
on Dec 30, 2016https://github.com/angular/angular/issues/13436#issuecomment-269811621
@tboschhttps://github.com/tbosch
https://bitbucket.org/schippie/aot-13436/branch/test2https://bitbucket.org/schippie/aot-13436/branch/test2
https://bitbucket.org/schippie/aot-13436/branch/test3https://bitbucket.org/schippie/aot-13436/branch/test3
https://bitbucket.org/schippie/aot-13436/branch/test4https://bitbucket.org/schippie/aot-13436/branch/test4
https://github.com/zahlprish
zahlprishhttps://github.com/zahlprish
on Jan 5, 2017https://github.com/angular/angular/issues/13436#issuecomment-270553000
https://github.com/nschipperbrainsmith
nschipperbrainsmithhttps://github.com/nschipperbrainsmith
on Jan 5, 2017https://github.com/angular/angular/issues/13436#issuecomment-270555490
@zahlprishhttps://github.com/zahlprish
https://github.com/simplifia
simplifiahttps://github.com/simplifia
on Jan 5, 2017https://github.com/angular/angular/issues/13436#issuecomment-270589768
https://github.com/rangle/typed-immutable-recordhttps://github.com/rangle/typed-immutable-record
https://github.com/zahlprish
zahlprishhttps://github.com/zahlprish
on Jan 10, 2017https://github.com/angular/angular/issues/13436#issuecomment-271725745
@simplifiahttps://github.com/simplifia
https://github.com/zahlprish
zahlprishhttps://github.com/zahlprish
on Jan 12, 2017https://github.com/angular/angular/issues/13436#issuecomment-272217405
https://github.com/nschipperbrainsmith
nschipperbrainsmithhttps://github.com/nschipperbrainsmith
on Jan 12, 2017https://github.com/angular/angular/issues/13436#issuecomment-272217982
@zahlprishhttps://github.com/zahlprish
https://github.com/zahlprish
zahlprishhttps://github.com/zahlprish
on Jan 12, 2017https://github.com/angular/angular/issues/13436#issuecomment-272224770
https://github.com/nadavsinai
nadavsinaihttps://github.com/nadavsinai
on Jan 16, 2017https://github.com/angular/angular/issues/13436#issuecomment-272870445
@tboschhttps://github.com/tbosch
https://github.com/dakolech
dakolechhttps://github.com/dakolech
on Jan 19, 2017https://github.com/angular/angular/issues/13436#issuecomment-273749154
https://github.com/artaommahe
artaommahehttps://github.com/artaommahe
on Jan 20, 2017https://github.com/angular/angular/issues/13436#issuecomment-274108919
https://github.com/nschipperbrainsmith
nschipperbrainsmithhttps://github.com/nschipperbrainsmith
on Jan 28, 2017https://github.com/angular/angular/issues/13436#issuecomment-275836469
https://github.com/nschipperbrainsmith
nschipperbrainsmithhttps://github.com/nschipperbrainsmith
on Feb 3, 2017https://github.com/angular/angular/issues/13436#issuecomment-277225990
@alexeaglehttps://github.com/alexeagle
#14154https://github.com/angular/angular/issues/14154
#14158https://github.com/angular/angular/pull/14158
https://github.com/alexeagle
alexeaglehttps://github.com/alexeagle
on Feb 3, 2017https://github.com/angular/angular/issues/13436#issuecomment-277289485
#14158https://github.com/angular/angular/pull/14158
alexeaglehttps://github.com/alexeagle
completedhttps://github.com/angular/angular/issues?q=is%3Aissue%20state%3Aclosed%20archived%3Afalse%20reason%3Acompleted
on Feb 3, 2017https://github.com/angular/angular/issues/13436#event-948290282
https://github.com/zahlprish
zahlprishhttps://github.com/zahlprish
on Feb 5, 2017https://github.com/angular/angular/issues/13436#issuecomment-277502911
https://github.com/nschipperbrainsmith
nschipperbrainsmithhttps://github.com/nschipperbrainsmith
on Feb 5, 2017https://github.com/angular/angular/issues/13436#issuecomment-277509647
@zahlprishhttps://github.com/zahlprish
@alexeaglehttps://github.com/alexeagle
https://github.com/apps/angular-automatic-lock-bot
angular-automatic-lock-bothttps://github.com/apps/angular-automatic-lock-bot
on Sep 10, 2019https://github.com/angular/angular/issues/13436#issuecomment-530060350
automatic conversation locking policyhttps://github.com/angular/angular/blob/67d80f/docs/GITHUB_PROCESS.md#conversation-locking
angular-automatic-lock-bothttps://github.com/apps/angular-automatic-lock-bot
on Sep 10, 2019https://github.com/angular/angular/issues/13436#event-2623238953
Sign up for freehttps://github.com/signup?return_to=https://github.com/angular/angular/issues/13436
Sign in to commenthttps://github.com/login?return_to=https://github.com/angular/angular/issues/13436
area: coreIssues related to the framework runtimehttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20core%22
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.