René's URL Explorer Experiment


Title: Provide customizable object comparison method for NgModel · Issue #13268 · angular/angular · GitHub

Open Graph Title: Provide customizable object comparison method for NgModel · Issue #13268 · angular/angular

X Title: Provide customizable object comparison method for NgModel · Issue #13268 · angular/angular

Description: I'm submitting a ... (check one with "x") [ ] bug report => search github for a similar issue or PR before submitting [x] feature request [ ] support request => Please do not submit support request here, instead see https://github.com/an...

Open Graph Description: I'm submitting a ... (check one with "x") [ ] bug report => search github for a similar issue or PR before submitting [x] feature request [ ] support request => Please do not submit support request...

X Description: I'm submitting a ... (check one with "x") [ ] bug report => search github for a similar issue or PR before submitting [x] feature request [ ] support request => Please do not su...

Opengraph URL: https://github.com/angular/angular/issues/13268

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Provide customizable object comparison method for NgModel","articleBody":"**I'm submitting a ...**  (check one with \"x\")\r\n```\r\n[ ] bug report => search github for a similar issue or PR before submitting\r\n[x] feature request\r\n[ ] support request => Please do not submit support request here, instead see https://github.com/angular/angular/blob/master/CONTRIBUTING.md#question\r\n```\r\n**Current behavior**\r\nCurrently NgModel does object reference comparison. This is not very flexible. \r\n\r\n**Minimal reproduction of the problem with instructions**\r\nSee example with two multi selects - first one doesn't use workaround to enforce usage of same instances. The second one does.\r\n\r\nhttp://plnkr.co/edit/MND6j3Wa5ZDsIt9X9ZVQ?p=preview\r\n\r\n**What is the motivation / use case for changing the behavior?**\r\nObjects do not always come from the same source. They typically come from some REST service. And they usually don't have the same instance.\r\n\r\nCurrent behavior requires workaround for something I believe to be very (if not the most) common use case. I think those should be supported by framework without requiring any workarounds.\r\n\r\n**Suggested solution**\r\nI suggest creating comparator object (or callback) which would compare two objects and return true if they are equal. NgModel would then internally use this comparator to compare objects.\r\n\r\nResulting code could look like this:\r\n```html\r\n\u003cselect multiple class=\"form-control\" \r\n name=\"selectedCountries\" \r\n [ngComparator]=\"countryComparator\" \r\n [(ngModel)]=\"selectedCountries\">\r\n   \u003coption *ngFor=\"let country of countries\" [ngValue]=\"country\">\r\n      {{country.name}}\r\n   \u003c/option>\r\n\u003c/select>\r\n```\r\n\r\nFramework could also provide some default comparators - for example one, which would compare object attributes. That one would be sufficient for quite a lot of use cases.\r\n\r\n\r\nIf there already is some standard solution, please point me to it. I tried to search and I didn't find anything. I found just [this stack overflow post](http://stackoverflow.com/questions/40325480/angular2-ngmodel-ngvalue-select-option-object-equality-across-different-instan) describing the same problem,  but not providing any solution.","author":{"url":"https://github.com/klinki","@type":"Person","name":"klinki"},"datePublished":"2016-12-06T11:35:47Z","url":"https://github.com/angular/angular/issues/13268"}

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:42812c86-4a48-6646-ac40-c873641b69e5
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-idABAE:E3C4F:12554C3:1764088:6B0121B3
html-safe-nonce7fc7d4f8ed80569583be50eb3acce3ca9312de5e3260c1d4ef7158df08f54369
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBQkFFOkUzQzRGOjEyNTU0QzM6MTc2NDA4ODo2QjAxMjFCMyIsInZpc2l0b3JfaWQiOiI5MDYwNzgwNzk0NjE5OTYxNzc5IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac2ac48bef6dfebc9a55c0a6f84572ea8af1e6c8b52835e800919cd40fa41408c4
hovercard-subject-tagissue:193749897
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/angular/angular/13268/issue_layout
twitter:imagehttps://opengraph.githubassets.com/0b8db3a871b655b13d740487b62c799d24d92b6bd63374a6075f5fc5f10e92fd/angular/angular/issues/13268
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/0b8db3a871b655b13d740487b62c799d24d92b6bd63374a6075f5fc5f10e92fd/angular/angular/issues/13268
og:image:altI'm submitting a ... (check one with "x") [ ] bug report => search github for a similar issue or PR before submitting [x] feature request [ ] support request => Please do not submit support request...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameklinki
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-preview
go-importgithub.com/angular/angular git https://github.com/angular/angular.git
octolytics-dimension-user_id139426
octolytics-dimension-user_loginangular
octolytics-dimension-repository_id24195339
octolytics-dimension-repository_nwoangular/angular
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id24195339
octolytics-dimension-repository_network_root_nwoangular/angular
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-nameissues

Links:

Skip to contenthttps://github.com/angular/angular/issues/13268#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fissues%2F13268
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fissues%2F13268
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=angular%2Fangular
Reloadhttps://github.com/angular/angular/issues/13268
Reloadhttps://github.com/angular/angular/issues/13268
Reloadhttps://github.com/angular/angular/issues/13268
angularhttps://github.com/angular
angularhttps://github.com/angular/angular
Codehttps://github.com/angular/angular
Issues835 (835)https://github.com/angular/angular/issues
Pull requests141 (141)https://github.com/angular/angular/pulls
Discussionshttps://github.com/angular/angular/discussions
Actionshttps://github.com/angular/angular/actions
Projectshttps://github.com/angular/angular/projects
Security and quality40 (40)https://github.com/angular/angular/security
Insightshttps://github.com/angular/angular/insights
https://github.com/angular/angular
New issuehttps://github.com/login?return_to=https://github.com/angular/angular/issues/13268
New issuehttps://github.com/login?return_to=https://github.com/angular/angular/issues/13268
Provide customizable object comparison method for NgModelhttps://github.com/angular/angular/issues/13268#top
area: formshttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20forms%22
featureLabel used to distinguish feature request from other issueshttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22feature%22
freq2: mediumhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22freq2%3A%20medium%22
https://github.com/klinki
klinkihttps://github.com/klinki
on Dec 6, 2016https://github.com/angular/angular/issues/13268#issue-193749897
http://plnkr.co/edit/MND6j3Wa5ZDsIt9X9ZVQ?p=previewhttp://plnkr.co/edit/MND6j3Wa5ZDsIt9X9ZVQ?p=preview
this stack overflow posthttp://stackoverflow.com/questions/40325480/angular2-ngmodel-ngvalue-select-option-object-equality-across-different-instan
pkozlowski-opensourcehttps://github.com/pkozlowski-opensource
area: formshttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20forms%22
featureLabel used to distinguish feature request from other issueshttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22feature%22
on Dec 6, 2016https://github.com/angular/angular/issues/13268#event-883576278
karahttps://github.com/kara
freq2: mediumhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22freq2%3A%20medium%22
on Dec 12, 2016https://github.com/angular/angular/issues/13268#event-889836308
https://github.com/noamichael
noamichaelhttps://github.com/noamichael
on Jan 12, 2017https://github.com/angular/angular/issues/13268#issuecomment-272158157
https://github.com/noamichael
noamichaelhttps://github.com/noamichael
on Jan 12, 2017https://github.com/angular/angular/issues/13268#issuecomment-272167041
mheveryhttps://github.com/mhevery
on Jan 31, 2017https://github.com/angular/angular/issues/13268#event-943965395
fix(forms): provide a method to compare options (#13349)https://github.com/angular/angular/commit/f89d004c519fd1645b9f94ff40cd740ad3658360
#13349https://github.com/angular/angular/pull/13349
https://docs.github.com/articles/closing-issues-via-commit-messages
f89d004https://github.com/angular/angular/commit/f89d004c519fd1645b9f94ff40cd740ad3658360
mheveryhttps://github.com/mhevery
completedhttps://github.com/angular/angular/issues?q=is%3Aissue%20state%3Aclosed%20archived%3Afalse%20reason%3Acompleted
f89d004https://github.com/angular/angular/commit/f89d004c519fd1645b9f94ff40cd740ad3658360
on Jan 31, 2017https://github.com/angular/angular/issues/13268#event-943966404
asnowwolfhttps://github.com/asnowwolf
on Aug 11, 2017https://github.com/angular/angular/issues/13268#event-1201913035
fix(forms): provide a method to compare options (angular#13349)https://github.com/asnowwolf/angular/commit/4bd444f5b5935ae8945b5c47e7f63fdb5a6bf734
angular#13349https://github.com/angular/angular/pull/13349
https://docs.github.com/articles/closing-issues-via-commit-messages
4bd444fhttps://github.com/asnowwolf/angular/commit/4bd444f5b5935ae8945b5c47e7f63fdb5a6bf734
juleskremerhttps://github.com/juleskremer
on Aug 28, 2017https://github.com/angular/angular/issues/13268#event-1224652212
fix(forms): provide a method to compare options (angular#13349)https://github.com/juleskremer/angular/commit/4432324bebac67fc1a91b0b8eba94ab58513651a
angular#13349https://github.com/angular/angular/pull/13349
https://docs.github.com/articles/closing-issues-via-commit-messages
4432324https://github.com/juleskremer/angular/commit/4432324bebac67fc1a91b0b8eba94ab58513651a
https://github.com/oskarols
oskarolshttps://github.com/oskarols
on Jan 15, 2018https://github.com/angular/angular/issues/13268#issuecomment-357664156
https://github.com/apps/angular-automatic-lock-bot
angular-automatic-lock-bothttps://github.com/apps/angular-automatic-lock-bot
on Sep 13, 2019https://github.com/angular/angular/issues/13268#issuecomment-531096963
automatic conversation locking policyhttps://github.com/angular/angular/blob/67d80f/docs/GITHUB_PROCESS.md#conversation-locking
angular-automatic-lock-bothttps://github.com/apps/angular-automatic-lock-bot
on Sep 13, 2019https://github.com/angular/angular/issues/13268#event-2631192902
Sign up for freehttps://github.com/signup?return_to=https://github.com/angular/angular/issues/13268
Sign in to commenthttps://github.com/login?return_to=https://github.com/angular/angular/issues/13268
area: formshttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20forms%22
featureLabel used to distinguish feature request from other issueshttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22feature%22
freq2: mediumhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22freq2%3A%20medium%22
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.