Title: Provide customizable object comparison method for NgModel · Issue #13268 · angular/angular · GitHub
Open Graph Title: Provide customizable object comparison method for NgModel · Issue #13268 · angular/angular
X Title: Provide customizable object comparison method for NgModel · Issue #13268 · angular/angular
Description: I'm submitting a ... (check one with "x") [ ] bug report => search github for a similar issue or PR before submitting [x] feature request [ ] support request => Please do not submit support request here, instead see https://github.com/an...
Open Graph Description: I'm submitting a ... (check one with "x") [ ] bug report => search github for a similar issue or PR before submitting [x] feature request [ ] support request => Please do not submit support request...
X Description: I'm submitting a ... (check one with "x") [ ] bug report => search github for a similar issue or PR before submitting [x] feature request [ ] support request => Please do not su...
Opengraph URL: https://github.com/angular/angular/issues/13268
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Provide customizable object comparison method for NgModel","articleBody":"**I'm submitting a ...** (check one with \"x\")\r\n```\r\n[ ] bug report => search github for a similar issue or PR before submitting\r\n[x] feature request\r\n[ ] support request => Please do not submit support request here, instead see https://github.com/angular/angular/blob/master/CONTRIBUTING.md#question\r\n```\r\n**Current behavior**\r\nCurrently NgModel does object reference comparison. This is not very flexible. \r\n\r\n**Minimal reproduction of the problem with instructions**\r\nSee example with two multi selects - first one doesn't use workaround to enforce usage of same instances. The second one does.\r\n\r\nhttp://plnkr.co/edit/MND6j3Wa5ZDsIt9X9ZVQ?p=preview\r\n\r\n**What is the motivation / use case for changing the behavior?**\r\nObjects do not always come from the same source. They typically come from some REST service. And they usually don't have the same instance.\r\n\r\nCurrent behavior requires workaround for something I believe to be very (if not the most) common use case. I think those should be supported by framework without requiring any workarounds.\r\n\r\n**Suggested solution**\r\nI suggest creating comparator object (or callback) which would compare two objects and return true if they are equal. NgModel would then internally use this comparator to compare objects.\r\n\r\nResulting code could look like this:\r\n```html\r\n\u003cselect multiple class=\"form-control\" \r\n name=\"selectedCountries\" \r\n [ngComparator]=\"countryComparator\" \r\n [(ngModel)]=\"selectedCountries\">\r\n \u003coption *ngFor=\"let country of countries\" [ngValue]=\"country\">\r\n {{country.name}}\r\n \u003c/option>\r\n\u003c/select>\r\n```\r\n\r\nFramework could also provide some default comparators - for example one, which would compare object attributes. That one would be sufficient for quite a lot of use cases.\r\n\r\n\r\nIf there already is some standard solution, please point me to it. I tried to search and I didn't find anything. I found just [this stack overflow post](http://stackoverflow.com/questions/40325480/angular2-ngmodel-ngvalue-select-option-object-equality-across-different-instan) describing the same problem, but not providing any solution.","author":{"url":"https://github.com/klinki","@type":"Person","name":"klinki"},"datePublished":"2016-12-06T11:35:47Z","url":"https://github.com/angular/angular/issues/13268"}
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:42812c86-4a48-6646-ac40-c873641b69e5 |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | ABAE:E3C4F:12554C3:1764088:6B0121B3 |
| html-safe-nonce | 7fc7d4f8ed80569583be50eb3acce3ca9312de5e3260c1d4ef7158df08f54369 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBQkFFOkUzQzRGOjEyNTU0QzM6MTc2NDA4ODo2QjAxMjFCMyIsInZpc2l0b3JfaWQiOiI5MDYwNzgwNzk0NjE5OTYxNzc5IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | 2ac48bef6dfebc9a55c0a6f84572ea8af1e6c8b52835e800919cd40fa41408c4 |
| hovercard-subject-tag | issue:193749897 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/angular/angular/13268/issue_layout |
| twitter:image | https://opengraph.githubassets.com/0b8db3a871b655b13d740487b62c799d24d92b6bd63374a6075f5fc5f10e92fd/angular/angular/issues/13268 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/0b8db3a871b655b13d740487b62c799d24d92b6bd63374a6075f5fc5f10e92fd/angular/angular/issues/13268 |
| og:image:alt | I'm submitting a ... (check one with "x") [ ] bug report => search github for a similar issue or PR before submitting [x] feature request [ ] support request => Please do not submit support request... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | klinki |
| hostname | github.com |
| expected-hostname | github.com |
| None | cc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c |
| turbo-cache-control | no-preview |
| go-import | github.com/angular/angular git https://github.com/angular/angular.git |
| octolytics-dimension-user_id | 139426 |
| octolytics-dimension-user_login | angular |
| octolytics-dimension-repository_id | 24195339 |
| octolytics-dimension-repository_nwo | angular/angular |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 24195339 |
| octolytics-dimension-repository_network_root_nwo | angular/angular |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 8c77c9e8439031ad54c75a250694842892f693e1 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | issues |
Links:
Viewport: width=device-width