René's URL Explorer Experiment


Title: AoT compiled components do not call inherited lifecycle hooks · Issue #12922 · angular/angular · GitHub

Open Graph Title: AoT compiled components do not call inherited lifecycle hooks · Issue #12922 · angular/angular

X Title: AoT compiled components do not call inherited lifecycle hooks · Issue #12922 · angular/angular

Description: I'm submitting a ... (check one with "x") [x] bug report => search github for a similar issue or PR before submitting [ ] feature request [ ] support request => Please do not submit support request here, instead see https://github.com/an...

Open Graph Description: I'm submitting a ... (check one with "x") [x] bug report => search github for a similar issue or PR before submitting [ ] feature request [ ] support request => Please do not submit support request...

X Description: I'm submitting a ... (check one with "x") [x] bug report => search github for a similar issue or PR before submitting [ ] feature request [ ] support request => Please do not su...

Opengraph URL: https://github.com/angular/angular/issues/12922

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"AoT compiled components do not call inherited lifecycle hooks","articleBody":"**I'm submitting a ...**  (check one with \"x\")\r\n```\r\n[x] bug report => search github for a similar issue or PR before submitting\r\n[ ] feature request\r\n[ ] support request => Please do not submit support request here, instead see https://github.com/angular/angular/blob/master/CONTRIBUTING.md#question\r\n```\r\n\r\n**Current behavior**\r\nThe AoT compiler does not look up the inheritance tree when checking for lifecycle hooks, which results in different behaviour than when compiling JiT.\r\n\r\n**Expected behavior**\r\n\r\nThe AoT compiler should search all super classes of a component for implementation of lifecycle hooks.\r\n\r\n**Minimal reproduction of the problem with instructions**\r\n\r\n```\r\nclass BaseComponent implements OnInit {\r\n  ngOnInit() {\r\n    // do something important\r\n  }\r\n}\r\n\r\n@Component( ... )\r\nclass ConcreteComponent extends BaseComponent {\r\n  ...\r\n}\r\n```\r\n\r\nWhen running in JiT mode, the `ngOnInit()` method will be called when the `ConcreteComponent` is instantiated. But in AoT mode, the function will not be called.\r\n\r\nCurrently, the workaround is to explicitly implement all the super class hooks:\r\n\r\n```\r\n@Component( ... )\r\nclass ConcreteComponent extends BaseComponent {\r\n  ngOnInit() {\r\n    super.ngOnInit();\r\n  }\r\n}\r\n```\r\n\r\nThis is the case for all the lifecycle hooks, not just `ngOnInit`.\r\n\r\n**What is the motivation / use case for changing the behavior?**\r\n\r\nThis is especially important for the `@angular/upgrade/static` library which has a base class, `UpgradeComponent`, for Angular 2 components that are used to upgrade Angular 1 components.\r\n\r\n* **Angular version:** \u003c=2.2.0 (and master at time of writing)\r\n","author":{"url":"https://github.com/petebacondarwin","@type":"Person","name":"petebacondarwin"},"datePublished":"2016-11-16T17:45:17Z","url":"https://github.com/angular/angular/issues/12922"}

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:58286248-cd78-300c-66ee-a69aed539b75
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-id9CD0:7A60E:909B9A:BCE577:6B00DFF0
html-safe-nonce7b053514dffaf01810acf9017e683c6652f25788edc4229bf20d29b8d6dd677e
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5Q0QwOjdBNjBFOjkwOUI5QTpCQ0U1Nzc6NkIwMERGRjAiLCJ2aXNpdG9yX2lkIjoiMjc3NDI2MzA5NjQ3NzI3ODE5MiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmaca7440c2362868c34a69d44c5e2ccc68db7ad11d224773341277e05a7de853c43
hovercard-subject-tagissue:189786867
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/angular/angular/12922/issue_layout
twitter:imagehttps://opengraph.githubassets.com/9d9e7cf0494088bf19d8a2124e94b83a3bff04e8ae01f74695fce4a26f1a43fb/angular/angular/issues/12922
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/9d9e7cf0494088bf19d8a2124e94b83a3bff04e8ae01f74695fce4a26f1a43fb/angular/angular/issues/12922
og:image:altI'm submitting a ... (check one with "x") [x] bug report => search github for a similar issue or PR before submitting [ ] feature request [ ] support request => Please do not submit support request...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamepetebacondarwin
hostnamegithub.com
expected-hostnamegithub.com
None043c3f30fbcbe2c6c8e729e10cbbbc90c406546f9fbbb67c648d38f6b7d16daf
turbo-cache-controlno-preview
go-importgithub.com/angular/angular git https://github.com/angular/angular.git
octolytics-dimension-user_id139426
octolytics-dimension-user_loginangular
octolytics-dimension-repository_id24195339
octolytics-dimension-repository_nwoangular/angular
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id24195339
octolytics-dimension-repository_network_root_nwoangular/angular
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release5425dc24e8bd8d6fca9641a12afc984825a43875
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-nameissues

Links:

Skip to contenthttps://github.com/angular/angular/issues/12922#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fissues%2F12922
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fissues%2F12922
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=angular%2Fangular
Reloadhttps://github.com/angular/angular/issues/12922
Reloadhttps://github.com/angular/angular/issues/12922
Reloadhttps://github.com/angular/angular/issues/12922
angularhttps://github.com/angular
angularhttps://github.com/angular/angular
Codehttps://github.com/angular/angular
Issues835 (835)https://github.com/angular/angular/issues
Pull requests140 (140)https://github.com/angular/angular/pulls
Discussionshttps://github.com/angular/angular/discussions
Actionshttps://github.com/angular/angular/actions
Projectshttps://github.com/angular/angular/projects
Security and quality40 (40)https://github.com/angular/angular/security
Insightshttps://github.com/angular/angular/insights
https://github.com/angular/angular
New issuehttps://github.com/login?return_to=https://github.com/angular/angular/issues/12922
New issuehttps://github.com/login?return_to=https://github.com/angular/angular/issues/12922
AoT compiled components do not call inherited lifecycle hookshttps://github.com/angular/angular/issues/12922#top
area: coreIssues related to the framework runtimehttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20core%22
freq2: mediumhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22freq2%3A%20medium%22
type: bug/fixhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22type%3A%20bug%2Ffix%22
workaround2: non-obvioushttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22workaround2%3A%20non-obvious%22
https://github.com/petebacondarwin
petebacondarwinhttps://github.com/petebacondarwin
on Nov 16, 2016https://github.com/angular/angular/issues/12922#issue-189786867
petebacondarwinhttps://github.com/petebacondarwin
area: coreIssues related to the framework runtimehttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20core%22
freq2: mediumhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22freq2%3A%20medium%22
hotlist: angular-core-teamhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22hotlist%3A%20angular-core-team%22
severity2: inconvenienthttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22severity2%3A%20inconvenient%22
type: bug/fixhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22type%3A%20bug%2Ffix%22
workaround2: non-obvioushttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22workaround2%3A%20non-obvious%22
on Nov 16, 2016https://github.com/angular/angular/issues/12922#event-861480951
petebacondarwinhttps://github.com/petebacondarwin
on Nov 16, 2016https://github.com/angular/angular/issues/12922#event-861480958
https://github.com/vicb
vicbhttps://github.com/vicb
on Nov 16, 2016https://github.com/angular/angular/issues/12922#issuecomment-261018037
#11606https://github.com/angular/angular/issues/11606
https://github.com/DzmitryShylovich
DzmitryShylovichhttps://github.com/DzmitryShylovich
on Nov 16, 2016https://github.com/angular/angular/issues/12922#issuecomment-261018414
#12756 (comment)https://github.com/angular/angular/issues/12756#issuecomment-260804139
https://github.com/petebacondarwin
petebacondarwinhttps://github.com/petebacondarwin
on Nov 16, 2016https://github.com/angular/angular/issues/12922#issuecomment-261019039
petebacondarwinhttps://github.com/petebacondarwin
completedhttps://github.com/angular/angular/issues?q=is%3Aissue%20state%3Aclosed%20archived%3Afalse%20reason%3Acompleted
on Nov 16, 2016https://github.com/angular/angular/issues/12922#event-861488650
https://github.com/insidewhy
insidewhyhttps://github.com/insidewhy
on Sep 25, 2017https://github.com/angular/angular/issues/12922#issuecomment-331992412
https://github.com/Nide83
Nide83https://github.com/Nide83
on Dec 18, 2018https://github.com/angular/angular/issues/12922#issuecomment-448358610
https://github.com/insidewhy
insidewhyhttps://github.com/insidewhy
on Dec 18, 2018https://github.com/angular/angular/issues/12922#issuecomment-448375417
@Nide83https://github.com/Nide83
https://github.com/Nide83
Nide83https://github.com/Nide83
on Dec 18, 2018https://github.com/angular/angular/issues/12922#issuecomment-448377641
@ohjameshttps://github.com/ohjames
https://github.com/Nide83
Nide83https://github.com/Nide83
on Dec 20, 2018https://github.com/angular/angular/issues/12922#issuecomment-449017695
https://github.com/petebacondarwin
petebacondarwinhttps://github.com/petebacondarwin
on Dec 20, 2018https://github.com/angular/angular/issues/12922#issuecomment-449084016
https://github.com/apps/angular-automatic-lock-bot
angular-automatic-lock-bothttps://github.com/apps/angular-automatic-lock-bot
on Sep 14, 2019https://github.com/angular/angular/issues/12922#issuecomment-531471801
automatic conversation locking policyhttps://github.com/angular/angular/blob/67d80f/docs/GITHUB_PROCESS.md#conversation-locking
angular-automatic-lock-bothttps://github.com/apps/angular-automatic-lock-bot
on Sep 14, 2019https://github.com/angular/angular/issues/12922#event-2634086741
Sign up for freehttps://github.com/signup?return_to=https://github.com/angular/angular/issues/12922
Sign in to commenthttps://github.com/login?return_to=https://github.com/angular/angular/issues/12922
area: coreIssues related to the framework runtimehttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20core%22
freq2: mediumhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22freq2%3A%20medium%22
type: bug/fixhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22type%3A%20bug%2Ffix%22
workaround2: non-obvioushttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22workaround2%3A%20non-obvious%22
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.