René's URL Explorer Experiment


Title: [2.2.0-rc.0] AoT can't add UpgradeComponent to @NgModule.entryComponents · Issue #12756 · angular/angular · GitHub

Open Graph Title: [2.2.0-rc.0] AoT can't add UpgradeComponent to @NgModule.entryComponents · Issue #12756 · angular/angular

X Title: [2.2.0-rc.0] AoT can't add UpgradeComponent to @NgModule.entryComponents · Issue #12756 · angular/angular

Description: I'm submitting a ... (check one with "x") [x] bug report => search github for a similar issue or PR before submitting [ ] feature request [ ] support request => Please do not submit support request here, instead see https://github.com/an...

Open Graph Description: I'm submitting a ... (check one with "x") [x] bug report => search github for a similar issue or PR before submitting [ ] feature request [ ] support request => Please do not submit support request...

X Description: I'm submitting a ... (check one with "x") [x] bug report => search github for a similar issue or PR before submitting [ ] feature request [ ] support request => Please do not su...

Opengraph URL: https://github.com/angular/angular/issues/12756

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"[2.2.0-rc.0] AoT can't add UpgradeComponent to @NgModule.entryComponents ","articleBody":"\u003c!--\r\nIF YOU DON'T FILL OUT THE FOLLOWING INFORMATION WE MIGHT CLOSE YOUR ISSUE WITHOUT INVESTIGATING\r\n-->\r\n\r\n**I'm submitting a ...**  (check one with \"x\")\r\n```\r\n[x] bug report => search github for a similar issue or PR before submitting\r\n[ ] feature request\r\n[ ] support request => Please do not submit support request here, instead see https://github.com/angular/angular/blob/master/CONTRIBUTING.md#question\r\n```\r\n\r\n**Current behavior**\r\n\u003c!-- Describe how the bug manifests. -->\r\nUpgradeComponent can not be added to entryComponents of @NgModule.\r\n\r\n**a) with JIT**\r\n1. compiles OK\r\n2. upgraded component does not render\r\n3. console error: Uncaught Error: Could not compile 'ForUpgradeDirective' because it is not a component\r\n\r\n**b) with AoT**\r\n1. compile FAILED\r\n2. compile error:\r\nERROR in ./_aot/module.ngfactory.ts\r\n(79,7): error TS2304: Cannot find name 'ForUpgradeDirectiveNgFactory'.\r\n\r\nIf you remove \"ForUpgradeDirective\" from entryComponents in src/module.ts\r\n\r\n**c) with JIT**\r\n1. compiles OK\r\n2. displays OK, browser shows\r\nng1: hello from ng1 \r\nng2: hello from ng1\r\n\r\n**d) with AoT**\r\n1. compiles OK\r\n2. display NOT OK, browser shows\r\nng1: hello from ng1 \r\nng2: \r\n\r\n**Expected behavior**\r\n\u003c!-- Describe what the behavior would be without the bug. -->\r\nShould compile & render UpgradeComponent when added to @NgModule.entryComponents \r\n\r\n**Minimal reproduction of the problem with instructions**\r\n\u003c!--\r\nIf the current behavior is a bug or you can illustrate your feature request better with an example, \r\nplease provide the *STEPS TO REPRODUCE* and if possible a *MINIMAL DEMO* of the problem via\r\nhttps://plnkr.co or similar (you can use this template as a starting point: http://plnkr.co/edit/tpl:AvJOMERrnz94ekVua0u5).\r\n-->\r\n[test-upgrade.zip](https://github.com/angular/angular/files/590615/test-upgrade.zip)\r\n\r\n\r\nfor a & b above\r\na) npm run jit\r\nb) npm run aot\r\n\r\nfor c & d above, remove ForUpgradeDirective from entryComponents and again run\r\nc) npm run jit\r\nd) npm run aot\r\n\r\n\r\n**What is the motivation / use case for changing the behavior?**\r\n\u003c!-- Describe the motivation or the concrete use case -->\r\n\r\nCan't upgrade ng1 components and use AoT at the same time\r\n\r\n**Please tell us about your environment:**\r\n\u003c!-- Operating system, IDE, package manager, HTTP server, ... -->\r\n\r\n* **Angular version:** 2.2.0-rc.0\r\n\u003c!-- Check whether this is still an issue in the most recent Angular version -->\r\n\r\n* **Browser:** [all]\r\n\u003c!-- All browsers where this could be reproduced -->\r\n \r\n* **Language:** [ TypeScript 2.0.2]\r\n\r\n* **Node (for AoT issues):** `node --version` =   v6.6.0\r\n","author":{"url":"https://github.com/guojenman","@type":"Person","name":"guojenman"},"datePublished":"2016-11-07T21:25:06Z","url":"https://github.com/angular/angular/issues/12756"}

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:8e3d3e2b-6307-46fa-527c-988498b36541
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-idDE4A:19114D:AEA795:E20B53:6B00E566
html-safe-nonce00ceae95467d5329a5bb28a36f23e68438c899829c82e975bac8feae73fc0faa
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJERTRBOjE5MTE0RDpBRUE3OTU6RTIwQjUzOjZCMDBFNTY2IiwidmlzaXRvcl9pZCI6IjcwMTA3NTMzODE5NTAwODg1NTAiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac12ac616e9c565178becdbd7b304f0b7a9fa64c1c652a6eb001f5c86487d12ff9
hovercard-subject-tagissue:187833136
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/angular/angular/12756/issue_layout
twitter:imagehttps://opengraph.githubassets.com/c99a2d09687f5e17408bbcaafb8790b92bd5f6a5a2dde778548ce8293ca480c6/angular/angular/issues/12756
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/c99a2d09687f5e17408bbcaafb8790b92bd5f6a5a2dde778548ce8293ca480c6/angular/angular/issues/12756
og:image:altI'm submitting a ... (check one with "x") [x] bug report => search github for a similar issue or PR before submitting [ ] feature request [ ] support request => Please do not submit support request...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameguojenman
hostnamegithub.com
expected-hostnamegithub.com
None27088b6977484d0d3321d9a11c907c6d6637b315cfa359ef7952dbf6292f9b14
turbo-cache-controlno-preview
go-importgithub.com/angular/angular git https://github.com/angular/angular.git
octolytics-dimension-user_id139426
octolytics-dimension-user_loginangular
octolytics-dimension-repository_id24195339
octolytics-dimension-repository_nwoangular/angular
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id24195339
octolytics-dimension-repository_network_root_nwoangular/angular
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release624179fb8b88d26ba5bba08894eb60a1c5a1d93d
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-nameissues

Links:

Skip to contenthttps://github.com/angular/angular/issues/12756#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fissues%2F12756
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fissues%2F12756
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=angular%2Fangular
Reloadhttps://github.com/angular/angular/issues/12756
Reloadhttps://github.com/angular/angular/issues/12756
Reloadhttps://github.com/angular/angular/issues/12756
angularhttps://github.com/angular
angularhttps://github.com/angular/angular
Codehttps://github.com/angular/angular
Issues835 (835)https://github.com/angular/angular/issues
Pull requests140 (140)https://github.com/angular/angular/pulls
Discussionshttps://github.com/angular/angular/discussions
Actionshttps://github.com/angular/angular/actions
Projectshttps://github.com/angular/angular/projects
Security and quality40 (40)https://github.com/angular/angular/security
Insightshttps://github.com/angular/angular/insights
https://github.com/angular/angular
New issuehttps://github.com/login?return_to=https://github.com/angular/angular/issues/12756
New issuehttps://github.com/login?return_to=https://github.com/angular/angular/issues/12756
[2.2.0-rc.0] AoT can't add UpgradeComponent to @NgModule.entryComponents https://github.com/angular/angular/issues/12756#top
https://github.com/guojenman
guojenmanhttps://github.com/guojenman
on Nov 7, 2016https://github.com/angular/angular/issues/12756#issue-187833136
@NgModulehttps://github.com/NgModule
test-upgrade.ziphttps://github.com/angular/angular/files/590615/test-upgrade.zip
vicbhttps://github.com/vicb
comp: upgradehttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22comp%3A%20upgrade%22
on Nov 9, 2016https://github.com/angular/angular/issues/12756#event-853769582
https://github.com/manfredsteyer
manfredsteyerhttps://github.com/manfredsteyer
on Nov 10, 2016https://github.com/angular/angular/issues/12756#issuecomment-259569398
https://github.com/alexeagle
alexeaglehttps://github.com/alexeagle
on Nov 11, 2016https://github.com/angular/angular/issues/12756#issuecomment-259862786
@boureyhttps://github.com/bourey
https://github.com/bourey
boureyhttps://github.com/bourey
on Nov 11, 2016https://github.com/angular/angular/issues/12756#issuecomment-259870076
https://github.com/manfredsteyer
manfredsteyerhttps://github.com/manfredsteyer
on Nov 11, 2016https://github.com/angular/angular/issues/12756#issuecomment-260059057
https://github.com/angular/angular/blob/master/modules/%40angular/upgrade/test/aot/integration/upgrade_component_spec.tshttps://github.com/angular/angular/blob/master/modules/%40angular/upgrade/test/aot/integration/upgrade_component_spec.ts
https://github.com/manfredsteyer
manfredsteyerhttps://github.com/manfredsteyer
on Nov 14, 2016https://github.com/angular/angular/issues/12756#issuecomment-260451141
https://github.com/gkalpak
gkalpakhttps://github.com/gkalpak
on Nov 14, 2016https://github.com/angular/angular/issues/12756#issuecomment-260474558
https://github.com/guojenman
guojenmanhttps://github.com/guojenman
on Nov 14, 2016https://github.com/angular/angular/issues/12756#issuecomment-260479089
https://github.com/guojenman
guojenmanhttps://github.com/guojenman
on Nov 14, 2016https://github.com/angular/angular/issues/12756#issuecomment-260480978
test-upgrade.ziphttps://github.com/angular/angular/files/590621/test-upgrade.zip
https://github.com/gkalpak
gkalpakhttps://github.com/gkalpak
on Nov 15, 2016https://github.com/angular/angular/issues/12756#issuecomment-260797158
DirectiveWrapperBuilderhttps://github.com/angular/angular/blob/8f5dd1f11e6ca1888fdbd3231c06d6df00aba5cc/modules/%40angular/compiler/src/directive_wrapper_compiler.ts#L80
fails to detecthttps://github.com/angular/angular/blob/8f5dd1f11e6ca1888fdbd3231c06d6df00aba5cc/modules/%40angular/compiler/src/directive_wrapper_compiler.ts#L99
never calls ngOnInit()https://github.com/angular/angular/blob/8f5dd1f11e6ca1888fdbd3231c06d6df00aba5cc/modules/%40angular/compiler/src/directive_wrapper_compiler.ts#L184-L188
@alexeaglehttps://github.com/alexeagle
https://github.com/alexeagle
alexeaglehttps://github.com/alexeagle
on Nov 15, 2016https://github.com/angular/angular/issues/12756#issuecomment-260804139
@tboschhttps://github.com/tbosch
https://github.com/manfredsteyer
manfredsteyerhttps://github.com/manfredsteyer
on Nov 16, 2016https://github.com/angular/angular/issues/12756#issuecomment-260810446
guojenmanhttps://github.com/guojenman
completedhttps://github.com/angular/angular/issues?q=is%3Aissue%20state%3Aclosed%20archived%3Afalse%20reason%3Acompleted
on Nov 16, 2016https://github.com/angular/angular/issues/12756#event-860294707
https://github.com/gkalpak
gkalpakhttps://github.com/gkalpak
on Nov 16, 2016https://github.com/angular/angular/issues/12756#issuecomment-260901869
https://github.com/apps/angular-automatic-lock-bot
angular-automatic-lock-bothttps://github.com/apps/angular-automatic-lock-bot
on Sep 10, 2019https://github.com/angular/angular/issues/12756#issuecomment-529789256
automatic conversation locking policyhttps://github.com/angular/angular/blob/67d80f/docs/GITHUB_PROCESS.md#conversation-locking
angular-automatic-lock-bothttps://github.com/apps/angular-automatic-lock-bot
on Sep 10, 2019https://github.com/angular/angular/issues/12756#event-2621035468
Sign up for freehttps://github.com/signup?return_to=https://github.com/angular/angular/issues/12756
Sign in to commenthttps://github.com/login?return_to=https://github.com/angular/angular/issues/12756
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.