Title: [2.2.0-rc.0] AoT can't add UpgradeComponent to @NgModule.entryComponents · Issue #12756 · angular/angular · GitHub
Open Graph Title: [2.2.0-rc.0] AoT can't add UpgradeComponent to @NgModule.entryComponents · Issue #12756 · angular/angular
X Title: [2.2.0-rc.0] AoT can't add UpgradeComponent to @NgModule.entryComponents · Issue #12756 · angular/angular
Description: I'm submitting a ... (check one with "x") [x] bug report => search github for a similar issue or PR before submitting [ ] feature request [ ] support request => Please do not submit support request here, instead see https://github.com/an...
Open Graph Description: I'm submitting a ... (check one with "x") [x] bug report => search github for a similar issue or PR before submitting [ ] feature request [ ] support request => Please do not submit support request...
X Description: I'm submitting a ... (check one with "x") [x] bug report => search github for a similar issue or PR before submitting [ ] feature request [ ] support request => Please do not su...
Opengraph URL: https://github.com/angular/angular/issues/12756
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"[2.2.0-rc.0] AoT can't add UpgradeComponent to @NgModule.entryComponents ","articleBody":"\u003c!--\r\nIF YOU DON'T FILL OUT THE FOLLOWING INFORMATION WE MIGHT CLOSE YOUR ISSUE WITHOUT INVESTIGATING\r\n-->\r\n\r\n**I'm submitting a ...** (check one with \"x\")\r\n```\r\n[x] bug report => search github for a similar issue or PR before submitting\r\n[ ] feature request\r\n[ ] support request => Please do not submit support request here, instead see https://github.com/angular/angular/blob/master/CONTRIBUTING.md#question\r\n```\r\n\r\n**Current behavior**\r\n\u003c!-- Describe how the bug manifests. -->\r\nUpgradeComponent can not be added to entryComponents of @NgModule.\r\n\r\n**a) with JIT**\r\n1. compiles OK\r\n2. upgraded component does not render\r\n3. console error: Uncaught Error: Could not compile 'ForUpgradeDirective' because it is not a component\r\n\r\n**b) with AoT**\r\n1. compile FAILED\r\n2. compile error:\r\nERROR in ./_aot/module.ngfactory.ts\r\n(79,7): error TS2304: Cannot find name 'ForUpgradeDirectiveNgFactory'.\r\n\r\nIf you remove \"ForUpgradeDirective\" from entryComponents in src/module.ts\r\n\r\n**c) with JIT**\r\n1. compiles OK\r\n2. displays OK, browser shows\r\nng1: hello from ng1 \r\nng2: hello from ng1\r\n\r\n**d) with AoT**\r\n1. compiles OK\r\n2. display NOT OK, browser shows\r\nng1: hello from ng1 \r\nng2: \r\n\r\n**Expected behavior**\r\n\u003c!-- Describe what the behavior would be without the bug. -->\r\nShould compile & render UpgradeComponent when added to @NgModule.entryComponents \r\n\r\n**Minimal reproduction of the problem with instructions**\r\n\u003c!--\r\nIf the current behavior is a bug or you can illustrate your feature request better with an example, \r\nplease provide the *STEPS TO REPRODUCE* and if possible a *MINIMAL DEMO* of the problem via\r\nhttps://plnkr.co or similar (you can use this template as a starting point: http://plnkr.co/edit/tpl:AvJOMERrnz94ekVua0u5).\r\n-->\r\n[test-upgrade.zip](https://github.com/angular/angular/files/590615/test-upgrade.zip)\r\n\r\n\r\nfor a & b above\r\na) npm run jit\r\nb) npm run aot\r\n\r\nfor c & d above, remove ForUpgradeDirective from entryComponents and again run\r\nc) npm run jit\r\nd) npm run aot\r\n\r\n\r\n**What is the motivation / use case for changing the behavior?**\r\n\u003c!-- Describe the motivation or the concrete use case -->\r\n\r\nCan't upgrade ng1 components and use AoT at the same time\r\n\r\n**Please tell us about your environment:**\r\n\u003c!-- Operating system, IDE, package manager, HTTP server, ... -->\r\n\r\n* **Angular version:** 2.2.0-rc.0\r\n\u003c!-- Check whether this is still an issue in the most recent Angular version -->\r\n\r\n* **Browser:** [all]\r\n\u003c!-- All browsers where this could be reproduced -->\r\n \r\n* **Language:** [ TypeScript 2.0.2]\r\n\r\n* **Node (for AoT issues):** `node --version` = v6.6.0\r\n","author":{"url":"https://github.com/guojenman","@type":"Person","name":"guojenman"},"datePublished":"2016-11-07T21:25:06Z","url":"https://github.com/angular/angular/issues/12756"}
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:8e3d3e2b-6307-46fa-527c-988498b36541 |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | DE4A:19114D:AEA795:E20B53:6B00E566 |
| html-safe-nonce | 00ceae95467d5329a5bb28a36f23e68438c899829c82e975bac8feae73fc0faa |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJERTRBOjE5MTE0RDpBRUE3OTU6RTIwQjUzOjZCMDBFNTY2IiwidmlzaXRvcl9pZCI6IjcwMTA3NTMzODE5NTAwODg1NTAiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 12ac616e9c565178becdbd7b304f0b7a9fa64c1c652a6eb001f5c86487d12ff9 |
| hovercard-subject-tag | issue:187833136 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/angular/angular/12756/issue_layout |
| twitter:image | https://opengraph.githubassets.com/c99a2d09687f5e17408bbcaafb8790b92bd5f6a5a2dde778548ce8293ca480c6/angular/angular/issues/12756 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/c99a2d09687f5e17408bbcaafb8790b92bd5f6a5a2dde778548ce8293ca480c6/angular/angular/issues/12756 |
| og:image:alt | I'm submitting a ... (check one with "x") [x] bug report => search github for a similar issue or PR before submitting [ ] feature request [ ] support request => Please do not submit support request... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | guojenman |
| hostname | github.com |
| expected-hostname | github.com |
| None | 27088b6977484d0d3321d9a11c907c6d6637b315cfa359ef7952dbf6292f9b14 |
| turbo-cache-control | no-preview |
| go-import | github.com/angular/angular git https://github.com/angular/angular.git |
| octolytics-dimension-user_id | 139426 |
| octolytics-dimension-user_login | angular |
| octolytics-dimension-repository_id | 24195339 |
| octolytics-dimension-repository_nwo | angular/angular |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 24195339 |
| octolytics-dimension-repository_network_root_nwo | angular/angular |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 624179fb8b88d26ba5bba08894eb60a1c5a1d93d |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | issues |
Links:
Viewport: width=device-width