René's URL Explorer Experiment


Title: Date pipe time component extraction issues across locales · Issue #12632 · angular/angular · GitHub

Open Graph Title: Date pipe time component extraction issues across locales · Issue #12632 · angular/angular

X Title: Date pipe time component extraction issues across locales · Issue #12632 · angular/angular

Description: I'm submitting a ... (check one with "x") [x] bug report => search github for a similar issue or PR before submitting [ ] feature request [ ] support request Current behavior The date pipe output is incorrect when custom formats are used...

Open Graph Description: I'm submitting a ... (check one with "x") [x] bug report => search github for a similar issue or PR before submitting [ ] feature request [ ] support request Current behavior The date pipe output i...

X Description: I'm submitting a ... (check one with "x") [x] bug report => search github for a similar issue or PR before submitting [ ] feature request [ ] support request Current behavior The d...

Opengraph URL: https://github.com/angular/angular/issues/12632

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Date pipe time component extraction issues across locales","articleBody":"**I'm submitting a ...**  (check one with \"x\")\r\n```\r\n[x] bug report => search github for a similar issue or PR before submitting\r\n[ ] feature request\r\n[ ] support request\r\n```\r\n\r\n**Current behavior**\r\nThe date pipe output is incorrect when custom formats are used with various locales. The current implementation will use Intl.DateTimeFormat to localize DateTime information, and then use string manipulation to extract individual components as the output is not granular enough. The bugs come mainly from assumptions about how the format looks across all locales. \r\n\r\nI've provided unit tests as a repro- the expected results are valid on Chrome, but not necessarily IE - (different browsers format locales differently, including the order of components, number system and alphabets used.) See the full tests created while investigating the issue at https://gist.github.com/gary-b/bdc67fae4767c7da08ee93965a955fa5 \r\n\r\nassume date = new Date(2015, 5, 15, 9, 3, 1);\r\n1.The day part ('a') output fails in various locales\r\n```\r\n// When Intl.DateTimeFormat puts the day part in front of the hour for the locale\r\npipe = new DatePipe('hu');\r\nexpect(pipe.transform(date, 'a')).toEqual('de.'); // outputs 9\r\n// When Intl.DateTimeFormat has a space in the day part string itself for the locale\r\npipe = new DatePipe('sr');\r\nexpect(pipe.transform(date, 'a')).toEqual('пре подне'); // outputs npe\r\n```\r\nSee the Intl.ts hourClockExtractor function. \r\n\r\n2.The 2 digit formatting (eg \"hh\") outputs a mix of numbering systems\r\n```\r\npipe = new DatePipe('mr');\r\nexpect(pipe.transform(date, 'hh')).toEqual('०९'); // outputs 0९\r\n```\r\nThe '0' is hard coded into angular's Intl.js digitModifier function.\r\n\r\n3.The timezone output fails with certain locales\r\n```\r\n// When the browser puts the hour after the timezone for the locale\r\npipe = new DatePipe('zh');\r\nexpect(pipe.transform(date, 'Z')).toEqual('GMT+1'); // outputs +19时\r\n// When Intl.DateTimeFormat outputs an hour identifier between the hour and the timezone for the locale, eg for fr you get 09 h UTC+1\r\npipe = new DatePipe('fr');\r\nexpect(pipe.transform(date, 'Z')).toEqual('UTC+1'); // outputs h UTC+1\r\n```\r\nSee the Intl.ts timeZoneGetter function.\r\n\r\n4.The era output doesn't work on any locale I tried\r\n```\r\nexpect(pipe.transform(date, 'G')).toEqual('A');//outputs 6 15, 2015 A\r\n```\r\nAngular's Intl.ts assumes the Intl.DateTimeFormat object will output the era on its own, it doesn't.\r\n\r\n**What is the motivation / use case for changing the behavior?**\r\nBroken.\r\n\r\n**Please tell us about your environment:**\r\nWindows 10\r\n\r\n* **Angular version:** 2.0.X\r\nAngular master\r\n\r\n* **Browser:** [all | Chrome XX | Firefox XX | IE XX | Safari XX | Mobile Chrome XX | Android X.X Web Browser | iOS XX Safari | iOS XX UIWebView | iOS XX WKWebView ]\r\nChrome (also have details of IE output in the gist)\r\n","author":{"url":"https://github.com/gary-b","@type":"Person","name":"gary-b"},"datePublished":"2016-10-31T19:12:17Z","url":"https://github.com/angular/angular/issues/12632"}

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:33cf804f-0761-ebb8-6d27-001b56bc169e
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-idAE86:25598F:1B1E79B:23C8FFE:6B01511D
html-safe-nonce4fe1aa4a3a0c357a75deba5fed4e26e7e8f060bce49bd421e77ec466492815d4
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBRTg2OjI1NTk4RjoxQjFFNzlCOjIzQzhGRkU6NkIwMTUxMUQiLCJ2aXNpdG9yX2lkIjoiOTEzNTgwNzg5ODk4MTU4NTE4MSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacb4483c65f29ab209dfa6d0dc1c5d3c37e7563fd51fcd49fc5781265d35c40aaa
hovercard-subject-tagissue:186371064
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/angular/angular/12632/issue_layout
twitter:imagehttps://opengraph.githubassets.com/f493b56f3a708d49eb3e7a1ca59cdba5122070ebaa787a235ac817174fe36950/angular/angular/issues/12632
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/f493b56f3a708d49eb3e7a1ca59cdba5122070ebaa787a235ac817174fe36950/angular/angular/issues/12632
og:image:altI'm submitting a ... (check one with "x") [x] bug report => search github for a similar issue or PR before submitting [ ] feature request [ ] support request Current behavior The date pipe output i...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamegary-b
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-preview
go-importgithub.com/angular/angular git https://github.com/angular/angular.git
octolytics-dimension-user_id139426
octolytics-dimension-user_loginangular
octolytics-dimension-repository_id24195339
octolytics-dimension-repository_nwoangular/angular
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id24195339
octolytics-dimension-repository_network_root_nwoangular/angular
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-nameissues

Links:

Skip to contenthttps://github.com/angular/angular/issues/12632#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fissues%2F12632
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fissues%2F12632
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=angular%2Fangular
Reloadhttps://github.com/angular/angular/issues/12632
Reloadhttps://github.com/angular/angular/issues/12632
Reloadhttps://github.com/angular/angular/issues/12632
angularhttps://github.com/angular
angularhttps://github.com/angular/angular
Codehttps://github.com/angular/angular
Issues836 (836)https://github.com/angular/angular/issues
Pull requests141 (141)https://github.com/angular/angular/pulls
Discussionshttps://github.com/angular/angular/discussions
Actionshttps://github.com/angular/angular/actions
Projectshttps://github.com/angular/angular/projects
Security and quality40 (40)https://github.com/angular/angular/security
Insightshttps://github.com/angular/angular/insights
https://github.com/angular/angular
New issuehttps://github.com/login?return_to=https://github.com/angular/angular/issues/12632
New issuehttps://github.com/login?return_to=https://github.com/angular/angular/issues/12632
Date pipe time component extraction issues across localeshttps://github.com/angular/angular/issues/12632#top
area: commonIssues related to APIs in the @angular/common packagehttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20common%22
area: i18nIssues related to localization and internationalizationhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20i18n%22
freq2: mediumhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22freq2%3A%20medium%22
type: bug/fixhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22type%3A%20bug%2Ffix%22
https://github.com/gary-b
gary-bhttps://github.com/gary-b
on Oct 31, 2016https://github.com/angular/angular/issues/12632#issue-186371064
https://gist.github.com/gary-b/bdc67fae4767c7da08ee93965a955fa5https://gist.github.com/gary-b/bdc67fae4767c7da08ee93965a955fa5
Nexthttps://github.com/angular/angular/issues/12632?timeline_page=1
https://github.com/DzmitryShylovich
DzmitryShylovichhttps://github.com/DzmitryShylovich
on Oct 31, 2016https://github.com/angular/angular/issues/12632#issuecomment-257391364
#10809https://github.com/angular/angular/issues/10809
https://github.com/gary-b
gary-bhttps://github.com/gary-b
on Oct 31, 2016https://github.com/angular/angular/issues/12632#issuecomment-257394348
@DzmitryShylovichhttps://github.com/DzmitryShylovich
#10809https://github.com/angular/angular/issues/10809
gary-bhttps://github.com/gary-b
on Oct 31, 2016https://github.com/angular/angular/issues/12632#event-842437635
gary-bhttps://github.com/gary-b
on Oct 31, 2016https://github.com/angular/angular/issues/12632#event-842446743
https://github.com/DzmitryShylovich
DzmitryShylovichhttps://github.com/DzmitryShylovich
on Oct 31, 2016https://github.com/angular/angular/issues/12632#issuecomment-257396484
pkozlowski-opensourcehttps://github.com/pkozlowski-opensource
area: commonIssues related to APIs in the @angular/common packagehttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20common%22
area: i18nIssues related to localization and internationalizationhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20i18n%22
on Oct 31, 2016https://github.com/angular/angular/issues/12632#event-842538143
vicbhttps://github.com/vicb
freq2: mediumhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22freq2%3A%20medium%22
severity3: brokenhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22severity3%3A%20broken%22
type: bug/fixhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22type%3A%20bug%2Ffix%22
on Nov 30, 2016https://github.com/angular/angular/issues/12632#event-877400395
https://github.com/pkozlowski-opensource
pkozlowski-opensourcehttps://github.com/pkozlowski-opensource
on Dec 12, 2016https://github.com/angular/angular/issues/12632#issuecomment-266434606
@gary-bhttps://github.com/gary-b
@DzmitryShylovichhttps://github.com/DzmitryShylovich
https://github.com/ocombe
ocombehttps://github.com/ocombe
on Jun 28, 2017https://github.com/angular/angular/issues/12632#issuecomment-311595276
#10809https://github.com/angular/angular/issues/10809
mheveryhttps://github.com/mhevery
on Aug 22, 2017https://github.com/angular/angular/issues/12632#event-1216707516
feat(common): drop use of the Intl API to improve browser support (#1…https://github.com/angular/angular/commit/079d884b6cbe179c3565d8db443d76b1ae041af7
#1…https://github.com/angular/angular/pull/18284
079d884https://github.com/angular/angular/commit/079d884b6cbe179c3565d8db443d76b1ae041af7
ocombehttps://github.com/ocombe
completedhttps://github.com/angular/angular/issues?q=is%3Aissue%20state%3Aclosed%20archived%3Afalse%20reason%3Acompleted
on Aug 25, 2017https://github.com/angular/angular/issues/12632#event-1221051263
https://github.com/apps/angular-automatic-lock-bot
angular-automatic-lock-bothttps://github.com/apps/angular-automatic-lock-bot
on Sep 12, 2019https://github.com/angular/angular/issues/12632#issuecomment-530720049
automatic conversation locking policyhttps://github.com/angular/angular/blob/67d80f/docs/GITHUB_PROCESS.md#conversation-locking
angular-automatic-lock-bothttps://github.com/apps/angular-automatic-lock-bot
on Sep 12, 2019https://github.com/angular/angular/issues/12632#event-2628276687
Sign up for freehttps://github.com/signup?return_to=https://github.com/angular/angular/issues/12632
Sign in to commenthttps://github.com/login?return_to=https://github.com/angular/angular/issues/12632
area: commonIssues related to APIs in the @angular/common packagehttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20common%22
area: i18nIssues related to localization and internationalizationhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20i18n%22
freq2: mediumhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22freq2%3A%20medium%22
type: bug/fixhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22type%3A%20bug%2Ffix%22
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.