René's URL Explorer Experiment


Title: Improve error message for when Injectable() is missing · Issue #12467 · angular/angular · GitHub

Open Graph Title: Improve error message for when Injectable() is missing · Issue #12467 · angular/angular

X Title: Improve error message for when Injectable() is missing · Issue #12467 · angular/angular

Description: I'm submitting a ... [x] bug report Current behavior If component A has a dependency on service B, but service B does not have the Injectable() decorator defined, a vague error message is thrown: Can't resolve all parameters for SomeServ...

Open Graph Description: I'm submitting a ... [x] bug report Current behavior If component A has a dependency on service B, but service B does not have the Injectable() decorator defined, a vague error message is thrown: C...

X Description: I'm submitting a ... [x] bug report Current behavior If component A has a dependency on service B, but service B does not have the Injectable() decorator defined, a vague error message is throw...

Opengraph URL: https://github.com/angular/angular/issues/12467

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Improve error message for when Injectable() is missing","articleBody":"**I'm submitting a ...** \n\n```\n[x] bug report\n```\n\n**Current behavior**\nIf component A has a dependency on service B, but service B does not have the `Injectable()` decorator defined, a vague error message is thrown:\n\n```\nCan't resolve all parameters for SomeService: (?, ?)\n```\n\nThis is the exact same error message for [when dependencies can't be loaded](http://stackoverflow.com/questions/37902476/automatic-ordering-of-exports-in-index-ts-makes-app-crash/37907696). Up until now that error message was given because I use barrel files and the order of import/exports should be adjusted. Thus, I was thrown off when trying to fix this problem.\n\n**Expected behavior**\nA specific error message like:\n\n```\nSomeService was provided, but an `Injectable()` decorator was not found\n```\n\n**Minimal reproduction of the problem with instructions**\n- Create a service, but omit the `Injectable()` decorator. This service should have a dependency to at least one other service (defined correctly).\n  \n  ```\n  import { Injectable } from '@angular/core';\n  \n  // oops, forgot the decorator\n  export class SomeService {\n    constructor(private otherService: OtherService) { }\n  }\n  \n  @Injectable()\n  export class OtherService { }\n  ```\n- Provide the services with the module.\n- Create a component that gets the `SomeService` injected.\n\nI used the Plnkr of the Angular quickstart to [reproduce this problem](http://plnkr.co/edit/VfNug0dJFNPcmeeboKzi?p=preview). On the `Car` service in `app/car/car.ts`, I simply removed the decorator. The console immediately shows the error:\n\n```\nCan't resolve all parameters for Car: (?, ?)\n```\n\n// Edit:\nIn the documentation, [it is mentioned that the injector will throw a `NoAnnotationError`](https://angular.io/docs/ts/latest/api/core/index/Injectable-decorator.html), but the link to [`NoAnnotationError`](https://angular.io/docs/ts/latest/api/core/index/NoAnnotationError) results in a 404.\n\n**What is the motivation / use case for changing the behavior?**\nA more precise error message would direct me to the problem instantly and the problem could have been fixed in a matter of seconds. Because this message is the exact same as when dependencies can't be resolved due to import/export order with barrel files, it now took me 30 minutes of stripping dependencies and order checking before I noticed this simple and tiny mistake.\n\n**Please tell us about your environment:**\nWindows 10, Chrome 53 and SystemJS as the module loader.\n- **Angular version:** 2.0.0 and upwards. It is still a problem in 2.1.0.\n- **Browser:** The web application crashes in all browsers. Chrome 53 and Edge 38 clearly show the error in the console. Firefox however, shows a `CompileMetadataResolver` and I'm not able to find a more specific error message.\n- **Language:** TypeScript 2.0.3.\n- **Node (for AoT issues):** 6.0.0.\n","author":{"url":"https://github.com/JPtenBerge","@type":"Person","name":"JPtenBerge"},"datePublished":"2016-10-23T09:39:58Z","url":"https://github.com/angular/angular/issues/12467"}

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:1e952161-4419-e7ff-2d41-72bf028d118f
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-idBB08:26ECEB:1BC1923:235703A:6B0140A5
html-safe-nonce25e8471deb3bf2d980cbd53f37c99f29d91c579292e454d4e497bcfd4c300a54
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCQjA4OjI2RUNFQjoxQkMxOTIzOjIzNTcwM0E6NkIwMTQwQTUiLCJ2aXNpdG9yX2lkIjoiMzI0MTY5MDk1MDAxMTAxMTIzNyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac942854f7911535efbacfa654fd3d34ce885d01ca8bb2ab68ff837b2cc514bab1
hovercard-subject-tagissue:184680439
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/angular/angular/12467/issue_layout
twitter:imagehttps://opengraph.githubassets.com/3dad86f9a651d0a263df646dd3531063739e6875fad6ab9bfc12239b03b40666/angular/angular/issues/12467
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/3dad86f9a651d0a263df646dd3531063739e6875fad6ab9bfc12239b03b40666/angular/angular/issues/12467
og:image:altI'm submitting a ... [x] bug report Current behavior If component A has a dependency on service B, but service B does not have the Injectable() decorator defined, a vague error message is thrown: C...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameJPtenBerge
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-preview
go-importgithub.com/angular/angular git https://github.com/angular/angular.git
octolytics-dimension-user_id139426
octolytics-dimension-user_loginangular
octolytics-dimension-repository_id24195339
octolytics-dimension-repository_nwoangular/angular
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id24195339
octolytics-dimension-repository_network_root_nwoangular/angular
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-nameissues

Links:

Skip to contenthttps://github.com/angular/angular/issues/12467#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fissues%2F12467
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fissues%2F12467
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=angular%2Fangular
Reloadhttps://github.com/angular/angular/issues/12467
Reloadhttps://github.com/angular/angular/issues/12467
Reloadhttps://github.com/angular/angular/issues/12467
angularhttps://github.com/angular
angularhttps://github.com/angular/angular
Codehttps://github.com/angular/angular
Issues836 (836)https://github.com/angular/angular/issues
Pull requests141 (141)https://github.com/angular/angular/pulls
Discussionshttps://github.com/angular/angular/discussions
Actionshttps://github.com/angular/angular/actions
Projectshttps://github.com/angular/angular/projects
Security and quality40 (40)https://github.com/angular/angular/security
Insightshttps://github.com/angular/angular/insights
https://github.com/angular/angular
New issuehttps://github.com/login?return_to=https://github.com/angular/angular/issues/12467
New issuehttps://github.com/login?return_to=https://github.com/angular/angular/issues/12467
Improve error message for when Injectable() is missinghttps://github.com/angular/angular/issues/12467#top
area: compilerIssues related to `ngc`, Angular's template compilerhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20compiler%22
area: coreIssues related to the framework runtimehttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20core%22
freq3: highhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22freq3%3A%20high%22
hotlist: error messageshttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22hotlist%3A%20error%20messages%22
type: bug/fixhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22type%3A%20bug%2Ffix%22
Backloghttps://github.com/angular/angular/milestone/82
https://github.com/JPtenBerge
JPtenBergehttps://github.com/JPtenBerge
on Oct 23, 2016https://github.com/angular/angular/issues/12467#issue-184680439
when dependencies can't be loadedhttp://stackoverflow.com/questions/37902476/automatic-ordering-of-exports-in-index-ts-makes-app-crash/37907696
reproduce this problemhttp://plnkr.co/edit/VfNug0dJFNPcmeeboKzi?p=preview
it is mentioned that the injector will throw a NoAnnotationErrorhttps://angular.io/docs/ts/latest/api/core/index/Injectable-decorator.html
NoAnnotationErrorhttps://angular.io/docs/ts/latest/api/core/index/NoAnnotationError
pkozlowski-opensourcehttps://github.com/pkozlowski-opensource
hotlist: error messageshttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22hotlist%3A%20error%20messages%22
area: coreIssues related to the framework runtimehttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20core%22
on Oct 23, 2016https://github.com/angular/angular/issues/12467#event-833032917
tboschhttps://github.com/tbosch
type: bug/fixhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22type%3A%20bug%2Ffix%22
freq3: highhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22freq3%3A%20high%22
severity1: confusinghttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22severity1%3A%20confusing%22
on Oct 26, 2016https://github.com/angular/angular/issues/12467#event-837416522
ngbothttps://github.com/apps/ngbot
Backloghttps://github.com/angular/angular/milestone/82
on Jan 23, 2018https://github.com/angular/angular/issues/12467#event-1437647493
https://github.com/codegagan
codegaganhttps://github.com/codegagan
on May 6, 2018https://github.com/angular/angular/issues/12467#issuecomment-386869077
https://github.com/bigteejay
bigteejayhttps://github.com/bigteejay
on May 23, 2018https://github.com/angular/angular/issues/12467#issuecomment-391507778
ActivatedRoutehttps://github.com/angular/angular/blob/6.0.3/packages/router/src/router_state.ts#L107
Routerhttps://github.com/angular/angular/blob/6.0.3/packages/router/src/router.ts#L200
https://github.com/pkozlowski-opensource
pkozlowski-opensourcehttps://github.com/pkozlowski-opensource
on Mar 10, 2020https://github.com/angular/angular/issues/12467#issuecomment-597147428
@Injectablehttps://github.com/Injectable
https://ng-run.com/edit/d0NblIE4tkjFnxSyKZFUhttps://ng-run.com/edit/d0NblIE4tkjFnxSyKZFU
pkozlowski-opensourcehttps://github.com/pkozlowski-opensource
completedhttps://github.com/angular/angular/issues?q=is%3Aissue%20state%3Aclosed%20archived%3Afalse%20reason%3Acompleted
on Mar 10, 2020https://github.com/angular/angular/issues/12467#event-3115210565
pkozlowski-opensourcehttps://github.com/pkozlowski-opensource
area: compilerIssues related to `ngc`, Angular's template compilerhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20compiler%22
on Mar 10, 2020https://github.com/angular/angular/issues/12467#event-3115211202
https://github.com/apps/angular-automatic-lock-bot
angular-automatic-lock-bothttps://github.com/apps/angular-automatic-lock-bot
on Apr 10, 2020https://github.com/angular/angular/issues/12467#issuecomment-612098086
automatic conversation locking policyhttps://github.com/angular/angular/blob/67d80f/docs/GITHUB_PROCESS.md#conversation-locking
angular-automatic-lock-bothttps://github.com/apps/angular-automatic-lock-bot
on Apr 10, 2020https://github.com/angular/angular/issues/12467#event-3222311225
Sign up for freehttps://github.com/signup?return_to=https://github.com/angular/angular/issues/12467
Sign in to commenthttps://github.com/login?return_to=https://github.com/angular/angular/issues/12467
area: compilerIssues related to `ngc`, Angular's template compilerhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20compiler%22
area: coreIssues related to the framework runtimehttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20core%22
freq3: highhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22freq3%3A%20high%22
hotlist: error messageshttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22hotlist%3A%20error%20messages%22
type: bug/fixhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22type%3A%20bug%2Ffix%22
BacklogNo due datehttps://github.com/angular/angular/milestone/82
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.