René's URL Explorer Experiment


Title: TestBed.configureTestingModule Performance Issue · Issue #12409 · angular/angular · GitHub

Open Graph Title: TestBed.configureTestingModule Performance Issue · Issue #12409 · angular/angular

X Title: TestBed.configureTestingModule Performance Issue · Issue #12409 · angular/angular

Description: I'm submitting a ... (check one with "x") [ ] bug report [x] feature request [ ] support request Current behavior Importing modules into TestBed.configureTestingModule can slow tests down substantially. We have a 'shared module' with par...

Open Graph Description: I'm submitting a ... (check one with "x") [ ] bug report [x] feature request [ ] support request Current behavior Importing modules into TestBed.configureTestingModule can slow tests down substanti...

X Description: I'm submitting a ... (check one with "x") [ ] bug report [x] feature request [ ] support request Current behavior Importing modules into TestBed.configureTestingModule can slow tests ...

Opengraph URL: https://github.com/angular/angular/issues/12409

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"TestBed.configureTestingModule Performance Issue","articleBody":"\u003c!--\nIF YOU DON'T FILL OUT THE FOLLOWING INFORMATION WE MIGHT CLOSE YOUR ISSUE WITHOUT INVESTIGATING\n-->\n\n**I'm submitting a ...**  (check one with \"x\")\n\n```\n[ ] bug report \n[x] feature request\n[ ] support request \n```\n\n**Current behavior**\n\n\u003c!-- Describe how the bug manifests. -->\n\nImporting modules into `TestBed.configureTestingModule` can slow tests down _substantially_. We have a 'shared module' with parts, that lots of our components use, including a third party library or two. It is very convenient to import this module as a rather than cherry pick in the tests, however testing a small component yesterday, I saw test bootstrap taking _two whole seconds_ and had to cherry-pick dependencies to make tests run reliably.\n\n**Expected behavior**\n\n\u003c!-- Describe what the behavior would be without the bug. -->\n\n`TestBed.configureTestingModule` should be performant. \n\n**Minimal reproduction of the problem with instructions**\n\n\u003c!--\nIf the current behavior is a bug or you can illustrate your feature request better with an example, \nplease provide the *STEPS TO REPRODUCE* and if possible a *MINIMAL DEMO* of the problem via\nhttps://plnkr.co or similar (you can use this template as a starting point: http://plnkr.co/edit/tpl:AvJOMERrnz94ekVua0u5).\n-->\n\nIn [this plunker](http://plnkr.co/edit/SXi7UW01I43zSCmr8Emp?p=preview)\n1. go to the `src/simple.spec.ts` and comment and un-comment the `SharedModule` import into `configureTestingModule`.\n1. Observe time it takes for test to run.\n\nI am seeing a jump from 0.079s to 0.241s. (~= 3x slower). Multiply that by 5 cases and this simple test takes a whole second. Make the shared module larger and you have real problems.\n\n**What is the motivation / use case for changing the behavior?**\n\n\u003c!-- Describe the motivation or the concrete use case -->\n1. Slow tests hurt TDD workflow\n2. Slow enough tests disconnect karma from the browser and fail the suite.\n\n**Please tell us about your environment:**\n\n\u003c!-- Operating system, IDE, package manager, HTTP server, ... -->\n\nWin10, VsCode, Webpack, \n- **Angular version:** 2.0.X\n  \n  \u003c!-- Check whether this is still an issue in the most recent Angular version -->\n  \n  Yes.\n- **Browser:** Locally, PhantomJS. Plunk tested in Chrome.\n- **Language:** TypeScript (though tests are transpiled to ES5 prior to running, naturally)\n\n_Note:_ Even as I write this, I wonder if it's a reasonable expectation for large modules to go through TestBed quickly? Maybe I'm just doing something wrong architecturally, (use multiple, smaller shared modules, not one big one, etc.) However, tests are time-consuming enough without having to track down every individual dependency of a more complex component just to get started.\n","author":{"url":"https://github.com/ollwenjones","@type":"Person","name":"ollwenjones"},"datePublished":"2016-10-20T15:52:41Z","url":"https://github.com/angular/angular/issues/12409"}

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:83c4a8d6-1cc9-efab-01e8-50ae14efa5a4
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-id80AE:3C21B:3165DA2:3F26C20:6B01C26B
html-safe-noncea4df116d806d87ac11302becd78d04ef99d13256683ee938060f06c980d86020
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4MEFFOjNDMjFCOjMxNjVEQTI6M0YyNkMyMDo2QjAxQzI2QiIsInZpc2l0b3JfaWQiOiI0MTEyOTA4MTM1MjQzNTYzNjI3IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac90b96b57a2b59a9c1f13fb0490bb179e1a7e0aa71fea853019a9f28fbfd3adc3
hovercard-subject-tagissue:184268919
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/angular/angular/12409/issue_layout
twitter:imagehttps://opengraph.githubassets.com/0d852ec5088f024512c36335406d2f8d447e0efbb1757f2a508e99c6745ef5fa/angular/angular/issues/12409
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/0d852ec5088f024512c36335406d2f8d447e0efbb1757f2a508e99c6745ef5fa/angular/angular/issues/12409
og:image:altI'm submitting a ... (check one with "x") [ ] bug report [x] feature request [ ] support request Current behavior Importing modules into TestBed.configureTestingModule can slow tests down substanti...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameollwenjones
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-preview
go-importgithub.com/angular/angular git https://github.com/angular/angular.git
octolytics-dimension-user_id139426
octolytics-dimension-user_loginangular
octolytics-dimension-repository_id24195339
octolytics-dimension-repository_nwoangular/angular
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id24195339
octolytics-dimension-repository_network_root_nwoangular/angular
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-nameissues

Links:

Skip to contenthttps://github.com/angular/angular/issues/12409#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fissues%2F12409
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fissues%2F12409
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=angular%2Fangular
Reloadhttps://github.com/angular/angular/issues/12409
Reloadhttps://github.com/angular/angular/issues/12409
Reloadhttps://github.com/angular/angular/issues/12409
angularhttps://github.com/angular
angularhttps://github.com/angular/angular
Codehttps://github.com/angular/angular
Issues835 (835)https://github.com/angular/angular/issues
Pull requests142 (142)https://github.com/angular/angular/pulls
Discussionshttps://github.com/angular/angular/discussions
Actionshttps://github.com/angular/angular/actions
Projectshttps://github.com/angular/angular/projects
Security and quality40 (40)https://github.com/angular/angular/security
Insightshttps://github.com/angular/angular/insights
https://github.com/angular/angular
New issuehttps://github.com/login?return_to=https://github.com/angular/angular/issues/12409
New issuehttps://github.com/login?return_to=https://github.com/angular/angular/issues/12409
TestBed.configureTestingModule Performance Issuehttps://github.com/angular/angular/issues/12409#top
https://github.com/kyliau
area: testingIssues related to Angular testing features, such as TestBedhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20testing%22
effort2: dayshttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22effort2%3A%20days%22
featureLabel used to distinguish feature request from other issueshttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22feature%22
freq2: mediumhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22freq2%3A%20medium%22
Backloghttps://github.com/angular/angular/milestone/82
https://github.com/ollwenjones
ollwenjoneshttps://github.com/ollwenjones
on Oct 20, 2016https://github.com/angular/angular/issues/12409#issue-184268919
this plunkerhttp://plnkr.co/edit/SXi7UW01I43zSCmr8Emp?p=preview
Nexthttps://github.com/angular/angular/issues/12409?timeline_page=1
vicbhttps://github.com/vicb
area: testingIssues related to Angular testing features, such as TestBedhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20testing%22
on Oct 21, 2016https://github.com/angular/angular/issues/12409#event-831404821
https://github.com/ollwenjones
ollwenjoneshttps://github.com/ollwenjones
on Oct 28, 2016https://github.com/angular/angular/issues/12409#issuecomment-256953173
https://github.com/vmandy
vmandyhttps://github.com/vmandy
on Nov 15, 2016https://github.com/angular/angular/issues/12409#issuecomment-260639661
https://github.com/ollwenjones
ollwenjoneshttps://github.com/ollwenjones
on Nov 15, 2016https://github.com/angular/angular/issues/12409#issuecomment-260672384
@vmandyhttps://github.com/vmandy
juliemrhttps://github.com/juliemr
on Nov 22, 2016https://github.com/angular/angular/issues/12409#event-868962455
https://github.com/FlemmingBehrend
FlemmingBehrendhttps://github.com/FlemmingBehrend
on Dec 1, 2016https://github.com/angular/angular/issues/12409#issuecomment-264151803
wallabyjs/public#885https://github.com/wallabyjs/public/issues/885
https://github.com/mlakmal
mlakmalhttps://github.com/mlakmal
on Dec 15, 2016https://github.com/angular/angular/issues/12409#issuecomment-267233169
https://github.com/ollwenjones
ollwenjoneshttps://github.com/ollwenjones
on Dec 15, 2016https://github.com/angular/angular/issues/12409#issuecomment-267328889
https://github.com/mlakmal
mlakmalhttps://github.com/mlakmal
on Dec 15, 2016https://github.com/angular/angular/issues/12409#issuecomment-267331283
https://github.com/ollwenjones
ollwenjoneshttps://github.com/ollwenjones
on Dec 15, 2016https://github.com/angular/angular/issues/12409#issuecomment-267333354
@mlakmalhttps://github.com/mlakmal
https://github.com/mlakmal
mlakmalhttps://github.com/mlakmal
on Dec 15, 2016https://github.com/angular/angular/issues/12409#issuecomment-267334474
@ollwenjoneshttps://github.com/ollwenjones
https://github.com/ollwenjones
ollwenjoneshttps://github.com/ollwenjones
on Dec 15, 2016https://github.com/angular/angular/issues/12409#issuecomment-267335406
@mlakmalhttps://github.com/mlakmal
https://github.com/michaelbromley
michaelbromleyhttps://github.com/michaelbromley
on Dec 15, 2016https://github.com/angular/angular/issues/12409#issuecomment-267345403
@ollwenjoneshttps://github.com/ollwenjones
https://github.com/marclaval
marclavalhttps://github.com/marclaval
on Dec 15, 2016https://github.com/angular/angular/issues/12409#issuecomment-267370211
#13500https://github.com/angular/angular/pull/13500
https://github.com/ollwenjones
ollwenjoneshttps://github.com/ollwenjones
on Dec 15, 2016https://github.com/angular/angular/issues/12409#issuecomment-267426065
@michaelbromleyhttps://github.com/michaelbromley
https://github.com/Goodwine
Goodwinehttps://github.com/Goodwine
on Dec 4, 2019https://github.com/angular/angular/issues/12409#issuecomment-561804735
@MatMercerhttps://github.com/MatMercer
docshttps://angular.io/guide/releases#support-policy-and-schedule
angular/angular-cli#6650https://github.com/angular/angular-cli/issues/6650
https://github.com/MatMercer
MatMercerhttps://github.com/MatMercer
on Dec 4, 2019https://github.com/angular/angular/issues/12409#issuecomment-561818235
from herehttps://github.com/topnotch48/ng-bullet-workspace/blob/master/projects/ng-bullet/src/testing.ts
@giniedphttps://github.com/giniedp
@giniedphttps://github.com/giniedp
use the ng-bullet from here, it's updated and worked with my angular 5.2.0https://github.com/topnotch48/ng-bullet-workspace/blob/master/projects/ng-bullet/src/testing.ts
@Goodwinehttps://github.com/Goodwine
https://github.com/giniedp
giniedphttps://github.com/giniedp
on Dec 4, 2019https://github.com/angular/angular/issues/12409#issuecomment-561822634
https://github.com/MatMercer
MatMercerhttps://github.com/MatMercer
on Dec 4, 2019https://github.com/angular/angular/issues/12409#issuecomment-561824111
@giniedphttps://github.com/giniedp
https://github.com/giniedp
giniedphttps://github.com/giniedp
on Dec 4, 2019https://github.com/angular/angular/issues/12409#issuecomment-561829482
https://github.com/MatMercer
MatMercerhttps://github.com/MatMercer
on Dec 4, 2019https://github.com/angular/angular/issues/12409#issuecomment-561874038
@giniedphttps://github.com/giniedp
@Goodwinehttps://github.com/Goodwine
@giniedphttps://github.com/giniedp
https://github.com/Quramy
Quramyhttps://github.com/Quramy
on Dec 5, 2019https://github.com/angular/angular/issues/12409#issuecomment-561908267
@Goodwinehttps://github.com/Goodwine
https://angular.io/guide/ivy#opting-into-angular-ivyhttps://angular.io/guide/ivy#opting-into-angular-ivy
https://github.com/angular/angular/blob/8.2.14/packages/core/src/render3/jit/module.ts#L49-L66https://github.com/angular/angular/blob/8.2.14/packages/core/src/render3/jit/module.ts#L49-L66
JoostKhttps://github.com/JoostK
fixed by Ivyhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22fixed%20by%20Ivy%22
on Mar 15, 2020https://github.com/angular/angular/issues/12409#event-3130621209
https://github.com/JoostK
JoostKhttps://github.com/JoostK
on Mar 15, 2020https://github.com/angular/angular/issues/12409#issuecomment-599223073
https://github.com/krokofant
krokofanthttps://github.com/krokofant
on Mar 15, 2020https://github.com/angular/angular/issues/12409#issuecomment-599223845
@JoostKhttps://github.com/JoostK
https://github.com/AndrewKushnir
AndrewKushnirhttps://github.com/AndrewKushnir
on May 29, 2020https://github.com/angular/angular/issues/12409#issuecomment-636221503
@JoostKhttps://github.com/JoostK
AndrewKushnirhttps://github.com/AndrewKushnir
completedhttps://github.com/angular/angular/issues?q=is%3Aissue%20state%3Aclosed%20archived%3Afalse%20reason%3Acompleted
on May 29, 2020https://github.com/angular/angular/issues/12409#event-3389059188
AndrewKushnirhttps://github.com/AndrewKushnir
triage #1https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22triage%20%231%22
on May 29, 2020https://github.com/angular/angular/issues/12409#event-3389059378
https://github.com/apps/angular-automatic-lock-bot
angular-automatic-lock-bothttps://github.com/apps/angular-automatic-lock-bot
on Jun 30, 2020https://github.com/angular/angular/issues/12409#issuecomment-651895710
automatic conversation locking policyhttps://github.com/angular/angular/blob/67d80f/docs/GITHUB_PROCESS.md#conversation-locking
angular-automatic-lock-bothttps://github.com/apps/angular-automatic-lock-bot
on Jun 30, 2020https://github.com/angular/angular/issues/12409#event-3498560671
Sign up for freehttps://github.com/signup?return_to=https://github.com/angular/angular/issues/12409
Sign in to commenthttps://github.com/login?return_to=https://github.com/angular/angular/issues/12409
kyliauhttps://github.com/kyliau
area: testingIssues related to Angular testing features, such as TestBedhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20testing%22
effort2: dayshttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22effort2%3A%20days%22
featureLabel used to distinguish feature request from other issueshttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22feature%22
freq2: mediumhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22freq2%3A%20medium%22
BacklogNo due datehttps://github.com/angular/angular/milestone/82
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.