René's URL Explorer Experiment


Title: destructor option for service providers · Issue #11228 · angular/angular · GitHub

Open Graph Title: destructor option for service providers · Issue #11228 · angular/angular

X Title: destructor option for service providers · Issue #11228 · angular/angular

Description: [ ] bug report => search github for a similar issue or PR before submitting [X ] feature request [ ] support request => Please do not submit support request here, instead see https://github.com/angular/angular/blob/master/CONTRIBUTING.md...

Open Graph Description: [ ] bug report => search github for a similar issue or PR before submitting [X ] feature request [ ] support request => Please do not submit support request here, instead see https://github.com/ang...

X Description: [ ] bug report => search github for a similar issue or PR before submitting [X ] feature request [ ] support request => Please do not submit support request here, instead see https://github.c...

Opengraph URL: https://github.com/angular/angular/issues/11228

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"destructor option for service providers","articleBody":"```\n[ ] bug report => search github for a similar issue or PR before submitting\n[X ] feature request\n[ ] support request => Please do not submit support request here, instead see https://github.com/angular/angular/blob/master/CONTRIBUTING.md#question\n```\n\n**Current behavior**\nSee example below:\n\n```\n@Injectable()\nexport class GlobalServiceProvidedInBootstrap {\n    public subscribe(f: Function);\n    public unsubscribe(f: Function);\n}\n```\n\n```\nexport function callback() {\n};\n\n@Injectable()\nexport class ServiceProvidedInElement {\n    constructor(public service: GlobalServiceProvidedInBootstrap) {\n        service.subscribe(callback);\n    }\n}\n```\n\n```\n@Component({\n    selector: 'example-tag',\n     providers: [ServiceProvidedInElement]\n})\nexport class ExampleTagComponent {\n    constructor(private s: ServiceProvidedInElement) {\n    }\n    public ngOnDestroy() {\n        this.s.service.unsubscribe(callback);\n    }\n}\n```\n\nThe problem I'm having in similar code is that the moment this component is destroyed, there is no way for me to unsubscribe ServiceProvidedInElement from GlobalServiceProvidedInBootstrap unless I use ngOnDestroy in the component.\n\n**Expected/desired behavior**\nThe expected behavior is that when I declare my providers, I should be able to set a callback to destroy my service provided. So instead of using ngOnDestroy I could do it like this:\n\n```\nexport SERVICE_PROVIDED_IN_ELEMENT_PROVIDERS = [\n    {\n        token: ServiceProvidedInElement,\n        useDestructor: function (element: ServiceProvidedInElement) {\n              element.service.unsubscribe(callback);\n        }\n    }\n];\n```\n","author":{"url":"https://github.com/pjordaan","@type":"Person","name":"pjordaan"},"datePublished":"2016-09-01T08:42:06Z","url":"https://github.com/angular/angular/issues/11228"}

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:253636ea-34dc-ef96-df48-143ad6f6f1c3
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-idE184:1201C:1BA540B:24BB226:6B0159CE
html-safe-noncea1aa94cf18ae702f762d160c3177cf7f024b881dea53767c9d09bf7eb57b08f1
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFMTg0OjEyMDFDOjFCQTU0MEI6MjRCQjIyNjo2QjAxNTlDRSIsInZpc2l0b3JfaWQiOiI4OTExOTQzMTU2ODU4MTgyMDk0IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac51e04e613b84779a3517e554d20a487f9a3f0b007d2963202743661d87b39eff
hovercard-subject-tagissue:174467779
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/angular/angular/11228/issue_layout
twitter:imagehttps://opengraph.githubassets.com/f3f6839e846f51cebd576882d7818d120d1f6425a40817e9560902c91d890a3f/angular/angular/issues/11228
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/f3f6839e846f51cebd576882d7818d120d1f6425a40817e9560902c91d890a3f/angular/angular/issues/11228
og:image:alt[ ] bug report => search github for a similar issue or PR before submitting [X ] feature request [ ] support request => Please do not submit support request here, instead see https://github.com/ang...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamepjordaan
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-preview
go-importgithub.com/angular/angular git https://github.com/angular/angular.git
octolytics-dimension-user_id139426
octolytics-dimension-user_loginangular
octolytics-dimension-repository_id24195339
octolytics-dimension-repository_nwoangular/angular
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id24195339
octolytics-dimension-repository_network_root_nwoangular/angular
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-nameissues

Links:

Skip to contenthttps://github.com/angular/angular/issues/11228#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fissues%2F11228
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fissues%2F11228
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=angular%2Fangular
Reloadhttps://github.com/angular/angular/issues/11228
Reloadhttps://github.com/angular/angular/issues/11228
Reloadhttps://github.com/angular/angular/issues/11228
angularhttps://github.com/angular
angularhttps://github.com/angular/angular
Codehttps://github.com/angular/angular
Issues836 (836)https://github.com/angular/angular/issues
Pull requests141 (141)https://github.com/angular/angular/pulls
Discussionshttps://github.com/angular/angular/discussions
Actionshttps://github.com/angular/angular/actions
Projectshttps://github.com/angular/angular/projects
Security and quality40 (40)https://github.com/angular/angular/security
Insightshttps://github.com/angular/angular/insights
https://github.com/angular/angular
New issuehttps://github.com/login?return_to=https://github.com/angular/angular/issues/11228
New issuehttps://github.com/login?return_to=https://github.com/angular/angular/issues/11228
#13369https://github.com/angular/angular/pull/13369
destructor option for service providershttps://github.com/angular/angular/issues/11228#top
#13369https://github.com/angular/angular/pull/13369
area: coreIssues related to the framework runtimehttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20core%22
featureLabel used to distinguish feature request from other issueshttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22feature%22
freq1: lowhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22freq1%3A%20low%22
https://github.com/pjordaan
pjordaanhttps://github.com/pjordaan
on Sep 1, 2016https://github.com/angular/angular/issues/11228#issue-174467779
Nexthttps://github.com/angular/angular/issues/11228?timeline_page=1
vicbhttps://github.com/vicb
featureLabel used to distinguish feature request from other issueshttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22feature%22
comp: corehttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22comp%3A%20core%22
on Sep 1, 2016https://github.com/angular/angular/issues/11228#event-775451075
mheveryhttps://github.com/mhevery
area: coreIssues related to the framework runtimehttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20core%22
comp: corehttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22comp%3A%20core%22
on Sep 7, 2016https://github.com/angular/angular/issues/11228#event-781547871
pkozlowski-opensourcehttps://github.com/pkozlowski-opensource
freq1: lowhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22freq1%3A%20low%22
severity2: inconvenienthttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22severity2%3A%20inconvenient%22
on Oct 12, 2016https://github.com/angular/angular/issues/11228#event-821051266
https://github.com/DzmitryShylovich
DzmitryShylovichhttps://github.com/DzmitryShylovich
on Nov 12, 2016https://github.com/angular/angular/issues/11228#issuecomment-260114764
https://github.com/zoechi
zoechihttps://github.com/zoechi
on Nov 14, 2016https://github.com/angular/angular/issues/11228#issuecomment-260263693
https://angular.io/docs/ts/latest/api/core/index/OnDestroy-class.htmlhttps://angular.io/docs/ts/latest/api/core/index/OnDestroy-class.html
https://github.com/DzmitryShylovich
DzmitryShylovichhttps://github.com/DzmitryShylovich
on Nov 14, 2016https://github.com/angular/angular/issues/11228#issuecomment-260276471
http://plnkr.co/edit/AgBYNxmW1aIPiDFAr5iu?p=previewhttp://plnkr.co/edit/AgBYNxmW1aIPiDFAr5iu?p=preview
https://github.com/zoechi
zoechihttps://github.com/zoechi
on Nov 14, 2016https://github.com/angular/angular/issues/11228#issuecomment-260280631
vicbhttps://github.com/vicb
completedhttps://github.com/angular/angular/issues?q=is%3Aissue%20state%3Aclosed%20archived%3Afalse%20reason%3Acompleted
#13369https://github.com/angular/angular/pull/13369
on Dec 13, 2016https://github.com/angular/angular/issues/11228#event-891288253
vicbhttps://github.com/vicb
on Dec 13, 2016https://github.com/angular/angular/issues/11228#event-891288409
docs(core): update OnDestroy description (#13369)https://github.com/angular/angular/commit/1d0ed6f75f243efa72c8aa1484028431f7b46e52
#13369https://github.com/angular/angular/pull/13369
https://docs.github.com/articles/closing-issues-via-commit-messages
1d0ed6fhttps://github.com/angular/angular/commit/1d0ed6f75f243efa72c8aa1484028431f7b46e52
docs(core): update OnDestroy description (#13369)https://github.com/angular/angular/commit/9e0e6b59d14c7985423697a254156d7ab18fea5a
#13369https://github.com/angular/angular/pull/13369
https://docs.github.com/articles/closing-issues-via-commit-messages
9e0e6b5https://github.com/angular/angular/commit/9e0e6b59d14c7985423697a254156d7ab18fea5a
https://github.com/maxkoretskyi
maxkoretskyihttps://github.com/maxkoretskyi
on Jun 7, 2017https://github.com/angular/angular/issues/11228#issuecomment-306759203
@DzmitryShylovichhttps://github.com/DzmitryShylovich
https://github.com/willshowell
willshowellhttps://github.com/willshowell
on Jun 29, 2017https://github.com/angular/angular/issues/11228#issuecomment-312022828
@MaximusKhttps://github.com/MaximusK
http://plnkr.co/edit/FA9bIc3dEiHundiKx95M?p=previewhttp://plnkr.co/edit/FA9bIc3dEiHundiKx95M?p=preview
https://github.com/gparlakov
gparlakovhttps://github.com/gparlakov
on Apr 15, 2018https://github.com/angular/angular/issues/11228#issuecomment-381384379
@aks1994https://github.com/aks1994
https://github.com/aks1994
aks1994https://github.com/aks1994
on Apr 15, 2018https://github.com/angular/angular/issues/11228#issuecomment-381384647
…https://github.com/angular/angular/issues/11228
@aks1994https://github.com/aks1994
https://github.com/aks1994https://github.com/aks1994
#11228 (comment)https://github.com/angular/angular/issues/11228#issuecomment-381384379
https://github.com/notifications/unsubscribe-auth/AcygdMZwhBD-MQ2w5PDGRyf82pPeM_zgks5tou1VgaJpZM4Jycxnhttps://github.com/notifications/unsubscribe-auth/AcygdMZwhBD-MQ2w5PDGRyf82pPeM_zgks5tou1VgaJpZM4Jycxn
https://github.com/gparlakov
gparlakovhttps://github.com/gparlakov
on Apr 15, 2018https://github.com/angular/angular/issues/11228#issuecomment-381393259
@aks1994https://github.com/aks1994
herehttps://stackblitz.com/edit/angular-atc7fp?file=app%2Fhello.component.ts
https://github.com/aks1994
aks1994https://github.com/aks1994
on Apr 16, 2018https://github.com/angular/angular/issues/11228#issuecomment-381456558
@gparlakovhttps://github.com/gparlakov
https://github.com/jscharett
jscharetthttps://github.com/jscharett
on Jul 6, 2018https://github.com/angular/angular/issues/11228#issuecomment-403060019
https://github.com/mlc-mlapis
mlc-mlapishttps://github.com/mlc-mlapis
on Jul 6, 2018https://github.com/angular/angular/issues/11228#issuecomment-403063284
@jscharetthttps://github.com/jscharett
https://github.com/jscharett
jscharetthttps://github.com/jscharett
on Jul 6, 2018https://github.com/angular/angular/issues/11228#issuecomment-403069717
@mlc-mlapishttps://github.com/mlc-mlapis
https://github.com/Sahil624
Sahil624https://github.com/Sahil624
on Feb 22, 2019https://github.com/angular/angular/issues/11228#issuecomment-466290141
https://github.com/shikharseth
shikharsethhttps://github.com/shikharseth
on May 9, 2019https://github.com/angular/angular/issues/11228#issuecomment-490759995
@Sahil624https://github.com/Sahil624
https://github.com/gparlakov
gparlakovhttps://github.com/gparlakov
on May 9, 2019https://github.com/angular/angular/issues/11228#issuecomment-490840246
@Sahil624https://github.com/Sahil624
@shikharsethhttps://github.com/shikharseth
https://github.com/shikharseth
shikharsethhttps://github.com/shikharseth
on May 9, 2019https://github.com/angular/angular/issues/11228#issuecomment-490845753
@gparlakovhttps://github.com/gparlakov
https://github.com/gparlakov
gparlakovhttps://github.com/gparlakov
on May 22, 2019https://github.com/angular/angular/issues/11228#issuecomment-494768627
@shikharsethhttps://github.com/shikharseth
https://github.com/Sahil624
Sahil624https://github.com/Sahil624
on May 22, 2019https://github.com/angular/angular/issues/11228#issuecomment-494876518
@Sahil624https://github.com/Sahil624
https://github.com/apps/angular-automatic-lock-bot
angular-automatic-lock-bothttps://github.com/apps/angular-automatic-lock-bot
on Sep 15, 2019https://github.com/angular/angular/issues/11228#issuecomment-531543400
automatic conversation locking policyhttps://github.com/angular/angular/blob/67d80f/docs/GITHUB_PROCESS.md#conversation-locking
angular-automatic-lock-bothttps://github.com/apps/angular-automatic-lock-bot
on Sep 15, 2019https://github.com/angular/angular/issues/11228#event-2634519737
Sign up for freehttps://github.com/signup?return_to=https://github.com/angular/angular/issues/11228
Sign in to commenthttps://github.com/login?return_to=https://github.com/angular/angular/issues/11228
area: coreIssues related to the framework runtimehttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20core%22
featureLabel used to distinguish feature request from other issueshttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22feature%22
freq1: lowhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22freq1%3A%20low%22
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.