René's URL Explorer Experiment


Title: Can Activate child, can Activate operational order · Issue #10845 · angular/angular · GitHub

Open Graph Title: Can Activate child, can Activate operational order · Issue #10845 · angular/angular

X Title: Can Activate child, can Activate operational order · Issue #10845 · angular/angular

Description: [x] bug report => search github for a similar issue or PR before submitting [ ] feature request [ ] support request => Please do not submit support request here, instead see https://github.com/angular/angular/blob/master/CONTRIBUTING.md#...

Open Graph Description: [x] bug report => search github for a similar issue or PR before submitting [ ] feature request [ ] support request => Please do not submit support request here, instead see https://github.com/angu...

X Description: [x] bug report => search github for a similar issue or PR before submitting [ ] feature request [ ] support request => Please do not submit support request here, instead see https://github.co...

Opengraph URL: https://github.com/angular/angular/issues/10845

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Can Activate child, can Activate operational order ","articleBody":"```\n[x] bug report => search github for a similar issue or PR before submitting\n[ ] feature request\n[ ] support request => Please do not submit support request here, instead see https://github.com/angular/angular/blob/master/CONTRIBUTING.md#question\n```\n\n**Current behavior**\n\nThe canActivate guard on the child component is called before the canActivateChild guard on the parent. \n\nROUTER_CONFIG\n\n``` js\n{\n        path: ':tenant',\n        canActivateChild: [TenantGuard], //** This is called second **\n        children: [\n            {\n                path: 'component-foo',\n                component: EmployeeSearch,\n                canActivate: [AuthGuard] //**This is called first **\n            }\n]\n}\n```\n\nThis is because canActivate is before canActivateChild in the check guards array. \n\n`[this.runCanActivate(s.route), this.runCanActivateChild(s.path)]`\n\nrouter.ts\n\n``` js\n  checkGuards(): Observable\u003cboolean> {\n    if (this.checks.length === 0) return Observable.of(true);\n    return Observable.from(this.checks)\n        .map(s => {\n          if (s instanceof CanActivate) {\n            return andObservables(\n                Observable.from([this.runCanActivate(s.route), this.runCanActivateChild(s.path)]));\n          } else if (s instanceof CanDeactivate) {\n            // workaround https://github.com/Microsoft/TypeScript/issues/7271\n            const s2 = s as CanDeactivate;\n            return this.runCanDeactivate(s2.component, s2.route);\n          } else {\n            throw new Error('Cannot be reached');\n          }\n        })\n        .mergeAll()\n        .every(result => result === true);\n  }\n```\n\n**Expected/desired behavior**\n\nI feel that the parent guard should be called and prevent transition before the child guard is called. \n\n**What is the motivation / use case for changing the behavior?**\n\nMy specific use case is that I have a parent route from which I want to, get, validate and set a tenant for use by child components and services.\n\nThen I want to check the user is authenticate on some of the child routes. My big issue is that my AuthGuard depends on the tenant having been set by the TenantGuard on the parent route.\n\nGenerically though I feel it makes more logical sense that a parent guard is checked before the child guard is checked \n\nHappy to fix this and update tests (pull request) if you are happy with an order swap.\n\n`[this.runCanActivateChild(s.path), this.runCanActivate(s.route)]`\n\n**Please tell us about your environment:**\n- **Angular version:** 2.0.0-rc.5\n- **Browser:** [all ] \n  - **Language:** [TypeScript 1.8.10] \n","author":{"url":"https://github.com/vespertilian","@type":"Person","name":"vespertilian"},"datePublished":"2016-08-16T09:58:28Z","url":"https://github.com/angular/angular/issues/10845"}

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:88136606-c959-4c07-d93a-e93b50e01ce6
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-idE5B8:3B6317:E080:1298D:6B015A39
html-safe-nonce456c1a7a6eeccb2e04e6f8f11dcc1db22f71023ebec3d58379248e971fb7272e
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFNUI4OjNCNjMxNzpFMDgwOjEyOThEOjZCMDE1QTM5IiwidmlzaXRvcl9pZCI6IjY3NzI0MDE0MTg3ODQ1NjE3MjIiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac708605121820414e50b14c66873a9aaae57ff122bae792151fc9c0d63fbf0bd1
hovercard-subject-tagissue:171370230
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/angular/angular/10845/issue_layout
twitter:imagehttps://opengraph.githubassets.com/3e86457129fdc720c41abaf607035542d26d90e4033a580530df97f0e53afe81/angular/angular/issues/10845
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/3e86457129fdc720c41abaf607035542d26d90e4033a580530df97f0e53afe81/angular/angular/issues/10845
og:image:alt[x] bug report => search github for a similar issue or PR before submitting [ ] feature request [ ] support request => Please do not submit support request here, instead see https://github.com/angu...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamevespertilian
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-preview
go-importgithub.com/angular/angular git https://github.com/angular/angular.git
octolytics-dimension-user_id139426
octolytics-dimension-user_loginangular
octolytics-dimension-repository_id24195339
octolytics-dimension-repository_nwoangular/angular
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id24195339
octolytics-dimension-repository_network_root_nwoangular/angular
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-nameissues

Links:

Skip to contenthttps://github.com/angular/angular/issues/10845#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fissues%2F10845
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fissues%2F10845
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=angular%2Fangular
Reloadhttps://github.com/angular/angular/issues/10845
Reloadhttps://github.com/angular/angular/issues/10845
Reloadhttps://github.com/angular/angular/issues/10845
angularhttps://github.com/angular
angularhttps://github.com/angular/angular
Codehttps://github.com/angular/angular
Issues836 (836)https://github.com/angular/angular/issues
Pull requests141 (141)https://github.com/angular/angular/pulls
Discussionshttps://github.com/angular/angular/discussions
Actionshttps://github.com/angular/angular/actions
Projectshttps://github.com/angular/angular/projects
Security and quality40 (40)https://github.com/angular/angular/security
Insightshttps://github.com/angular/angular/insights
https://github.com/angular/angular
New issuehttps://github.com/login?return_to=https://github.com/angular/angular/issues/10845
New issuehttps://github.com/login?return_to=https://github.com/angular/angular/issues/10845
Can Activate child, can Activate operational order https://github.com/angular/angular/issues/10845#top
area: routerhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20router%22
type: bug/fixhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22type%3A%20bug%2Ffix%22
https://github.com/vespertilian
vespertilianhttps://github.com/vespertilian
on Aug 16, 2016https://github.com/angular/angular/issues/10845#issue-171370230
karahttps://github.com/kara
area: routerhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20router%22
on Aug 17, 2016https://github.com/angular/angular/issues/10845#event-758931458
vsavkinhttps://github.com/vsavkin
type: bug/fixhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22type%3A%20bug%2Ffix%22
on Aug 19, 2016https://github.com/angular/angular/issues/10845#event-761851722
vsavkinhttps://github.com/vsavkin
on Aug 19, 2016https://github.com/angular/angular/issues/10845#event-761851760
https://github.com/vsavkin
vsavkinhttps://github.com/vsavkin
on Aug 28, 2016https://github.com/angular/angular/issues/10845#issuecomment-242957038
#11063https://github.com/angular/angular/pull/11063
vsavkinhttps://github.com/vsavkin
completedhttps://github.com/angular/angular/issues?q=is%3Aissue%20state%3Aclosed%20archived%3Afalse%20reason%3Acompleted
on Aug 28, 2016https://github.com/angular/angular/issues/10845#event-769897407
DzmitryShylovichhttps://github.com/DzmitryShylovich
vsavkinhttps://github.com/vsavkin
on Apr 1, 2017https://github.com/angular/angular/issues/10845#event-1025099858
https://github.com/apps/angular-automatic-lock-bot
angular-automatic-lock-bothttps://github.com/apps/angular-automatic-lock-bot
on Sep 11, 2019https://github.com/angular/angular/issues/10845#issuecomment-530224121
automatic conversation locking policyhttps://github.com/angular/angular/blob/67d80f/docs/GITHUB_PROCESS.md#conversation-locking
angular-automatic-lock-bothttps://github.com/apps/angular-automatic-lock-bot
on Sep 11, 2019https://github.com/angular/angular/issues/10845#event-2624437787
Sign up for freehttps://github.com/signup?return_to=https://github.com/angular/angular/issues/10845
Sign in to commenthttps://github.com/login?return_to=https://github.com/angular/angular/issues/10845
area: routerhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20router%22
type: bug/fixhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22type%3A%20bug%2Ffix%22
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.