René's URL Explorer Experiment


Title: Make resolve results injectable in constructor · Issue #10838 · angular/angular · GitHub

Open Graph Title: Make resolve results injectable in constructor · Issue #10838 · angular/angular

X Title: Make resolve results injectable in constructor · Issue #10838 · angular/angular

Description: [ ] bug report => search github for a similar issue or PR before submitting [X] feature request [ ] support request First off, many thanks for your really great work on Angular. We love where this is going. Thanks! Current behavior Given...

Open Graph Description: [ ] bug report => search github for a similar issue or PR before submitting [X] feature request [ ] support request First off, many thanks for your really great work on Angular. We love where this ...

X Description: [ ] bug report => search github for a similar issue or PR before submitting [X] feature request [ ] support request First off, many thanks for your really great work on Angular. We love where th...

Opengraph URL: https://github.com/angular/angular/issues/10838

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Make resolve results injectable in constructor","articleBody":"```\n[ ] bug report => search github for a similar issue or PR before submitting\n[X] feature request\n[ ] support request\n```\n\nFirst off, many thanks for your really great work on Angular. We love where this is going. Thanks! \n\n**Current behavior**\n\nGiven a component:\n\n``` typescript\n@Component({\n    template: require('./book-detail.html')\n})\nexport class BookDetail implements OnInit {\n\n    private book : Book;\n\n    constructor(private route: ActivatedRoute) {}\n\n    ngOnInit(): void {\n        this.route.data.subscribe((data: { book: Book }) => {\n            this.book = data.book;\n        });\n    }\n\n}\n```\n\nAnd a resolver:\n\n``` typescript\n@Injectable()\nexport class BookDetailResolve implements Resolve\u003cany> {\n    constructor(private bookService: BookService) {}\n\n    resolve(route: ActivatedRouteSnapshot): Promise\u003cBook> {\n        let id : number = _.toNumber(route.params['id']);\n        return this.bookService.getBook(id);\n    }\n}\n```\n\nAnd a configuration in the router: \n\n``` typescript\n            path: ':id',\n            component: BookDetail,\n            resolve: {\n              book: BookDetailResolve\n            }\n```\n\nThe way a book is passed to BookDetail is now done by having BookDetail implement OnInit and using the ngInit to read the book from the ActivatedRoute.\n\n**Expected/desired behavior**\n\nIdeally, it would be possible to have the following code:\n\n``` typescript\n@Component({\n    template: require('./book-detail.html')\n})\nexport class BookDetail {\n\n    constructor(private book: Book) {}\n\n}\n```\n\nIn other words, the book as described in the route (and returned by BookDetailResolve) is injected directly into the constructor of BookDetail. This removes code which basically serves no purpose since resolve guarantees that all arguments are resolved prior to initializing the component. Code becomes predictable and the programming model is much easier to understand.\n\n**What is the motivation / use case for changing the behavior?**\n\nTo reduce code which serves only as boilerplate and strive towards a cleaner and easier-to-understand codebase.\n- **Angular version:** 2.0.0-rc.5","author":{"url":"https://github.com/robert-bor","@type":"Person","name":"robert-bor"},"datePublished":"2016-08-16T06:36:28Z","url":"https://github.com/angular/angular/issues/10838"}

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:348c3c0a-dc65-1874-18e8-500f6fd9c247
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-idBAAC:6DC60:1FF02C:27FB94:6B00FCF3
html-safe-nonce401000b9d947678bc57c748cc7c6e7229192b5de23278d80582f471ac9f7973b
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCQUFDOjZEQzYwOjFGRjAyQzoyN0ZCOTQ6NkIwMEZDRjMiLCJ2aXNpdG9yX2lkIjoiOTE2NzAwMTgyNTU0NTYxNjYyOCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac636be1f9767884fe239fa8b3369f661455720cbd4f76d3008aa46c3158fb5151
hovercard-subject-tagissue:171335784
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/angular/angular/10838/issue_layout
twitter:imagehttps://opengraph.githubassets.com/d01bc450dfe98f2a798d2febd1709352200b42335bb7eeead89078c2353055ce/angular/angular/issues/10838
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/d01bc450dfe98f2a798d2febd1709352200b42335bb7eeead89078c2353055ce/angular/angular/issues/10838
og:image:alt[ ] bug report => search github for a similar issue or PR before submitting [X] feature request [ ] support request First off, many thanks for your really great work on Angular. We love where this ...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamerobert-bor
hostnamegithub.com
expected-hostnamegithub.com
Nonee208d86428ec00a57ade75058166297440e8128a01e5287c31a53dc042bbf187
turbo-cache-controlno-preview
go-importgithub.com/angular/angular git https://github.com/angular/angular.git
octolytics-dimension-user_id139426
octolytics-dimension-user_loginangular
octolytics-dimension-repository_id24195339
octolytics-dimension-repository_nwoangular/angular
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id24195339
octolytics-dimension-repository_network_root_nwoangular/angular
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release7dafd017fb7809a839c443dba08622af38e63c09
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-nameissues

Links:

Skip to contenthttps://github.com/angular/angular/issues/10838#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fissues%2F10838
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fissues%2F10838
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=angular%2Fangular
Reloadhttps://github.com/angular/angular/issues/10838
Reloadhttps://github.com/angular/angular/issues/10838
Reloadhttps://github.com/angular/angular/issues/10838
angularhttps://github.com/angular
angularhttps://github.com/angular/angular
Codehttps://github.com/angular/angular
Issues835 (835)https://github.com/angular/angular/issues
Pull requests141 (141)https://github.com/angular/angular/pulls
Discussionshttps://github.com/angular/angular/discussions
Actionshttps://github.com/angular/angular/actions
Projectshttps://github.com/angular/angular/projects
Security and quality40 (40)https://github.com/angular/angular/security
Insightshttps://github.com/angular/angular/insights
https://github.com/angular/angular
New issuehttps://github.com/login?return_to=https://github.com/angular/angular/issues/10838
New issuehttps://github.com/login?return_to=https://github.com/angular/angular/issues/10838
Make resolve results injectable in constructorhttps://github.com/angular/angular/issues/10838#top
area: routerhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20router%22
featureLabel used to distinguish feature request from other issueshttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22feature%22
freq2: mediumhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22freq2%3A%20medium%22
Backloghttps://github.com/angular/angular/milestone/82
https://github.com/robert-bor
robert-borhttps://github.com/robert-bor
on Aug 16, 2016https://github.com/angular/angular/issues/10838#issue-171335784
pkozlowski-opensourcehttps://github.com/pkozlowski-opensource
area: routerhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20router%22
on Aug 16, 2016https://github.com/angular/angular/issues/10838#event-757167933
vsavkinhttps://github.com/vsavkin
featureLabel used to distinguish feature request from other issueshttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22feature%22
on Aug 19, 2016https://github.com/angular/angular/issues/10838#event-761848981
vsavkinhttps://github.com/vsavkin
freq2: mediumhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22freq2%3A%20medium%22
on Oct 10, 2016https://github.com/angular/angular/issues/10838#event-818706367
https://github.com/DzmitryShylovich
DzmitryShylovichhttps://github.com/DzmitryShylovich
on Dec 21, 2016https://github.com/angular/angular/issues/10838#issuecomment-268658322
https://github.com/robert-bor
robert-borhttps://github.com/robert-bor
on Dec 22, 2016https://github.com/angular/angular/issues/10838#issuecomment-268749885
https://github.com/Colorfulstan
Colorfulstanhttps://github.com/Colorfulstan
on Dec 22, 2016https://github.com/angular/angular/issues/10838#issuecomment-268778891
https://github.com/DzmitryShylovich
DzmitryShylovichhttps://github.com/DzmitryShylovich
on Dec 22, 2016https://github.com/angular/angular/issues/10838#issuecomment-268779352
@Colorfulstanhttps://github.com/Colorfulstan
#9787https://github.com/angular/angular/issues/9787
ngbothttps://github.com/apps/ngbot
Backloghttps://github.com/angular/angular/milestone/82
on Jan 23, 2018https://github.com/angular/angular/issues/10838#event-1437654484
https://github.com/apps/angular-robot
angular-robothttps://github.com/apps/angular-robot
on Jun 4, 2021https://github.com/angular/angular/issues/10838#issuecomment-854773253
documentationhttps://github.com/angular/angular/blob/e29eb8abfbfdfb793e08ac88e14b7ba6d2ff2136/docs/GITHUB_PROCESS.md#feature-request-process
angular-robothttps://github.com/apps/angular-robot
votes requiredhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22votes%20required%22
on Jun 4, 2021https://github.com/angular/angular/issues/10838#event-4843528079
https://github.com/apps/angular-robot
angular-robothttps://github.com/apps/angular-robot
on Jun 24, 2021https://github.com/angular/angular/issues/10838#issuecomment-867662388
communityhttps://angular.io/resources?category=community
packagehttps://angular.io/guide/creating-libraries
documentationhttps://github.com/angular/angular/blob/e29eb8abfbfdfb793e08ac88e14b7ba6d2ff2136/docs/GITHUB_PROCESS.md#feature-request-process
angular-robothttps://github.com/apps/angular-robot
insufficient voteshttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22insufficient%20votes%22
on Jun 24, 2021https://github.com/angular/angular/issues/10838#event-4934816928
atscotthttps://github.com/atscott
completedhttps://github.com/angular/angular/issues?q=is%3Aissue%20state%3Aclosed%20archived%3Afalse%20reason%3Acompleted
on Jul 23, 2021https://github.com/angular/angular/issues/10838#event-5063401600
https://github.com/apps/angular-automatic-lock-bot
angular-automatic-lock-bothttps://github.com/apps/angular-automatic-lock-bot
on Aug 23, 2021https://github.com/angular/angular/issues/10838#issuecomment-903914623
automatic conversation locking policyhttps://github.com/angular/angular/blob/8f24bc9443b3872fe095d9f7f77b308a361a13b4/docs/GITHUB_PROCESS.md#conversation-locking
angular-automatic-lock-bothttps://github.com/apps/angular-automatic-lock-bot
on Aug 23, 2021https://github.com/angular/angular/issues/10838#event-5195467852
Sign up for freehttps://github.com/signup?return_to=https://github.com/angular/angular/issues/10838
Sign in to commenthttps://github.com/login?return_to=https://github.com/angular/angular/issues/10838
area: routerhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20router%22
featureLabel used to distinguish feature request from other issueshttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22feature%22
freq2: mediumhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22freq2%3A%20medium%22
BacklogNo due datehttps://github.com/angular/angular/milestone/82
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.