Title: Logging broken when first argument is an element · Issue #2145 · androidannotations/androidannotations · GitHub
Open Graph Title: Logging broken when first argument is an element · Issue #2145 · androidannotations/androidannotations
X Title: Logging broken when first argument is an element · Issue #2145 · androidannotations/androidannotations
Description: While working on #2143 I found that for some places the logging might be broken. e.g. androidannotations/AndroidAnnotations/androidannotations-core/androidannotations/src/main/java/org/androidannotations/internal/process/ModelProcessor.j...
Open Graph Description: While working on #2143 I found that for some places the logging might be broken. e.g. androidannotations/AndroidAnnotations/androidannotations-core/androidannotations/src/main/java/org/androidannot...
X Description: While working on #2143 I found that for some places the logging might be broken. e.g. androidannotations/AndroidAnnotations/androidannotations-core/androidannotations/src/main/java/org/androidannot...
Opengraph URL: https://github.com/androidannotations/androidannotations/issues/2145
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Logging broken when first argument is an element","articleBody":"While working on https://github.com/androidannotations/androidannotations/issues/2143 I found that for some places the logging might be broken.\r\n\r\ne.g.\r\nhttps://github.com/androidannotations/androidannotations/blob/074df636fbd482cea3f797eece296524a877fd67/AndroidAnnotations/androidannotations-core/androidannotations/src/main/java/org/androidannotations/internal/process/ModelProcessor.java#L203\r\n\r\nresults in the message:\r\n\u003e 17:54:26.825 [Task worker for ':' Thread 2] ERROR o.a.i.p.ModelProcessor:203 - Skip element because it's abstract\r\n\r\nThis happens as the signatures of the trace methods are\r\n```\r\nvoid trace(String message, Object... args);\r\nvoid trace(String message, Element element, Object... args);\r\n```\r\nInstead of using the first (and in this case desired version) the compiler uses the second version of `trace` as the first parameter after the message is an `Element` adn so it is not usedas replacement for the `{}` the log message but the message (without a valuefor `{}`) is attached to the element.\r\n\r\nI think we should review all places where we use these logs and possibly even refactor the logger to avoid similar issues. maybe move the `element` in front of the string parameter?\r\n\r\n@WonderCsabo wdyt?","author":{"url":"https://github.com/dodgex","@type":"Person","name":"dodgex"},"datePublished":"2018-06-09T16:11:21.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":3},"url":"https://github.com/2145/androidannotations/issues/2145"}
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:9e995e3d-9b2f-06f3-c065-ab10becc4100 |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | EB5C:145FC1:200F7EB:2E31C0E:6A60AEA1 |
| html-safe-nonce | 0a4b717238b0b61e25a4ece5ebfa4b80b4f740ea76548ccc69f5390998f7441b |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFQjVDOjE0NUZDMToyMDBGN0VCOjJFMzFDMEU6NkE2MEFFQTEiLCJ2aXNpdG9yX2lkIjoiNTQ2OTg3ODA4MTQ2NDM0ODMyMSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | c07b09ba18243b6ec32c04d880cc4c5644fa64f08854215311caa93a91e37848 |
| hovercard-subject-tag | issue:330899346 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/androidannotations/androidannotations/2145/issue_layout |
| twitter:image | https://opengraph.githubassets.com/8193f231f7fe282e0f4822bda1478faa5f708d16891f5355db967162cdeda02b/androidannotations/androidannotations/issues/2145 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/8193f231f7fe282e0f4822bda1478faa5f708d16891f5355db967162cdeda02b/androidannotations/androidannotations/issues/2145 |
| og:image:alt | While working on #2143 I found that for some places the logging might be broken. e.g. androidannotations/AndroidAnnotations/androidannotations-core/androidannotations/src/main/java/org/androidannot... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | dodgex |
| hostname | github.com |
| expected-hostname | github.com |
| None | 35671f8a6946a7a2a81d51ae49f5465bdc5f925c23c9cb839206b24345dbe8d9 |
| turbo-cache-control | no-preview |
| go-import | github.com/androidannotations/androidannotations git https://github.com/androidannotations/androidannotations.git |
| octolytics-dimension-user_id | 1315313 |
| octolytics-dimension-user_login | androidannotations |
| octolytics-dimension-repository_id | 3116751 |
| octolytics-dimension-repository_nwo | androidannotations/androidannotations |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 3116751 |
| octolytics-dimension-repository_network_root_nwo | androidannotations/androidannotations |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 746dc49090e6e3995bb502dce0f8807393e36eda |
| ui-target | canary-2 |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width