René's URL Explorer Experiment


Title: fix(types): derive response arms from schemas by bokelley · Pull Request #922 · adcontextprotocol/adcp-client-python · GitHub

Open Graph Title: fix(types): derive response arms from schemas by bokelley · Pull Request #922 · adcontextprotocol/adcp-client-python

X Title: fix(types): derive response arms from schemas by bokelley · Pull Request #922 · adcontextprotocol/adcp-client-python

Description: A python library to interact with adcp servers. Contribute to adcontextprotocol/adcp-client-python development by creating an account on GitHub.

Open Graph Description: Summary This replaces the hand-written post-generate response-arm stubs with schema-derived generation so numbered SDK response classes stay aligned with the JSON schemas. It regenerates the affect...

X Description: Summary This replaces the hand-written post-generate response-arm stubs with schema-derived generation so numbered SDK response classes stay aligned with the JSON schemas. It regenerates the affect...

Opengraph URL: https://github.com/adcontextprotocol/adcp-client-python/pull/922

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:d743430b-a616-ecc6-1f53-070ef1bc1dc0
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idC416:785A9:EBF59E:12BA8DF:6B010A93
html-safe-noncef306fce9d93363c8b450b39f9b6e090a81aef50903fe408084914659ba285c5a
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDNDE2Ojc4NUE5OkVCRjU5RToxMkJBOERGOjZCMDEwQTkzIiwidmlzaXRvcl9pZCI6IjE4NjYxODg5NTAwNDE4NTY2NjAiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac1db2fb922d16a822fff135fd8e33d1758ff725fc11b0fbe6fa618ef5bac607f8
hovercard-subject-tagpull_request:3816673611
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/adcontextprotocol/adcp-client-python/922/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/208629463a5c969c46e47efba1846916afa799f15ebd3363cb392e1b77ee9a14/adcontextprotocol/adcp-client-python/pull/922
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/208629463a5c969c46e47efba1846916afa799f15ebd3363cb392e1b77ee9a14/adcontextprotocol/adcp-client-python/pull/922
og:image:altSummary This replaces the hand-written post-generate response-arm stubs with schema-derived generation so numbered SDK response classes stay aligned with the JSON schemas. It regenerates the affect...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamebokelley
hostnamegithub.com
expected-hostnamegithub.com
Nonecb7fa109eca7d4156c889f474306b0e91336055e9adf8fd4684b61e49094d124
turbo-cache-controlno-cache
go-importgithub.com/adcontextprotocol/adcp-client-python git https://github.com/adcontextprotocol/adcp-client-python.git
octolytics-dimension-user_id221690821
octolytics-dimension-user_loginadcontextprotocol
octolytics-dimension-repository_id1090305973
octolytics-dimension-repository_nwoadcontextprotocol/adcp-client-python
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id1090305973
octolytics-dimension-repository_network_root_nwoadcontextprotocol/adcp-client-python
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release2b59d31a4e44f08b7af67a4b67f8fd0af3befe2a
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/adcontextprotocol/adcp-client-python/pull/922#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fadcontextprotocol%2Fadcp-client-python%2Fpull%2F922
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fadcontextprotocol%2Fadcp-client-python%2Fpull%2F922
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=adcontextprotocol%2Fadcp-client-python
Reloadhttps://github.com/adcontextprotocol/adcp-client-python/pull/922
Reloadhttps://github.com/adcontextprotocol/adcp-client-python/pull/922
Reloadhttps://github.com/adcontextprotocol/adcp-client-python/pull/922
adcontextprotocolhttps://github.com/adcontextprotocol
adcp-client-pythonhttps://github.com/adcontextprotocol/adcp-client-python
Codehttps://github.com/adcontextprotocol/adcp-client-python
Issues44 (44)https://github.com/adcontextprotocol/adcp-client-python/issues
Pull requests13 (13)https://github.com/adcontextprotocol/adcp-client-python/pulls
Actionshttps://github.com/adcontextprotocol/adcp-client-python/actions
Projectshttps://github.com/adcontextprotocol/adcp-client-python/projects
Security and qualityhttps://github.com/adcontextprotocol/adcp-client-python/security
Insightshttps://github.com/adcontextprotocol/adcp-client-python/insights
https://github.com/adcontextprotocol/adcp-client-python
bokelleyhttps://github.com/bokelley
mainhttps://github.com/adcontextprotocol/adcp-client-python/tree/main
manual-arms-schema-mismatchhttps://github.com/adcontextprotocol/adcp-client-python/tree/manual-arms-schema-mismatch
Conversationhttps://github.com/adcontextprotocol/adcp-client-python/pull/922
Commits1 (1)https://github.com/adcontextprotocol/adcp-client-python/pull/922/commits
Checkshttps://github.com/adcontextprotocol/adcp-client-python/pull/922/checks
Files changedhttps://github.com/adcontextprotocol/adcp-client-python/pull/922/files
fix(types): derive response arms from schemashttps://github.com/adcontextprotocol/adcp-client-python/pull/922#top
bokelleyhttps://github.com/bokelley
mainhttps://github.com/adcontextprotocol/adcp-client-python/tree/main
manual-arms-schema-mismatchhttps://github.com/adcontextprotocol/adcp-client-python/tree/manual-arms-schema-mismatch
https://github.com/bokelley
bokelleyhttps://github.com/bokelley
Jun 6, 2026https://github.com/adcontextprotocol/adcp-client-python/pull/922#issue-4604613327
Please reload this pagehttps://github.com/adcontextprotocol/adcp-client-python/pull/922
https://github.com/bokelley
bokelleyhttps://github.com/bokelley
force-pushedhttps://github.com/adcontextprotocol/adcp-client-python/compare/f7efd6a12bb259eb0859f9ddacb4752d508b7f0f..1f619f69c2c55bd3b81cbdd9de0f547c5820ca15
f7efd6ahttps://github.com/adcontextprotocol/adcp-client-python/commit/f7efd6a12bb259eb0859f9ddacb4752d508b7f0f
1f619f6https://github.com/adcontextprotocol/adcp-client-python/commit/1f619f69c2c55bd3b81cbdd9de0f547c5820ca15
Compare https://github.com/adcontextprotocol/adcp-client-python/compare/f7efd6a12bb259eb0859f9ddacb4752d508b7f0f..1f619f69c2c55bd3b81cbdd9de0f547c5820ca15
June 6, 2026 18:20https://github.com/adcontextprotocol/adcp-client-python/pull/922#event-26426463527
https://github.com/apps/github-code-quality
github-code-qualityhttps://github.com/apps/github-code-quality
Jun 6, 2026 https://github.com/adcontextprotocol/adcp-client-python/pull/922#pullrequestreview-4443535653
View reviewed changes https://github.com/adcontextprotocol/adcp-client-python/pull/922/files
src/adcp/types/generated_poc/brand/acquire_rights_response.pyhttps://github.com/adcontextprotocol/adcp-client-python/pull/922/files#diff-0c3a91d0c4314a6f0fb7f878709ee6dfabc7c03725846bbd4eaaf718e3dd77dd
Please reload this pagehttps://github.com/adcontextprotocol/adcp-client-python/pull/922
src/adcp/types/generated_poc/creative/get_creative_features_response.pyhttps://github.com/adcontextprotocol/adcp-client-python/pull/922/files#diff-1c3f7bec459fec35f333ba8964d5aedfb18e6a0ea9433d083700c832a2928281
Please reload this pagehttps://github.com/adcontextprotocol/adcp-client-python/pull/922
src/adcp/types/generated_poc/brand/get_rights_response.pyhttps://github.com/adcontextprotocol/adcp-client-python/pull/922/files#diff-a6619eab1db6692ea55e9420b8305dbe313be875a56ef29d8af27705c90b8718
Please reload this pagehttps://github.com/adcontextprotocol/adcp-client-python/pull/922
src/adcp/types/generated_poc/creative/preview_creative_response.pyhttps://github.com/adcontextprotocol/adcp-client-python/pull/922/files#diff-8474c292fefb1bdedbe21026df0ca6d9e34582168883d0c9c31f3c4a429e80b3
Please reload this pagehttps://github.com/adcontextprotocol/adcp-client-python/pull/922
src/adcp/types/generated_poc/account/sync_accounts_response.pyhttps://github.com/adcontextprotocol/adcp-client-python/pull/922/files#diff-810b46fd6b0abe64d5a9365215ac6ce4b874ff3948bee12bb2d6b5d72ed6db6f
Please reload this pagehttps://github.com/adcontextprotocol/adcp-client-python/pull/922
src/adcp/types/generated_poc/creative/sync_creatives_response.pyhttps://github.com/adcontextprotocol/adcp-client-python/pull/922/files#diff-667a4aa9247bf44e54af5ecb9faa047c9c47bff1a872d629c3ca2a439e820ef0
Please reload this pagehttps://github.com/adcontextprotocol/adcp-client-python/pull/922
src/adcp/types/guards.pyhttps://github.com/adcontextprotocol/adcp-client-python/pull/922/files#diff-2b6934fc474443bf13b5b8d757a30c31df374b146a5033a68fad36908ca3b707
Please reload this pagehttps://github.com/adcontextprotocol/adcp-client-python/pull/922
https://github.com/apps/aao-ipr-bot
aao-ipr-bothttps://github.com/apps/aao-ipr-bot
Jun 6, 2026 https://github.com/adcontextprotocol/adcp-client-python/pull/922#pullrequestreview-4443537208
View reviewed changes https://github.com/adcontextprotocol/adcp-client-python/pull/922/files
aao-ipr-bothttps://github.com/apps/aao-ipr-bot
https://github.com/adcontextprotocol/adcp-client-python/pull/922#pullrequestreview-4443537208
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/adcontextprotocol/adcp-client-python/pull/922
https://github.com/apps/aao-ipr-bot
aao-ipr-bothttps://github.com/apps/aao-ipr-bot
Jun 6, 2026 https://github.com/adcontextprotocol/adcp-client-python/pull/922#pullrequestreview-4443540516
View reviewed changes https://github.com/adcontextprotocol/adcp-client-python/pull/922/files
aao-ipr-bothttps://github.com/apps/aao-ipr-bot
https://github.com/adcontextprotocol/adcp-client-python/pull/922#pullrequestreview-4443540516
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/adcontextprotocol/adcp-client-python/pull/922
https://github.com/bokelley
bokelleyhttps://github.com/bokelley
force-pushedhttps://github.com/adcontextprotocol/adcp-client-python/compare/1f619f69c2c55bd3b81cbdd9de0f547c5820ca15..d78e9cf8ebb9703f821f917563a8cba09526d810
1f619f6https://github.com/adcontextprotocol/adcp-client-python/commit/1f619f69c2c55bd3b81cbdd9de0f547c5820ca15
d78e9cfhttps://github.com/adcontextprotocol/adcp-client-python/commit/d78e9cf8ebb9703f821f917563a8cba09526d810
Compare https://github.com/adcontextprotocol/adcp-client-python/compare/1f619f69c2c55bd3b81cbdd9de0f547c5820ca15..d78e9cf8ebb9703f821f917563a8cba09526d810
June 6, 2026 18:48https://github.com/adcontextprotocol/adcp-client-python/pull/922#event-26426823714
https://github.com/bokelley
fix(types): derive response arms from schemashttps://github.com/adcontextprotocol/adcp-client-python/pull/922/commits/7947169b90e166bed7564f653d799d900b49b22c
7947169https://github.com/adcontextprotocol/adcp-client-python/pull/922/commits/7947169b90e166bed7564f653d799d900b49b22c
https://github.com/bokelley
bokelleyhttps://github.com/bokelley
force-pushedhttps://github.com/adcontextprotocol/adcp-client-python/compare/d78e9cf8ebb9703f821f917563a8cba09526d810..7947169b90e166bed7564f653d799d900b49b22c
d78e9cfhttps://github.com/adcontextprotocol/adcp-client-python/commit/d78e9cf8ebb9703f821f917563a8cba09526d810
7947169https://github.com/adcontextprotocol/adcp-client-python/commit/7947169b90e166bed7564f653d799d900b49b22c
Compare https://github.com/adcontextprotocol/adcp-client-python/compare/d78e9cf8ebb9703f821f917563a8cba09526d810..7947169b90e166bed7564f653d799d900b49b22c
June 6, 2026 18:57https://github.com/adcontextprotocol/adcp-client-python/pull/922#event-26426956635
https://github.com/apps/aao-ipr-bot
aao-ipr-bothttps://github.com/apps/aao-ipr-bot
Jun 6, 2026 https://github.com/adcontextprotocol/adcp-client-python/pull/922#pullrequestreview-4443582200
View reviewed changes https://github.com/adcontextprotocol/adcp-client-python/pull/922/files/7947169b90e166bed7564f653d799d900b49b22c
aao-ipr-bothttps://github.com/apps/aao-ipr-bot
https://github.com/adcontextprotocol/adcp-client-python/pull/922#pullrequestreview-4443582200
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/adcontextprotocol/adcp-client-python/pull/922
https://github.com/apps/aao-ipr-bot
aao-ipr-bothttps://github.com/apps/aao-ipr-bot
Jun 6, 2026 https://github.com/adcontextprotocol/adcp-client-python/pull/922#pullrequestreview-4443597142
View reviewed changes https://github.com/adcontextprotocol/adcp-client-python/pull/922/files/7947169b90e166bed7564f653d799d900b49b22c
aao-ipr-bothttps://github.com/apps/aao-ipr-bot
https://github.com/adcontextprotocol/adcp-client-python/pull/922#pullrequestreview-4443597142
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/adcontextprotocol/adcp-client-python/pull/922
https://github.com/bokelley
bokelleyhttps://github.com/bokelley
70abb5ahttps://github.com/adcontextprotocol/adcp-client-python/commit/70abb5aca884a5af3b9339b3d9da73832bf22034
Jun 6, 2026https://github.com/adcontextprotocol/adcp-client-python/pull/922#event-26427152170
Please reload this pagehttps://github.com/adcontextprotocol/adcp-client-python/pull/922
https://github.com/bokelley
bokelleyhttps://github.com/bokelley
June 6, 2026 19:10https://github.com/adcontextprotocol/adcp-client-python/pull/922#event-26427152647
https://github.com/apps/aao-ipr-bot
aao-ipr-bothttps://github.com/apps/aao-ipr-bot
Jun 6, 2026 https://github.com/adcontextprotocol/adcp-client-python/pull/922#ref-pullrequest-4604801039
chore(main): release 6.3.0-beta.9 #923 https://github.com/adcontextprotocol/adcp-client-python/pull/923
fix(types): align SyncCreativesResponse Creative & CreateMediaBuyResponse1 with rc.9 schema #921 https://github.com/adcontextprotocol/adcp-client-python/pull/921
SyncCreativesResponse Creative item missing 9 of 12 spec-defined fields #918 https://github.com/adcontextprotocol/adcp-client-python/issues/918
CreateMediaBuyResponse1 incorrectly declares buyer_ref (not in AdCP 3.x schema since GA) #914 https://github.com/adcontextprotocol/adcp-client-python/issues/914
bokelleyhttps://github.com/bokelley
Jun 6, 2026 https://github.com/adcontextprotocol/adcp-client-python/pull/922#ref-commit-1dfd8b4
https://github.com/bokelley
https://github.com/claude
chore(codegen): re-snapshot collision allowlist afterhttps://github.com/adcontextprotocol/adcp-client-python/commit/1dfd8b452d768ff23edf1e67eea53db00aa202f9
#922https://github.com/adcontextprotocol/adcp-client-python/pull/922
1dfd8b4https://github.com/adcontextprotocol/adcp-client-python/commit/1dfd8b452d768ff23edf1e67eea53db00aa202f9
#922https://github.com/adcontextprotocol/adcp-client-python/pull/922
#922https://github.com/adcontextprotocol/adcp-client-python/pull/922
https://github.com/apps/aao-ipr-bot
aao-ipr-bothttps://github.com/apps/aao-ipr-bot
Jun 6, 2026 https://github.com/adcontextprotocol/adcp-client-python/pull/922#ref-pullrequest-4604251799
feat(codegen): fail consolidate on unallowlisted name collisions #919 https://github.com/adcontextprotocol/adcp-client-python/pull/919
bokelleyhttps://github.com/bokelley
Jun 6, 2026 https://github.com/adcontextprotocol/adcp-client-python/pull/922#ref-commit-d9367a0
https://github.com/bokelley
https://github.com/claude
feat(codegen): fail consolidate on unallowlisted name collisions (https://github.com/adcontextprotocol/adcp-client-python/commit/d9367a0b20d2884146f207b13b11e3a0820911a8
#919https://github.com/adcontextprotocol/adcp-client-python/pull/919
)https://github.com/adcontextprotocol/adcp-client-python/commit/d9367a0b20d2884146f207b13b11e3a0820911a8
d9367a0https://github.com/adcontextprotocol/adcp-client-python/commit/d9367a0b20d2884146f207b13b11e3a0820911a8
#911https://github.com/adcontextprotocol/adcp-client-python/issues/911
#922https://github.com/adcontextprotocol/adcp-client-python/pull/922
#922https://github.com/adcontextprotocol/adcp-client-python/pull/922
#922https://github.com/adcontextprotocol/adcp-client-python/pull/922
https://github.com/KonstantinMirin
KonstantinMirinhttps://github.com/KonstantinMirin
Jun 8, 2026 https://github.com/adcontextprotocol/adcp-client-python/pull/922#ref-issue-4614074055
Request: v5.7.1 patch release with #913/#914/#918 fixes #946 https://github.com/adcontextprotocol/adcp-client-python/issues/946
https://github.co/hiddenchars
https://github.com/adcontextprotocol/adcp-client-python/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fadcontextprotocol%2Fadcp-client-python%2Fpull%2F922
https://github.com/apps/aao-ipr-bot
aao-ipr-bot[bot] https://github.com/apps/aao-ipr-bot
https://github.com/adcontextprotocol/adcp-client-python/pull/922/files/7947169b90e166bed7564f653d799d900b49b22c
https://github.com/apps/github-code-quality
github-code-quality[bot] https://github.com/apps/github-code-quality
https://github.com/adcontextprotocol/adcp-client-python/pull/922/files/1f619f69c2c55bd3b81cbdd9de0f547c5820ca15
Please reload this pagehttps://github.com/adcontextprotocol/adcp-client-python/pull/922
Please reload this pagehttps://github.com/adcontextprotocol/adcp-client-python/pull/922
https://github.com/bokelley
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.