| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:b5e1f5bb-fde6-a00d-e5cd-f2e850b46845 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | E6AA:34CAB:A37809:D1CD7A:6B00F600 |
| html-safe-nonce | 11699ad1572ce72593c0fe9e36d65086bd5a4ef9bce786331a50eaf62eaedfe9 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFNkFBOjM0Q0FCOkEzNzgwOTpEMUNEN0E6NkIwMEY2MDAiLCJ2aXNpdG9yX2lkIjoiNzEyMTc0MjAyNDE0MjgxMjY3MiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 40b01698ca7f1447215e85712ad09df0207c8ed68011763fc97467a00d7094fe |
| hovercard-subject-tag | pull_request:3730120709 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/adcontextprotocol/adcp-client-python/798/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/0570713c940c513939c29bde2a8a6ca2cbadbb6e786a72d3a29ca3d9e4ff71da/adcontextprotocol/adcp-client-python/pull/798 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/0570713c940c513939c29bde2a8a6ca2cbadbb6e786a72d3a29ca3d9e4ff71da/adcontextprotocol/adcp-client-python/pull/798 |
| og:image:alt | Summary
All non-blocking follow-up items from the two Argus reviews on PR #789, bundled into one PR with four cohesive commits so reviewers can read the story incrementally.
#
Commit
Items
1... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | bokelley |
| hostname | github.com |
| expected-hostname | github.com |
| None | 4ef498cbabcbe3c50befc7a5b743e7072ee770b4daf0e15e54801180d1fa91fc |
| turbo-cache-control | no-cache |
| go-import | github.com/adcontextprotocol/adcp-client-python git https://github.com/adcontextprotocol/adcp-client-python.git |
| octolytics-dimension-user_id | 221690821 |
| octolytics-dimension-user_login | adcontextprotocol |
| octolytics-dimension-repository_id | 1090305973 |
| octolytics-dimension-repository_nwo | adcontextprotocol/adcp-client-python |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 1090305973 |
| octolytics-dimension-repository_network_root_nwo | adcontextprotocol/adcp-client-python |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 9983dd5da06943f833c971dd5b6bc988e2858be5 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | pull-requests |
| Skip to content | https://github.com/adcontextprotocol/adcp-client-python/pull/798#start-of-content |
| https://github.com/ |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fadcontextprotocol%2Fadcp-client-python%2Fpull%2F798 |
| GitHubRepository hosting, code review, and collaboration | https://github.com/platform |
| CopilotAI coding agent for tasks, projects, and automated work | https://github.com/features/copilot |
| ActionsCI/CD and automation | https://github.com/features/actions |
| Code QualityQuality analysis, fixes, and enforcement | https://github.com/features/code-quality |
| CodespacesCloud development environments | https://github.com/features/codespaces |
| Code SecurityVulnerability detection and remediation | https://github.com/security/advanced-security/code-security |
| Secret ProtectionSecret scanning and leak prevention | https://github.com/security/advanced-security/secret-protection |
| All Features | https://github.com/features |
| Documentation | https://docs.github.com/en |
| Training | https://learn.github.com/skills |
| Certifications | https://learn.github.com/credentials |
| Build with Copilot | https://github.com/features/ai |
| Customize Copilot | https://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview |
| Integrations | https://github.com/marketplace |
| Trending repos | https://github.com/trending |
| GitHub Sponsors | https://github.com/open-source/sponsors |
| Developer articles | https://github.com/resources/articles |
| ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place. | https://github.blog/changelog/ |
| Enterprises | https://github.com/enterprise |
| Team | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| See all industries | https://github.com/solutions/industry |
| Why GitHub | https://github.com/why-github |
| Customer Stories | https://github.com/customer-stories |
| Business insights | https://github.com/solutions/executive-insights |
| Trust Center | https://github.com/trust-center |
| GitHub Advanced SecurityEnterprise-grade code security | https://github.com/security/advanced-security |
| Copilot for businessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Documentation | https://docs.github.com/en |
| Resource center | https://github.com/resources |
| Blog | https://github.blog/ |
| Events & webinars | https://github.com/resources/events |
| Community Forum | https://github.com/orgs/community/discussions |
| Customer Stories | https://github.com/customer-stories |
| Integrations | https://github.com/marketplace |
| Customer support | https://help.github.com/ |
| Training | https://learn.github.com/skills |
| GitHub Status | https://www.githubstatus.com/ |
| About | https://github.com/about |
| Partners | https://github.com/partners |
| Changelog | https://github.blog/changelog/ |
| GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub. | https://githubuniverse.com/ |
| Pricing | https://github.com/pricing |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fadcontextprotocol%2Fadcp-client-python%2Fpull%2F798 |
| Sign up | https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=adcontextprotocol%2Fadcp-client-python |
| Reload | https://github.com/adcontextprotocol/adcp-client-python/pull/798 |
| Reload | https://github.com/adcontextprotocol/adcp-client-python/pull/798 |
| Reload | https://github.com/adcontextprotocol/adcp-client-python/pull/798 |
| adcontextprotocol | https://github.com/adcontextprotocol |
| adcp-client-python | https://github.com/adcontextprotocol/adcp-client-python |
| Code | https://github.com/adcontextprotocol/adcp-client-python |
| Issues44 (44) | https://github.com/adcontextprotocol/adcp-client-python/issues |
| Pull requests13 (13) | https://github.com/adcontextprotocol/adcp-client-python/pulls |
| Actions | https://github.com/adcontextprotocol/adcp-client-python/actions |
| Projects | https://github.com/adcontextprotocol/adcp-client-python/projects |
| Security and quality | https://github.com/adcontextprotocol/adcp-client-python/security |
| Insights | https://github.com/adcontextprotocol/adcp-client-python/insights |
| https://github.com/adcontextprotocol/adcp-client-python |
| bokelley | https://github.com/bokelley |
| main | https://github.com/adcontextprotocol/adcp-client-python/tree/main |
| bokelley/signing-followups-argus | https://github.com/adcontextprotocol/adcp-client-python/tree/bokelley/signing-followups-argus |
| Conversation | https://github.com/adcontextprotocol/adcp-client-python/pull/798 |
| Commits5 (5) | https://github.com/adcontextprotocol/adcp-client-python/pull/798/commits |
| Checks | https://github.com/adcontextprotocol/adcp-client-python/pull/798/checks |
| Files changed | https://github.com/adcontextprotocol/adcp-client-python/pull/798/files |
| fix(signing): Argus follow-ups on #789 — IDNA + IP literals, Protocol contract, misconfig warnings, diagnostic hygiene | https://github.com/adcontextprotocol/adcp-client-python/pull/798#top |
| bokelley | https://github.com/bokelley |
| main | https://github.com/adcontextprotocol/adcp-client-python/tree/main |
| bokelley/signing-followups-argus | https://github.com/adcontextprotocol/adcp-client-python/tree/bokelley/signing-followups-argus |
|
| https://github.com/bokelley |
| bokelley | https://github.com/bokelley |
| May 22, 2026 | https://github.com/adcontextprotocol/adcp-client-python/pull/798#issue-4502409961 |
| #789 | https://github.com/adcontextprotocol/adcp-client-python/pull/789 |
| #789 | https://github.com/adcontextprotocol/adcp-client-python/pull/789 |
| #789 | https://github.com/adcontextprotocol/adcp-client-python/pull/789 |
| #789 | https://github.com/adcontextprotocol/adcp-client-python/pull/789 |
| #350 | https://github.com/adcontextprotocol/adcp-client-python/issues/350 |
| Claude Code | https://claude.com/claude-code |
| Please reload this page | https://github.com/adcontextprotocol/adcp-client-python/pull/798 |
| bokelley | https://github.com/bokelley |
| May 22, 2026 07:48 | https://github.com/adcontextprotocol/adcp-client-python/pull/798#commits-pushed-1bda50d |
|
| https://github.com/bokelley |
|
| https://github.com/claude |
| refactor(signing): centralize IDNA host canonicalization, add IP lite… | https://github.com/adcontextprotocol/adcp-client-python/pull/798/commits/1bda50d227d0b3fa3503cf4a7549a096814afba4 |
| 1bda50d | https://github.com/adcontextprotocol/adcp-client-python/pull/798/commits/1bda50d227d0b3fa3503cf4a7549a096814afba4 |
| #789 | https://github.com/adcontextprotocol/adcp-client-python/pull/789 |
| #789 | https://github.com/adcontextprotocol/adcp-client-python/pull/789 |
| #789 | https://github.com/adcontextprotocol/adcp-client-python/pull/789 |
|
| https://github.com/bokelley |
|
| https://github.com/claude |
| feat(signing): public BrandSourcedJwksResolver Protocol + tighten jwk… | https://github.com/adcontextprotocol/adcp-client-python/pull/798/commits/6210c8bfc78aa5c74055debf6d59dfeccb248607 |
| 6210c8b | https://github.com/adcontextprotocol/adcp-client-python/pull/798/commits/6210c8bfc78aa5c74055debf6d59dfeccb248607 |
| #789 | https://github.com/adcontextprotocol/adcp-client-python/pull/789 |
| #789 | https://github.com/adcontextprotocol/adcp-client-python/pull/789 |
|
| https://github.com/bokelley |
|
| https://github.com/claude |
| feat(signing): warn on key_origins misconfiguration | https://github.com/adcontextprotocol/adcp-client-python/pull/798/commits/e5457a704f230652345b83355243dfba39f4c79a |
| e5457a7 | https://github.com/adcontextprotocol/adcp-client-python/pull/798/commits/e5457a704f230652345b83355243dfba39f4c79a |
| #789 | https://github.com/adcontextprotocol/adcp-client-python/pull/789 |
| #789 | https://github.com/adcontextprotocol/adcp-client-python/pull/789 |
|
| https://github.com/bokelley |
|
| https://github.com/claude |
| fix(signing): cap key_origins entry size, route cold-cache jwks_uri=N… | https://github.com/adcontextprotocol/adcp-client-python/pull/798/commits/733ed4e43bd63cd5ae3eb3c4a977d8aab2a207cb |
| 733ed4e | https://github.com/adcontextprotocol/adcp-client-python/pull/798/commits/733ed4e43bd63cd5ae3eb3c4a977d8aab2a207cb |
| #789 | https://github.com/adcontextprotocol/adcp-client-python/pull/789 |
| #789 | https://github.com/adcontextprotocol/adcp-client-python/pull/789 |
| https://github.com/apps/github-code-quality |
| github-code-quality | https://github.com/apps/github-code-quality |
|
May 22, 2026
| https://github.com/adcontextprotocol/adcp-client-python/pull/798#pullrequestreview-4345211449 |
|
View reviewed changes
| https://github.com/adcontextprotocol/adcp-client-python/pull/798/files/733ed4e43bd63cd5ae3eb3c4a977d8aab2a207cb |
| src/adcp/signing/jwks.py | https://github.com/adcontextprotocol/adcp-client-python/pull/798/files/733ed4e43bd63cd5ae3eb3c4a977d8aab2a207cb#diff-cd4fd783da77b4e77ac5b4b7766bd1933319005b09ad2c26f87defc099702dcd |
| Please reload this page | https://github.com/adcontextprotocol/adcp-client-python/pull/798 |
| https://github.com/apps/aao-ipr-bot |
| aao-ipr-bot | https://github.com/apps/aao-ipr-bot |
|
May 22, 2026
| https://github.com/adcontextprotocol/adcp-client-python/pull/798#pullrequestreview-4345251976 |
|
View reviewed changes
| https://github.com/adcontextprotocol/adcp-client-python/pull/798/files/733ed4e43bd63cd5ae3eb3c4a977d8aab2a207cb |
| aao-ipr-bot | https://github.com/apps/aao-ipr-bot |
| https://github.com/adcontextprotocol/adcp-client-python/pull/798#pullrequestreview-4345251976 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| #789 | https://github.com/adcontextprotocol/adcp-client-python/pull/789 |
| #350 | https://github.com/adcontextprotocol/adcp-client-python/issues/350 |
| Please reload this page | https://github.com/adcontextprotocol/adcp-client-python/pull/798 |
|
| https://github.com/bokelley |
|
| https://github.com/claude |
| chore(signing): docstring on BrandSourcedJwksResolver.__call__ to sil… | https://github.com/adcontextprotocol/adcp-client-python/pull/798/commits/17dc76cbc0a505b8e8daa1979f695860e5bd27d0 |
| 17dc76c | https://github.com/adcontextprotocol/adcp-client-python/pull/798/commits/17dc76cbc0a505b8e8daa1979f695860e5bd27d0 |
| https://github.com/bokelley |
| bokelley | https://github.com/bokelley |
| aao-ipr-bot[bot] | https://github.com/apps/aao-ipr-bot |
| stale review | https://github.com/adcontextprotocol/adcp-client-python/pull/798#pullrequestreview-4345251976 |
| 17dc76c | https://github.com/adcontextprotocol/adcp-client-python/commit/17dc76cbc0a505b8e8daa1979f695860e5bd27d0 |
| May 22, 2026 12:33 | https://github.com/adcontextprotocol/adcp-client-python/pull/798#event-25851216816 |
| https://github.com/apps/aao-ipr-bot |
| aao-ipr-bot | https://github.com/apps/aao-ipr-bot |
|
May 22, 2026
| https://github.com/adcontextprotocol/adcp-client-python/pull/798#pullrequestreview-4345486479 |
|
View reviewed changes
| https://github.com/adcontextprotocol/adcp-client-python/pull/798/files/17dc76cbc0a505b8e8daa1979f695860e5bd27d0 |
| aao-ipr-bot | https://github.com/apps/aao-ipr-bot |
| https://github.com/adcontextprotocol/adcp-client-python/pull/798#pullrequestreview-4345486479 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/adcontextprotocol/adcp-client-python/pull/798 |
| https://github.com/bokelley |
| bokelley | https://github.com/bokelley |
| fcb64fc | https://github.com/adcontextprotocol/adcp-client-python/commit/fcb64fcfae8b42822bdf92c289dcb771191419c4 |
| May 22, 2026 | https://github.com/adcontextprotocol/adcp-client-python/pull/798#event-25851755153 |
| Please reload this page | https://github.com/adcontextprotocol/adcp-client-python/pull/798 |
| https://github.com/bokelley |
| bokelley | https://github.com/bokelley |
| May 22, 2026 12:49 | https://github.com/adcontextprotocol/adcp-client-python/pull/798#event-25851756452 |
| https://github.com/apps/github-actions |
| github-actions | https://github.com/apps/github-actions |
|
May 22, 2026
| https://github.com/adcontextprotocol/adcp-client-python/pull/798#ref-pullrequest-4487262475 |
|
chore(main): release 5.7.0
#751
| https://github.com/adcontextprotocol/adcp-client-python/pull/751 |
| https://github.co/hiddenchars |
| https://github.com/adcontextprotocol/adcp-client-python/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fadcontextprotocol%2Fadcp-client-python%2Fpull%2F798 |
|
| https://github.com/apps/aao-ipr-bot |
|
aao-ipr-bot[bot]
| https://github.com/apps/aao-ipr-bot |
|
| https://github.com/adcontextprotocol/adcp-client-python/pull/798/files/17dc76cbc0a505b8e8daa1979f695860e5bd27d0 |
|
| https://github.com/apps/github-code-quality |
|
github-code-quality[bot]
| https://github.com/apps/github-code-quality |
|
| https://github.com/adcontextprotocol/adcp-client-python/pull/798/files/733ed4e43bd63cd5ae3eb3c4a977d8aab2a207cb |
| Please reload this page | https://github.com/adcontextprotocol/adcp-client-python/pull/798 |
| Please reload this page | https://github.com/adcontextprotocol/adcp-client-python/pull/798 |
|
| https://github.com/bokelley |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |