René's URL Explorer Experiment


Title: feat(signing): verifier key_origins check + IDNA-2008 canonicalization (closes #776, #777) by bokelley · Pull Request #789 · adcontextprotocol/adcp-client-python · GitHub

Open Graph Title: feat(signing): verifier key_origins check + IDNA-2008 canonicalization (closes #776, #777) by bokelley · Pull Request #789 · adcontextprotocol/adcp-client-python

X Title: feat(signing): verifier key_origins check + IDNA-2008 canonicalization (closes #776, #777) by bokelley · Pull Request #789 · adcontextprotocol/adcp-client-python

Description: A python library to interact with adcp servers. Contribute to adcontextprotocol/adcp-client-python development by creating an account on GitHub.

Open Graph Description: Summary Two related follow-ups from the #350 v3-identity series that PR #785 (just merged) had no room for; both touch src/adcp/signing/ canonicalization so they ship together to keep the IDNA stor...

X Description: Summary Two related follow-ups from the #350 v3-identity series that PR #785 (just merged) had no room for; both touch src/adcp/signing/ canonicalization so they ship together to keep the IDNA stor...

Opengraph URL: https://github.com/adcontextprotocol/adcp-client-python/pull/789

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:fd7dc13c-85b6-d485-e6b2-c1edb27e2643
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id90DE:291B58:44553:563A0:6B00F411
html-safe-nonce9f09482f4f9709f508f5b46cc9545a951f23c74c51726c3caa9b98dfdefa8d80
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5MERFOjI5MUI1ODo0NDU1Mzo1NjNBMDo2QjAwRjQxMSIsInZpc2l0b3JfaWQiOiI3NTk0MjU4NzUyNDk3MzE2ODgxIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac25fe4f89491f5cc2d46ec5c900d89e351f80d266d395a4d702f32d1ec19aa50c
hovercard-subject-tagpull_request:3729169053
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/adcontextprotocol/adcp-client-python/789/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/80661fef1604c1571cdbbe4c8ed94593d6e89aa13460fdc54a287defd778ed66/adcontextprotocol/adcp-client-python/pull/789
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/80661fef1604c1571cdbbe4c8ed94593d6e89aa13460fdc54a287defd778ed66/adcontextprotocol/adcp-client-python/pull/789
og:image:altSummary Two related follow-ups from the #350 v3-identity series that PR #785 (just merged) had no room for; both touch src/adcp/signing/ canonicalization so they ship together to keep the IDNA stor...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamebokelley
hostnamegithub.com
expected-hostnamegithub.com
None4ef498cbabcbe3c50befc7a5b743e7072ee770b4daf0e15e54801180d1fa91fc
turbo-cache-controlno-cache
go-importgithub.com/adcontextprotocol/adcp-client-python git https://github.com/adcontextprotocol/adcp-client-python.git
octolytics-dimension-user_id221690821
octolytics-dimension-user_loginadcontextprotocol
octolytics-dimension-repository_id1090305973
octolytics-dimension-repository_nwoadcontextprotocol/adcp-client-python
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id1090305973
octolytics-dimension-repository_network_root_nwoadcontextprotocol/adcp-client-python
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release9983dd5da06943f833c971dd5b6bc988e2858be5
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/adcontextprotocol/adcp-client-python/pull/789#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fadcontextprotocol%2Fadcp-client-python%2Fpull%2F789
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fadcontextprotocol%2Fadcp-client-python%2Fpull%2F789
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=adcontextprotocol%2Fadcp-client-python
Reloadhttps://github.com/adcontextprotocol/adcp-client-python/pull/789
Reloadhttps://github.com/adcontextprotocol/adcp-client-python/pull/789
Reloadhttps://github.com/adcontextprotocol/adcp-client-python/pull/789
adcontextprotocolhttps://github.com/adcontextprotocol
adcp-client-pythonhttps://github.com/adcontextprotocol/adcp-client-python
Codehttps://github.com/adcontextprotocol/adcp-client-python
Issues44 (44)https://github.com/adcontextprotocol/adcp-client-python/issues
Pull requests13 (13)https://github.com/adcontextprotocol/adcp-client-python/pulls
Actionshttps://github.com/adcontextprotocol/adcp-client-python/actions
Projectshttps://github.com/adcontextprotocol/adcp-client-python/projects
Security and qualityhttps://github.com/adcontextprotocol/adcp-client-python/security
Insightshttps://github.com/adcontextprotocol/adcp-client-python/insights
https://github.com/adcontextprotocol/adcp-client-python
bokelleyhttps://github.com/bokelley
mainhttps://github.com/adcontextprotocol/adcp-client-python/tree/main
bokelley/issue-776-777-verifier-key-origins-idnahttps://github.com/adcontextprotocol/adcp-client-python/tree/bokelley/issue-776-777-verifier-key-origins-idna
Conversationhttps://github.com/adcontextprotocol/adcp-client-python/pull/789
Commits5 (5)https://github.com/adcontextprotocol/adcp-client-python/pull/789/commits
Checkshttps://github.com/adcontextprotocol/adcp-client-python/pull/789/checks
Files changedhttps://github.com/adcontextprotocol/adcp-client-python/pull/789/files
feat(signing): verifier key_origins check + IDNA-2008 canonicalization (closes #776, #777)https://github.com/adcontextprotocol/adcp-client-python/pull/789#top
bokelleyhttps://github.com/bokelley
mainhttps://github.com/adcontextprotocol/adcp-client-python/tree/main
bokelley/issue-776-777-verifier-key-origins-idnahttps://github.com/adcontextprotocol/adcp-client-python/tree/bokelley/issue-776-777-verifier-key-origins-idna
https://github.com/bokelley
bokelleyhttps://github.com/bokelley
May 22, 2026https://github.com/adcontextprotocol/adcp-client-python/pull/789#issue-4501294566
#350https://github.com/adcontextprotocol/adcp-client-python/issues/350
#785https://github.com/adcontextprotocol/adcp-client-python/pull/785
#777https://github.com/adcontextprotocol/adcp-client-python/issues/777
#776https://github.com/adcontextprotocol/adcp-client-python/issues/776
#775https://github.com/adcontextprotocol/adcp-client-python/pull/775
Please reload this pagehttps://github.com/adcontextprotocol/adcp-client-python/pull/789
https://github.com/apps/aao-ipr-bot
aao-ipr-bothttps://github.com/apps/aao-ipr-bot
May 22, 2026 https://github.com/adcontextprotocol/adcp-client-python/pull/789#pullrequestreview-4344088773
View reviewed changes https://github.com/adcontextprotocol/adcp-client-python/pull/789/files
aao-ipr-bothttps://github.com/apps/aao-ipr-bot
https://github.com/adcontextprotocol/adcp-client-python/pull/789#pullrequestreview-4344088773
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
CVE-2024-3651https://github.com/advisories/GHSA-jjg7-2v4v-x38h
#776https://github.com/adcontextprotocol/adcp-client-python/issues/776
Please reload this pagehttps://github.com/adcontextprotocol/adcp-client-python/pull/789
bokelleyhttps://github.com/bokelley
May 22, 2026 06:51https://github.com/adcontextprotocol/adcp-client-python/pull/789#commits-pushed-8ee5147
https://github.com/bokelley
https://github.com/claude
feat(signing): IDNA-2008 canonicalization across signing pipeline (cl…https://github.com/adcontextprotocol/adcp-client-python/pull/789/commits/8ee51472031dbb595c2d19ba6e74a13a15a89639
8ee5147https://github.com/adcontextprotocol/adcp-client-python/pull/789/commits/8ee51472031dbb595c2d19ba6e74a13a15a89639
#777https://github.com/adcontextprotocol/adcp-client-python/issues/777
https://github.com/bokelley
https://github.com/claude
feat(signing): plumb identity.key_origins check through verifier (closeshttps://github.com/adcontextprotocol/adcp-client-python/pull/789/commits/b14808274db9046ed259e0d82dc51b00355ffb81
b148082https://github.com/adcontextprotocol/adcp-client-python/pull/789/commits/b14808274db9046ed259e0d82dc51b00355ffb81
#776https://github.com/adcontextprotocol/adcp-client-python/issues/776
#775https://github.com/adcontextprotocol/adcp-client-python/pull/775
https://github.com/bokelley
https://github.com/claude
fix(signing): addresshttps://github.com/adcontextprotocol/adcp-client-python/pull/789/commits/66b17de337f8b69b5b5a6dbe43de3c38ac0b7328
#789https://github.com/adcontextprotocol/adcp-client-python/pull/789
review — CVE pin + verify_from_agent_url w…https://github.com/adcontextprotocol/adcp-client-python/pull/789/commits/66b17de337f8b69b5b5a6dbe43de3c38ac0b7328
66b17dehttps://github.com/adcontextprotocol/adcp-client-python/pull/789/commits/66b17de337f8b69b5b5a6dbe43de3c38ac0b7328
#789https://github.com/adcontextprotocol/adcp-client-python/pull/789
CVE-2024-3651https://github.com/advisories/GHSA-jjg7-2v4v-x38h
#776https://github.com/adcontextprotocol/adcp-client-python/issues/776
#776https://github.com/adcontextprotocol/adcp-client-python/issues/776
CVE-2024-3651https://github.com/advisories/GHSA-jjg7-2v4v-x38h
https://github.com/bokelley
bokelleyhttps://github.com/bokelley
force-pushedhttps://github.com/adcontextprotocol/adcp-client-python/compare/707c009a68b1197ec7f2e1207b2f689f704d75c6..66b17de337f8b69b5b5a6dbe43de3c38ac0b7328
707c009https://github.com/adcontextprotocol/adcp-client-python/commit/707c009a68b1197ec7f2e1207b2f689f704d75c6
66b17dehttps://github.com/adcontextprotocol/adcp-client-python/commit/66b17de337f8b69b5b5a6dbe43de3c38ac0b7328
Compare https://github.com/adcontextprotocol/adcp-client-python/compare/707c009a68b1197ec7f2e1207b2f689f704d75c6..66b17de337f8b69b5b5a6dbe43de3c38ac0b7328
May 22, 2026 10:57https://github.com/adcontextprotocol/adcp-client-python/pull/789#event-25848066135
https://github.com/bokelley
bokelleyhttps://github.com/bokelley
May 22, 2026https://github.com/adcontextprotocol/adcp-client-python/pull/789#issuecomment-4518052961
66b17de3https://github.com/adcontextprotocol/adcp-client-python/pull/789/commits/66b17de3
#1https://github.com/adcontextprotocol/adcp-client-python/pull/1
CVE-2024-3651https://github.com/advisories/GHSA-jjg7-2v4v-x38h
#2https://github.com/adcontextprotocol/adcp-client-python/pull/2
Please reload this pagehttps://github.com/adcontextprotocol/adcp-client-python/pull/789
https://github.com/bokelley
bokelleyhttps://github.com/bokelley
May 22, 2026 10:58https://github.com/adcontextprotocol/adcp-client-python/pull/789#event-25848084221
https://github.com/bokelley
bokelleyhttps://github.com/bokelley
May 22, 2026https://github.com/adcontextprotocol/adcp-client-python/pull/789#issuecomment-4518064998
#1https://github.com/adcontextprotocol/adcp-client-python/pull/1
CVE-2024-3651https://github.com/advisories/GHSA-jjg7-2v4v-x38h
#2https://github.com/adcontextprotocol/adcp-client-python/pull/2
https://claude.ai/code/session_01Y9cTwcXUwzZFYtWmAufJhVhttps://claude.ai/code/session_01Y9cTwcXUwzZFYtWmAufJhV
Claude Codehttps://claude.ai/code
Please reload this pagehttps://github.com/adcontextprotocol/adcp-client-python/pull/789
https://github.com/apps/aao-ipr-bot
aao-ipr-bothttps://github.com/apps/aao-ipr-bot
May 22, 2026 https://github.com/adcontextprotocol/adcp-client-python/pull/789#pullrequestreview-4344883326
View reviewed changes https://github.com/adcontextprotocol/adcp-client-python/pull/789/files/66b17de337f8b69b5b5a6dbe43de3c38ac0b7328
aao-ipr-bothttps://github.com/apps/aao-ipr-bot
https://github.com/adcontextprotocol/adcp-client-python/pull/789#pullrequestreview-4344883326
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
#776https://github.com/adcontextprotocol/adcp-client-python/issues/776
CVE-2024-3651https://github.com/advisories/GHSA-jjg7-2v4v-x38h
GHSA-jjg7-2v4v-x38hhttps://github.com/advisories/GHSA-jjg7-2v4v-x38h
Please reload this pagehttps://github.com/adcontextprotocol/adcp-client-python/pull/789
https://github.com/bokelley
https://github.com/claude
fix(signing): plumb jwks_uri into _BrandJsonStaticJwksResolverhttps://github.com/adcontextprotocol/adcp-client-python/pull/789/commits/7801f61297bf5f49dd31cc1a911eab3ae9966842
7801f61https://github.com/adcontextprotocol/adcp-client-python/pull/789/commits/7801f61297bf5f49dd31cc1a911eab3ae9966842
66b17dehttps://github.com/adcontextprotocol/adcp-client-python/commit/66b17de337f8b69b5b5a6dbe43de3c38ac0b7328
#789https://github.com/adcontextprotocol/adcp-client-python/pull/789
https://github.com/bokelley
bokelleyhttps://github.com/bokelley
May 22, 2026https://github.com/adcontextprotocol/adcp-client-python/pull/789#issuecomment-4518173167
7801f612https://github.com/adcontextprotocol/adcp-client-python/pull/789/commits/7801f612
Please reload this pagehttps://github.com/adcontextprotocol/adcp-client-python/pull/789
https://github.com/bokelley
bokelleyhttps://github.com/bokelley
May 22, 2026https://github.com/adcontextprotocol/adcp-client-python/pull/789#issuecomment-4518179153
https://claude.ai/code/session_01LyiBfX4oZcuGjVrKKZS7X6https://claude.ai/code/session_01LyiBfX4oZcuGjVrKKZS7X6
Claude Codehttps://claude.ai/code
Please reload this pagehttps://github.com/adcontextprotocol/adcp-client-python/pull/789
https://github.com/apps/aao-ipr-bot
aao-ipr-bothttps://github.com/apps/aao-ipr-bot
May 22, 2026 https://github.com/adcontextprotocol/adcp-client-python/pull/789#pullrequestreview-4344976406
View reviewed changes https://github.com/adcontextprotocol/adcp-client-python/pull/789/files/862fc55bdf256dcaf0efbf6a433c269d522a3864
aao-ipr-bothttps://github.com/apps/aao-ipr-bot
https://github.com/adcontextprotocol/adcp-client-python/pull/789#pullrequestreview-4344976406
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
CVE-2024-3651https://github.com/advisories/GHSA-jjg7-2v4v-x38h
Please reload this pagehttps://github.com/adcontextprotocol/adcp-client-python/pull/789
https://github.com/bokelley
Merge branch 'main' into bokelley/issue-776-777-verifier-key-origins-…https://github.com/adcontextprotocol/adcp-client-python/pull/789/commits/862fc55bdf256dcaf0efbf6a433c269d522a3864
862fc55https://github.com/adcontextprotocol/adcp-client-python/pull/789/commits/862fc55bdf256dcaf0efbf6a433c269d522a3864
https://github.com/bokelley
bokelleyhttps://github.com/bokelley
31354b4https://github.com/adcontextprotocol/adcp-client-python/commit/31354b4d813116d55e255c2b5f28fa599a09b0e7
May 22, 2026https://github.com/adcontextprotocol/adcp-client-python/pull/789#event-25849202780
Please reload this pagehttps://github.com/adcontextprotocol/adcp-client-python/pull/789
https://github.com/bokelley
bokelleyhttps://github.com/bokelley
May 22, 2026 11:33https://github.com/adcontextprotocol/adcp-client-python/pull/789#event-25849203418
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
May 22, 2026 https://github.com/adcontextprotocol/adcp-client-python/pull/789#ref-pullrequest-4487262475
chore(main): release 5.7.0 #751 https://github.com/adcontextprotocol/adcp-client-python/pull/751
https://github.com/bokelley
bokelleyhttps://github.com/bokelley
May 22, 2026 https://github.com/adcontextprotocol/adcp-client-python/pull/789#ref-pullrequest-4502409961
fix(signing): Argus follow-ups on #789 — IDNA + IP literals, Protocol contract, misconfig warnings, diagnostic hygiene #798 https://github.com/adcontextprotocol/adcp-client-python/pull/798
bokelleyhttps://github.com/bokelley
May 22, 2026 https://github.com/adcontextprotocol/adcp-client-python/pull/789#ref-commit-fcb64fc
https://github.com/bokelley
https://github.com/claude
fix(signing): Argus follow-ups onhttps://github.com/adcontextprotocol/adcp-client-python/commit/fcb64fcfae8b42822bdf92c289dcb771191419c4
#789https://github.com/adcontextprotocol/adcp-client-python/pull/789
— IDNA + IP literals, Protocol…https://github.com/adcontextprotocol/adcp-client-python/commit/fcb64fcfae8b42822bdf92c289dcb771191419c4
fcb64fchttps://github.com/adcontextprotocol/adcp-client-python/commit/fcb64fcfae8b42822bdf92c289dcb771191419c4
#798https://github.com/adcontextprotocol/adcp-client-python/pull/798
#789https://github.com/adcontextprotocol/adcp-client-python/pull/789
#789https://github.com/adcontextprotocol/adcp-client-python/pull/789
#789https://github.com/adcontextprotocol/adcp-client-python/pull/789
#789https://github.com/adcontextprotocol/adcp-client-python/pull/789
#789https://github.com/adcontextprotocol/adcp-client-python/pull/789
#789https://github.com/adcontextprotocol/adcp-client-python/pull/789
#789https://github.com/adcontextprotocol/adcp-client-python/pull/789
#789https://github.com/adcontextprotocol/adcp-client-python/pull/789
#789https://github.com/adcontextprotocol/adcp-client-python/pull/789
https://github.co/hiddenchars
https://github.com/adcontextprotocol/adcp-client-python/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fadcontextprotocol%2Fadcp-client-python%2Fpull%2F789
https://github.com/apps/aao-ipr-bot
aao-ipr-bot[bot] https://github.com/apps/aao-ipr-bot
https://github.com/adcontextprotocol/adcp-client-python/pull/789/files/862fc55bdf256dcaf0efbf6a433c269d522a3864
Please reload this pagehttps://github.com/adcontextprotocol/adcp-client-python/pull/789
Please reload this pagehttps://github.com/adcontextprotocol/adcp-client-python/pull/789
https://github.com/bokelley
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.