| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:8506d1f4-8507-7f4e-7b00-b01e71a72eae |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | D24C:34EA7D:B03C39:E30D5D:6B00E5BF |
| html-safe-nonce | 91cbdd9990e134e7fdad151a64bbc9d0fbc5b8d1cf91d6745ef63b06089c7850 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEMjRDOjM0RUE3RDpCMDNDMzk6RTMwRDVEOjZCMDBFNUJGIiwidmlzaXRvcl9pZCI6IjU0MDU5NzY0MDI2OTg3NTc1NjciLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 2705821ef47d55a8c6b8068688c967e82aff2751b1a6769599ef154da6749a50 |
| hovercard-subject-tag | pull_request:3711895338 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/adcontextprotocol/adcp-client-python/744/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/bb7bff01fb6bd8cf495f4b19ba4b67de7c8a61aed714b3c4a664e8a593a5e10d/adcontextprotocol/adcp-client-python/pull/744 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/bb7bff01fb6bd8cf495f4b19ba4b67de7c8a61aed714b3c4a664e8a593a5e10d/adcontextprotocol/adcp-client-python/pull/744 |
| og:image:alt | Fixes #742.
Problem
Format.assets in the generated code uses a closed Pydantic discriminated union — every arm has a Literal['image']/Literal['video']/… annotation with no fallback.... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | bokelley |
| hostname | github.com |
| expected-hostname | github.com |
| None | 27088b6977484d0d3321d9a11c907c6d6637b315cfa359ef7952dbf6292f9b14 |
| turbo-cache-control | no-cache |
| go-import | github.com/adcontextprotocol/adcp-client-python git https://github.com/adcontextprotocol/adcp-client-python.git |
| octolytics-dimension-user_id | 221690821 |
| octolytics-dimension-user_login | adcontextprotocol |
| octolytics-dimension-repository_id | 1090305973 |
| octolytics-dimension-repository_nwo | adcontextprotocol/adcp-client-python |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 1090305973 |
| octolytics-dimension-repository_network_root_nwo | adcontextprotocol/adcp-client-python |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 624179fb8b88d26ba5bba08894eb60a1c5a1d93d |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | pull-requests |
| Skip to content | https://github.com/adcontextprotocol/adcp-client-python/pull/744#start-of-content |
| https://github.com/ |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fadcontextprotocol%2Fadcp-client-python%2Fpull%2F744 |
| GitHubRepository hosting, code review, and collaboration | https://github.com/platform |
| CopilotAI coding agent for tasks, projects, and automated work | https://github.com/features/copilot |
| ActionsCI/CD and automation | https://github.com/features/actions |
| Code QualityQuality analysis, fixes, and enforcement | https://github.com/features/code-quality |
| CodespacesCloud development environments | https://github.com/features/codespaces |
| Code SecurityVulnerability detection and remediation | https://github.com/security/advanced-security/code-security |
| Secret ProtectionSecret scanning and leak prevention | https://github.com/security/advanced-security/secret-protection |
| All Features | https://github.com/features |
| Documentation | https://docs.github.com/en |
| Training | https://learn.github.com/skills |
| Certifications | https://learn.github.com/credentials |
| Build with Copilot | https://github.com/features/ai |
| Customize Copilot | https://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview |
| Integrations | https://github.com/marketplace |
| Trending repos | https://github.com/trending |
| GitHub Sponsors | https://github.com/open-source/sponsors |
| Developer articles | https://github.com/resources/articles |
| ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place. | https://github.blog/changelog/ |
| Enterprises | https://github.com/enterprise |
| Team | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| See all industries | https://github.com/solutions/industry |
| Why GitHub | https://github.com/why-github |
| Customer Stories | https://github.com/customer-stories |
| Business insights | https://github.com/solutions/executive-insights |
| Trust Center | https://github.com/trust-center |
| GitHub Advanced SecurityEnterprise-grade code security | https://github.com/security/advanced-security |
| Copilot for businessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Documentation | https://docs.github.com/en |
| Resource center | https://github.com/resources |
| Blog | https://github.blog/ |
| Events & webinars | https://github.com/resources/events |
| Community Forum | https://github.com/orgs/community/discussions |
| Customer Stories | https://github.com/customer-stories |
| Integrations | https://github.com/marketplace |
| Customer support | https://help.github.com/ |
| Training | https://learn.github.com/skills |
| GitHub Status | https://www.githubstatus.com/ |
| About | https://github.com/about |
| Partners | https://github.com/partners |
| Changelog | https://github.blog/changelog/ |
| GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub. | https://githubuniverse.com/ |
| Pricing | https://github.com/pricing |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fadcontextprotocol%2Fadcp-client-python%2Fpull%2F744 |
| Sign up | https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=adcontextprotocol%2Fadcp-client-python |
| Reload | https://github.com/adcontextprotocol/adcp-client-python/pull/744 |
| Reload | https://github.com/adcontextprotocol/adcp-client-python/pull/744 |
| Reload | https://github.com/adcontextprotocol/adcp-client-python/pull/744 |
| adcontextprotocol | https://github.com/adcontextprotocol |
| adcp-client-python | https://github.com/adcontextprotocol/adcp-client-python |
| Code | https://github.com/adcontextprotocol/adcp-client-python |
| Issues44 (44) | https://github.com/adcontextprotocol/adcp-client-python/issues |
| Pull requests12 (12) | https://github.com/adcontextprotocol/adcp-client-python/pulls |
| Actions | https://github.com/adcontextprotocol/adcp-client-python/actions |
| Projects | https://github.com/adcontextprotocol/adcp-client-python/projects |
| Security and quality | https://github.com/adcontextprotocol/adcp-client-python/security |
| Insights | https://github.com/adcontextprotocol/adcp-client-python/insights |
| https://github.com/adcontextprotocol/adcp-client-python |
| bokelley | https://github.com/bokelley |
| main | https://github.com/adcontextprotocol/adcp-client-python/tree/main |
| claude/issue-742-open-asset-union | https://github.com/adcontextprotocol/adcp-client-python/tree/claude/issue-742-open-asset-union |
| Conversation | https://github.com/adcontextprotocol/adcp-client-python/pull/744 |
| Commits2 (2) | https://github.com/adcontextprotocol/adcp-client-python/pull/744/commits |
| Checks | https://github.com/adcontextprotocol/adcp-client-python/pull/744/checks |
| Files changed | https://github.com/adcontextprotocol/adcp-client-python/pull/744/files |
| fix(types): open Format.assets discriminated union — add UnknownFormatAsset fallback arm | https://github.com/adcontextprotocol/adcp-client-python/pull/744#top |
| bokelley | https://github.com/bokelley |
| main | https://github.com/adcontextprotocol/adcp-client-python/tree/main |
| claude/issue-742-open-asset-union | https://github.com/adcontextprotocol/adcp-client-python/tree/claude/issue-742-open-asset-union |
|
| https://github.com/bokelley |
| bokelley | https://github.com/bokelley |
| May 19, 2026 | https://github.com/adcontextprotocol/adcp-client-python/pull/744#issue-4480906136 |
| #742 | https://github.com/adcontextprotocol/adcp-client-python/issues/742 |
| Claude Code | https://claude.ai/code/session_01LpZ6ogBaffZNt6qBoZJwVY |
| Please reload this page | https://github.com/adcontextprotocol/adcp-client-python/pull/744 |
|
| https://github.com/claude |
| fix(types): open Format.assets discriminated union with UnknownFormat… | https://github.com/adcontextprotocol/adcp-client-python/pull/744/commits/ebbb07b03e1e939361d113bb5ec9727c7a3535f4 |
| ebbb07b | https://github.com/adcontextprotocol/adcp-client-python/pull/744/commits/ebbb07b03e1e939361d113bb5ec9727c7a3535f4 |
| #742 | https://github.com/adcontextprotocol/adcp-client-python/issues/742 |
| https://github.com/bokelley |
| bokelley | https://github.com/bokelley |
|
May 19, 2026
| https://github.com/adcontextprotocol/adcp-client-python/pull/744#ref-issue-4478849124 |
|
Creative-format asset_type is a closed discriminated union — additive spec growth breaks all response consumers
#742
| https://github.com/adcontextprotocol/adcp-client-python/issues/742 |
| https://github.com/bokelley |
| bokelley | https://github.com/bokelley |
|
bug
| https://github.com/adcontextprotocol/adcp-client-python/issues?q=state%3Aopen%20label%3Abug |
|
claude-triaged
| https://github.com/adcontextprotocol/adcp-client-python/issues?q=state%3Aopen%20label%3Aclaude-triaged |
| May 19, 2026 | https://github.com/adcontextprotocol/adcp-client-python/pull/744#event-25726255450 |
|
| https://github.com/bokelley |
| Merge branch 'main' into claude/issue-742-open-asset-union | https://github.com/adcontextprotocol/adcp-client-python/pull/744/commits/e645ccfca27a805b46c475fdc696fc3de8941f5e |
| e645ccf | https://github.com/adcontextprotocol/adcp-client-python/pull/744/commits/e645ccfca27a805b46c475fdc696fc3de8941f5e |
| https://github.com/bokelley |
| bokelley | https://github.com/bokelley |
| May 19, 2026 22:38 | https://github.com/adcontextprotocol/adcp-client-python/pull/744#event-25730194216 |
| https://github.com/bokelley |
| bokelley | https://github.com/bokelley |
| 7904f85 | https://github.com/adcontextprotocol/adcp-client-python/commit/7904f85ca0a9241977fb70e782a687425a4a7565 |
| May 19, 2026 | https://github.com/adcontextprotocol/adcp-client-python/pull/744#event-25730195887 |
| Please reload this page | https://github.com/adcontextprotocol/adcp-client-python/pull/744 |
| https://github.com/apps/github-actions |
| github-actions | https://github.com/apps/github-actions |
|
May 19, 2026
| https://github.com/adcontextprotocol/adcp-client-python/pull/744#ref-pullrequest-4450175375 |
|
chore(main): release 5.6.0
#740
| https://github.com/adcontextprotocol/adcp-client-python/pull/740 |
|
bug(types): hand-written asset unions route 14 of 21 declared asset types; 7 silently fall through to UnknownFormatAsset
#1486
| https://github.com/adcontextprotocol/adcp-client-python/issues/1486 |
|
fix(types): generate the open asset unions, and derive the vocabulary they route by
#1501
| https://github.com/adcontextprotocol/adcp-client-python/pull/1501 |
| KonstantinMirin | https://github.com/KonstantinMirin |
|
Oct 14, 2026
| https://github.com/adcontextprotocol/adcp-client-python/pull/744#ref-commit-bd4257c |
|
| https://github.com/KonstantinMirin |
| fix(types): generate the open asset unions, and derive the vocabulary… | https://github.com/KonstantinMirin/adcp-client-python/commit/bd4257c0004164ae7417ca0782e962c83f1884ec |
| bd4257c | https://github.com/KonstantinMirin/adcp-client-python/commit/bd4257c0004164ae7417ca0782e962c83f1884ec |
| adcontextprotocol#1486 | https://github.com/adcontextprotocol/adcp-client-python/issues/1486 |
| adcontextprotocol#744 | https://github.com/adcontextprotocol/adcp-client-python/pull/744 |
| bokelley | https://github.com/bokelley |
|
Oct 22, 2026
| https://github.com/adcontextprotocol/adcp-client-python/pull/744#ref-commit-30a72ee |
|
| https://github.com/KonstantinMirin |
|
| https://github.com/bokelley |
|
| https://github.com/claude |
| fix(types): generate the open asset unions, and derive the vocabulary… | https://github.com/adcontextprotocol/adcp-client-python/commit/30a72ee2a409bccb53fe961816584bdea2518f70 |
| 30a72ee | https://github.com/adcontextprotocol/adcp-client-python/commit/30a72ee2a409bccb53fe961816584bdea2518f70 |
| #1501 | https://github.com/adcontextprotocol/adcp-client-python/pull/1501 |
| #1486 | https://github.com/adcontextprotocol/adcp-client-python/issues/1486 |
| #744 | https://github.com/adcontextprotocol/adcp-client-python/pull/744 |
| https://github.co/hiddenchars |
| https://github.com/adcontextprotocol/adcp-client-python/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fadcontextprotocol%2Fadcp-client-python%2Fpull%2F744 |
| Please reload this page | https://github.com/adcontextprotocol/adcp-client-python/pull/744 |
|
bug
| https://github.com/adcontextprotocol/adcp-client-python/issues?q=state%3Aopen%20label%3Abug |
|
claude-triaged
| https://github.com/adcontextprotocol/adcp-client-python/issues?q=state%3Aopen%20label%3Aclaude-triaged |
|
Creative-format asset_type is a closed discriminated union — additive spec growth breaks all response consumers
| https://github.com/adcontextprotocol/adcp-client-python/issues/742 |
| Please reload this page | https://github.com/adcontextprotocol/adcp-client-python/pull/744 |
|
| https://github.com/bokelley |
|
| https://github.com/claude |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |