René's URL Explorer Experiment


Title: fix(types): open Format.assets discriminated union — add UnknownFormatAsset fallback arm by bokelley · Pull Request #744 · adcontextprotocol/adcp-client-python · GitHub

Open Graph Title: fix(types): open Format.assets discriminated union — add UnknownFormatAsset fallback arm by bokelley · Pull Request #744 · adcontextprotocol/adcp-client-python

X Title: fix(types): open Format.assets discriminated union — add UnknownFormatAsset fallback arm by bokelley · Pull Request #744 · adcontextprotocol/adcp-client-python

Description: A python library to interact with adcp servers. Contribute to adcontextprotocol/adcp-client-python development by creating an account on GitHub.

Open Graph Description: Fixes #742. Problem Format.assets in the generated code uses a closed Pydantic discriminated union — every arm has a Literal['image']/Literal['video']/… annotation with no fallback....

X Description: Fixes #742. Problem Format.assets in the generated code uses a closed Pydantic discriminated union — every arm has a Literal['image']/Literal['video']/… annotation w...

Opengraph URL: https://github.com/adcontextprotocol/adcp-client-python/pull/744

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:8506d1f4-8507-7f4e-7b00-b01e71a72eae
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idD24C:34EA7D:B03C39:E30D5D:6B00E5BF
html-safe-nonce91cbdd9990e134e7fdad151a64bbc9d0fbc5b8d1cf91d6745ef63b06089c7850
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEMjRDOjM0RUE3RDpCMDNDMzk6RTMwRDVEOjZCMDBFNUJGIiwidmlzaXRvcl9pZCI6IjU0MDU5NzY0MDI2OTg3NTc1NjciLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac2705821ef47d55a8c6b8068688c967e82aff2751b1a6769599ef154da6749a50
hovercard-subject-tagpull_request:3711895338
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/adcontextprotocol/adcp-client-python/744/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/bb7bff01fb6bd8cf495f4b19ba4b67de7c8a61aed714b3c4a664e8a593a5e10d/adcontextprotocol/adcp-client-python/pull/744
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/bb7bff01fb6bd8cf495f4b19ba4b67de7c8a61aed714b3c4a664e8a593a5e10d/adcontextprotocol/adcp-client-python/pull/744
og:image:altFixes #742. Problem Format.assets in the generated code uses a closed Pydantic discriminated union — every arm has a Literal['image']/Literal['video']/… annotation with no fallback....
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamebokelley
hostnamegithub.com
expected-hostnamegithub.com
None27088b6977484d0d3321d9a11c907c6d6637b315cfa359ef7952dbf6292f9b14
turbo-cache-controlno-cache
go-importgithub.com/adcontextprotocol/adcp-client-python git https://github.com/adcontextprotocol/adcp-client-python.git
octolytics-dimension-user_id221690821
octolytics-dimension-user_loginadcontextprotocol
octolytics-dimension-repository_id1090305973
octolytics-dimension-repository_nwoadcontextprotocol/adcp-client-python
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id1090305973
octolytics-dimension-repository_network_root_nwoadcontextprotocol/adcp-client-python
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release624179fb8b88d26ba5bba08894eb60a1c5a1d93d
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/adcontextprotocol/adcp-client-python/pull/744#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fadcontextprotocol%2Fadcp-client-python%2Fpull%2F744
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fadcontextprotocol%2Fadcp-client-python%2Fpull%2F744
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=adcontextprotocol%2Fadcp-client-python
Reloadhttps://github.com/adcontextprotocol/adcp-client-python/pull/744
Reloadhttps://github.com/adcontextprotocol/adcp-client-python/pull/744
Reloadhttps://github.com/adcontextprotocol/adcp-client-python/pull/744
adcontextprotocolhttps://github.com/adcontextprotocol
adcp-client-pythonhttps://github.com/adcontextprotocol/adcp-client-python
Codehttps://github.com/adcontextprotocol/adcp-client-python
Issues44 (44)https://github.com/adcontextprotocol/adcp-client-python/issues
Pull requests12 (12)https://github.com/adcontextprotocol/adcp-client-python/pulls
Actionshttps://github.com/adcontextprotocol/adcp-client-python/actions
Projectshttps://github.com/adcontextprotocol/adcp-client-python/projects
Security and qualityhttps://github.com/adcontextprotocol/adcp-client-python/security
Insightshttps://github.com/adcontextprotocol/adcp-client-python/insights
https://github.com/adcontextprotocol/adcp-client-python
bokelleyhttps://github.com/bokelley
mainhttps://github.com/adcontextprotocol/adcp-client-python/tree/main
claude/issue-742-open-asset-unionhttps://github.com/adcontextprotocol/adcp-client-python/tree/claude/issue-742-open-asset-union
Conversationhttps://github.com/adcontextprotocol/adcp-client-python/pull/744
Commits2 (2)https://github.com/adcontextprotocol/adcp-client-python/pull/744/commits
Checkshttps://github.com/adcontextprotocol/adcp-client-python/pull/744/checks
Files changedhttps://github.com/adcontextprotocol/adcp-client-python/pull/744/files
fix(types): open Format.assets discriminated union — add UnknownFormatAsset fallback armhttps://github.com/adcontextprotocol/adcp-client-python/pull/744#top
bokelleyhttps://github.com/bokelley
mainhttps://github.com/adcontextprotocol/adcp-client-python/tree/main
claude/issue-742-open-asset-unionhttps://github.com/adcontextprotocol/adcp-client-python/tree/claude/issue-742-open-asset-union
https://github.com/bokelley
bokelleyhttps://github.com/bokelley
May 19, 2026https://github.com/adcontextprotocol/adcp-client-python/pull/744#issue-4480906136
#742https://github.com/adcontextprotocol/adcp-client-python/issues/742
Claude Codehttps://claude.ai/code/session_01LpZ6ogBaffZNt6qBoZJwVY
Please reload this pagehttps://github.com/adcontextprotocol/adcp-client-python/pull/744
https://github.com/claude
fix(types): open Format.assets discriminated union with UnknownFormat…https://github.com/adcontextprotocol/adcp-client-python/pull/744/commits/ebbb07b03e1e939361d113bb5ec9727c7a3535f4
ebbb07bhttps://github.com/adcontextprotocol/adcp-client-python/pull/744/commits/ebbb07b03e1e939361d113bb5ec9727c7a3535f4
#742https://github.com/adcontextprotocol/adcp-client-python/issues/742
https://github.com/bokelley
bokelleyhttps://github.com/bokelley
May 19, 2026 https://github.com/adcontextprotocol/adcp-client-python/pull/744#ref-issue-4478849124
Creative-format asset_type is a closed discriminated union — additive spec growth breaks all response consumers #742 https://github.com/adcontextprotocol/adcp-client-python/issues/742
https://github.com/bokelley
bokelleyhttps://github.com/bokelley
bug https://github.com/adcontextprotocol/adcp-client-python/issues?q=state%3Aopen%20label%3Abug
claude-triaged https://github.com/adcontextprotocol/adcp-client-python/issues?q=state%3Aopen%20label%3Aclaude-triaged
May 19, 2026https://github.com/adcontextprotocol/adcp-client-python/pull/744#event-25726255450
https://github.com/bokelley
Merge branch 'main' into claude/issue-742-open-asset-unionhttps://github.com/adcontextprotocol/adcp-client-python/pull/744/commits/e645ccfca27a805b46c475fdc696fc3de8941f5e
e645ccfhttps://github.com/adcontextprotocol/adcp-client-python/pull/744/commits/e645ccfca27a805b46c475fdc696fc3de8941f5e
https://github.com/bokelley
bokelleyhttps://github.com/bokelley
May 19, 2026 22:38https://github.com/adcontextprotocol/adcp-client-python/pull/744#event-25730194216
https://github.com/bokelley
bokelleyhttps://github.com/bokelley
7904f85https://github.com/adcontextprotocol/adcp-client-python/commit/7904f85ca0a9241977fb70e782a687425a4a7565
May 19, 2026https://github.com/adcontextprotocol/adcp-client-python/pull/744#event-25730195887
Please reload this pagehttps://github.com/adcontextprotocol/adcp-client-python/pull/744
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
May 19, 2026 https://github.com/adcontextprotocol/adcp-client-python/pull/744#ref-pullrequest-4450175375
chore(main): release 5.6.0 #740 https://github.com/adcontextprotocol/adcp-client-python/pull/740
bug(types): hand-written asset unions route 14 of 21 declared asset types; 7 silently fall through to UnknownFormatAsset #1486 https://github.com/adcontextprotocol/adcp-client-python/issues/1486
fix(types): generate the open asset unions, and derive the vocabulary they route by #1501 https://github.com/adcontextprotocol/adcp-client-python/pull/1501
KonstantinMirinhttps://github.com/KonstantinMirin
Oct 14, 2026 https://github.com/adcontextprotocol/adcp-client-python/pull/744#ref-commit-bd4257c
https://github.com/KonstantinMirin
fix(types): generate the open asset unions, and derive the vocabulary…https://github.com/KonstantinMirin/adcp-client-python/commit/bd4257c0004164ae7417ca0782e962c83f1884ec
bd4257chttps://github.com/KonstantinMirin/adcp-client-python/commit/bd4257c0004164ae7417ca0782e962c83f1884ec
adcontextprotocol#1486https://github.com/adcontextprotocol/adcp-client-python/issues/1486
adcontextprotocol#744https://github.com/adcontextprotocol/adcp-client-python/pull/744
bokelleyhttps://github.com/bokelley
Oct 22, 2026 https://github.com/adcontextprotocol/adcp-client-python/pull/744#ref-commit-30a72ee
https://github.com/KonstantinMirin
https://github.com/bokelley
https://github.com/claude
fix(types): generate the open asset unions, and derive the vocabulary…https://github.com/adcontextprotocol/adcp-client-python/commit/30a72ee2a409bccb53fe961816584bdea2518f70
30a72eehttps://github.com/adcontextprotocol/adcp-client-python/commit/30a72ee2a409bccb53fe961816584bdea2518f70
#1501https://github.com/adcontextprotocol/adcp-client-python/pull/1501
#1486https://github.com/adcontextprotocol/adcp-client-python/issues/1486
#744https://github.com/adcontextprotocol/adcp-client-python/pull/744
https://github.co/hiddenchars
https://github.com/adcontextprotocol/adcp-client-python/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fadcontextprotocol%2Fadcp-client-python%2Fpull%2F744
Please reload this pagehttps://github.com/adcontextprotocol/adcp-client-python/pull/744
bug https://github.com/adcontextprotocol/adcp-client-python/issues?q=state%3Aopen%20label%3Abug
claude-triaged https://github.com/adcontextprotocol/adcp-client-python/issues?q=state%3Aopen%20label%3Aclaude-triaged
Creative-format asset_type is a closed discriminated union — additive spec growth breaks all response consumers https://github.com/adcontextprotocol/adcp-client-python/issues/742
Please reload this pagehttps://github.com/adcontextprotocol/adcp-client-python/pull/744
https://github.com/bokelley
https://github.com/claude
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.