| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:a79007c8-42a6-6acd-14d5-d7b0c2b8bbe2 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | D758:14F601:11CB92E:16BC0F5:6B01079D |
| html-safe-nonce | 976ac6820eed452d5b7511853cea409ad670b410ae3419703493b1cee7778949 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJENzU4OjE0RjYwMToxMUNCOTJFOjE2QkMwRjU6NkIwMTA3OUQiLCJ2aXNpdG9yX2lkIjoiMTcxODc1MTIxMzkyMDUyMDA5MyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 9f922f2f664428f6a158d368a404a9768087cbcfece77db05bd91cebdf206824 |
| hovercard-subject-tag | pull_request:3665551084 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/adcontextprotocol/adcp-client-python/686/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/c265375a8d99d809ce52ffa620ff94c461fef9c220468a5e442f0c7f563c469d/adcontextprotocol/adcp-client-python/pull/686 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/c265375a8d99d809ce52ffa620ff94c461fef9c220468a5e442f0c7f563c469d/adcontextprotocol/adcp-client-python/pull/686 |
| og:image:alt | Closes #683
Summary
After PR #679, the v2.5→v3 adapter correctly extracts the hostname from brand_manifest URLs, but silently drops any non-standard path. A buyer hosting at https://cdn.acmecorp.co... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | bokelley |
| hostname | github.com |
| expected-hostname | github.com |
| None | cb7fa109eca7d4156c889f474306b0e91336055e9adf8fd4684b61e49094d124 |
| turbo-cache-control | no-cache |
| go-import | github.com/adcontextprotocol/adcp-client-python git https://github.com/adcontextprotocol/adcp-client-python.git |
| octolytics-dimension-user_id | 221690821 |
| octolytics-dimension-user_login | adcontextprotocol |
| octolytics-dimension-repository_id | 1090305973 |
| octolytics-dimension-repository_nwo | adcontextprotocol/adcp-client-python |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 1090305973 |
| octolytics-dimension-repository_network_root_nwo | adcontextprotocol/adcp-client-python |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 2b59d31a4e44f08b7af67a4b67f8fd0af3befe2a |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | pull-requests |
| Skip to content | https://github.com/adcontextprotocol/adcp-client-python/pull/686#start-of-content |
| https://github.com/ |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fadcontextprotocol%2Fadcp-client-python%2Fpull%2F686 |
| GitHubRepository hosting, code review, and collaboration | https://github.com/platform |
| CopilotAI coding agent for tasks, projects, and automated work | https://github.com/features/copilot |
| ActionsCI/CD and automation | https://github.com/features/actions |
| Code QualityQuality analysis, fixes, and enforcement | https://github.com/features/code-quality |
| CodespacesCloud development environments | https://github.com/features/codespaces |
| Code SecurityVulnerability detection and remediation | https://github.com/security/advanced-security/code-security |
| Secret ProtectionSecret scanning and leak prevention | https://github.com/security/advanced-security/secret-protection |
| All Features | https://github.com/features |
| Documentation | https://docs.github.com/en |
| Training | https://learn.github.com/skills |
| Certifications | https://learn.github.com/credentials |
| Build with Copilot | https://github.com/features/ai |
| Customize Copilot | https://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview |
| Integrations | https://github.com/marketplace |
| Trending repos | https://github.com/trending |
| GitHub Sponsors | https://github.com/open-source/sponsors |
| Developer articles | https://github.com/resources/articles |
| ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place. | https://github.blog/changelog/ |
| Enterprises | https://github.com/enterprise |
| Team | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| See all industries | https://github.com/solutions/industry |
| Why GitHub | https://github.com/why-github |
| Customer Stories | https://github.com/customer-stories |
| Business insights | https://github.com/solutions/executive-insights |
| Trust Center | https://github.com/trust-center |
| GitHub Advanced SecurityEnterprise-grade code security | https://github.com/security/advanced-security |
| Copilot for businessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Documentation | https://docs.github.com/en |
| Resource center | https://github.com/resources |
| Blog | https://github.blog/ |
| Events & webinars | https://github.com/resources/events |
| Community Forum | https://github.com/orgs/community/discussions |
| Customer Stories | https://github.com/customer-stories |
| Integrations | https://github.com/marketplace |
| Customer support | https://help.github.com/ |
| Training | https://learn.github.com/skills |
| GitHub Status | https://www.githubstatus.com/ |
| About | https://github.com/about |
| Partners | https://github.com/partners |
| Changelog | https://github.blog/changelog/ |
| GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub. | https://githubuniverse.com/ |
| Pricing | https://github.com/pricing |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fadcontextprotocol%2Fadcp-client-python%2Fpull%2F686 |
| Sign up | https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=adcontextprotocol%2Fadcp-client-python |
| Reload | https://github.com/adcontextprotocol/adcp-client-python/pull/686 |
| Reload | https://github.com/adcontextprotocol/adcp-client-python/pull/686 |
| Reload | https://github.com/adcontextprotocol/adcp-client-python/pull/686 |
| adcontextprotocol | https://github.com/adcontextprotocol |
| adcp-client-python | https://github.com/adcontextprotocol/adcp-client-python |
| Code | https://github.com/adcontextprotocol/adcp-client-python |
| Issues44 (44) | https://github.com/adcontextprotocol/adcp-client-python/issues |
| Pull requests13 (13) | https://github.com/adcontextprotocol/adcp-client-python/pulls |
| Actions | https://github.com/adcontextprotocol/adcp-client-python/actions |
| Projects | https://github.com/adcontextprotocol/adcp-client-python/projects |
| Security and quality | https://github.com/adcontextprotocol/adcp-client-python/security |
| Insights | https://github.com/adcontextprotocol/adcp-client-python/insights |
| https://github.com/adcontextprotocol/adcp-client-python |
| bokelley | https://github.com/bokelley |
| main | https://github.com/adcontextprotocol/adcp-client-python/tree/main |
| claude/issue-683-brand-manifest-path-warning | https://github.com/adcontextprotocol/adcp-client-python/tree/claude/issue-683-brand-manifest-path-warning |
| Conversation | https://github.com/adcontextprotocol/adcp-client-python/pull/686 |
| Commits1 (1) | https://github.com/adcontextprotocol/adcp-client-python/pull/686/commits |
| Checks | https://github.com/adcontextprotocol/adcp-client-python/pull/686/checks |
| Files changed | https://github.com/adcontextprotocol/adcp-client-python/pull/686/files |
| fix(compat): warn when brand_manifest non-standard path is silently flattened to domain | https://github.com/adcontextprotocol/adcp-client-python/pull/686#top |
| bokelley | https://github.com/bokelley |
| main | https://github.com/adcontextprotocol/adcp-client-python/tree/main |
| claude/issue-683-brand-manifest-path-warning | https://github.com/adcontextprotocol/adcp-client-python/tree/claude/issue-683-brand-manifest-path-warning |
|
| https://github.com/bokelley |
| bokelley | https://github.com/bokelley |
| May 12, 2026 | https://github.com/adcontextprotocol/adcp-client-python/pull/686#issue-4425448640 |
| #683 | https://github.com/adcontextprotocol/adcp-client-python/issues/683 |
| #679 | https://github.com/adcontextprotocol/adcp-client-python/pull/679 |
| adcp#3121 | https://github.com/adcontextprotocol/adcp/issues/3121 |
| https://claude.ai/code/session_01X44xueoHmfHRYeKL8giv2F | https://claude.ai/code/session_01X44xueoHmfHRYeKL8giv2F |
| Claude Code | https://claude.ai/code/session_01X44xueoHmfHRYeKL8giv2F |
| Please reload this page | https://github.com/adcontextprotocol/adcp-client-python/pull/686 |
| https://github.com/bokelley |
| bokelley | https://github.com/bokelley |
|
claude-triaged
| https://github.com/adcontextprotocol/adcp-client-python/issues?q=state%3Aopen%20label%3Aclaude-triaged |
| May 12, 2026 | https://github.com/adcontextprotocol/adcp-client-python/pull/686#event-25408979982 |
|
v2.5 brand_manifest with non-standard path is silently flattened to domain only
#683
| https://github.com/adcontextprotocol/adcp-client-python/issues/683 |
|
fix(compat): handle inline BrandManifest object in v2.5 adapters
#685
| https://github.com/adcontextprotocol/adcp-client-python/pull/685 |
|
| https://github.com/claude |
|
| https://github.com/bokelley |
| fix(compat): warn when brand_manifest non-standard path is flattened … | https://github.com/adcontextprotocol/adcp-client-python/pull/686/commits/fdfdd1bd0a99ee68b3b5adcb71c3d5c6aa0e42a5 |
| fdfdd1b | https://github.com/adcontextprotocol/adcp-client-python/pull/686/commits/fdfdd1bd0a99ee68b3b5adcb71c3d5c6aa0e42a5 |
| https://cdn.acmecorp.com/brand-manifest.json | https://cdn.acmecorp.com/brand-manifest.json |
| https://cdn.acmecorp.com/.well-known/brand.json | https://cdn.acmecorp.com/.well-known/brand.json |
| #683 | https://github.com/adcontextprotocol/adcp-client-python/issues/683 |
| https://claude.ai/code/session_01X44xueoHmfHRYeKL8giv2F | https://claude.ai/code/session_01X44xueoHmfHRYeKL8giv2F |
| https://github.com/bokelley |
| bokelley | https://github.com/bokelley |
| force-pushed | https://github.com/adcontextprotocol/adcp-client-python/compare/274fb938bb5dbac9e96f1f6005834d2daeeba725..fdfdd1bd0a99ee68b3b5adcb71c3d5c6aa0e42a5 |
| 274fb93 | https://github.com/adcontextprotocol/adcp-client-python/commit/274fb938bb5dbac9e96f1f6005834d2daeeba725 |
| fdfdd1b | https://github.com/adcontextprotocol/adcp-client-python/commit/fdfdd1bd0a99ee68b3b5adcb71c3d5c6aa0e42a5 |
|
Compare
| https://github.com/adcontextprotocol/adcp-client-python/compare/274fb938bb5dbac9e96f1f6005834d2daeeba725..fdfdd1bd0a99ee68b3b5adcb71c3d5c6aa0e42a5 |
| May 12, 2026 01:27 | https://github.com/adcontextprotocol/adcp-client-python/pull/686#event-25409136992 |
| https://github.com/bokelley |
| bokelley | https://github.com/bokelley |
|
May 12, 2026
| https://github.com/adcontextprotocol/adcp-client-python/pull/686#ref-issue-4425476796 |
|
Extend brand_manifest non-standard-path warning to inline-object branch
#687
| https://github.com/adcontextprotocol/adcp-client-python/issues/687 |
| https://github.com/bokelley |
| bokelley | https://github.com/bokelley |
| May 12, 2026 01:31 | https://github.com/adcontextprotocol/adcp-client-python/pull/686#event-25409236450 |
| https://github.com/bokelley |
| bokelley | https://github.com/bokelley |
| May 12, 2026 | https://github.com/adcontextprotocol/adcp-client-python/pull/686#issuecomment-4426512995 |
| #685 | https://github.com/adcontextprotocol/adcp-client-python/pull/685 |
| #685 | https://github.com/adcontextprotocol/adcp-client-python/pull/685 |
| #687 | https://github.com/adcontextprotocol/adcp-client-python/issues/687 |
| Please reload this page | https://github.com/adcontextprotocol/adcp-client-python/pull/686 |
| https://github.com/bokelley |
| bokelley | https://github.com/bokelley |
| 0568d2e | https://github.com/adcontextprotocol/adcp-client-python/commit/0568d2eafea58a66b96ebd38afef218558f06edf |
| May 12, 2026 | https://github.com/adcontextprotocol/adcp-client-python/pull/686#event-25409238796 |
| Please reload this page | https://github.com/adcontextprotocol/adcp-client-python/pull/686 |
| https://github.com/bokelley |
| bokelley | https://github.com/bokelley |
| May 12, 2026 01:31 | https://github.com/adcontextprotocol/adcp-client-python/pull/686#event-25409239898 |
| https://github.com/apps/github-actions |
| github-actions | https://github.com/apps/github-actions |
|
May 12, 2026
| https://github.com/adcontextprotocol/adcp-client-python/pull/686#ref-pullrequest-4425343482 |
|
chore(main): release 5.3.0
#682
| https://github.com/adcontextprotocol/adcp-client-python/pull/682 |
|
fix(compat): warn on non-standard brand_manifest path in inline-object branch
#688
| https://github.com/adcontextprotocol/adcp-client-python/pull/688 |
|
refactor(compat): normalize + cap brand_manifest warning dedup
#691
| https://github.com/adcontextprotocol/adcp-client-python/pull/691 |
| https://github.co/hiddenchars |
| https://github.com/adcontextprotocol/adcp-client-python/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fadcontextprotocol%2Fadcp-client-python%2Fpull%2F686 |
| Please reload this page | https://github.com/adcontextprotocol/adcp-client-python/pull/686 |
|
claude-triaged
| https://github.com/adcontextprotocol/adcp-client-python/issues?q=state%3Aopen%20label%3Aclaude-triaged |
|
v2.5 brand_manifest with non-standard path is silently flattened to domain only
| https://github.com/adcontextprotocol/adcp-client-python/issues/683 |
| Please reload this page | https://github.com/adcontextprotocol/adcp-client-python/pull/686 |
|
| https://github.com/bokelley |
|
| https://github.com/claude |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |