René's URL Explorer Experiment


Title: fix(compat): warn when brand_manifest non-standard path is silently flattened to domain by bokelley · Pull Request #686 · adcontextprotocol/adcp-client-python · GitHub

Open Graph Title: fix(compat): warn when brand_manifest non-standard path is silently flattened to domain by bokelley · Pull Request #686 · adcontextprotocol/adcp-client-python

X Title: fix(compat): warn when brand_manifest non-standard path is silently flattened to domain by bokelley · Pull Request #686 · adcontextprotocol/adcp-client-python

Description: A python library to interact with adcp servers. Contribute to adcontextprotocol/adcp-client-python development by creating an account on GitHub.

Open Graph Description: Closes #683 Summary After PR #679, the v2.5→v3 adapter correctly extracts the hostname from brand_manifest URLs, but silently drops any non-standard path. A buyer hosting at https://cdn.acmecorp.co...

X Description: Closes #683 Summary After PR #679, the v2.5→v3 adapter correctly extracts the hostname from brand_manifest URLs, but silently drops any non-standard path. A buyer hosting at https://cdn.acmecorp.co...

Opengraph URL: https://github.com/adcontextprotocol/adcp-client-python/pull/686

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:a79007c8-42a6-6acd-14d5-d7b0c2b8bbe2
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idD758:14F601:11CB92E:16BC0F5:6B01079D
html-safe-nonce976ac6820eed452d5b7511853cea409ad670b410ae3419703493b1cee7778949
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJENzU4OjE0RjYwMToxMUNCOTJFOjE2QkMwRjU6NkIwMTA3OUQiLCJ2aXNpdG9yX2lkIjoiMTcxODc1MTIxMzkyMDUyMDA5MyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac9f922f2f664428f6a158d368a404a9768087cbcfece77db05bd91cebdf206824
hovercard-subject-tagpull_request:3665551084
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/adcontextprotocol/adcp-client-python/686/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/c265375a8d99d809ce52ffa620ff94c461fef9c220468a5e442f0c7f563c469d/adcontextprotocol/adcp-client-python/pull/686
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/c265375a8d99d809ce52ffa620ff94c461fef9c220468a5e442f0c7f563c469d/adcontextprotocol/adcp-client-python/pull/686
og:image:altCloses #683 Summary After PR #679, the v2.5→v3 adapter correctly extracts the hostname from brand_manifest URLs, but silently drops any non-standard path. A buyer hosting at https://cdn.acmecorp.co...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamebokelley
hostnamegithub.com
expected-hostnamegithub.com
Nonecb7fa109eca7d4156c889f474306b0e91336055e9adf8fd4684b61e49094d124
turbo-cache-controlno-cache
go-importgithub.com/adcontextprotocol/adcp-client-python git https://github.com/adcontextprotocol/adcp-client-python.git
octolytics-dimension-user_id221690821
octolytics-dimension-user_loginadcontextprotocol
octolytics-dimension-repository_id1090305973
octolytics-dimension-repository_nwoadcontextprotocol/adcp-client-python
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id1090305973
octolytics-dimension-repository_network_root_nwoadcontextprotocol/adcp-client-python
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release2b59d31a4e44f08b7af67a4b67f8fd0af3befe2a
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/adcontextprotocol/adcp-client-python/pull/686#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fadcontextprotocol%2Fadcp-client-python%2Fpull%2F686
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fadcontextprotocol%2Fadcp-client-python%2Fpull%2F686
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=adcontextprotocol%2Fadcp-client-python
Reloadhttps://github.com/adcontextprotocol/adcp-client-python/pull/686
Reloadhttps://github.com/adcontextprotocol/adcp-client-python/pull/686
Reloadhttps://github.com/adcontextprotocol/adcp-client-python/pull/686
adcontextprotocolhttps://github.com/adcontextprotocol
adcp-client-pythonhttps://github.com/adcontextprotocol/adcp-client-python
Codehttps://github.com/adcontextprotocol/adcp-client-python
Issues44 (44)https://github.com/adcontextprotocol/adcp-client-python/issues
Pull requests13 (13)https://github.com/adcontextprotocol/adcp-client-python/pulls
Actionshttps://github.com/adcontextprotocol/adcp-client-python/actions
Projectshttps://github.com/adcontextprotocol/adcp-client-python/projects
Security and qualityhttps://github.com/adcontextprotocol/adcp-client-python/security
Insightshttps://github.com/adcontextprotocol/adcp-client-python/insights
https://github.com/adcontextprotocol/adcp-client-python
bokelleyhttps://github.com/bokelley
mainhttps://github.com/adcontextprotocol/adcp-client-python/tree/main
claude/issue-683-brand-manifest-path-warninghttps://github.com/adcontextprotocol/adcp-client-python/tree/claude/issue-683-brand-manifest-path-warning
Conversationhttps://github.com/adcontextprotocol/adcp-client-python/pull/686
Commits1 (1)https://github.com/adcontextprotocol/adcp-client-python/pull/686/commits
Checkshttps://github.com/adcontextprotocol/adcp-client-python/pull/686/checks
Files changedhttps://github.com/adcontextprotocol/adcp-client-python/pull/686/files
fix(compat): warn when brand_manifest non-standard path is silently flattened to domainhttps://github.com/adcontextprotocol/adcp-client-python/pull/686#top
bokelleyhttps://github.com/bokelley
mainhttps://github.com/adcontextprotocol/adcp-client-python/tree/main
claude/issue-683-brand-manifest-path-warninghttps://github.com/adcontextprotocol/adcp-client-python/tree/claude/issue-683-brand-manifest-path-warning
https://github.com/bokelley
bokelleyhttps://github.com/bokelley
May 12, 2026https://github.com/adcontextprotocol/adcp-client-python/pull/686#issue-4425448640
#683https://github.com/adcontextprotocol/adcp-client-python/issues/683
#679https://github.com/adcontextprotocol/adcp-client-python/pull/679
adcp#3121https://github.com/adcontextprotocol/adcp/issues/3121
https://claude.ai/code/session_01X44xueoHmfHRYeKL8giv2Fhttps://claude.ai/code/session_01X44xueoHmfHRYeKL8giv2F
Claude Codehttps://claude.ai/code/session_01X44xueoHmfHRYeKL8giv2F
Please reload this pagehttps://github.com/adcontextprotocol/adcp-client-python/pull/686
https://github.com/bokelley
bokelleyhttps://github.com/bokelley
claude-triaged https://github.com/adcontextprotocol/adcp-client-python/issues?q=state%3Aopen%20label%3Aclaude-triaged
May 12, 2026https://github.com/adcontextprotocol/adcp-client-python/pull/686#event-25408979982
v2.5 brand_manifest with non-standard path is silently flattened to domain only #683 https://github.com/adcontextprotocol/adcp-client-python/issues/683
fix(compat): handle inline BrandManifest object in v2.5 adapters #685 https://github.com/adcontextprotocol/adcp-client-python/pull/685
https://github.com/claude
https://github.com/bokelley
fix(compat): warn when brand_manifest non-standard path is flattened …https://github.com/adcontextprotocol/adcp-client-python/pull/686/commits/fdfdd1bd0a99ee68b3b5adcb71c3d5c6aa0e42a5
fdfdd1bhttps://github.com/adcontextprotocol/adcp-client-python/pull/686/commits/fdfdd1bd0a99ee68b3b5adcb71c3d5c6aa0e42a5
https://cdn.acmecorp.com/brand-manifest.jsonhttps://cdn.acmecorp.com/brand-manifest.json
https://cdn.acmecorp.com/.well-known/brand.jsonhttps://cdn.acmecorp.com/.well-known/brand.json
#683https://github.com/adcontextprotocol/adcp-client-python/issues/683
https://claude.ai/code/session_01X44xueoHmfHRYeKL8giv2Fhttps://claude.ai/code/session_01X44xueoHmfHRYeKL8giv2F
https://github.com/bokelley
bokelleyhttps://github.com/bokelley
force-pushedhttps://github.com/adcontextprotocol/adcp-client-python/compare/274fb938bb5dbac9e96f1f6005834d2daeeba725..fdfdd1bd0a99ee68b3b5adcb71c3d5c6aa0e42a5
274fb93https://github.com/adcontextprotocol/adcp-client-python/commit/274fb938bb5dbac9e96f1f6005834d2daeeba725
fdfdd1bhttps://github.com/adcontextprotocol/adcp-client-python/commit/fdfdd1bd0a99ee68b3b5adcb71c3d5c6aa0e42a5
Compare https://github.com/adcontextprotocol/adcp-client-python/compare/274fb938bb5dbac9e96f1f6005834d2daeeba725..fdfdd1bd0a99ee68b3b5adcb71c3d5c6aa0e42a5
May 12, 2026 01:27https://github.com/adcontextprotocol/adcp-client-python/pull/686#event-25409136992
https://github.com/bokelley
bokelleyhttps://github.com/bokelley
May 12, 2026 https://github.com/adcontextprotocol/adcp-client-python/pull/686#ref-issue-4425476796
Extend brand_manifest non-standard-path warning to inline-object branch #687 https://github.com/adcontextprotocol/adcp-client-python/issues/687
https://github.com/bokelley
bokelleyhttps://github.com/bokelley
May 12, 2026 01:31https://github.com/adcontextprotocol/adcp-client-python/pull/686#event-25409236450
https://github.com/bokelley
bokelleyhttps://github.com/bokelley
May 12, 2026https://github.com/adcontextprotocol/adcp-client-python/pull/686#issuecomment-4426512995
#685https://github.com/adcontextprotocol/adcp-client-python/pull/685
#685https://github.com/adcontextprotocol/adcp-client-python/pull/685
#687https://github.com/adcontextprotocol/adcp-client-python/issues/687
Please reload this pagehttps://github.com/adcontextprotocol/adcp-client-python/pull/686
https://github.com/bokelley
bokelleyhttps://github.com/bokelley
0568d2ehttps://github.com/adcontextprotocol/adcp-client-python/commit/0568d2eafea58a66b96ebd38afef218558f06edf
May 12, 2026https://github.com/adcontextprotocol/adcp-client-python/pull/686#event-25409238796
Please reload this pagehttps://github.com/adcontextprotocol/adcp-client-python/pull/686
https://github.com/bokelley
bokelleyhttps://github.com/bokelley
May 12, 2026 01:31https://github.com/adcontextprotocol/adcp-client-python/pull/686#event-25409239898
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
May 12, 2026 https://github.com/adcontextprotocol/adcp-client-python/pull/686#ref-pullrequest-4425343482
chore(main): release 5.3.0 #682 https://github.com/adcontextprotocol/adcp-client-python/pull/682
fix(compat): warn on non-standard brand_manifest path in inline-object branch #688 https://github.com/adcontextprotocol/adcp-client-python/pull/688
refactor(compat): normalize + cap brand_manifest warning dedup #691 https://github.com/adcontextprotocol/adcp-client-python/pull/691
https://github.co/hiddenchars
https://github.com/adcontextprotocol/adcp-client-python/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fadcontextprotocol%2Fadcp-client-python%2Fpull%2F686
Please reload this pagehttps://github.com/adcontextprotocol/adcp-client-python/pull/686
claude-triaged https://github.com/adcontextprotocol/adcp-client-python/issues?q=state%3Aopen%20label%3Aclaude-triaged
v2.5 brand_manifest with non-standard path is silently flattened to domain only https://github.com/adcontextprotocol/adcp-client-python/issues/683
Please reload this pagehttps://github.com/adcontextprotocol/adcp-client-python/pull/686
https://github.com/bokelley
https://github.com/claude
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.