René's URL Explorer Experiment


Title: fix(server): preserve Starlette lifespan when public_url is callable by bokelley · Pull Request #680 · adcontextprotocol/adcp-client-python · GitHub

Open Graph Title: fix(server): preserve Starlette lifespan when public_url is callable by bokelley · Pull Request #680 · adcontextprotocol/adcp-client-python

X Title: fix(server): preserve Starlette lifespan when public_url is callable by bokelley · Pull Request #680 · adcontextprotocol/adcp-client-python

Description: A python library to interact with adcp servers. Contribute to adcontextprotocol/adcp-client-python development by creating an account on GitHub.

Open Graph Description: Summary Fixes #676. serve(transport="both", public_url=<callable>) crashed at lifespan startup with AttributeError: 'function' object has no attribute 'router' and t...

X Description: Summary Fixes #676. serve(transport=&quot;both&quot;, public_url=&lt;callable&gt;) crashed at lifespan startup with AttributeError: &#39;function&#39; object has no attribut...

Opengraph URL: https://github.com/adcontextprotocol/adcp-client-python/pull/680

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:0cecd701-b82f-758e-b18e-4477d6eee81e
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id9038:E3C4F:B51E73:E80D31:6B00FAF6
html-safe-noncebcb9c431a99f43dcb1fca3a1e7ae091943aa085d7357f002e21494c2a62810aa
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5MDM4OkUzQzRGOkI1MUU3MzpFODBEMzE6NkIwMEZBRjYiLCJ2aXNpdG9yX2lkIjoiODQwNDgzNzI5NTkzMjM3Mzc1MCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac555785fe8c9875b7fd342476b4df47d27c26b66733b63cb0d58b0aae1f2cb015
hovercard-subject-tagpull_request:3664544105
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/adcontextprotocol/adcp-client-python/680/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/cc716719603ed7c63eba4da9b3845e56bf79b35492934b747524d784c9288e58/adcontextprotocol/adcp-client-python/pull/680
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/cc716719603ed7c63eba4da9b3845e56bf79b35492934b747524d784c9288e58/adcontextprotocol/adcp-client-python/pull/680
og:image:altSummary Fixes #676. serve(transport="both", public_url=<callable>) crashed at lifespan startup with AttributeError: 'function' object has no attribute 'router' and t...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamebokelley
hostnamegithub.com
expected-hostnamegithub.com
Nonee208d86428ec00a57ade75058166297440e8128a01e5287c31a53dc042bbf187
turbo-cache-controlno-cache
go-importgithub.com/adcontextprotocol/adcp-client-python git https://github.com/adcontextprotocol/adcp-client-python.git
octolytics-dimension-user_id221690821
octolytics-dimension-user_loginadcontextprotocol
octolytics-dimension-repository_id1090305973
octolytics-dimension-repository_nwoadcontextprotocol/adcp-client-python
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id1090305973
octolytics-dimension-repository_network_root_nwoadcontextprotocol/adcp-client-python
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release7dafd017fb7809a839c443dba08622af38e63c09
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/adcontextprotocol/adcp-client-python/pull/680#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fadcontextprotocol%2Fadcp-client-python%2Fpull%2F680
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fadcontextprotocol%2Fadcp-client-python%2Fpull%2F680
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=adcontextprotocol%2Fadcp-client-python
Reloadhttps://github.com/adcontextprotocol/adcp-client-python/pull/680
Reloadhttps://github.com/adcontextprotocol/adcp-client-python/pull/680
Reloadhttps://github.com/adcontextprotocol/adcp-client-python/pull/680
adcontextprotocolhttps://github.com/adcontextprotocol
adcp-client-pythonhttps://github.com/adcontextprotocol/adcp-client-python
Codehttps://github.com/adcontextprotocol/adcp-client-python
Issues44 (44)https://github.com/adcontextprotocol/adcp-client-python/issues
Pull requests13 (13)https://github.com/adcontextprotocol/adcp-client-python/pulls
Actionshttps://github.com/adcontextprotocol/adcp-client-python/actions
Projectshttps://github.com/adcontextprotocol/adcp-client-python/projects
Security and qualityhttps://github.com/adcontextprotocol/adcp-client-python/security
Insightshttps://github.com/adcontextprotocol/adcp-client-python/insights
https://github.com/adcontextprotocol/adcp-client-python
bokelleyhttps://github.com/bokelley
mainhttps://github.com/adcontextprotocol/adcp-client-python/tree/main
claude/issue-676-callable-public-url-lifespanhttps://github.com/adcontextprotocol/adcp-client-python/tree/claude/issue-676-callable-public-url-lifespan
Conversationhttps://github.com/adcontextprotocol/adcp-client-python/pull/680
Commits1 (1)https://github.com/adcontextprotocol/adcp-client-python/pull/680/commits
Checkshttps://github.com/adcontextprotocol/adcp-client-python/pull/680/checks
Files changedhttps://github.com/adcontextprotocol/adcp-client-python/pull/680/files
fix(server): preserve Starlette lifespan when public_url is callablehttps://github.com/adcontextprotocol/adcp-client-python/pull/680#top
bokelleyhttps://github.com/bokelley
mainhttps://github.com/adcontextprotocol/adcp-client-python/tree/main
claude/issue-676-callable-public-url-lifespanhttps://github.com/adcontextprotocol/adcp-client-python/tree/claude/issue-676-callable-public-url-lifespan
https://github.com/bokelley
bokelleyhttps://github.com/bokelley
May 11, 2026https://github.com/adcontextprotocol/adcp-client-python/pull/680#issue-4424260762
#676https://github.com/adcontextprotocol/adcp-client-python/issues/676
Please reload this pagehttps://github.com/adcontextprotocol/adcp-client-python/pull/680
https://github.com/bokelley
https://github.com/claude
fix(server): preserve Starlette lifespan when public_url is callablehttps://github.com/adcontextprotocol/adcp-client-python/pull/680/commits/216ff52d0e85cb72226ee0e4785e60566b622475
216ff52https://github.com/adcontextprotocol/adcp-client-python/pull/680/commits/216ff52d0e85cb72226ee0e4785e60566b622475
#676https://github.com/adcontextprotocol/adcp-client-python/issues/676
https://github.com/bokelley
bokelleyhttps://github.com/bokelley
May 12, 2026https://github.com/adcontextprotocol/adcp-client-python/pull/680#issuecomment-4426344089
Please reload this pagehttps://github.com/adcontextprotocol/adcp-client-python/pull/680
https://github.com/bokelley
bokelleyhttps://github.com/bokelley
8632847https://github.com/adcontextprotocol/adcp-client-python/commit/86328470ff9b53f6837368edd14851c16032efa7
May 12, 2026https://github.com/adcontextprotocol/adcp-client-python/pull/680#event-25408382125
Please reload this pagehttps://github.com/adcontextprotocol/adcp-client-python/pull/680
https://github.com/bokelley
bokelleyhttps://github.com/bokelley
May 12, 2026 00:52https://github.com/adcontextprotocol/adcp-client-python/pull/680#event-25408382914
https://github.com/bokelley
bokelleyhttps://github.com/bokelley
May 12, 2026https://github.com/adcontextprotocol/adcp-client-python/pull/680#issuecomment-4426347597
@bokelleyhttps://github.com/bokelley
https://claude.ai/code/${CLAUDE_CODE_REMOTE_SESSION_ID}https://claude.ai/code/$%7BCLAUDE_CODE_REMOTE_SESSION_ID%7D
Claude Codehttps://claude.ai/code
Please reload this pagehttps://github.com/adcontextprotocol/adcp-client-python/pull/680
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
May 12, 2026 https://github.com/adcontextprotocol/adcp-client-python/pull/680#ref-pullrequest-4425343482
chore(main): release 5.3.0 #682 https://github.com/adcontextprotocol/adcp-client-python/pull/682
https://github.com/bokelley
bokelleyhttps://github.com/bokelley
May 12, 2026 https://github.com/adcontextprotocol/adcp-client-python/pull/680#ref-issue-4433201658
feat(server): expose lifespan / on_startup / on_shutdown hooks on serve() #709 https://github.com/adcontextprotocol/adcp-client-python/issues/709
https://github.co/hiddenchars
https://github.com/adcontextprotocol/adcp-client-python/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fadcontextprotocol%2Fadcp-client-python%2Fpull%2F680
Please reload this pagehttps://github.com/adcontextprotocol/adcp-client-python/pull/680
serve(transport="both") + callable public_url crashes at startup: 'function' object has no attribute 'router' https://github.com/adcontextprotocol/adcp-client-python/issues/676
Please reload this pagehttps://github.com/adcontextprotocol/adcp-client-python/pull/680
https://github.com/bokelley
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.