René's URL Explorer Experiment


Title: fix(decisioning): wrap pydantic.ValidationError from delegates as INVALID_REQUEST by bokelley · Pull Request #656 · adcontextprotocol/adcp-client-python · GitHub

Open Graph Title: fix(decisioning): wrap pydantic.ValidationError from delegates as INVALID_REQUEST by bokelley · Pull Request #656 · adcontextprotocol/adcp-client-python

X Title: fix(decisioning): wrap pydantic.ValidationError from delegates as INVALID_REQUEST by bokelley · Pull Request #656 · adcontextprotocol/adcp-client-python

Description: Closes #652 Summary Platform delegates that manually call RequestModel.model_validate() against a stricter subclass schema previously surfaced as INTERNAL_ERROR (terminal) when the buyer's input failed validation, stripping all field information from the wire envelope. This PR converts those pydantic.ValidationError exceptions to INVALID_REQUEST (correctable) with populated field and details.validation_errors, matching the behaviour already present in _coerce_params_to_platform_type for the annotation-coercion path. Two changes: _validation_error_to_invalid_request helper — builds the AdcpError("INVALID_REQUEST") with narrow_union_errors-filtered field paths, with a safe fallback if the narrowing import fails. Input values are excluded from the error payload on both paths (include_input=False) to avoid leaking buyer-supplied data. except _ValidationError clause in _invoke_platform_method — inserted between except TypeError and except Exception, fires on_failure hook (so proposal-flow reservations are released) before re-raising the wrapped error. Note: the framework cannot distinguish a buyer-request ValidationError from a seller-response construction ValidationError at this catch boundary. The tradeoff is intentional and consistent with _coerce_params_to_platform_type — surfacing INVALID_REQUEST correctable with field paths is strictly more informative than INTERNAL_ERROR terminal in either case. What was tested pytest tests/test_decisioning_dispatch.py → 56 passed (includes updated test_invoke_validation_error_surfaces_narrowed_field_paths and new test_invoke_validation_error_from_manual_model_validate_is_invalid_request) pytest tests/ --ignore=tests/integration → 4298 passed, 0 new failures (1 pre-existing TLS integration test excluded) ruff check src/adcp/decisioning/dispatch.py → all checks passed mypy src/adcp/decisioning/dispatch.py --ignore-missing-imports → no new errors on changed lines Pre-PR review code-reviewer: approved after 1 blocker fixed — fallback exc.errors() call now passes include_input=False, include_context=False to prevent buyer-supplied data leaking into details.validation_errors; 1 nit noted (exc: Any signature loses static type info) dx-expert: approved — field dot-join produces correct "extra_field" for extra='forbid' errors; details shape asymmetry from _internal_error_details is intentional; no suggestion field is consistent with all peer INVALID_REQUEST wraps in the same file Triage-managed PR. This bot does not currently iterate on review comments or PR conversation threads (only on the source issue). To unblock: Push fixup commits directly: gh pr checkout → fix → push. Or re-trigger: comment /triage execute on the source issue. See adcp#3121 for context. Session: https://claude.ai/code/session_01J7nYYToyy7PCs6CgQGRAWN Generated by Claude Code

Open Graph Description: Closes #652 Summary Platform delegates that manually call RequestModel.model_validate() against a stricter subclass schema previously surfaced as INTERNAL_ERROR (terminal) when the buyer's inpu...

X Description: Closes #652 Summary Platform delegates that manually call RequestModel.model_validate() against a stricter subclass schema previously surfaced as INTERNAL_ERROR (terminal) when the buyer's ...

Opengraph URL: https://github.com/adcontextprotocol/adcp-client-python/pull/656

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:5b719936-2412-9955-e826-14fce50da02d
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idEB1E:1F2F:6C3CB3:9034C7:6B018D74
html-safe-noncefb8d31ebc9976802a9321fca31a2449abcc63afb4c401d582f497c5fe53f4ef6
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFQjFFOjFGMkY6NkMzQ0IzOjkwMzRDNzo2QjAxOEQ3NCIsInZpc2l0b3JfaWQiOiI3NzQ1MTMyNTM4NzQyNDA4ODQiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac02e40b6247618928952a7ed3fd3b10c99dd207ab22b1a5177c59bd7939df9d99
hovercard-subject-tagpull_request:3659928649
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/adcontextprotocol/adcp-client-python/pull/656/files
twitter:imagehttps://avatars.githubusercontent.com/u/134922?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/134922?s=400&v=4
og:image:altCloses #652 Summary Platform delegates that manually call RequestModel.model_validate() against a stricter subclass schema previously surfaced as INTERNAL_ERROR (terminal) when the buyer's inpu...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/adcontextprotocol/adcp-client-python git https://github.com/adcontextprotocol/adcp-client-python.git
octolytics-dimension-user_id221690821
octolytics-dimension-user_loginadcontextprotocol
octolytics-dimension-repository_id1090305973
octolytics-dimension-repository_nwoadcontextprotocol/adcp-client-python
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id1090305973
octolytics-dimension-repository_network_root_nwoadcontextprotocol/adcp-client-python
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetcanary-2
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/adcontextprotocol/adcp-client-python/pull/656/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fadcontextprotocol%2Fadcp-client-python%2Fpull%2F656%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fadcontextprotocol%2Fadcp-client-python%2Fpull%2F656%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=adcontextprotocol%2Fadcp-client-python
Reloadhttps://github.com/adcontextprotocol/adcp-client-python/pull/656/files
Reloadhttps://github.com/adcontextprotocol/adcp-client-python/pull/656/files
Reloadhttps://github.com/adcontextprotocol/adcp-client-python/pull/656/files
adcontextprotocolhttps://github.com/adcontextprotocol
adcp-client-pythonhttps://github.com/adcontextprotocol/adcp-client-python
Codehttps://github.com/adcontextprotocol/adcp-client-python
Issues44 (44)https://github.com/adcontextprotocol/adcp-client-python/issues
Pull requests13 (13)https://github.com/adcontextprotocol/adcp-client-python/pulls
Actionshttps://github.com/adcontextprotocol/adcp-client-python/actions
Projectshttps://github.com/adcontextprotocol/adcp-client-python/projects
Security and qualityhttps://github.com/adcontextprotocol/adcp-client-python/security
Insightshttps://github.com/adcontextprotocol/adcp-client-python/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fadcontextprotocol%2Fadcp-client-python%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fadcontextprotocol%2Fadcp-client-python%2Fissues%2Fnew%2Fchoose
bokelleyhttps://github.com/bokelley
mainhttps://github.com/adcontextprotocol/adcp-client-python/tree/main
claude/issue-652-validation-error-invalid-requesthttps://github.com/adcontextprotocol/adcp-client-python/tree/claude/issue-652-validation-error-invalid-request
Conversation 0 https://github.com/adcontextprotocol/adcp-client-python/pull/656
Commits 3 https://github.com/adcontextprotocol/adcp-client-python/pull/656/commits
Checks 15 https://github.com/adcontextprotocol/adcp-client-python/pull/656/checks
Files changed https://github.com/adcontextprotocol/adcp-client-python/pull/656/files
Please reload this pagehttps://github.com/adcontextprotocol/adcp-client-python/pull/656/files
fix(decisioning): wrap pydantic.ValidationError from delegates as INVALID_REQUEST https://github.com/adcontextprotocol/adcp-client-python/pull/656/files#top
Show all changes 3 commits https://github.com/adcontextprotocol/adcp-client-python/pull/656/files
4053f55 fix(decisioning): wrap pydantic.ValidationError from delegates as INV… claude May 11, 2026 https://github.com/adcontextprotocol/adcp-client-python/pull/656/commits/4053f558e503877111b1178029444aa3ea34784b
7038f97 fix(decisioning): omit input from validation_errors fallback path claude May 11, 2026 https://github.com/adcontextprotocol/adcp-client-python/pull/656/commits/7038f972e918245c413771241201e60165911434
b92f821 fix(decisioning): remove silent fallback in ValidationError → INVALID… bokelley May 11, 2026 https://github.com/adcontextprotocol/adcp-client-python/pull/656/commits/b92f8210f186157499f18fb0528b3a855b7834dd
Clear filters https://github.com/adcontextprotocol/adcp-client-python/pull/656/files
Please reload this pagehttps://github.com/adcontextprotocol/adcp-client-python/pull/656/files
Please reload this pagehttps://github.com/adcontextprotocol/adcp-client-python/pull/656/files
dispatch.py https://github.com/adcontextprotocol/adcp-client-python/pull/656/files#diff-4d7e58b97af0183a9899752992d11923aa23cc0df5a343f2e01dd157a2ad6b69
test_decisioning_dispatch.py https://github.com/adcontextprotocol/adcp-client-python/pull/656/files#diff-b1be5291e75257d0f1062ae07a54ccc4f5dcfcef355037ac1493eb73c85297f8
https://github.com/adcontextprotocol/adcp-client-python/blob/main/.github/CODEOWNERS#L3
src/adcp/decisioning/dispatch.pyhttps://github.com/adcontextprotocol/adcp-client-python/pull/656/files#diff-4d7e58b97af0183a9899752992d11923aa23cc0df5a343f2e01dd157a2ad6b69
View file https://github.com/adcontextprotocol/adcp-client-python/blob/b92f8210f186157499f18fb0528b3a855b7834dd/src/adcp/decisioning/dispatch.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/adcontextprotocol/adcp-client-python/pull/656/{{ revealButtonHref }}
https://github.com/adcontextprotocol/adcp-client-python/pull/656/files#diff-4d7e58b97af0183a9899752992d11923aa23cc0df5a343f2e01dd157a2ad6b69
https://github.com/adcontextprotocol/adcp-client-python/pull/656/files#diff-4d7e58b97af0183a9899752992d11923aa23cc0df5a343f2e01dd157a2ad6b69
https://github.com/adcontextprotocol/adcp-client-python/pull/656/files#diff-4d7e58b97af0183a9899752992d11923aa23cc0df5a343f2e01dd157a2ad6b69
https://github.com/adcontextprotocol/adcp-client-python/pull/656/files#diff-4d7e58b97af0183a9899752992d11923aa23cc0df5a343f2e01dd157a2ad6b69
https://github.com/adcontextprotocol/adcp-client-python/pull/656/files#diff-4d7e58b97af0183a9899752992d11923aa23cc0df5a343f2e01dd157a2ad6b69
https://github.com/adcontextprotocol/adcp-client-python/pull/656/files#diff-4d7e58b97af0183a9899752992d11923aa23cc0df5a343f2e01dd157a2ad6b69
https://github.com/adcontextprotocol/adcp-client-python/pull/656/files#diff-4d7e58b97af0183a9899752992d11923aa23cc0df5a343f2e01dd157a2ad6b69
https://github.com/adcontextprotocol/adcp-client-python/pull/656/files#diff-4d7e58b97af0183a9899752992d11923aa23cc0df5a343f2e01dd157a2ad6b69
https://github.com/adcontextprotocol/adcp-client-python/blob/main/.github/CODEOWNERS#L3
tests/test_decisioning_dispatch.pyhttps://github.com/adcontextprotocol/adcp-client-python/pull/656/files#diff-b1be5291e75257d0f1062ae07a54ccc4f5dcfcef355037ac1493eb73c85297f8
View file https://github.com/adcontextprotocol/adcp-client-python/blob/b92f8210f186157499f18fb0528b3a855b7834dd/tests/test_decisioning_dispatch.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/adcontextprotocol/adcp-client-python/pull/656/{{ revealButtonHref }}
https://github.com/adcontextprotocol/adcp-client-python/pull/656/files#diff-b1be5291e75257d0f1062ae07a54ccc4f5dcfcef355037ac1493eb73c85297f8
https://github.com/adcontextprotocol/adcp-client-python/pull/656/files#diff-b1be5291e75257d0f1062ae07a54ccc4f5dcfcef355037ac1493eb73c85297f8
https://github.com/adcontextprotocol/adcp-client-python/pull/656/files#diff-b1be5291e75257d0f1062ae07a54ccc4f5dcfcef355037ac1493eb73c85297f8
https://github.com/adcontextprotocol/adcp-client-python/pull/656/files#diff-b1be5291e75257d0f1062ae07a54ccc4f5dcfcef355037ac1493eb73c85297f8
Please reload this pagehttps://github.com/adcontextprotocol/adcp-client-python/pull/656/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.