René's URL Explorer Experiment


Title: feat(webhooks): HMAC/bearer/Docker/Standard Webhooks delivery modes by bokelley · Pull Request #482 · adcontextprotocol/adcp-client-python · GitHub

Open Graph Title: feat(webhooks): HMAC/bearer/Docker/Standard Webhooks delivery modes by bokelley · Pull Request #482 · adcontextprotocol/adcp-client-python

X Title: feat(webhooks): HMAC/bearer/Docker/Standard Webhooks delivery modes by bokelley · Pull Request #482 · adcontextprotocol/adcp-client-python

Description: Summary Closes #478. Three additive features on the existing WebhookSender stack: Alt-auth modes — WebhookSender.from_bearer_token, from_adcp_legacy_hmac, from_standard_webhooks_secret for buyers who authenticate at the gateway, run AdCP-3.x HMAC, or run Svix/Resend. TransportHook Protocol + DockerLocalhostRewrite — opt-in URL rewrite before SSRF for senders running inside Docker. Hooks run pre-SSRF but SSRF remains authoritative on the rewritten URL; DockerLocalhostRewrite raises at sender construction unless allow_private_destinations=True so the rewrite can't be a silent no-op. adcp.signing.standard_webhooks — pure-Python standardwebhooks.com v1 primitives with svix-Python interop tested both directions. Internal: extracted WebhookAuthStrategy Protocol with four concrete strategies (JWK / AdCP-legacy HMAC / Standard Webhooks / bearer). _send_bytes now calls self._auth.build_auth_headers per request — HMAC modes naturally re-sign on resend() with a fresh timestamp, which the receiver-side 300s skew window requires. Public __init__ signature unchanged; alt-auth constructors bypass via internal _from_strategy. Triage decisions resolved (from issue #478 expert review) F3 SSRF boundary — hooks run before SSRF; SSRF authoritative on the rewritten URL. DockerLocalhostRewrite.validate_for_sender raises if allow_private_destinations=False. Test test_hook_cannot_punch_through_ssrf_when_private_disallowed proves the invariant: a malicious hook rewriting to 127.0.0.1 is still rejected when the operator has not opted in. F1/F4 Standard Webhooks secret encoding — split into two typed constructors. from_adcp_legacy_hmac(bytes) takes raw HMAC key bytes; from_standard_webhooks_secret(str) takes the canonical whsec_ form and base64-decodes internally. The encoding contract lives in the constructor name; can't accidentally swap. Auth-mode mypy — WebhookAuthStrategy Protocol replaces the propagated Optional[PrivateKey]. Strict mypy passes across 764 src files. HMAC resend() re-signs — falls out of the strategy abstraction. Tests assert fresh webhook-timestamp / X-AdCP-Timestamp and fresh signatures across replays of the same body bytes. send_raw idempotency_key — kept required across all modes; migration doc examples pass it explicitly. Test plan tests/conformance/signing/test_standard_webhooks.py — 16 unit tests including svix-Python interop (sign→svix verify and svix sign→our verify) tests/conformance/signing/test_webhook_sender_alt_auth.py — 16 e2e tests round-tripping each new mode through httpx.ASGITransport tests/conformance/signing/test_webhook_transport_hooks.py — 14 tests including the SSRF-can't-be-bypassed proof and the construction-time allow_private_destinations guard tests/conformance/signing/test_webhook_sender_e2e.py — 21 existing JWK e2e tests still pass after the strategy refactor tests/integration/test_standard_webhooks_svix_sandbox.py — env-gated real-Svix delivery test (set SVIX_SANDBOX_URL + SVIX_SANDBOX_SECRET to run) mypy clean (764 src files), ruff clean (changed files), pre-commit gates passing Full test suite: 3565 pass, 21 skip, 1 pre-existing failure unrelated to #478 (test_v3_reference_seller_passes_with_no_warnings — V3ReferenceSeller.__init__ missing upstream kwarg, fails on main too) Migration docs/webhooks/migration-from-fragmented-senders.md is a translation table for operators with multiple legacy senders — covers each pattern (hand-built bearer / hand-built HMAC with the sign-vs-body bug / hand-built Svix-style / custom Docker rewrite / per-call retry / per-call SSRF) with the equivalent on the consolidated API. 🤖 Generated with Claude Code

Open Graph Description: Summary Closes #478. Three additive features on the existing WebhookSender stack: Alt-auth modes — WebhookSender.from_bearer_token, from_adcp_legacy_hmac, from_standard_webhooks_secret for buyers ...

X Description: Summary Closes #478. Three additive features on the existing WebhookSender stack: Alt-auth modes — WebhookSender.from_bearer_token, from_adcp_legacy_hmac, from_standard_webhooks_secret for buyers ...

Opengraph URL: https://github.com/adcontextprotocol/adcp-client-python/pull/482

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:085ddf62-3457-ddc6-a7d1-389091f952d6
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idA2F2:928E2:DD3EB8:12820F2:6B010401
html-safe-noncee48e940deed0e464c128deafc1d8ae1cdcd5bab29274ed6af8d5e16fdfd77e23
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBMkYyOjkyOEUyOkREM0VCODoxMjgyMEYyOjZCMDEwNDAxIiwidmlzaXRvcl9pZCI6Ijg2MDExOTY0ODMzNzY2NDUxMjIiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac1c71c5e408d10a6057c00b3deff51f143884c8c483fff5c972267571b56d7947
hovercard-subject-tagpull_request:3620335036
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/adcontextprotocol/adcp-client-python/pull/482/files
twitter:imagehttps://avatars.githubusercontent.com/u/134922?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/134922?s=400&v=4
og:image:altSummary Closes #478. Three additive features on the existing WebhookSender stack: Alt-auth modes — WebhookSender.from_bearer_token, from_adcp_legacy_hmac, from_standard_webhooks_secret for buyers ...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonecb7fa109eca7d4156c889f474306b0e91336055e9adf8fd4684b61e49094d124
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/adcontextprotocol/adcp-client-python git https://github.com/adcontextprotocol/adcp-client-python.git
octolytics-dimension-user_id221690821
octolytics-dimension-user_loginadcontextprotocol
octolytics-dimension-repository_id1090305973
octolytics-dimension-repository_nwoadcontextprotocol/adcp-client-python
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id1090305973
octolytics-dimension-repository_network_root_nwoadcontextprotocol/adcp-client-python
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release2b59d31a4e44f08b7af67a4b67f8fd0af3befe2a
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/adcontextprotocol/adcp-client-python/pull/482/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fadcontextprotocol%2Fadcp-client-python%2Fpull%2F482%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fadcontextprotocol%2Fadcp-client-python%2Fpull%2F482%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=adcontextprotocol%2Fadcp-client-python
Reloadhttps://github.com/adcontextprotocol/adcp-client-python/pull/482/files
Reloadhttps://github.com/adcontextprotocol/adcp-client-python/pull/482/files
Reloadhttps://github.com/adcontextprotocol/adcp-client-python/pull/482/files
adcontextprotocolhttps://github.com/adcontextprotocol
adcp-client-pythonhttps://github.com/adcontextprotocol/adcp-client-python
Codehttps://github.com/adcontextprotocol/adcp-client-python
Issues44 (44)https://github.com/adcontextprotocol/adcp-client-python/issues
Pull requests13 (13)https://github.com/adcontextprotocol/adcp-client-python/pulls
Actionshttps://github.com/adcontextprotocol/adcp-client-python/actions
Projectshttps://github.com/adcontextprotocol/adcp-client-python/projects
Security and qualityhttps://github.com/adcontextprotocol/adcp-client-python/security
Insightshttps://github.com/adcontextprotocol/adcp-client-python/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fadcontextprotocol%2Fadcp-client-python%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fadcontextprotocol%2Fadcp-client-python%2Fissues%2Fnew%2Fchoose
bokelleyhttps://github.com/bokelley
mainhttps://github.com/adcontextprotocol/adcp-client-python/tree/main
bokelley/issue-478-webhook-exthttps://github.com/adcontextprotocol/adcp-client-python/tree/bokelley/issue-478-webhook-ext
Conversation 1 https://github.com/adcontextprotocol/adcp-client-python/pull/482
Commits 1 https://github.com/adcontextprotocol/adcp-client-python/pull/482/commits
Checks 13 https://github.com/adcontextprotocol/adcp-client-python/pull/482/checks
Files changed https://github.com/adcontextprotocol/adcp-client-python/pull/482/files
Please reload this pagehttps://github.com/adcontextprotocol/adcp-client-python/pull/482/files
feat(webhooks): HMAC/bearer/Docker/Standard Webhooks delivery modes https://github.com/adcontextprotocol/adcp-client-python/pull/482/files#top
Show all changes 1 commit https://github.com/adcontextprotocol/adcp-client-python/pull/482/files
7fbae09 feat(webhooks): HMAC/bearer/Docker/Standard Webhooks delivery modes bokelley May 3, 2026 https://github.com/adcontextprotocol/adcp-client-python/pull/482/commits/7fbae09960fda9cc2595fc4fcdb914734465812f
Clear filters https://github.com/adcontextprotocol/adcp-client-python/pull/482/files
Please reload this pagehttps://github.com/adcontextprotocol/adcp-client-python/pull/482/files
Please reload this pagehttps://github.com/adcontextprotocol/adcp-client-python/pull/482/files
migration-from-fragmented-senders.md https://github.com/adcontextprotocol/adcp-client-python/pull/482/files#diff-3460bbf5e1eda9e3d01b6488bb635ea9ae574e1d23f60f2a6cfcbf3565fc065c
__init__.py https://github.com/adcontextprotocol/adcp-client-python/pull/482/files#diff-9e5029ee28dee984d5a3e3134d4981b70268cfddcb5bf9c1f340a0356833e84a
standard_webhooks.py https://github.com/adcontextprotocol/adcp-client-python/pull/482/files#diff-ff3ac4634a2d246652d407b81a7bddbc922f3dd2b64d5964d55f7840048069eb
webhook_auth.py https://github.com/adcontextprotocol/adcp-client-python/pull/482/files#diff-d9c26d862adc5d0d7565c5c4cc0ff22f2a2808499df12ef03e7c6b21c09b57d2
webhook_sender.py https://github.com/adcontextprotocol/adcp-client-python/pull/482/files#diff-c5467dcf5c2db69324dd8dd06ec4be04402e1ec880fe252bb4b15efceb5226e0
webhook_transport_hooks.py https://github.com/adcontextprotocol/adcp-client-python/pull/482/files#diff-4691d069822567f03495dd9ac489fdda442676f93922e7376bfc867b391ac340
webhooks.py https://github.com/adcontextprotocol/adcp-client-python/pull/482/files#diff-de1acd69f0d7a9be3801c3c65c37cab6d7001c837f1da91834ef8a37a77ab9b6
test_standard_webhooks.py https://github.com/adcontextprotocol/adcp-client-python/pull/482/files#diff-2c1d06367fd234460f1e059027c8638b2ed7b168fe16e9d9fed87acd47ed730e
test_webhook_sender_alt_auth.py https://github.com/adcontextprotocol/adcp-client-python/pull/482/files#diff-d05243a2ed6a2f872f9f613bc303099398b683930bf06d1c7f7dc411b745ebc8
test_webhook_sender_e2e.py https://github.com/adcontextprotocol/adcp-client-python/pull/482/files#diff-664e7ca5ad3971f88402e172ae3bce1a79ef7f6bf4df5964de91aa53d0caee0e
test_webhook_transport_hooks.py https://github.com/adcontextprotocol/adcp-client-python/pull/482/files#diff-fa0e948d3aed501d0a05ec5dac5c7993fc07c8556b8fed6922df000dbb2f338a
test_standard_webhooks_svix_sandbox.py https://github.com/adcontextprotocol/adcp-client-python/pull/482/files#diff-73c49f9d0a61bfd14d52f78c515619d80b6364a10bd8c655042641f1798a167e
https://github.com/adcontextprotocol/adcp-client-python/blob/main/.github/CODEOWNERS#L3
docs/webhooks/migration-from-fragmented-senders.mdhttps://github.com/adcontextprotocol/adcp-client-python/pull/482/files#diff-3460bbf5e1eda9e3d01b6488bb635ea9ae574e1d23f60f2a6cfcbf3565fc065c
View file https://github.com/adcontextprotocol/adcp-client-python/blob/7fbae09960fda9cc2595fc4fcdb914734465812f/docs/webhooks/migration-from-fragmented-senders.md
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/adcontextprotocol/adcp-client-python/pull/482/{{ revealButtonHref }}
https://github.com/adcontextprotocol/adcp-client-python/blob/main/.github/CODEOWNERS#L3
src/adcp/signing/__init__.pyhttps://github.com/adcontextprotocol/adcp-client-python/pull/482/files#diff-9e5029ee28dee984d5a3e3134d4981b70268cfddcb5bf9c1f340a0356833e84a
View file https://github.com/adcontextprotocol/adcp-client-python/blob/7fbae09960fda9cc2595fc4fcdb914734465812f/src/adcp/signing/__init__.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/adcontextprotocol/adcp-client-python/pull/482/{{ revealButtonHref }}
https://github.com/adcontextprotocol/adcp-client-python/pull/482/files#diff-9e5029ee28dee984d5a3e3134d4981b70268cfddcb5bf9c1f340a0356833e84a
https://github.com/adcontextprotocol/adcp-client-python/pull/482/files#diff-9e5029ee28dee984d5a3e3134d4981b70268cfddcb5bf9c1f340a0356833e84a
https://github.com/adcontextprotocol/adcp-client-python/pull/482/files#diff-9e5029ee28dee984d5a3e3134d4981b70268cfddcb5bf9c1f340a0356833e84a
https://github.com/adcontextprotocol/adcp-client-python/pull/482/files#diff-9e5029ee28dee984d5a3e3134d4981b70268cfddcb5bf9c1f340a0356833e84a
https://github.com/adcontextprotocol/adcp-client-python/pull/482/files#diff-9e5029ee28dee984d5a3e3134d4981b70268cfddcb5bf9c1f340a0356833e84a
https://github.com/adcontextprotocol/adcp-client-python/pull/482/files#diff-9e5029ee28dee984d5a3e3134d4981b70268cfddcb5bf9c1f340a0356833e84a
https://github.com/adcontextprotocol/adcp-client-python/pull/482/files#diff-9e5029ee28dee984d5a3e3134d4981b70268cfddcb5bf9c1f340a0356833e84a
Please reload this pagehttps://github.com/adcontextprotocol/adcp-client-python/pull/482/files
Please reload this pagehttps://github.com/adcontextprotocol/adcp-client-python/pull/482/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.