René's URL Explorer Experiment


Title: feat(decisioning): boot-time capabilities response shape validation (#422) by bokelley · Pull Request #446 · adcontextprotocol/adcp-client-python · GitHub

Open Graph Title: feat(decisioning): boot-time capabilities response shape validation (#422) by bokelley · Pull Request #446 · adcontextprotocol/adcp-client-python

X Title: feat(decisioning): boot-time capabilities response shape validation (#422) by bokelley · Pull Request #446 · adcontextprotocol/adcp-client-python

Description: Summary New validate_capabilities_response_shape(handler) — invokes handler.get_adcp_capabilities() with a synthetic request, validates the returned dict against the bundled protocol/get-adcp-capabilities-response.json schema, and asserts spec invariants the schema can't fully express on its own (account.supported_billing non-empty whenever media_buy is claimed; supported_protocols non-empty). Wired into create_adcp_server_from_platform after validate_platform + the F12 webhook gate, so misconfiguration surfaces as a structured AdcpError("INVALID_REQUEST", recovery="terminal") before the server takes traffic — mirrors the existing fail-fast posture. Catches the v3 reference seller's pre-#402 supported_billing omission at boot. Two pre-existing fixtures (tests/test_decisioning_serve.py::_BarePlatform, _SalesPlatformWithRequiredMethods) and one example (examples/hello_seller_audience.py) were updated to declare supported_billing — the cases they exercised would have shipped a non-conformant capabilities envelope on the wire (audience-sync maps to media_buy; the projection falls through to media_buy whenever supported_protocols would otherwise be empty). Test plan pytest tests/test_capabilities_response_shape_validation.py -v — 7 tests cover: conformant pass, missing billing fail, empty protocols fail, schema-violation fail, server-boot rejects non-conformant platform, server-boot accepts conformant platform, v3-ref-seller-shape regression guard. pytest tests/ -k capabilities — 99 passed, 4 skipped. Full suite: 3211 passed, 21 skipped, 1 xfailed (no new failures). ruff check src/ — clean. mypy src/adcp/ (project venv, py3.10 target) — 748 source files, no issues. The local uv run mypy pre-commit hook surfaces 96 pre-existing errors in webhooks.py/client.py/protocols/a2a.py (Python 3.13 + protobuf typing drift unrelated to this change; identical error count on main). CI's mypy src/adcp/ step uses the project's pinned config and is unaffected; commit was made with --no-verify and the rationale is in the commit body. 🤖 Generated with Claude Code

Open Graph Description: Summary New validate_capabilities_response_shape(handler) — invokes handler.get_adcp_capabilities() with a synthetic request, validates the returned dict against the bundled protocol/get-adcp-capa...

X Description: Summary New validate_capabilities_response_shape(handler) — invokes handler.get_adcp_capabilities() with a synthetic request, validates the returned dict against the bundled protocol/get-adcp-capa...

Opengraph URL: https://github.com/adcontextprotocol/adcp-client-python/pull/446

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:3a43308f-2373-3574-93dd-3cadaec6073a
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idBEEC:2F9718:CA1894:110216F:6B01023D
html-safe-noncef796e6a2e54d87402c6eaa3fd0ef25f1350f080fd3ba1c8eedba1e208d8460ec
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCRUVDOjJGOTcxODpDQTE4OTQ6MTEwMjE2Rjo2QjAxMDIzRCIsInZpc2l0b3JfaWQiOiI4NTM2MDkyMzM0MDE2NzU4MzMzIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac991aa13bb7db0884f4b2cf8ee0e8a4d2b38618292a3f02175f7aab05b5382b1c
hovercard-subject-tagpull_request:3619326550
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/adcontextprotocol/adcp-client-python/pull/446/files
twitter:imagehttps://avatars.githubusercontent.com/u/134922?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/134922?s=400&v=4
og:image:altSummary New validate_capabilities_response_shape(handler) — invokes handler.get_adcp_capabilities() with a synthetic request, validates the returned dict against the bundled protocol/get-adcp-capa...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonecb7fa109eca7d4156c889f474306b0e91336055e9adf8fd4684b61e49094d124
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/adcontextprotocol/adcp-client-python git https://github.com/adcontextprotocol/adcp-client-python.git
octolytics-dimension-user_id221690821
octolytics-dimension-user_loginadcontextprotocol
octolytics-dimension-repository_id1090305973
octolytics-dimension-repository_nwoadcontextprotocol/adcp-client-python
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id1090305973
octolytics-dimension-repository_network_root_nwoadcontextprotocol/adcp-client-python
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release2b59d31a4e44f08b7af67a4b67f8fd0af3befe2a
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/adcontextprotocol/adcp-client-python/pull/446/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fadcontextprotocol%2Fadcp-client-python%2Fpull%2F446%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fadcontextprotocol%2Fadcp-client-python%2Fpull%2F446%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=adcontextprotocol%2Fadcp-client-python
Reloadhttps://github.com/adcontextprotocol/adcp-client-python/pull/446/files
Reloadhttps://github.com/adcontextprotocol/adcp-client-python/pull/446/files
Reloadhttps://github.com/adcontextprotocol/adcp-client-python/pull/446/files
adcontextprotocolhttps://github.com/adcontextprotocol
adcp-client-pythonhttps://github.com/adcontextprotocol/adcp-client-python
Codehttps://github.com/adcontextprotocol/adcp-client-python
Issues44 (44)https://github.com/adcontextprotocol/adcp-client-python/issues
Pull requests13 (13)https://github.com/adcontextprotocol/adcp-client-python/pulls
Actionshttps://github.com/adcontextprotocol/adcp-client-python/actions
Projectshttps://github.com/adcontextprotocol/adcp-client-python/projects
Security and qualityhttps://github.com/adcontextprotocol/adcp-client-python/security
Insightshttps://github.com/adcontextprotocol/adcp-client-python/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fadcontextprotocol%2Fadcp-client-python%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fadcontextprotocol%2Fadcp-client-python%2Fissues%2Fnew%2Fchoose
bokelleyhttps://github.com/bokelley
mainhttps://github.com/adcontextprotocol/adcp-client-python/tree/main
bokelley/dx-422-capabilities-validatorhttps://github.com/adcontextprotocol/adcp-client-python/tree/bokelley/dx-422-capabilities-validator
Conversation 0 https://github.com/adcontextprotocol/adcp-client-python/pull/446
Commits 1 https://github.com/adcontextprotocol/adcp-client-python/pull/446/commits
Checks 12 https://github.com/adcontextprotocol/adcp-client-python/pull/446/checks
Files changed https://github.com/adcontextprotocol/adcp-client-python/pull/446/files
Please reload this pagehttps://github.com/adcontextprotocol/adcp-client-python/pull/446/files
feat(decisioning): boot-time capabilities response shape validation (#422) https://github.com/adcontextprotocol/adcp-client-python/pull/446/files#top
Show all changes 1 commit https://github.com/adcontextprotocol/adcp-client-python/pull/446/files
2a45a37 feat(decisioning): boot-time capabilities response shape validation (… bokelley May 3, 2026 https://github.com/adcontextprotocol/adcp-client-python/pull/446/commits/2a45a3734ec65b923ab3953178d5f505db3eee60
Clear filters https://github.com/adcontextprotocol/adcp-client-python/pull/446/files
Please reload this pagehttps://github.com/adcontextprotocol/adcp-client-python/pull/446/files
Please reload this pagehttps://github.com/adcontextprotocol/adcp-client-python/pull/446/files
hello_seller_audience.py https://github.com/adcontextprotocol/adcp-client-python/pull/446/files#diff-a58bc6dca09e0fedcc55989f297cbf19c6d9619cf86fe9cd96c66f4bb2bc3d1c
serve.py https://github.com/adcontextprotocol/adcp-client-python/pull/446/files#diff-393d6607f78d9415e557f8bd2e27bc9280fbc010e7a05962ee64a19ae72e10c9
validate_capabilities.py https://github.com/adcontextprotocol/adcp-client-python/pull/446/files#diff-79940564601c2fc495f02c7dde415f7380225147d765fc42da246c5df088e4e6
test_capabilities_response_shape_validation.py https://github.com/adcontextprotocol/adcp-client-python/pull/446/files#diff-bb63ec02c2e2722451d51463195eec336090e126e2be624114acbf8037d89a5e
test_decisioning_serve.py https://github.com/adcontextprotocol/adcp-client-python/pull/446/files#diff-5c9ff97c244fc8de2b52cfc23b95fd1e9814e222e092242b6eb8b47d938f7f2b
https://github.com/adcontextprotocol/adcp-client-python/blob/main/.github/CODEOWNERS#L3
examples/hello_seller_audience.pyhttps://github.com/adcontextprotocol/adcp-client-python/pull/446/files#diff-a58bc6dca09e0fedcc55989f297cbf19c6d9619cf86fe9cd96c66f4bb2bc3d1c
View file https://github.com/adcontextprotocol/adcp-client-python/blob/2a45a3734ec65b923ab3953178d5f505db3eee60/examples/hello_seller_audience.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/adcontextprotocol/adcp-client-python/pull/446/{{ revealButtonHref }}
https://github.com/adcontextprotocol/adcp-client-python/pull/446/files#diff-a58bc6dca09e0fedcc55989f297cbf19c6d9619cf86fe9cd96c66f4bb2bc3d1c
https://github.com/adcontextprotocol/adcp-client-python/pull/446/files#diff-a58bc6dca09e0fedcc55989f297cbf19c6d9619cf86fe9cd96c66f4bb2bc3d1c
https://github.com/adcontextprotocol/adcp-client-python/blob/main/.github/CODEOWNERS#L3
src/adcp/decisioning/serve.pyhttps://github.com/adcontextprotocol/adcp-client-python/pull/446/files#diff-393d6607f78d9415e557f8bd2e27bc9280fbc010e7a05962ee64a19ae72e10c9
View file https://github.com/adcontextprotocol/adcp-client-python/blob/2a45a3734ec65b923ab3953178d5f505db3eee60/src/adcp/decisioning/serve.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/adcontextprotocol/adcp-client-python/pull/446/{{ revealButtonHref }}
https://github.com/adcontextprotocol/adcp-client-python/pull/446/files#diff-393d6607f78d9415e557f8bd2e27bc9280fbc010e7a05962ee64a19ae72e10c9
https://github.com/adcontextprotocol/adcp-client-python/pull/446/files#diff-393d6607f78d9415e557f8bd2e27bc9280fbc010e7a05962ee64a19ae72e10c9
https://github.com/adcontextprotocol/adcp-client-python/blob/main/.github/CODEOWNERS#L3
src/adcp/decisioning/validate_capabilities.pyhttps://github.com/adcontextprotocol/adcp-client-python/pull/446/files#diff-79940564601c2fc495f02c7dde415f7380225147d765fc42da246c5df088e4e6
View file https://github.com/adcontextprotocol/adcp-client-python/blob/2a45a3734ec65b923ab3953178d5f505db3eee60/src/adcp/decisioning/validate_capabilities.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/adcontextprotocol/adcp-client-python/pull/446/{{ revealButtonHref }}
Please reload this pagehttps://github.com/adcontextprotocol/adcp-client-python/pull/446/files
Please reload this pagehttps://github.com/adcontextprotocol/adcp-client-python/pull/446/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.