René's URL Explorer Experiment


Title: fix(decisioning): handler shims for every non-sales wire tool by bokelley · Pull Request #337 · adcontextprotocol/adcp-client-python · GitHub

Open Graph Title: fix(decisioning): handler shims for every non-sales wire tool by bokelley · Pull Request #337 · adcontextprotocol/adcp-client-python

X Title: fix(decisioning): handler shims for every non-sales wire tool by bokelley · Pull Request #337 · adcontextprotocol/adcp-client-python

Description: Summary The Emma AudioStack DX smoke test caught a load-bearing gap. The breadth-sprint (PRs #332–#335) shipped 10 Protocol classes + REQUIRED_METHODS coverage at the static layer, but `PlatformHandler` only had 9 sales-* shims. Every non-sales wire tool (`build_creative`, `get_signals`, `check_governance`, `get_brand_identity`, `list_content_standards`, `create_property_list`, `create_collection_list`, ...) was 404 at the wire even though: capabilities advertised the slug `validate_platform` reported green at boot the wire-tool registry at `mcp_tools.py:1262-1320` already mapped each tool name to its Request type This PR closes the gap: 31 new handler shims, one per wire tool the breadth-sprint Protocols cover. Wins AudioStack DX regression test pinned by name in the test suite — no silent regression. UNSUPPORTED_FEATURE runtime gate for optional Protocol methods (`preview_creative`, `get_media_buy_artifacts`, `get_creative_features`). Buyers calling an unimplemented optional now get a structured wire error instead of `INTERNAL_ERROR`. advertised_tools drift guard — the test `test_advertised_tools_covers_every_specialism_wire_tool` enforces every spec wire tool we ship has both a shim method AND an advertised entry. Adding a new specialism Protocol without wiring the shim will fail this test. Test plan 42 new tests in `tests/test_decisioning_handler_shims.py` covering: advertised set drift guard, parametrized shim-existence per tool, end-to-end shim→`_invoke_platform_method`→platform-method for one tool per Protocol family, `sync_audiences` arg-projection, `UNSUPPORTED_FEATURE` surface for optionals, AudioStack DX regression `pytest tests/` — 2308 passed (up from 2266) `mypy src/adcp/decisioning/` clean Pre-commit gates pass Follow-up Re-run the Emma AudioStack test after this lands to confirm the friction report verdict moves from 4/10 ("partial fail") toward 8+/10. If the DX is now crazy-easy for creative-generative, the same pattern should hold for the other Protocol families. Held release pile (now 11 PRs queued for 4.4.0) Foundation (#316), codemod (#329), parity rename + Tier 1 docs (#330), F12 (#331) Breadth sprint specialism Protocols: Signals/Audience (#332), Creative (#333), Governance (#334), Brand+Lists (#335) handoff_to_workflow (#336) handler shims (this PR) 🤖 Generated with Claude Code

Open Graph Description: Summary The Emma AudioStack DX smoke test caught a load-bearing gap. The breadth-sprint (PRs #332–#335) shipped 10 Protocol classes + REQUIRED_METHODS coverage at the static layer, but `PlatformHan...

X Description: Summary The Emma AudioStack DX smoke test caught a load-bearing gap. The breadth-sprint (PRs #332–#335) shipped 10 Protocol classes + REQUIRED_METHODS coverage at the static layer, but `PlatformHan...

Opengraph URL: https://github.com/adcontextprotocol/adcp-client-python/pull/337

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:2e2b452d-7c66-ee6f-e067-4d26527ae6be
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id84DE:21E3E7:E2EB66:12C18DA:6B00FEF2
html-safe-nonce659dcc43b1b2601a910c5a032fd50097ab6ffc49d0d9c91ff48ff0499cca9600
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4NERFOjIxRTNFNzpFMkVCNjY6MTJDMThEQTo2QjAwRkVGMiIsInZpc2l0b3JfaWQiOiIxNDAwMDQ3MjE1ODc0OTk4MDAyIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac867d0f3b43b93e4185452f5fde111b4942a63248897a8cc90650c05e55320f60
hovercard-subject-tagpull_request:3613844775
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/adcontextprotocol/adcp-client-python/pull/337/files
twitter:imagehttps://avatars.githubusercontent.com/u/134922?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/134922?s=400&v=4
og:image:altSummary The Emma AudioStack DX smoke test caught a load-bearing gap. The breadth-sprint (PRs #332–#335) shipped 10 Protocol classes + REQUIRED_METHODS coverage at the static layer, but `PlatformHan...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonecb7fa109eca7d4156c889f474306b0e91336055e9adf8fd4684b61e49094d124
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/adcontextprotocol/adcp-client-python git https://github.com/adcontextprotocol/adcp-client-python.git
octolytics-dimension-user_id221690821
octolytics-dimension-user_loginadcontextprotocol
octolytics-dimension-repository_id1090305973
octolytics-dimension-repository_nwoadcontextprotocol/adcp-client-python
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id1090305973
octolytics-dimension-repository_network_root_nwoadcontextprotocol/adcp-client-python
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release2b59d31a4e44f08b7af67a4b67f8fd0af3befe2a
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/adcontextprotocol/adcp-client-python/pull/337/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fadcontextprotocol%2Fadcp-client-python%2Fpull%2F337%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fadcontextprotocol%2Fadcp-client-python%2Fpull%2F337%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=adcontextprotocol%2Fadcp-client-python
Reloadhttps://github.com/adcontextprotocol/adcp-client-python/pull/337/files
Reloadhttps://github.com/adcontextprotocol/adcp-client-python/pull/337/files
Reloadhttps://github.com/adcontextprotocol/adcp-client-python/pull/337/files
adcontextprotocolhttps://github.com/adcontextprotocol
adcp-client-pythonhttps://github.com/adcontextprotocol/adcp-client-python
Codehttps://github.com/adcontextprotocol/adcp-client-python
Issues44 (44)https://github.com/adcontextprotocol/adcp-client-python/issues
Pull requests13 (13)https://github.com/adcontextprotocol/adcp-client-python/pulls
Actionshttps://github.com/adcontextprotocol/adcp-client-python/actions
Projectshttps://github.com/adcontextprotocol/adcp-client-python/projects
Security and qualityhttps://github.com/adcontextprotocol/adcp-client-python/security
Insightshttps://github.com/adcontextprotocol/adcp-client-python/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fadcontextprotocol%2Fadcp-client-python%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fadcontextprotocol%2Fadcp-client-python%2Fissues%2Fnew%2Fchoose
bokelleyhttps://github.com/bokelley
mainhttps://github.com/adcontextprotocol/adcp-client-python/tree/main
bokelley/decisioning-handler-shimshttps://github.com/adcontextprotocol/adcp-client-python/tree/bokelley/decisioning-handler-shims
Conversation 0 https://github.com/adcontextprotocol/adcp-client-python/pull/337
Commits 2 https://github.com/adcontextprotocol/adcp-client-python/pull/337/commits
Checks 11 https://github.com/adcontextprotocol/adcp-client-python/pull/337/checks
Files changed https://github.com/adcontextprotocol/adcp-client-python/pull/337/files
Please reload this pagehttps://github.com/adcontextprotocol/adcp-client-python/pull/337/files
fix(decisioning): handler shims for every non-sales wire tool https://github.com/adcontextprotocol/adcp-client-python/pull/337/files#top
Show all changes 2 commits https://github.com/adcontextprotocol/adcp-client-python/pull/337/files
0c3a22f fix(decisioning): handler shims for every non-sales wire tool bokelley May 1, 2026 https://github.com/adcontextprotocol/adcp-client-python/pull/337/commits/0c3a22ff6f1bfadcc48955da43959501f52a38b9
48657e8 fix(decisioning): expert P0/P1 fixes on handler shims bokelley May 1, 2026 https://github.com/adcontextprotocol/adcp-client-python/pull/337/commits/48657e895660488f61c2b1121a76e40f905d0e47
Clear filters https://github.com/adcontextprotocol/adcp-client-python/pull/337/files
Please reload this pagehttps://github.com/adcontextprotocol/adcp-client-python/pull/337/files
Please reload this pagehttps://github.com/adcontextprotocol/adcp-client-python/pull/337/files
handler.py https://github.com/adcontextprotocol/adcp-client-python/pull/337/files#diff-80df6165eb0ffc2e3f5cc0ad6c9410d18f68f1337065d84bc60e1352d45639a6
test_decisioning_handler_shims.py https://github.com/adcontextprotocol/adcp-client-python/pull/337/files#diff-4b2066b5a84cc0910eb15b390c518b0514804ee9e5ff1c3e92892bd02153c871
Please reload this pagehttps://github.com/adcontextprotocol/adcp-client-python/pull/337/files
Please reload this pagehttps://github.com/adcontextprotocol/adcp-client-python/pull/337/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.