| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:4d11dd61-67e6-3727-a7c4-6190b9b00a1c |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | ABCA:240CD1:C09D90:F6AB2A:6B00FD26 |
| html-safe-nonce | 656949bbf2fe3ca5881db11f0e397d1a20cbec3d4de340088a8fb7beaa61b241 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBQkNBOjI0MENEMTpDMDlEOTA6RjZBQjJBOjZCMDBGRDI2IiwidmlzaXRvcl9pZCI6IjE0Mjk1NjM2ODI4MzIwNTU1OTAiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 7efcc2eea76588da35294231bbaa5998a24a49cf112497b5bed4d2620cfbbdaf |
| hovercard-subject-tag | pull_request:3606161776 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/adcontextprotocol/adcp-client-python/317/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/4a048b4abaf4dd17f59a32fd37dce0b023f4ea1af5f4a61ada7572e684b424fd/adcontextprotocol/adcp-client-python/pull/317 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/4a048b4abaf4dd17f59a32fd37dce0b023f4ea1af5f4a61ada7572e684b424fd/adcontextprotocol/adcp-client-python/pull/317 |
| og:image:alt | Closes #314
Root Cause
The JS storyboard runner (@adcp/sdk) detects the test controller by calling comply_test_controller(scenario='list_scenarios') and checking the response shape. Its det... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | bokelley |
| hostname | github.com |
| expected-hostname | github.com |
| None | e208d86428ec00a57ade75058166297440e8128a01e5287c31a53dc042bbf187 |
| turbo-cache-control | no-cache |
| go-import | github.com/adcontextprotocol/adcp-client-python git https://github.com/adcontextprotocol/adcp-client-python.git |
| octolytics-dimension-user_id | 221690821 |
| octolytics-dimension-user_login | adcontextprotocol |
| octolytics-dimension-repository_id | 1090305973 |
| octolytics-dimension-repository_nwo | adcontextprotocol/adcp-client-python |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 1090305973 |
| octolytics-dimension-repository_network_root_nwo | adcontextprotocol/adcp-client-python |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 7dafd017fb7809a839c443dba08622af38e63c09 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | pull-requests |
| Skip to content | https://github.com/adcontextprotocol/adcp-client-python/pull/317#start-of-content |
| https://github.com/ |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fadcontextprotocol%2Fadcp-client-python%2Fpull%2F317 |
| GitHubRepository hosting, code review, and collaboration | https://github.com/platform |
| CopilotAI coding agent for tasks, projects, and automated work | https://github.com/features/copilot |
| ActionsCI/CD and automation | https://github.com/features/actions |
| Code QualityQuality analysis, fixes, and enforcement | https://github.com/features/code-quality |
| CodespacesCloud development environments | https://github.com/features/codespaces |
| Code SecurityVulnerability detection and remediation | https://github.com/security/advanced-security/code-security |
| Secret ProtectionSecret scanning and leak prevention | https://github.com/security/advanced-security/secret-protection |
| All Features | https://github.com/features |
| Documentation | https://docs.github.com/en |
| Training | https://learn.github.com/skills |
| Certifications | https://learn.github.com/credentials |
| Build with Copilot | https://github.com/features/ai |
| Customize Copilot | https://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview |
| Integrations | https://github.com/marketplace |
| Trending repos | https://github.com/trending |
| GitHub Sponsors | https://github.com/open-source/sponsors |
| Developer articles | https://github.com/resources/articles |
| ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place. | https://github.blog/changelog/ |
| Enterprises | https://github.com/enterprise |
| Team | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| See all industries | https://github.com/solutions/industry |
| Why GitHub | https://github.com/why-github |
| Customer Stories | https://github.com/customer-stories |
| Business insights | https://github.com/solutions/executive-insights |
| Trust Center | https://github.com/trust-center |
| GitHub Advanced SecurityEnterprise-grade code security | https://github.com/security/advanced-security |
| Copilot for businessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Documentation | https://docs.github.com/en |
| Resource center | https://github.com/resources |
| Blog | https://github.blog/ |
| Events & webinars | https://github.com/resources/events |
| Community Forum | https://github.com/orgs/community/discussions |
| Customer Stories | https://github.com/customer-stories |
| Integrations | https://github.com/marketplace |
| Customer support | https://help.github.com/ |
| Training | https://learn.github.com/skills |
| GitHub Status | https://www.githubstatus.com/ |
| About | https://github.com/about |
| Partners | https://github.com/partners |
| Changelog | https://github.blog/changelog/ |
| GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub. | https://githubuniverse.com/ |
| Pricing | https://github.com/pricing |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fadcontextprotocol%2Fadcp-client-python%2Fpull%2F317 |
| Sign up | https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=adcontextprotocol%2Fadcp-client-python |
| Reload | https://github.com/adcontextprotocol/adcp-client-python/pull/317 |
| Reload | https://github.com/adcontextprotocol/adcp-client-python/pull/317 |
| Reload | https://github.com/adcontextprotocol/adcp-client-python/pull/317 |
| adcontextprotocol | https://github.com/adcontextprotocol |
| adcp-client-python | https://github.com/adcontextprotocol/adcp-client-python |
| Code | https://github.com/adcontextprotocol/adcp-client-python |
| Issues44 (44) | https://github.com/adcontextprotocol/adcp-client-python/issues |
| Pull requests13 (13) | https://github.com/adcontextprotocol/adcp-client-python/pulls |
| Actions | https://github.com/adcontextprotocol/adcp-client-python/actions |
| Projects | https://github.com/adcontextprotocol/adcp-client-python/projects |
| Security and quality | https://github.com/adcontextprotocol/adcp-client-python/security |
| Insights | https://github.com/adcontextprotocol/adcp-client-python/insights |
| https://github.com/adcontextprotocol/adcp-client-python |
| bokelley | https://github.com/bokelley |
| main | https://github.com/adcontextprotocol/adcp-client-python/tree/main |
| claude/issue-314-controller-detected-fix | https://github.com/adcontextprotocol/adcp-client-python/tree/claude/issue-314-controller-detected-fix |
| Conversation | https://github.com/adcontextprotocol/adcp-client-python/pull/317 |
| Commits2 (2) | https://github.com/adcontextprotocol/adcp-client-python/pull/317/commits |
| Checks | https://github.com/adcontextprotocol/adcp-client-python/pull/317/checks |
| Files changed | https://github.com/adcontextprotocol/adcp-client-python/pull/317/files |
| fix(server): comply_test_controller returns dict to fix controller_detected: false | https://github.com/adcontextprotocol/adcp-client-python/pull/317#top |
| bokelley | https://github.com/bokelley |
| main | https://github.com/adcontextprotocol/adcp-client-python/tree/main |
| claude/issue-314-controller-detected-fix | https://github.com/adcontextprotocol/adcp-client-python/tree/claude/issue-314-controller-detected-fix |
|
| https://github.com/bokelley |
| bokelley | https://github.com/bokelley |
| Apr 30, 2026 | https://github.com/adcontextprotocol/adcp-client-python/pull/317#issue-4355045323 |
| #314 | https://github.com/adcontextprotocol/adcp-client-python/issues/314 |
| adcp#3121 | https://github.com/adcontextprotocol/adcp/issues/3121 |
| https://claude.ai/code/session_01LuThNVrmmHfVvPbfrbWsvy | https://claude.ai/code/session_01LuThNVrmmHfVvPbfrbWsvy |
| Claude Code | https://claude.ai/code/session_01LuThNVrmmHfVvPbfrbWsvy |
| Please reload this page | https://github.com/adcontextprotocol/adcp-client-python/pull/317 |
| claude | https://github.com/claude |
| April 30, 2026 03:04 | https://github.com/adcontextprotocol/adcp-client-python/pull/317#commits-pushed-a8cd73b |
|
| https://github.com/claude |
| fix(server): comply_test_controller returns dict to fix controller_de… | https://github.com/adcontextprotocol/adcp-client-python/pull/317/commits/a8cd73bd7f7c4d38b024c000422ed0d7d93ef8b1 |
| a8cd73b | https://github.com/adcontextprotocol/adcp-client-python/pull/317/commits/a8cd73bd7f7c4d38b024c000422ed0d7d93ef8b1 |
| #314 | https://github.com/adcontextprotocol/adcp-client-python/issues/314 |
| https://claude.ai/code/session_01LuThNVrmmHfVvPbfrbWsvy | https://claude.ai/code/session_01LuThNVrmmHfVvPbfrbWsvy |
|
| https://github.com/claude |
| test(server): add regression test for comply_test_controller dict ret… | https://github.com/adcontextprotocol/adcp-client-python/pull/317/commits/14842c7d274b1598ddacd11d09893df799845225 |
| 14842c7 | https://github.com/adcontextprotocol/adcp-client-python/pull/317/commits/14842c7d274b1598ddacd11d09893df799845225 |
| #314 | https://github.com/adcontextprotocol/adcp-client-python/issues/314 |
| https://claude.ai/code/session_01LuThNVrmmHfVvPbfrbWsvy | https://claude.ai/code/session_01LuThNVrmmHfVvPbfrbWsvy |
| https://github.com/bokelley |
| bokelley | https://github.com/bokelley |
|
Apr 30, 2026
| https://github.com/adcontextprotocol/adcp-client-python/pull/317#ref-issue-4354871475 |
|
storyboard: investigate why controller_detected stays false despite list_scenarios returning all 12 scenarios
#314
| https://github.com/adcontextprotocol/adcp-client-python/issues/314 |
| https://github.com/bokelley |
| bokelley | https://github.com/bokelley |
|
claude-triaged
| https://github.com/adcontextprotocol/adcp-client-python/issues?q=state%3Aopen%20label%3Aclaude-triaged |
| Apr 30, 2026 | https://github.com/adcontextprotocol/adcp-client-python/pull/317#event-25017016512 |
| https://github.com/bokelley |
| bokelley | https://github.com/bokelley |
|
Apr 30, 2026
| https://github.com/adcontextprotocol/adcp-client-python/pull/317#ref-issue-4354396793 |
|
examples/seller_agent.py: storyboard content gaps exposed by #296 transport fix
#304
| https://github.com/adcontextprotocol/adcp-client-python/issues/304 |
| https://github.com/bokelley |
| bokelley | https://github.com/bokelley |
| April 30, 2026 13:23 | https://github.com/adcontextprotocol/adcp-client-python/pull/317#event-25035586502 |
| https://github.com/bokelley |
| bokelley | https://github.com/bokelley |
| 9244d46 | https://github.com/adcontextprotocol/adcp-client-python/commit/9244d464e756dcef969ebdb3f9b49369c06a1f58 |
| Apr 30, 2026 | https://github.com/adcontextprotocol/adcp-client-python/pull/317#event-25035588809 |
| Please reload this page | https://github.com/adcontextprotocol/adcp-client-python/pull/317 |
| https://github.com/bokelley |
| bokelley | https://github.com/bokelley |
| April 30, 2026 13:23 | https://github.com/adcontextprotocol/adcp-client-python/pull/317#event-25035590952 |
| https://github.com/apps/github-actions |
| github-actions | https://github.com/apps/github-actions |
|
Apr 30, 2026
| https://github.com/adcontextprotocol/adcp-client-python/pull/317#ref-pullrequest-4354575888 |
|
chore(main): release 4.2.0
#311
| https://github.com/adcontextprotocol/adcp-client-python/pull/311 |
|
storyboard: 5 fixture-dependent failures (default product fixtures + measurement_terms + targeting_overlay persistence)
#319
| https://github.com/adcontextprotocol/adcp-client-python/issues/319 |
|
fix(examples): close last 5 storyboard fixture-dependent failures (#319)
#322
| https://github.com/adcontextprotocol/adcp-client-python/pull/322 |
| bokelley | https://github.com/bokelley |
|
Apr 30, 2026
| https://github.com/adcontextprotocol/adcp-client-python/pull/317#ref-commit-d92cfb1 |
|
| https://github.com/bokelley |
|
| https://github.com/claude |
| fix(examples): close last 5 storyboard fixture-dependent failures ( | https://github.com/adcontextprotocol/adcp-client-python/commit/d92cfb13839fa26a4ab69ae2db941c752db054a1 |
| #319 | https://github.com/adcontextprotocol/adcp-client-python/issues/319 |
| … | https://github.com/adcontextprotocol/adcp-client-python/commit/d92cfb13839fa26a4ab69ae2db941c752db054a1 |
| d92cfb1 | https://github.com/adcontextprotocol/adcp-client-python/commit/d92cfb13839fa26a4ab69ae2db941c752db054a1 |
| #322 | https://github.com/adcontextprotocol/adcp-client-python/pull/322 |
| #317 | https://github.com/adcontextprotocol/adcp-client-python/pull/317 |
| #309 | https://github.com/adcontextprotocol/adcp-client-python/pull/309 |
| #319 | https://github.com/adcontextprotocol/adcp-client-python/issues/319 |
| https://github.co/hiddenchars |
| https://github.com/adcontextprotocol/adcp-client-python/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fadcontextprotocol%2Fadcp-client-python%2Fpull%2F317 |
| Please reload this page | https://github.com/adcontextprotocol/adcp-client-python/pull/317 |
|
claude-triaged
| https://github.com/adcontextprotocol/adcp-client-python/issues?q=state%3Aopen%20label%3Aclaude-triaged |
|
storyboard: investigate why controller_detected stays false despite list_scenarios returning all 12 scenarios
| https://github.com/adcontextprotocol/adcp-client-python/issues/314 |
| Please reload this page | https://github.com/adcontextprotocol/adcp-client-python/pull/317 |
|
| https://github.com/bokelley |
|
| https://github.com/claude |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |