René's URL Explorer Experiment


Title: fix(server): comply_test_controller returns dict to fix controller_detected: false by bokelley · Pull Request #317 · adcontextprotocol/adcp-client-python · GitHub

Open Graph Title: fix(server): comply_test_controller returns dict to fix controller_detected: false by bokelley · Pull Request #317 · adcontextprotocol/adcp-client-python

X Title: fix(server): comply_test_controller returns dict to fix controller_detected: false by bokelley · Pull Request #317 · adcontextprotocol/adcp-client-python

Description: A python library to interact with adcp servers. Contribute to adcontextprotocol/adcp-client-python development by creating an account on GitHub.

Open Graph Description: Closes #314 Root Cause The JS storyboard runner (@adcp/sdk) detects the test controller by calling comply_test_controller(scenario='list_scenarios') and checking the response shape. Its det...

X Description: Closes #314 Root Cause The JS storyboard runner (@adcp/sdk) detects the test controller by calling comply_test_controller(scenario='list_scenarios') and checking the response shape....

Opengraph URL: https://github.com/adcontextprotocol/adcp-client-python/pull/317

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:4d11dd61-67e6-3727-a7c4-6190b9b00a1c
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idABCA:240CD1:C09D90:F6AB2A:6B00FD26
html-safe-nonce656949bbf2fe3ca5881db11f0e397d1a20cbec3d4de340088a8fb7beaa61b241
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBQkNBOjI0MENEMTpDMDlEOTA6RjZBQjJBOjZCMDBGRDI2IiwidmlzaXRvcl9pZCI6IjE0Mjk1NjM2ODI4MzIwNTU1OTAiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac7efcc2eea76588da35294231bbaa5998a24a49cf112497b5bed4d2620cfbbdaf
hovercard-subject-tagpull_request:3606161776
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/adcontextprotocol/adcp-client-python/317/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/4a048b4abaf4dd17f59a32fd37dce0b023f4ea1af5f4a61ada7572e684b424fd/adcontextprotocol/adcp-client-python/pull/317
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/4a048b4abaf4dd17f59a32fd37dce0b023f4ea1af5f4a61ada7572e684b424fd/adcontextprotocol/adcp-client-python/pull/317
og:image:altCloses #314 Root Cause The JS storyboard runner (@adcp/sdk) detects the test controller by calling comply_test_controller(scenario='list_scenarios') and checking the response shape. Its det...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamebokelley
hostnamegithub.com
expected-hostnamegithub.com
Nonee208d86428ec00a57ade75058166297440e8128a01e5287c31a53dc042bbf187
turbo-cache-controlno-cache
go-importgithub.com/adcontextprotocol/adcp-client-python git https://github.com/adcontextprotocol/adcp-client-python.git
octolytics-dimension-user_id221690821
octolytics-dimension-user_loginadcontextprotocol
octolytics-dimension-repository_id1090305973
octolytics-dimension-repository_nwoadcontextprotocol/adcp-client-python
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id1090305973
octolytics-dimension-repository_network_root_nwoadcontextprotocol/adcp-client-python
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release7dafd017fb7809a839c443dba08622af38e63c09
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/adcontextprotocol/adcp-client-python/pull/317#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fadcontextprotocol%2Fadcp-client-python%2Fpull%2F317
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fadcontextprotocol%2Fadcp-client-python%2Fpull%2F317
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=adcontextprotocol%2Fadcp-client-python
Reloadhttps://github.com/adcontextprotocol/adcp-client-python/pull/317
Reloadhttps://github.com/adcontextprotocol/adcp-client-python/pull/317
Reloadhttps://github.com/adcontextprotocol/adcp-client-python/pull/317
adcontextprotocolhttps://github.com/adcontextprotocol
adcp-client-pythonhttps://github.com/adcontextprotocol/adcp-client-python
Codehttps://github.com/adcontextprotocol/adcp-client-python
Issues44 (44)https://github.com/adcontextprotocol/adcp-client-python/issues
Pull requests13 (13)https://github.com/adcontextprotocol/adcp-client-python/pulls
Actionshttps://github.com/adcontextprotocol/adcp-client-python/actions
Projectshttps://github.com/adcontextprotocol/adcp-client-python/projects
Security and qualityhttps://github.com/adcontextprotocol/adcp-client-python/security
Insightshttps://github.com/adcontextprotocol/adcp-client-python/insights
https://github.com/adcontextprotocol/adcp-client-python
bokelleyhttps://github.com/bokelley
mainhttps://github.com/adcontextprotocol/adcp-client-python/tree/main
claude/issue-314-controller-detected-fixhttps://github.com/adcontextprotocol/adcp-client-python/tree/claude/issue-314-controller-detected-fix
Conversationhttps://github.com/adcontextprotocol/adcp-client-python/pull/317
Commits2 (2)https://github.com/adcontextprotocol/adcp-client-python/pull/317/commits
Checkshttps://github.com/adcontextprotocol/adcp-client-python/pull/317/checks
Files changedhttps://github.com/adcontextprotocol/adcp-client-python/pull/317/files
fix(server): comply_test_controller returns dict to fix controller_detected: falsehttps://github.com/adcontextprotocol/adcp-client-python/pull/317#top
bokelleyhttps://github.com/bokelley
mainhttps://github.com/adcontextprotocol/adcp-client-python/tree/main
claude/issue-314-controller-detected-fixhttps://github.com/adcontextprotocol/adcp-client-python/tree/claude/issue-314-controller-detected-fix
https://github.com/bokelley
bokelleyhttps://github.com/bokelley
Apr 30, 2026https://github.com/adcontextprotocol/adcp-client-python/pull/317#issue-4355045323
#314https://github.com/adcontextprotocol/adcp-client-python/issues/314
adcp#3121https://github.com/adcontextprotocol/adcp/issues/3121
https://claude.ai/code/session_01LuThNVrmmHfVvPbfrbWsvyhttps://claude.ai/code/session_01LuThNVrmmHfVvPbfrbWsvy
Claude Codehttps://claude.ai/code/session_01LuThNVrmmHfVvPbfrbWsvy
Please reload this pagehttps://github.com/adcontextprotocol/adcp-client-python/pull/317
claudehttps://github.com/claude
April 30, 2026 03:04https://github.com/adcontextprotocol/adcp-client-python/pull/317#commits-pushed-a8cd73b
https://github.com/claude
fix(server): comply_test_controller returns dict to fix controller_de…https://github.com/adcontextprotocol/adcp-client-python/pull/317/commits/a8cd73bd7f7c4d38b024c000422ed0d7d93ef8b1
a8cd73bhttps://github.com/adcontextprotocol/adcp-client-python/pull/317/commits/a8cd73bd7f7c4d38b024c000422ed0d7d93ef8b1
#314https://github.com/adcontextprotocol/adcp-client-python/issues/314
https://claude.ai/code/session_01LuThNVrmmHfVvPbfrbWsvyhttps://claude.ai/code/session_01LuThNVrmmHfVvPbfrbWsvy
https://github.com/claude
test(server): add regression test for comply_test_controller dict ret…https://github.com/adcontextprotocol/adcp-client-python/pull/317/commits/14842c7d274b1598ddacd11d09893df799845225
14842c7https://github.com/adcontextprotocol/adcp-client-python/pull/317/commits/14842c7d274b1598ddacd11d09893df799845225
#314https://github.com/adcontextprotocol/adcp-client-python/issues/314
https://claude.ai/code/session_01LuThNVrmmHfVvPbfrbWsvyhttps://claude.ai/code/session_01LuThNVrmmHfVvPbfrbWsvy
https://github.com/bokelley
bokelleyhttps://github.com/bokelley
Apr 30, 2026 https://github.com/adcontextprotocol/adcp-client-python/pull/317#ref-issue-4354871475
storyboard: investigate why controller_detected stays false despite list_scenarios returning all 12 scenarios #314 https://github.com/adcontextprotocol/adcp-client-python/issues/314
https://github.com/bokelley
bokelleyhttps://github.com/bokelley
claude-triaged https://github.com/adcontextprotocol/adcp-client-python/issues?q=state%3Aopen%20label%3Aclaude-triaged
Apr 30, 2026https://github.com/adcontextprotocol/adcp-client-python/pull/317#event-25017016512
https://github.com/bokelley
bokelleyhttps://github.com/bokelley
Apr 30, 2026 https://github.com/adcontextprotocol/adcp-client-python/pull/317#ref-issue-4354396793
examples/seller_agent.py: storyboard content gaps exposed by #296 transport fix #304 https://github.com/adcontextprotocol/adcp-client-python/issues/304
https://github.com/bokelley
bokelleyhttps://github.com/bokelley
April 30, 2026 13:23https://github.com/adcontextprotocol/adcp-client-python/pull/317#event-25035586502
https://github.com/bokelley
bokelleyhttps://github.com/bokelley
9244d46https://github.com/adcontextprotocol/adcp-client-python/commit/9244d464e756dcef969ebdb3f9b49369c06a1f58
Apr 30, 2026https://github.com/adcontextprotocol/adcp-client-python/pull/317#event-25035588809
Please reload this pagehttps://github.com/adcontextprotocol/adcp-client-python/pull/317
https://github.com/bokelley
bokelleyhttps://github.com/bokelley
April 30, 2026 13:23https://github.com/adcontextprotocol/adcp-client-python/pull/317#event-25035590952
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
Apr 30, 2026 https://github.com/adcontextprotocol/adcp-client-python/pull/317#ref-pullrequest-4354575888
chore(main): release 4.2.0 #311 https://github.com/adcontextprotocol/adcp-client-python/pull/311
storyboard: 5 fixture-dependent failures (default product fixtures + measurement_terms + targeting_overlay persistence) #319 https://github.com/adcontextprotocol/adcp-client-python/issues/319
fix(examples): close last 5 storyboard fixture-dependent failures (#319) #322 https://github.com/adcontextprotocol/adcp-client-python/pull/322
bokelleyhttps://github.com/bokelley
Apr 30, 2026 https://github.com/adcontextprotocol/adcp-client-python/pull/317#ref-commit-d92cfb1
https://github.com/bokelley
https://github.com/claude
fix(examples): close last 5 storyboard fixture-dependent failures (https://github.com/adcontextprotocol/adcp-client-python/commit/d92cfb13839fa26a4ab69ae2db941c752db054a1
#319https://github.com/adcontextprotocol/adcp-client-python/issues/319
…https://github.com/adcontextprotocol/adcp-client-python/commit/d92cfb13839fa26a4ab69ae2db941c752db054a1
d92cfb1https://github.com/adcontextprotocol/adcp-client-python/commit/d92cfb13839fa26a4ab69ae2db941c752db054a1
#322https://github.com/adcontextprotocol/adcp-client-python/pull/322
#317https://github.com/adcontextprotocol/adcp-client-python/pull/317
#309https://github.com/adcontextprotocol/adcp-client-python/pull/309
#319https://github.com/adcontextprotocol/adcp-client-python/issues/319
https://github.co/hiddenchars
https://github.com/adcontextprotocol/adcp-client-python/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fadcontextprotocol%2Fadcp-client-python%2Fpull%2F317
Please reload this pagehttps://github.com/adcontextprotocol/adcp-client-python/pull/317
claude-triaged https://github.com/adcontextprotocol/adcp-client-python/issues?q=state%3Aopen%20label%3Aclaude-triaged
storyboard: investigate why controller_detected stays false despite list_scenarios returning all 12 scenarios https://github.com/adcontextprotocol/adcp-client-python/issues/314
Please reload this pagehttps://github.com/adcontextprotocol/adcp-client-python/pull/317
https://github.com/bokelley
https://github.com/claude
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.